4458 Commits

Author SHA1 Message Date
Ian Hickson
1d93e924b7
Clean up matters related to "offstageness". (#27425)
In particular, make debugVisitOnstageChildren only work in debug mode, and add documentation.
2019-02-13 15:36:47 -08:00
Marco Scannadinari
d8cd2ff484 Ensure all curves return 0 and 1 in .transform(t) when t=0/1 (#27409) 2019-02-13 15:17:42 -08:00
Michael Goderbauer
46cabdab22
Fix overflow clipping/fading for text (#27892) 2019-02-13 13:49:00 -08:00
Tim Traversy
f372eb37e6 DatePicker noon/midnight overflow fix (#27773) 2019-02-13 13:03:12 -08:00
jslavitz
1196dbe94a
Fixes a cursor offset mistake for Material on iOS (#27851)
* Fixes offset and unblocks roll
2019-02-13 12:25:25 -08:00
Greg Spencer
ef9c059ef2
Hook up character events and unmodified code points to Android raw key event handling. (#27853)
This makes Android raw key event handling use the "character" data coming from the engine properly, and gets rid of the "toLowerCase" hack that I was using to normalize logical key events, in favor of using the new "plainCodePoint" that has the unmodified code point (the code point as if no modifier keys were pressed).
2019-02-12 19:40:19 -08:00
xster
8d0346a0ec
Handle back swipe completed->completed or completed->dismissed transitions (#27866) 2019-02-12 18:50:06 -08:00
Jonah Williams
7cc694e5d5
Track InheritedElement dependencies in diagnostic properties (#27387) 2019-02-12 18:37:51 -08:00
Michael Goderbauer
aa8f86135d
Fix crash when disposing nested Scrollables while holding in overscroll position (#27864) 2019-02-12 18:00:35 -08:00
Raouf Rahiche
964fab0205 fix small typo (#27659)
just a small typo 
the word "the constraints" is duplicated
2019-02-12 15:54:50 -08:00
xster
892c8919c7
Add long-press-drag cursor move support on iOS (#26001) 2019-02-12 15:10:48 -08:00
Jake Gough
dfce0a7f0b Added 'physics' prop to Stepper. (#26297)
* Update stepper.dart

Added 'physics' prop which allows the developer to assign the Stepper's scroll view's 'ScrollPhysics' which can solve with unwanted scrolling behaviour if the parent is also a scroll view. Defaults to 'AlwaysScrollableScrollPhysics' if null.

* Update stepper.dart

Removed unnecessary import and defaulting to 'AlwaysScrollableScrollPhysics' if physics prop is null.

* Update stepper.dart

Ran through format to remove unwanted whitespace which Analysis isn't happy about.

* Update stepper.dart

Tried reformatting again.

* Update stepper.dart

Tried reformatting again.

* Update stepper.dart

Formatting again why do you hate me github editor.

* Update stepper.dart

* Update stepper.dart

if this format doesn't work i'll cry

* Update stepper_test.dart

Added Stepper scroll tests. One that fails to find Text after Stepper if physics left as null and one that succeeds if physics set to `ClampingScrollPhysics()`

* Update stepper_test.dart

Added const constructors

* Update stepper_test.dart

trying to get rid of whitespace again

* Update stepper_test.dart

* Update stepper_test.dart

why whitespace why

* Update stepper_test.dart

* Update stepper_test.dart

* Update stepper_test.dart

* Update stepper_test.dart

Swapped to `findsNothing` because I'm an idiot.

* Update stepper_test.dart

* Update stepper.dart
2019-02-12 14:02:36 -08:00
rami-a
c348be9739
[Material] Update the card demo in the Gallery to demonstrate different uses of the Card widget (#27699)
Additionally, this adds a tappable Card example to the Card documentation.
2019-02-12 16:56:47 -05:00
vanya elizarov
f021ee27be CupertinoSliverRefreshControl inactive overscroll behavior (#27588) 2019-02-12 13:41:17 -08:00
KyleWong
cb2ac0a125 Null check logic for datatable. (#27632) 2019-02-12 01:05:09 -08:00
Hans Muller
5ee5766c89
Add builder parameter to showDatePicker, showTimePicker (#27703) 2019-02-11 15:53:31 -08:00
Kate Lovett
c58e31a74f
Cupertino TextField Cursor Fix (#27697)
* Fix for #26261. Changes CupertinoTextField's cursorColor to read from CupertinoTheme instead of prior default of activeBlue. CursorColor will still default to activeBlue for light theme and activeOrange for dark theme if a primary color has not been specified for the CupertinoTheme.

* Reverted unnecessary changes in XCode file.

* Updated text_field.dart per suggestions from @gspencergoog

* Updated comments for cursorColor to reflect appropriate hyperlinks per @Hixie

* Simplified cursorColor assignment per @xster

* Added test in cupertino/text_field_test.dart to check for correct cursorColor based on CupertinoTheme per @Hixie & @xster.
2019-02-11 12:54:21 -08:00
Anthony
39bb6712f6
[Material] Simple API for skipping over certain Slider shapes (#27613)
* Provide a simmplified API for skipping over slider thumb, overlay, and tick mark painting

* doc fixes

* comments

* comments

* comments

* comments

* comments

* analyzer

* comments
2019-02-11 14:57:41 -05:00
Hans Muller
944ede85ff
TextField should only set EditableText.cursorOffset for iOS (#27663) 2019-02-08 14:31:35 -08:00
Greg Spencer
431cfdafd9
Adding support for logical and physical key events (#27627)
This adds support for logical and physical key information inside of RawKeyEvent. This allows developers to differentiate keys in a platform-agnostic way. They are able to tell the physical location of a key (PhysicalKeyboardKey) and a logical meaning of the key (LogicalKeyboardKey), as well as get notified of the character generated by the keypress. All of which is useful for handling keyboard shortcuts.

This PR builds on the previous PR (#27620) which generated the key code mappings and definitions.
2019-02-08 12:42:34 -08:00
Kartik Sharma
b7807ce84c Update an IconButton sample, add RaisedButton sample (#27169) 2019-02-08 12:14:38 -08:00
Hans Muller
022f7d892e
Make FlexibleSpaceBar title padding configurable (#27623) 2019-02-08 10:44:50 -08:00
xster
9e4ab00e34
Handle CupertinoTabScaffold rebuilds with deleted tabs (#27576) 2019-02-07 17:25:15 -08:00
xster
07d015d441
Let text selection toolbar buttons be independent from theme (#27573) 2019-02-07 13:20:39 -08:00
Alexander Ryzhov
dc1eefa997 Fixed #27621: CupertinoTimerPicker breaks if minuteInterval > 1 (#27647) 2019-02-07 13:20:10 -08:00
Matt Carroll
a13fdbcf32
Implemented Dark Mode for Android (#25525) (#26605) 2019-02-06 16:52:47 -08:00
Michael Goderbauer
0aee2f5004
minor doc fixes for overlay (#27616) 2019-02-06 15:57:36 -08:00
Hans Muller
a9c05a72f7
Update OutlineButton default border width and highlight elevation (#27575)
These changes are **backwards incompatible**. Tests that verify OutlineButton visuals, for example golden image tests, will need to be updated.
2019-02-06 15:53:56 -08:00
Michael Goderbauer
e6ed069b32
Fix initial scroll of TabBar in release mode (#27568) 2019-02-06 14:39:51 -08:00
xster
ee30499a7e
Stop using SelectionChangedCause internally to show the text selection toolbar (#27534) 2019-02-06 14:39:14 -08:00
Greg Spencer
da27f62337
Make a kReleaseMode constant that is public. (#27502)
Before this, we had several places where an isReleaseMode was defined, all with the same definition. This just makes it more broadly visible to allow our users to use it, as well as creating debug and profile versions, and adding a device lab test for it.

Since this is a const value, this makes it possible for a developer to easily mark blocks that can be removed at AOT compile time.
2019-02-06 14:37:17 -08:00
Marco Scannadinari
a872514ad8 Fix immediately overriding the user's chosen AM/PM selection (#26904) 2019-02-06 14:11:29 -08:00
Anthony
b356b94aef
[Material] Allow slider shapes to be easily resized (#27510)
* Add size configs for round default shapes, and add tests, for all shapes that can be sized without creating new custom shape painters
2019-02-06 13:47:52 -05:00
xster
3dbec84052
Small cleanup in CupertinoSliverRefreshControl (#27570) 2019-02-05 19:12:37 -08:00
Matt Carroll
30f8d3b392
Fix window bug in _sendPlatformMessage() (#27541). (#27564) 2019-02-05 14:44:20 -08:00
Hans Muller
dfa489c394
Update OutlineButton on-pressed fill color (#27519) 2019-02-05 14:36:43 -08:00
xster
32b9c2f07e
Add more RenderEditable test coverage (#27003) 2019-02-05 00:54:54 -08:00
Ian Hickson
f4d5646b31
Make NotchedShape more practical to use (#27487)
This PR does two things:

- It allows BottomAppBar to have a custom shape even when it doesn't
  have a notch.

- It adds AutomaticNotchedShape, an adapter from ShapeBorder to
  NotchedShape.
2019-02-04 22:24:41 -08:00
Matt Carroll
9b053dd0d7
Move Brightness to dart:ui in the engine (#27479). (#27481) 2019-02-04 19:29:47 -08:00
Michael Goderbauer
9165afdd4e
Removed double the (#27509) 2019-02-04 18:31:24 -08:00
Hans Muller
05dc9444b9
Updated focus handling for nested FocusScopes (#27365)
Updated focus handling in FocusManager et al and EditableText so that TextFields within nested FocusScopes can gain the focus and show the keybaord.
2019-02-04 16:54:51 -08:00
Matt Carroll
92125ed38f
Enable dependency injection of Window instead of using static property (#27389) 2019-02-04 16:46:04 -08:00
Ian Hickson
7b618005c9
[H] Tabs (#27477)
* Crash when a TabBar is put in a BottomAppBar.

* Tabs bugs (e.g. crash on transparent material)

- Tabs would crash when placed on transparent Materials
- Tabs would fail to render the child if an icon was specified
2019-02-04 15:11:07 -08:00
Sander Kersten
5b828764c4 Remove leftover of GlobalKey removal listeners (#27432) 2019-02-04 11:46:54 -08:00
Hans Muller
28fc34c054
Update docs for initstate(), didUpdateWidget(), dispose() (#27501) 2019-02-04 11:45:21 -08:00
Gary Qian
c6cc3cdeda
Integrate Strut: Add StrutStyle, expose Strut API, wire up strut with dart:ui, Roll engine 31a7f4d..e7eb1c8 (7 commits) (#26332)
Includes a breaking change to dart:ui ParagraphStyle where lineHeight is renamed to height for consistency with TextStyle.
2019-02-04 10:17:25 -08:00
Ian Hickson
496ddc580c
[H] Expose "center" on CustomScrollView (#27424)
* Expose "center" on CustomScrollView

* Also support anchor
2019-02-02 16:23:39 -08:00
liyuqian
16d3847847
Fix typo "when when" (#27413) 2019-02-01 15:04:51 -08:00
rami-a
4ba35a6eab
Add elevation/pressElevation to ChipThemeData (#27399)
Allow the theme to provide these values to Chips
2019-02-01 15:54:02 -05:00
MhdHejazi
af3cdb33da #19060 Update material.google.com links to material.io (#26807) 2019-02-01 10:14:48 -08:00