3762 Commits

Author SHA1 Message Date
Chris Bracken
ed32e3e102 Temporarily pin Travis Dart SDK to 2.0.0-dev.63.0 (flutter/engine#5586)
This is a temporary workaround to unbreak the build. The breakage was
caused by differences in the latest released dev Dart SDK
(2.0.0-dev.64.0) and the version currently used by Flutter
(2.0.0-dev.63.0).

Revert once the SDK has been updated in the engine.
2018-06-21 15:55:28 -07:00
Ryan Macnak
0474c47fec No-copy kernel loading. (flutter/engine#5580)
Required by https://dart-review.googlesource.com/c/sdk/+/60202
2018-06-21 15:44:04 -07:00
Sigurd Meldgaard
bfc31675be Postpone dart initialization to -viewWillAppear on iOS (flutter/engine#5553) 2018-06-21 12:43:38 +02:00
Jason Simmons
78dfc68e0a Make Engine::GetFontCollection public (flutter/engine#5578)
Required by the Fuchsia embedder
2018-06-20 10:54:58 -07:00
skia-flutter-autoroll
bfdfd8b7ed Roll src/third_party/skia 6c56055f65fc..8c5f9ef80179 (12 commits) (flutter/engine#5577)
Auto-roller completed checks. Merging.
2018-06-20 13:52:41 -04:00
liyuqian
a4a4fc0cd4 Improve perf overlay performance. (flutter/engine#5571)
1. Mark perf overlay path as volatile
2. Set sample_margin_width = 0 to get a bar graph instead of saw-tooth.

Previously, the perf overlay itself could be a significant performance
hit and that makes it difficult to profile flutter app.
2018-06-19 16:42:21 -07:00
Jason Simmons
0b419727e7 Load the ICU data file asset from the "flutter_shared" path (flutter/engine#5567)
See https://github.com/flutter/flutter/issues/18514
2018-06-19 14:34:13 -07:00
Ryan Macnak
e8df7055bc Replace AssetResolver GetAsBuffer with GetAsMapping. (flutter/engine#5546)
Toward no-copy loading of kernel.
2018-06-19 14:24:19 -07:00
Chinmay Garde
ac0d77e6ab Use SkImageFilter::MakeMatrixFilter instead of importing an internal Skia header. (flutter/engine#5569)
Part of fixing https://bugs.chromium.org/p/skia/issues/detail?id=7741
2018-06-19 13:26:06 -07:00
Chinmay Garde
a7d32b86e5 Get rid of an include of an internal Skia header in GPU Surface GL. (flutter/engine#5568) 2018-06-19 13:12:46 -07:00
Alexander Aprelev
ed3090321a Roll dart sdk to 4c9689c1d2da97d0aa25cf16cc90c2e463ad157f (flutter/engine#5559)
* Roll dart sdk to 4c9689c1d2da97d0aa25cf16cc90c2e463ad157f

Changes since last roll:
```
4c9689c1d2 [vm] Support pluggable expression compiler for `evaluate` service api call.
d70c38eed8 [Gardening] Mark test as flaky on also non-kernel (legacy)
060ee6769e Make CastStreamSubscription.onData handle a null callback
f7289aa219 Remove specification of naming conventions.
87131780cb Add appendix to spec which specifies JavaScript integer behavior.
dfeaf79cef Fix VM accepting too many overlarge hex numbers in int.parse.
c84a9f46b2 Recompute ClassHierarchy after adding noSuchMethod forwarding stubs
b558a9c2f4 Handle missing compile-time errors
3df126c497 [gardening] Update status for vm-kernel-linux-debug
e22706793d Treat objects with .call as "subtypes" of function types
b960e5a3ed [gardening] Mark standalone_2/io/directory_test as Crash on dartkp/debug
e2d72aad91 Prepare tools/bots/try_benchmarks.sh for Dart 2.
de5f9ea95f Add --use-fasta-parser flags to dartanalyzer and the analysis server.
e2d903c4dc Remove packages/ directory resolution from CFE
aabb78f56a Update checked-in SDK to 2.0.0-dev.63.0 on mac and linux.
bc8d77231d Improve flags documentation, reenable hints in dart2js.
209a602769 Tweak for fixes tests - use orElse to avoid exception.
0e4c158847 Issue 33458. Suggest 'Create Class' Quick Fix for creation without new.
44650cc9eb Pass the location of vm_platform to compile_platform from the commandline.
0bac650833 switch to dart_action until prebuilt Windows Dart VM is updated
82ed18cdb9 Update checked-in Windows SDK to 2.0.0-dev.63.0
2394097e44 Support for including/excluding the same path in ContextRoot.isAnalyzed().
f59389b688 Optimize .runtimeType impact based on usage
ee1f7f5a93 Fix newly reported warnings
afa8ff6292 Add a resource provider that supports file overlays
a63cf8e0cb Add --no-preview-dart-2 flag.
2a396d5315 [vm/intrinsics] Intrinsify 64-bit int typed data.
dd8988c9b2 - Moved all WebGL rendering/drawing constants to synthesized class WebGL. - Removed obsolete Dartium/_blink code.
541dd195bb Enable creating full kernel files in addition to outlines from the bazel worker for kernel.
8e9e8e1da0 Fix various bugs and regularize behavior of returns statements in various kinds of functions.
f1d1da6164 [vm/precomp] Reduce the size of slow-path code in precompiled mode.
b51d3d4146 Key string should be avoided
1e906c3f7e Add no-op entry point for IncrementalCompiler
aeeb7baa96 Change error message to not use imperative tone
309baedc72 Mark some frequently flaky co19 dart2js tests.
1a08341730 Analyzer status file update
ac039abc83 Add option to check if a dill is self-contained
f479435bca - Removed custom handling of fill - it was wrong the method is now overloaded. - Associate the JS class SpeechSyntesisVoice with the correct Dart class (DDC). - Top-level querySelectorAll wasn't generic. - Handle "static" for attributes in the IDLs.
d2a37231b3 optimize await in async* methods in dartdevc
8f0106e490 Update more Analyzer fasta tests
53c2a6f9d5 Cleanup remaining unescape string call sites
1ef4399df0 Run dartfmt --fix for dart2 on pkg/dev_compiler
38eda19be6 Fix resolve_input_uri_test on windows.
5bf6436bc9 Initial implementations of two generators
03bcc495f7 [fuchsia] Migrate process creation to fdio_spawn_vmo
0cf860f361 Remove pub_build_validity test
c015e8d303 Improve invalid string literal error recovery
84f077842b Update CHANGELOG.md for 2.0.0-dev.63 release
7757fa784a [vm] Remove redundant Profiler::DumpStackTrace().
2bc9025be3 Consider initializing formals during top-level type inference
9df6426adb Mark the library analyzer.dart as being deprecated
bd956620fe Remove code that is causing a couple of hints
d99aeb3e13 [kernel] Update Fuchsia suspend to use new API.
6f44d3f208 Issue 2287. Move all, but constructors and fields set in constructors, from StatelessWidget into State.
729e9942bd Support multiple files in messages test.
99575f79ca Split ContextAwareGenerator and its subclasses
41a8b79475 Use the inferred type of const lists/maps to for constant evaluation.
2972ca61f8 Fix continue in invalidation logic
c54a302495 [VM] Evaluate symbols in kernel2kernel constant evaluator in AOT (even in non-const contexts)
4a7ccd5c9a Deleted TODO comment in Scoping
8dca855de1 Specify dynamic type of Futures/... returned from async/... functions
385d825469 Make frontend_server initialize from dill work again
2716b6f9a6 Add test to frontend_server that mimics the flutter benchmarks
17d2839a03 Fixed tests for FF difference.
6779ea0cc6 GN rules: add libraries_specification_uri argument to the  compile_platform template.
12b33ada44 [VM interpreter] Support NativeCall kernel bytecode.
db72134f90 [vm/inliner] Add smi return type of clamped convertors.
33feee3b03 [vm/kernel/bytecode] Fix arguments passing in native factory constructors
c30ce41ae6 Add hook to use single-root in fasta scripts and make use of it when creating the dart2js platform files.
34ee27a52d Update to the latest pub
bfb9a4eab8 linter 0.1.53
dfe6385eb0 Fix a Dart 2 runtime cast failure
f7ef66f5b0 Issue 33412. Fix for race condition in knownFiles during search.
aca417a256 Fix test and expected failure.
664f756914 [vm] Reduce maximum new generation size and growth rate.
bd603ba3c6 Record dependencies via CompilerContext
```
2018-06-18 20:56:50 -07:00
Chinmay Garde
93a6d340fa Add explicit casts to pointer data members on Android. (flutter/engine#5558)
This accounts for changes made in https://github.com/flutter/engine/pull/5556
2018-06-18 12:08:11 -07:00
Jason Simmons
2c651a9de5 Create images from uncompressed pixel data (flutter/engine#5550)
Fixes https://github.com/flutter/flutter/issues/9184
2018-06-18 11:37:47 -07:00
Andrew Wilson
f03c5ed766 Make window metrics doubles to reduce rounding issues. (flutter/engine#5556) 2018-06-18 10:36:58 -07:00
Andrew Wilson
504172abbe Revert "Make window metrics doubles to reduce rounding issues."
This reverts commit 564095bca0cb6ec993d94b4561ca2733851243d3.
2018-06-18 09:47:37 -07:00
Andrew Wilson
564095bca0 Make window metrics doubles to reduce rounding issues. 2018-06-18 09:43:30 -07:00
Ian Hickson
19d7432403 Remove spurious log messages (flutter/engine#5547)
These are making some of the tests that are sensitive to output flakey.
2018-06-15 14:15:35 -07:00
egdaniel
d019976b47 Nosksp backend context (flutter/engine#5544)
* Use new vulkan factory of GrContext which doens't take an sk_sp.

* remove unneeded member.
2018-06-15 14:53:50 -04:00
Maurice Parrish
be469ff641 Added method for receiving Dynamic Links (flutter/engine#5534) 2018-06-15 10:37:47 -07:00
Chinmay Garde
87576b3405 On snapshot, perform a device to host transfer for images resident on the GPU. (flutter/engine#5538) 2018-06-14 18:04:13 -07:00
Jason Simmons
f31724a16c libtxt: fix the adjustment of code unit runs for line justification (flutter/engine#5536)
Fixes https://github.com/flutter/flutter/issues/18483
2018-06-14 16:14:37 -07:00
Jason Simmons
97cf68d6c8 Lazily load fonts that are embedded within the application (flutter/engine#5533)
Previously the engine would load all embedded fonts listed in the app's
font manifest during startup.  This change creates a Skia font manager that
is backed by the engine's AssetManager and can load embedded font assets
on demand.
2018-06-14 16:13:56 -07:00
Jason Simmons
e6c5053114 libtxt: hold a weak_ptr to the txt::FontCollection in the fallback provider given to Minikin (flutter/engine#5531)
The txt::FontCollection contains a cache of minikin::FontCollection objects,
which in turn hold a fallback provider that refers back to the txt::FontCollection.
Using a weak_ptr in the fallback provider breaks the circular reference.
2018-06-14 15:50:03 -07:00
Jason Simmons
929f5df0f5 libtxt: update the unit tests and benchmarks (flutter/engine#5523)
* pass a locale to GetMinikinFontCollectionForFamily
* provide the ICU data file path
* loosen checks based on the Minikin LineBreaker's line widths
  (LineBreaker widths do not exactly match the advances calculated during layout)
2018-06-13 15:33:59 -07:00
Jason Simmons
3877686f88 Maintain a FontCollection for each engine instance instead of a process-wide singleton (flutter/engine#5521) 2018-06-13 14:28:21 -07:00
Ben Konyi
a5eb947cba Pinned versions of package:test and package:path for testing/dart tests (flutter/engine#5522) 2018-06-13 12:59:45 -07:00
Ben Konyi
a3b839a0bf IsolateNameServer reland (flutter/engine#5519)
* Reland "Added IsolateNameServer functionality (#5410)"

This reverts commit 1598c7ad7b830b298647c17a0c85f3648f6b737d.

* Fixed issue with isolate_name_server_test which caused test to timeout

* Disabled thread_annotations on Android as they aren't supported in the
NDK headers for std::mutex. Readded thread annotations to
IsolateNameServer.
2018-06-13 11:57:10 -07:00
Ben Konyi
1598c7ad7b Revert "Added IsolateNameServer functionality (#5410)" (flutter/engine#5516)
This reverts commit 851868ef29597ca8711f2de2e759069e26930c7d.
2018-06-12 17:03:13 -07:00
Ben Konyi
851868ef29 Added IsolateNameServer functionality (flutter/engine#5410)
* Added IsolateNameServer functionality, which allows for the association
of string names with isolate SendPort ids that can be used to establish
inter-isolate communications.
2018-06-12 15:50:48 -07:00
Dan Field
32b1182b0b Expose approximateBytesUsed for Picture (flutter/engine#5378) 2018-06-12 15:34:23 -04:00
Florian Loitsch
a9d585ce2f Roll the Dart VM. (flutter/engine#5510)
* Roll the Dart VM.

c95617b19c Add a release note about the VM going sync-async
05f11aa74c [kernel] Account for defaultType in some of the Kernel visitors
c39c2c8ac1 Handle type variables in optional function typed parameter in jsinterop methods
a4af44b470 [VM] Do not invoke any functions during AOT compilation
5be73cd166 Make debug printing of function types more robust.
6054cb3e1f CompilerContext always expects a Future now
6213303e65 Fix some runtime check failures in tests
d17ec7c131 Move inference data from JClosedWorld to GlobalTypeInferenceResults.
6fcc68bee3 Adjust test status.
fe21518df8 Improve literal list recovery
134e00fd73 Treat 64 bit ints as unsigned until conversion to JS.
b375d69800 [observatory] When the VM is forwarding events to the Android or Fuchsia system tracers, link to the document describing how to use them.
edb1642709 [vm] Repair interpreter build.
a9fef15ff3 Add FileResult and AnalysisDriver.getFileSync().
787a43ec78 [vm] Fix some missing private name mangling in the kernel reader.
1cf348b29f Mark enum_private_test/02 as pass, crash
cc1a817faa Use ZX_THREAD_STATE_BASIC on state output of ZX_INFO_THREAD.
4e0e72a65f Fix map_insert_remove_oom_test.
8421e69fbb [js_runtime] Make _checkLength more likely to be inlined
b66dd3d456 Stop using generic comment syntax in observatory.
b667be4861 Fix source maps strong mode runtime failure in dart2js.
7b972a653b [vm/linearscan] Account for definitions with no SSA name when processing PairLocation outputs.
09fc582bfd Fix EvalExpression test.
f2883d1b4f Fix test error message expectation on Windows.
8bfbce33f1 Mark cc/Profiler_CodeTicks as failing on Windows, dartk x64 config
a8c2263d3f Issue 33336. AnalysisDriver.discoverAvailableFiles() should notify the scheduler that there is work to do.
b7493b663e [vm/inliner] Inline small int convertors.
6b71414296 [Test status] Update status of several triaged lib_2/mirrors tests
1f03109200 Proposed replacement for SourceFactory
60631b0944 Remove unnecessary casts from observatory.
bfa8be887a Extending dartLangSpec.tex with super-bounded types and variance.
daee781179 Revise beginTypeVariable event in event sequence
e0ca1514a2 Mark test as failing.

* Update hash.
2018-06-12 18:14:24 +02:00
Chris Bracken
0ab5914e26 Revert "Eliminate support for Dart 1 (#5504)" (flutter/engine#5505)
Broke runtime_unittests, which are still running directly from source.

This reverts commit 6a89437fec6f67c8f6526b22dd50f3e992dd9699.
2018-06-11 18:12:10 -07:00
Chris Bracken
6a89437fec Eliminate support for Dart 1 (flutter/engine#5504)
Eliminates support for running directly from sources or script snapshots. In
debug mode, we run from a kernel snapshot; in profile and release modes, we
link in AOT-compiled code.

Renames --dart-non-checked-mode to --disable-dart-asserts since checked mode
does not make sense in Dart 2.
2018-06-11 17:00:43 -07:00
Dan Field
5d78c7447b make analyzer happy (flutter/engine#5499) 2018-06-10 12:47:14 -04:00
Dan Field
e90ea73260 Allow custom foreground paint to be used for drawing text (flutter/engine#5395)
* Allow specifying the foreground paint

* fix typo

* doc update

* call paint.reset
2018-06-10 00:21:18 -04:00
Stanislav Baranov
633a89dbb3 Support for saving Dart compilation trace on device. (flutter/engine#5443)
Support for saving Dart compilation trace on device.
2018-06-08 15:26:29 -07:00
Chris Bracken
f2a864c5e4 Enforce clang-format on all files in commit (flutter/engine#5495)
* Enforce clang-format on all files in commit

This re-enforces clang-format across all files changed in the commit.

In c10c417, we enabled checking only for the lines changed in the diff
in order to reduce the change of merge conflicts with the shell refactor
landed in 82c5c8f.

* Reformat sources to match latest clang-format

As part of re-enabling clang-format across the codebase, reformat all
code to match the latest toolchain.
2018-06-08 15:10:54 -07:00
Greg Spencer
2681ed21ac Fixing image encoding format conversion. (flutter/engine#5489)
On a Linux host, we were having to convert the type of the bitmap to N32, but we weren't also fixing the channel order to RGBA, so consequently we were getting BGRA when the API was asking for RGBA. This forces the color format to be RGBA when that is what is asked for.

We weren't needing to do conversion on macOS, so macOS was always getting RGBA.
2018-06-07 18:06:47 -07:00
Stanislav Baranov
6d140f4e43 Fix compile error introduce in #5473. (flutter/engine#5488)
Fix compile error introduced in #5473.
2018-06-07 15:36:35 -07:00
Stanislav Baranov
5afc3daf35 Support running bundles from zip file. (flutter/engine#5473)
Support running bundles from zip file.
2018-06-07 15:09:23 -07:00
Jason Simmons
7087b9810f libtxt: only apply ellipsizing to the last text run in the line (flutter/engine#5486)
Paragraph layout breaks the text into lines, and ellipsizing (if applicable)
will truncate the last run of a line at the point where word wrap would have
occurred.

Fixes https://github.com/flutter/flutter/issues/18198
2018-06-07 14:24:03 -07:00
Zachary Anderson
18f4c34c51 Revert: Remove uses of ReleaseOwnership from vulkan backend (flutter/engine#5484) 2018-06-07 10:42:48 -07:00
Greg Spencer
614d9a1d10 Fix animation diagram identifiers (flutter/engine#5481)
I forgot that the identifiers need to be unique per page for the animation tags.
This makes them unique.

Doc change only, no code.
2018-06-06 16:15:13 -07:00
Greg Spencer
4d1bb07254 Add diagram links for StrokeJoin and StrokeCap (flutter/engine#5456)
This updates the documentation for StrokeJoin and StrokeCap to contain animated diagrams that describe their function. The actual diagrams reside in the assets-for-api-docs repo.
2018-06-06 14:10:52 -07:00
Jason Simmons
979746e748 libtxt: add all styles of a fallback font family to the cache (flutter/engine#5474)
libtxt will query Skia for a fallback typeface when it encounters a character
that is not found in the primary font.  The font collection should make all
the variants of the fallback typeface's font family available to Minikin for
use in future font lookups.

Fixes https://github.com/flutter/flutter/issues/17985
2018-06-06 12:22:50 -07:00
Sigurd Meldgaard
916d9eb5fc App life cycle delegate (flutter/engine#5302)
* Move the handling of delegating AppDelegate callback out of FlutterAppDelegate.

Also moves the plugin registry to FlutterViewController. So each view-controller will handle its
own plugins.

This is intended to simplify including one or more Flutter views in an existing iOS app and giving
more precise control of plugin registration.

Fixes: https://github.com/flutter/flutter/issues/16539

* formatting

* Update license golden file

* Fixed type error

* FREEZE.unindexed

* Fix Header types

* Revert "FREEZE.unindexed"

This reverts commit bebb70056c9bcb90b4321bdc2873896623ed6faa.
2018-06-06 10:49:40 +02:00
Zachary Anderson
e95110f16f Adds dynamic, interpreter configs to tools/gn (flutter/engine#5446)
Adds --dynamic and --interpreter flags to
tools/gn. These flags result in engines with
properties as follows:

--dynamic:
- JIT targeting native code on Android and
  DBC on iOS

--interpreter
- Target DBC even if running on Android.

For example:

gn --android --dynamic --interpreter --runtime-mode release

Will generate an engine:
- Without Dart asserts
- Without Observatory
- With JIT compililation to DBC

into out/android_dynamic_release_dbc
2018-06-05 14:52:52 -07:00
Stanislav Baranov
5c89db5409 Remove unused argument. (flutter/engine#5471) 2018-06-05 13:11:18 -07:00
Alexander Aprelev
da47083cc5 Roll dart to a5e41681e55d1e74684bfff530218db556d77ee8 (flutter/engine#5467)
* Roll dart to a5e41681e55d1e74684bfff530218db556d77ee8.

* Update license
2018-06-05 08:35:44 -07:00
Mikkel Nygaard Ravn
dcbfb0277c Update FlutterPluginRegistrxxx docs for iOS (flutter/engine#5415) 2018-06-05 08:19:07 +02:00