247 Commits

Author SHA1 Message Date
Adam Barth
9c5a4433a7 Fix typos and error handling in setup_dart_analyzer
TBR=eseidel@google.com

Review URL: https://codereview.chromium.org/1235673002 .
2015-07-10 12:12:10 -07:00
Adam Barth
740b12a9d1 Add a script to setup source tree for Dart analyzer
Once the new Dart analyzer server rolls in, this script will set up your source
tree to integrate with it properly.

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1227913007 .
2015-07-10 12:02:35 -07:00
Adam Barth
024a5d3a32 Ban dart:mirrors in Sky
We don't use dart:mirrors and we don't want to start because it prevents some
sorts of static analysis.

R=ianh@google.com

Review URL: https://codereview.chromium.org/1233463002 .
2015-07-09 14:07:51 -07:00
Adam Barth
a40fd86bb3 Build skyx packages by default
Now that we have all the Dart packages we need in //third_party, we can build
skyx bundles by default.

As part of this change, I've made it possible to build skyx bundles on Linux
and I've made the gn target names of the mojoms in //sky/services consistent
with each other and with //mojo/services/public.

TBR=eseidel@google.com

Review URL: https://codereview.chromium.org/1227973002 .
2015-07-09 08:39:45 -07:00
John McCutchan
c247eeea92 Roll to v16 for republishing with .sdkext support
BUG=
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1231653002 .
2015-07-08 14:57:05 -07:00
John McCutchan
a6dcaf967c Some fixes for big_red_button.py
BUG=
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1227803002 .
2015-07-08 14:07:04 -07:00
John McCutchan
c1c922465a Allow big_red_button to take path arguments
BUG=
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1227103002 .
2015-07-08 13:17:42 -07:00
Ian Fischer
864d76f3b1 Remove reference to deleted “win” python file to prevent crash when running test_sky
R=abarth@chromium.org, abarth@google.com

Review URL: https://codereview.chromium.org/1227053002 .
2015-07-08 10:19:06 -07:00
Adam Barth
5d7a476bc5 Add skydoc.py, a tool for running dartdoc
This CL starts us down the path of generating documentation from our source.

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1218663011 .
2015-07-08 08:26:11 -07:00
Eric Seidel
a62b3b2514 Update skyx after material design update d86123d4c71d28
R=abarth@chromium.org, abarth@google.com

Review URL: https://codereview.chromium.org/1225593004 .
2015-07-07 17:07:19 -07:00
Eric Seidel
766bbf5e33 Add big_red_button script so that others can deploy
R=abarth@chromium.org, abarth@google.com

Review URL: https://codereview.chromium.org/1214193007 .
2015-07-07 16:28:13 -07:00
Eric Seidel
c1ebc56e38 Fix demo_launcher location for realz
TBR=abarth@google.com

Review URL: https://codereview.chromium.org/1222313014 .
2015-07-07 16:22:52 -07:00
Eric Seidel
3c6cfb958e Update demo_launcher apk location in roll_versions.py
TBR=abarth@google.com

Review URL: https://codereview.chromium.org/1220393004 .
2015-07-07 16:20:27 -07:00
Ian Fischer
95e86b76c7 Attempt to stop sky_server before starting it to avoid confusion and the warning message.
R=abarth@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1222913006 .
2015-07-07 15:47:38 -07:00
Eric Seidel
63cefd8bc1 Use sky_shell instead of mojo_shell for testing.
This does way more than a single CL should do, sorry.
- Fixed a bunch of logging/error reporting during loads.
- Made it possible for --package-root to be absolute.
- Fixed (hypothetically) parts of iOS build to be clang-plugin-compliant.
- Made all tests pass in sky_shell
- Removed a bunch of layout_tests including windows support.

I'll remove all the mojo test harness stuff in a follow-up patch.

R=abarth@chromium.org, abarth@google.com

Review URL: https://codereview.chromium.org/1215953006.
2015-07-06 17:45:49 -07:00
Adam Barth
d94e1d6255 Move home.dart into example/demo_launcher
This CL makes home.dart less of a special snowflake and instead makes it a peer
to the other Sky examples. As a result, we can add a sky.yaml file and embed
the thumbnail assets it needs into demo_launcher.skyx.

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1215703010.
2015-07-06 14:49:03 -07:00
Adam Barth
7de453e634 Add skyx packages for all the Sky demos (except game)
This CL factors the skyx build logic out of sky/apk/rules.gni so that we can
build skyx bundles without building entire APKs. This change makes it possible
to build skyx bundles for all the examples (except game).

TBR=eseidel@google.com

Review URL: https://codereview.chromium.org/1222673003.
2015-07-02 17:07:44 -07:00
Adam Barth
2e477f067e Add a flag for building skyx packages
This CL adds a build-time flag for building skyx packages, which make our
example Sky applications work offline. We can't enable this flag by default yet
because our build bots lack a few Dart packages, but landing this flag will let
folks experiment with this feature locally.

TBR=eseidel@google.com

Review URL: https://codereview.chromium.org/1221203002.
2015-07-02 16:41:35 -07:00
Adam Barth
25fc061387 SkyDemo should use explicit intents
This CL switches SkyDemo over to using explicit intents for deciding which Sky
apps to run. This change lets us get rid of the hacky "sky" URI scheme.
Instead, we use normal URLs but we require the sender of the intent to be
explicit in directing the VIEW intent to us.

TBR=eseidel@google.com

Review URL: https://codereview.chromium.org/1221123003.
2015-07-02 15:41:45 -07:00
Adam Barth
baf2807ee3 Port skyx to Dart
Rather than require Sky developers to have a Python environment, we should
write our tooling for Sky in Dart. This CL converts skyx.py into skyx.dart and
makes skyx.py into a wrapper for skyx.dart. We still need the Python wrapper
because gn requires that build actions are written in Python.

This code isn't wired into the main build yet. We'll need to add some more pub
packages to our buildbot environment first.

TBR=eseidel@google.com

Review URL: https://codereview.chromium.org/1213213003.
2015-07-02 09:12:39 -07:00
Chinmay Garde
4dc4727536 Make sure skyanalyzer uses absolute paths to construct url-mappings for
dartanalyzer

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1215883006.
2015-06-30 15:29:18 -07:00
Viktor Lidholt
7e38a80358 Updates sky_server has for Mac
BUG=
R=abarth@chromium.org, ianh@google.com

Review URL: https://codereview.chromium.org/1221893002.
2015-06-30 14:47:11 -07:00
Adam Barth
7d7cde505f Download material design icons using DEPS
We need the material design icons at build time in order to build Sky
application bundles that include the icons. Therefore, we need can't wait until
runtime to download the icons.

Also, rather than copying all the icons into each out directory, we just
symlink to the copy in the source tree.

R=eseidel@chromium.org, eseidel@google.com

Review URL: https://codereview.chromium.org/1217283002.
2015-06-30 10:32:09 -07:00
Adam Barth
205ab9f778 Add a script for packaging Sky bundles
This script consumes a sky.yaml file and produces a bundle that contains the
listed material design assets as well as the snapshot binary. This script isn't
wired into the build system yet because we don't yet download the material
design icons using DEPS.

R=chinmaygarde@google.com, eseidel@google.com

Review URL: https://codereview.chromium.org/1220893002.
2015-06-30 10:22:02 -07:00
Adam Barth
9062c56136 Make it possible to run a test in sky_shell
This CL makes it possible to run sky/tests/raw/bogus_import.dart in sky_shell
on Linux. We'd eventually like to scale this up to running all the tests.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1218633003.
2015-06-29 10:39:44 -07:00
Adam Barth
46363355ba Cleanup sky/sdk/examples
* Remove all the DOM-based examples except for the old stocks app
* Rename stocks2 to stocks
* Promote hello_widgets.dart to a top-level hello_world example

TBR=ianh@google.com

Review URL: https://codereview.chromium.org/1219493003.
2015-06-27 00:00:18 -07:00
Adam Barth
0bc960761a Add MineDigger.apk that works offline
This CL builds an APK for MineDigger that works offline. We use |sky_packager|
to snapshot the Dart code, which we then extract from the APK during startup.
If we succeed in extracting a snapshot, we load it by default.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1211253004.
2015-06-26 23:18:13 -07:00
Adam Barth
06adbc9aa6 Move examples to //sky/sdk/example
We're trying to follow the pattern described in https://www.dartlang.org/tools/pub/package-layout.html

TBR=iansf@google.com

Review URL: https://codereview.chromium.org/1210173004.
2015-06-26 22:52:40 -07:00
Ian Fischer
6ae1de6c46 Move sky/examples to sky/sdk/lib/example, and code changes to support that change. Fixes T277.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1218593002.
2015-06-26 15:06:40 -07:00
Adam Barth
570cfb6299 Support snapshots in sky_shell (again)
Unbreak support for snapshots now that we have our offline Dart loader. Also,
wire up support for snapshots in sky_shell on Linux.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1212623002.
2015-06-25 17:10:35 -07:00
Adam Barth
1f258f383e Add support for snapshot loading to Sky
This CL adds the ability to load Dart snapshot files created by sky_packager in
Sky. Using a snapshot lets us transmit all the code for an app in a single blob
and should improve startup time. Later CLs will make this codepath easier to
use and evaluate performance.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1197133004.
2015-06-23 18:40:01 -07:00
Adam Barth
a7b4b3f24a Silence some analyzer warnings
These warnings were added in the previous CL because we started added a URL
mapping for dart:mojo.internal.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1207453003.
2015-06-23 08:19:54 -07:00
Adam Barth
d0f60bc3f5 Move internals.dart out of Sky SDK
This file doesn't belong in the SDK because it is an implementation detail of
the Sky engine. Instead, this CL moves the code for dart:sky.internals into the
snapshot. This CL is a step towards merging dart:sky.internals with dart:sky,
which also resides in the snapshot.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1200953007.
2015-06-23 07:44:28 -07:00
Adam Barth
2bdbd664cf Make sky/tools/packager build on Mac
This CL removes all C++11 library features from sky/tools/packager because we
can't use C++11 library features on Mac.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1198313004.
2015-06-23 07:41:52 -07:00
Hixie
3ed42112b0 Update README.md and HACKING.md and resulting yak shave.
Update sky_server:
 - update its help string to admit that it wants the package path as well.
 - be quiet by default, since it makes the build chatty.
 - have a -v for verbose mode, for people who like it chatty.
 - have a default port of 8000, since that's what everyone used.
 - have a -p option to set the port, for people who don't use the default.
 - remove its mapping for gen/, since a TODO told me to.
 - remove the dependency on the build configuration, since it's no longer used.
 - teach it about .dart files.
 - rename sky_server/README to README.md, for consistency with other READMEs.
Update shelldb to speak the new sky_server protocol.
Update tests/services/iframe-embed-vmc.sky since the sky_server change broke the hack it was using.
Update skyserver.py to speak the new sky_server protocol.
Make webkitpy use SkyServer instead of spawning sky_server itself, since a TODO told me to.
Teach webkitpy about dart files.
Teach test_perf about dart files. (untested)
Teach sky_tool about main.dart, main.sky is deprecated. (untested)

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1200993002.
2015-06-22 13:39:16 -07:00
Hixie
bfab895dcf Make the skyanalyzer check the stocks app during testing.
Also, fix the last warning which I conveniently (yet accidentally) left in to test this.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1190223002.
2015-06-18 17:17:38 -07:00
Hixie
ea10435cec Factor out the analyzer part of shelldb so we can reuse it in tests.
This also introduces a new set_build_dir command to shelldb so you can
set the build directory without starting sky.

R=abarth@chromium.org, abarth, eseidel

Review URL: https://codereview.chromium.org/1193733004.
2015-06-18 16:54:52 -07:00
Adam Barth
883f673a6b Update Dart dependency and patch dart_controller to account for non-backwards compatible API update
Patch originally by chinmaygarde.

R=chinmaygarde@google.com

Review URL: https://codereview.chromium.org/1185233002.
2015-06-15 18:34:27 -07:00
Viet-Trung Luu
d887d2cd7e Fix sky/tools/packager/BUILD.gn.
scopes.h -> scope.h.

TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/1177123005.
2015-06-15 11:16:17 -07:00
Adam Barth
15fab09ab2 Introduce sky_packager
sky_packager is a tool that generates a Dart script snapshot for Dart files
intended to run with dart:sky. I plan to use this tool to experiment with
startup performance.

R=jackson@google.com

Review URL: https://codereview.chromium.org/1178213003.
2015-06-15 10:42:17 -07:00
Adam Barth
d59f88b826 Port sky_home to the new SkyView world
R=ianh@google.com, eseidel@chromium.org

Review URL: https://codereview.chromium.org/1178293004.
2015-06-12 16:53:29 -07:00
Hixie
406d7dbae1 Make it possible to test that the stock app doesn't crash on startup and paints the basic scaffold more or less correctly.
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1177043008.
2015-06-11 15:36:40 -07:00
Eric Seidel
b164b86e35 Teach roll_versions.py how to update CHANGELOG.md files.
This is feature creep.  But it was simple and fun. :p

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1175393002.
2015-06-11 12:48:33 -07:00
Eric Seidel
b3949716cc Add a roll_versions.py script and roll versions once.
This isn't perfect, since it makes non-minimal modifications
to the yaml and xml files.  In the yaml case it sorts the keys
and in the xml case it doesn't do the fancy attribute wrapping,
but this seems good enough to use.

R=abarth@chromium.org, johnmccutchen@google.com

Review URL: https://codereview.chromium.org/1179633003.
2015-06-10 16:16:52 -07:00
Eric Seidel
9bef57480a Resurrect deploy_sdk and make it use prepare_pub_packages.py
Works like a charm, and is now much simpler thanks to John's work.

R=abarth@chromium.org, johnmccutchan@google.com

Review URL: https://codereview.chromium.org/1174683003.
2015-06-09 13:18:59 -07:00
Adam Barth
6d7a850e25 Remove outdated copy of download_material_design_icons
The current copy is in //sky/sdk/lib.

TBR=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1160393003
2015-06-04 08:43:00 -07:00
Adam Barth
05a7ed066c Rename skydb to mojodb
The skydb tool is actually used to run many mojo apps that aren't related to
Sky.

R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/1164023004
2015-06-03 17:03:42 -07:00
Eric Seidel
00ead9f76f Don't run adb as part of shelldb boot
This defers running adb until we actually need the device-id
which makes shelldb not crash when adb isn't avaiable.

I also fixed to use ADB_PATH.

Chinmay ran into this when trying shelldb on Mac.

R=chinmaygarde@google.com, iansf@google.com

Review URL: https://codereview.chromium.org/1161843007
2015-06-03 11:20:33 -07:00
Przemyslaw Pietrzkiewicz
568b39c889 Connect mojo:debugger to window_manager only when requested.
This patch makes mojo:debugger automatically connect to window_manager
only when run by skydb, so that running the debugger for tracing and
profiling doesn't bring the side-effect of spawning window_manager.

Note that we might in the future change this to make the connection to
window_manager lazy when load() or reload() is requested, but this would
require a more involved change to skydb. The way taken in this patch
doesn't change the skydb codepath while enabling usage of debugger for
interactive tracing / profiling.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1157253007
2015-06-02 17:40:05 +02:00
Przemyslaw Pietrzkiewicz
3a7e97e696 Pull Sky debugger up to services/debugger.
Sky debugger is a native mojo app that puts up an http server and talks
to other mojo apps in response to http requests, allowing to
interactively start/stop tracing, profile, etc.

This is generally useful also when one does not run mojo_shell through
skydb, hence this patch pulls the debugger into services/debugger.

We can then add plumbing for running with the debugger in devtools.

Bug: domokit/devtools/#4.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/1151573010
2015-06-01 19:05:15 +02:00