DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
35,840 Commits 882 Branches 1,069 Tags
Commit Graph

27284 Commits

Author SHA1 Message Date
Jonah Williams
eae27f210b [Impeller] make strokes slightly lighter. (flutter/engine#53067) 
We can set the minimum stroke width to 0.5 to guarantee at least one hit of 4x MSAA coverage. This doesn't fix stroke fidelity issues but it does make it a bit better.

https://github.com/flutter/flutter/issues/144313
 2024-05-28 21:04:21 +00:00
skia-flutter-autoroll
ad5ba74b0d Roll Skia from 23ddbb590e44 to 229d94a8807e (2 revisions) (flutter/engine#53071) 
https://skia.googlesource.com/skia.git/+log/23ddbb590e44..229d94a8807e

2024-05-28 borenet@google.com Remove Pixel4XL SkpBench jobs
2024-05-28 nicolettep@google.com [graphite] VulkanSamplerYcbcrConversion -> VulkanYcbcrConversion

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-28 20:50:22 +00:00
Justin McCandless
6dfec16435 FlutterFragment predictive back (flutter/engine#52302) 
Android add-to-app apps now support predictive back when going between Activities or back to the home screen. Predictive back route transitions within the Flutter part of the app are not yet supported.
 2024-05-28 12:52:05 -07:00
skia-flutter-autoroll
be9ea34652 Roll Skia from 02c359cf8233 to 23ddbb590e44 (2 revisions) (flutter/engine#53070) 
https://skia.googlesource.com/skia.git/+log/02c359cf8233..23ddbb590e44

2024-05-28 fmalita@google.com [skottie] Fix word animation with explicit line breaks
2024-05-28 kjlubick@google.com Fix GLWindowContext_unix

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-28 19:42:17 +00:00
skia-flutter-autoroll
0ee23e14e8 Roll Skia from 4f91b3865441 to 02c359cf8233 (1 revision) (flutter/engine#53069) 
https://skia.googlesource.com/skia.git/+log/4f91b3865441..02c359cf8233

2024-05-28 michaelludwig@google.com Reland "[graphite] Use approx-fit textures in async readback"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-28 18:42:22 +00:00
gaaclarke
4795bc576d [Impeller] shrunk the buffer for the rrect_blur (flutter/engine#53068) 
issue https://github.com/flutter/flutter/issues/148496

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-28 18:29:09 +00:00
skia-flutter-autoroll
9f29233004 Roll Skia from 91cd2b48377a to 4f91b3865441 (4 revisions) (flutter/engine#53066) 
https://skia.googlesource.com/skia.git/+log/91cd2b48377a..4f91b3865441

2024-05-28 johnstiles@google.com Reorder stroke tesselator checks to do a bit less work.
2024-05-28 johnstiles@google.com Use mad in dither, blend and modulo computations.
2024-05-28 johnstiles@google.com Implement swap() for Skia hash tables.
2024-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 8ecbf179f1e3 to df449d7e2ec1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-28 17:39:20 +00:00
Gray Mackall
802e5d2cd3 Upgrade all[most] androidx dependencies to latest (flutter/engine#53001) 
Upgrades every `androidx` dependency in the `src/third_party/android_embedding_dependencies` bundle to the latest version, except the `lifecycle` group*. Tested running a couple of apps as well because when updating these dependencies in the past I've been able to build the engine but then flutter run fail when trying to run an app.

Fixes https://github.com/flutter/flutter/issues/129307, also unblocks a feature that will eventually be needed for Scribe.

[*]`2.8.0` is the latest there, but I ran into an issue with dexing when I tried to upgrade, due to b/336164417, an AGP bug that had its fix backported to all >`8.0.0` versions, but we still support less than that so we will have to wait on that upgrade.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-28 16:58:59 +00:00
skia-flutter-autoroll
4cc2731490 Roll Skia from 0c2c490021b7 to 91cd2b48377a (3 revisions) (flutter/engine#53065) 
https://skia.googlesource.com/skia.git/+log/0c2c490021b7..91cd2b48377a

2024-05-28 kjlubick@google.com Make frameworks available when linking executables too
2024-05-28 drott@chromium.org [Fontations-backend] Fix direction of cap-height and x-height
2024-05-28 johnstiles@google.com Add support for golden tests of private Runtime Shaders.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-28 16:29:23 +00:00
skia-flutter-autoroll
e0680c89dc Roll Skia from 545203f95d4e to 0c2c490021b7 (2 revisions) (flutter/engine#53063) 
https://skia.googlesource.com/skia.git/+log/545203f95d4e..0c2c490021b7

2024-05-28 johnstiles@google.com Restore some tests to the WGSL tests fileset.
2024-05-28 kjlubick@google.com Need to rewrite VulkanMemoryAllocatorWrapper header #include

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-28 15:12:08 +00:00
skia-flutter-autoroll
15b1f2186e Roll Skia from 74b4d97be6ab to 545203f95d4e (1 revision) (flutter/engine#53062) 
https://skia.googlesource.com/skia.git/+log/74b4d97be6ab..545203f95d4e

2024-05-28 drott@chromium.org [Fontations-backend] Roll Fontations, Skrifa to 0.19.2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-28 14:06:22 +00:00
johnniwinther
43149fdc24 Remove use of --nnbd-agnostic (flutter/engine#53055) 
The Dart VM no longer supports unsound null safety, so we don't need to
generate the platform in agnostic mode.
 2024-05-28 10:07:40 +02:00
Jonah Williams
c670f5191f [Impeller] Use scaled font to determine bounds, match Skia position rounding behavior, add subpixel X/Y/All/None positioning. (flutter/engine#53042) 
Multiple fixes to text rendering that match skia behavior on almost all bugs I've found, except for the glyphs are still _slightly_ too fine for some CJK text. The fixes are:

1. Compute the gylph size in the typographer context, using text size * scale factor text, instead of computing smaller bounds and scaling it up. This was not accurate and as a result we would positon glyphs incorrect by multiple pixels sometimes, causing uneven rows.

2. Match Skia's rounding behavior. previously we were rounding in multiple places, Skia rounds once. This is important to prevent jumping.

3. Use 4 subpixel X positions for rendering. This is the big one that ensures the visible layout matches exactly. Adds support for Y, both, and none positioning too. I couldn't find any examples of just Y or both. Some fonts may specify that have no subpixel positioning. So we don't bother to compute it for those.

Fixes https://github.com/flutter/flutter/issues/138386 / mostly, except slightly not bold enough.
Fixes https://github.com/flutter/flutter/issues/147577 / mostly, except slightly not bold enough.
Fixes https://github.com/flutter/flutter/issues/140475
Fixes https://github.com/flutter/flutter/issues/141467 
Fixes https://github.com/flutter/flutter/issues/135523
Fixes https://github.com/flutter/flutter/issues/127815
 2024-05-28 06:08:05 +00:00
skia-flutter-autoroll
373ded8e27 Roll Skia from 064f93590e63 to 312160c7c920 (1 revision) (flutter/engine#53058) 
https://skia.googlesource.com/skia.git/+log/064f93590e63..312160c7c920

2024-05-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 75ae5ddd462e to 6cab40b89cc8 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-28 05:54:35 +00:00
Chinmay Garde
6c35a86b30 Add an unoptimized Android debug config to local_engine.json. (flutter/engine#53057) 2024-05-28 04:58:24 +00:00
Byoungchan Lee
d56c301037 Add Linux platform support for fetching refresh rate on startup. (flutter/engine#52934) 
This patch addresses the missing implementation of
`platformDispatcher.views` on Linux. It checks the refresh rate of the
renderer's window and returns the value. Without this implementation,
`WidgetsBinding.instance.platformDispatcher.views.first.display.size`
would throw an exception on Linux, preventing safe usage.

Related: https://github.com/flutter/flutter/issues/144230
 2024-05-28 12:38:07 +12:00
skia-flutter-autoroll
a470e63489 Roll Skia from 33234e7c2072 to a74086522b47 (3 revisions) (flutter/engine#53052) 
https://skia.googlesource.com/skia.git/+log/33234e7c2072..a74086522b47

2024-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 75ae5ddd462e to 6cab40b89cc8
2024-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from a4f76cda0587 to 75ae5ddd462e (2 revisions)
2024-05-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from deff872bef22 to ab1d358e50d2 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,bwils@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-27 07:00:31 +00:00
Chinmay Garde
51a803510c [Impeller] Suppress SPIRV validation errors in latest Vulkan SDK. (flutter/engine#53049) 
Workaround for https://github.com/flutter/flutter/issues/149111
 2024-05-27 05:15:27 +00:00
auto-submit[bot]
f0cb5fe589 Reverts "Roll Dart SDK from 641d61332238 to b759e9f83ff9 (1 revision) (#53032)" (flutter/engine#53041) 
Reverts: flutter/engine#53032
Initiated by: zanderso
Reason for reverting: https://github.com/flutter/flutter/issues/149093
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/641d61332238..b759e9f83ff9

2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-192.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-25 19:21:49 +00:00
auto-submit[bot]
0b1584084b Reverts "Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) (#53036)" (flutter/engine#53040) 
Reverts: flutter/engine#53036
Initiated by: zanderso
Reason for reverting: https://github.com/flutter/flutter/issues/149093
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/b759e9f83ff9..aed02f471e34

2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-193.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-25 19:17:47 +00:00
auto-submit[bot]
08bca93595 Reverts "Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) (#53037)" (flutter/engine#53039) 
Reverts: flutter/engine#53037
Initiated by: zanderso
Reason for reverting: https://github.com/flutter/flutter/issues/149093
Original PR Author: skia-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:

https://dart.googlesource.com/sdk.git/+log/aed02f471e34..17c351dd16f4

2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-194.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-25 19:11:47 +00:00
skia-flutter-autoroll
66843dd18c Roll Dart SDK from aed02f471e34 to 17c351dd16f4 (1 revision) (flutter/engine#53037) 
https://dart.googlesource.com/sdk.git/+log/aed02f471e34..17c351dd16f4

2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-194.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-25 10:39:37 +00:00
skia-flutter-autoroll
bae66f7349 Roll Dart SDK from b759e9f83ff9 to aed02f471e34 (1 revision) (flutter/engine#53036) 
https://dart.googlesource.com/sdk.git/+log/b759e9f83ff9..aed02f471e34

2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-193.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-25 06:28:33 +00:00
skia-flutter-autoroll
bff4a24c63 Roll Fuchsia Linux SDK from 9PoD1BZXVglZ-EWu3... to j_hH7zx04OsJaL9p2... (flutter/engine#53035) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-25 05:36:26 +00:00
skia-flutter-autoroll
8fe5a8c7f8 Roll Dart SDK from 641d61332238 to b759e9f83ff9 (1 revision) (flutter/engine#53032) 
https://dart.googlesource.com/sdk.git/+log/641d61332238..b759e9f83ff9

2024-05-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-192.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-25 02:30:06 +00:00
skia-flutter-autoroll
72736f5772 Roll Skia from 0b7d656b9c03 to 7eb8515603c1 (1 revision) (flutter/engine#53031) 
https://skia.googlesource.com/skia.git/+log/0b7d656b9c03..7eb8515603c1

2024-05-25 jvanverth@google.com Revert "[ganesh] Support vertical LCD with SDF text"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-25 01:08:17 +00:00
skia-flutter-autoroll
4b1f1c5d3d Roll Dart SDK from 4ef8ed68a8d4 to 641d61332238 (1 revision) (flutter/engine#53029) 
https://dart.googlesource.com/sdk.git/+log/4ef8ed68a8d4..641d61332238

2024-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-191.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 22:02:04 +00:00
skia-flutter-autoroll
01dbe1d5ad Roll Skia from 10459d97152a to 0b7d656b9c03 (3 revisions) (flutter/engine#53028) 
https://skia.googlesource.com/skia.git/+log/10459d97152a..0b7d656b9c03

2024-05-24 jvanverth@google.com [graphite] Fix some more SDF GMs
2024-05-24 michaelludwig@google.com Revert "[graphite] Use approx-fit textures in async readback"
2024-05-24 robertphillips@google.com [graphite] Add morphology ImageFilter to Precompilation system

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 21:54:18 +00:00
Jim Graham
43b9282bec Reland "DisplayListBuilder internal reorganization with better rendering op overlap detection" (52646) (flutter/engine#53002) 
Reverts https://github.com/flutter/engine/pull/52725

This commit makes some long-needed internal improvements to the way that the DisplayListBuilder manages its per-save/saveLayer data. The information for layer bounds and matrix/clips is now maintained in the layer info structure itself rather than shared across a number of stack structures which required careful alignment of the 3 different stacks and made it more difficult to compare and update adjacent layers during save and restore operations.

The new code stores all information for a layer within a single structure and the save and restore operations can be more clear about which information they are getting or setting in the current and parent layers.

In addition, the layer bounds accumulations were updated to have a more flexible algorithm for detecting overlap of rendering operations for the opacity peephole optimization. Previously, more than one rendering op on a layer would prevent opacity peephole optimizations, but now the condition will be recognized until the first rendering op that overlaps the bounds of the previous rendering operations. This will help for some potentially common cases of 2 non-overlapping ops or even a list of rendering operations laid out in a row.
 2024-05-24 21:20:50 +00:00
skia-flutter-autoroll
a7b2ed7bf8 Roll Skia from 137a4ea4e033 to 10459d97152a (3 revisions) (flutter/engine#53027) 
https://skia.googlesource.com/skia.git/+log/137a4ea4e033..10459d97152a

2024-05-24 jvanverth@google.com [graphite] Fix surfaceprops_df.
2024-05-24 ccameron@chromium.org Replace SkDynamicMemoryEndianWStream with helper functions
2024-05-24 michaelludwig@google.com [graphite] Use approx-fit textures in async readback

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 20:52:22 +00:00
skia-flutter-autoroll
c1121245f8 Roll Skia from d252bca326a6 to 137a4ea4e033 (1 revision) (flutter/engine#53026) 
https://skia.googlesource.com/skia.git/+log/d252bca326a6..137a4ea4e033

2024-05-24 robertphillips@google.com [graphite] Settle on BlurMaskFilter Precompilation API

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 19:54:02 +00:00
skia-flutter-autoroll
c550a7d292 Roll Skia from 97783ac3000d to d252bca326a6 (2 revisions) (flutter/engine#53025) 
https://skia.googlesource.com/skia.git/+log/97783ac3000d..d252bca326a6

2024-05-24 sky@google.com Don't draw paths that are too large to tesselate
2024-05-24 jvanverth@google.com [ganesh] Support vertical LCD with SDF text

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 18:52:17 +00:00
Chinmay Garde
c8a7439178 Rename Skia specific TUs. (flutter/engine#52855) 
Fixes https://github.com/flutter/flutter/issues/148235
 2024-05-24 18:40:18 +00:00
Harry Terkelsen
1f57178c37 [canvaskit] Fix overlay reorganization for edge case with only 1 overlay (flutter/engine#53006) 
When there is only 1 overlay, move pictures in the reduced rendering to the last canvas instead of the second-to-last.

Fixes a bug in https://github.com/flutter/engine/pull/51397

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-24 18:00:06 +00:00
skia-flutter-autoroll
7615b27ee5 Roll Dart SDK from 49b226cecee7 to 4ef8ed68a8d4 (1 revision) (flutter/engine#53024) 
https://dart.googlesource.com/sdk.git/+log/49b226cecee7..4ef8ed68a8d4

2024-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-190.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 17:58:23 +00:00
skia-flutter-autoroll
c5eda847c0 Roll Skia from f832549400ab to 97783ac3000d (1 revision) (flutter/engine#53023) 
https://skia.googlesource.com/skia.git/+log/f832549400ab..97783ac3000d

2024-05-24 kjlubick@google.com Cleanup vulkan memory allocator and include in Bazel build (for now)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 17:49:59 +00:00
gaaclarke
e6b3c034ea [Impeller] sped up the linear gradient by moving calculations to the cpu (flutter/engine#53007) 
issue: https://github.com/flutter/flutter/issues/148496

The linked issue showed us as ALU bound with the linear gradient, this should relieve some of that pressure.

Tests:  There is already existing golden tests for this, this just changed the performance, no new functionality.

## summary of math improvements:
- (num_colors - 1) * division -> multiplication
- (num_colors - 1) * subtractions removed
- removes 1 `dot()`
- 1 division -> multiplication
- 1 subtraction removed

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-24 17:40:53 +00:00
skia-flutter-autoroll
0d2067cbb6 Roll Skia from 956e77ac96fd to f832549400ab (1 revision) (flutter/engine#53022) 
https://skia.googlesource.com/skia.git/+log/956e77ac96fd..f832549400ab

2024-05-24 michaelludwig@google.com [graphite] Fix synchronous readback on WebGPU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 15:35:18 +00:00
skia-flutter-autoroll
6d1638946b Roll Skia from 92f576fd2c52 to 956e77ac96fd (2 revisions) (flutter/engine#53021) 
https://skia.googlesource.com/skia.git/+log/92f576fd2c52..956e77ac96fd

2024-05-24 eriksombroek@gmail.com Add asWinding, isEmpty and addReversePath to SKPath export
2024-05-24 ccameron@chromium.org Add SkDynamicMemoryEndianWStream

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 14:28:37 +00:00
skia-flutter-autoroll
2a72db9b37 Roll Dart SDK from fef7786d65f9 to 49b226cecee7 (1 revision) (flutter/engine#53020) 
https://dart.googlesource.com/sdk.git/+log/fef7786d65f9..49b226cecee7

2024-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-189.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 13:54:12 +00:00
skia-flutter-autoroll
6d097a7581 Roll Skia from 33f0e2e61db9 to 8b8cf5b49988 (1 revision) (flutter/engine#53017) 
https://skia.googlesource.com/skia.git/+log/33f0e2e61db9..8b8cf5b49988

2024-05-24 drott@chromium.org [Fontations-backend] Hint advances and support linear advances

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 09:25:24 +00:00
skia-flutter-autoroll
dd507ffa6a Roll Skia from 447b7a9db1a7 to fc250ec3157f (1 revision) (flutter/engine#53015) 
https://skia.googlesource.com/skia.git/+log/447b7a9db1a7..fc250ec3157f

2024-05-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 20b2eb18a250 to a4f76cda0587 (2 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 06:54:23 +00:00
skia-flutter-autoroll
965dd8c241 Roll Fuchsia Linux SDK from jQHA0UEiQtfQTuWzM... to 9PoD1BZXVglZ-EWu3... (flutter/engine#53012) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 04:30:11 +00:00
skia-flutter-autoroll
7169f1d11c Roll Dart SDK from 9d7324ea563a to fef7786d65f9 (1 revision) (flutter/engine#53011) 
https://dart.googlesource.com/sdk.git/+log/9d7324ea563a..fef7786d65f9

2024-05-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-188.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 04:28:05 +00:00
skia-flutter-autoroll
4c98a6478c Roll Dart SDK from 7809d6e332ff to 9d7324ea563a (7 revisions) (flutter/engine#53008) 
https://dart.googlesource.com/sdk.git/+log/7809d6e332ff..9d7324ea563a

2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-187.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-186.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-185.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-184.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-183.0.dev
2024-05-23 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-182.0.dev
2024-05-22 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-181.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-24 00:19:53 +00:00
LongCatIsLooong
35ca2dd175 Allow unsetting TextStyle.height (flutter/engine#52940) 
Introduces a sentinel value `kTextHeightNone` for `ui.TextStyle.height` which can be used to "unset" the current `TextStyle.height` (and for consistency, it applies to `StructStyle.height` and `ParagraphStyle.height` too). Documentation of `TextStyle.height` can be found [here](https://main-api.flutter.dev/flutter/painting/TextStyle/height.html) (the one from `painting` library not `dart:ui`).
 
part of https://github.com/flutter/flutter/issues/58765: currently `TextStyle.height` uses `null` as the sentinel value for "no height multiplier specified, use the font height", which has conflicting semantics: it means the height multiplier is not set (so the span height is determined by font metrics) but in reality it also means the height should inherit from its parent span (or in `copyWith` context, it means do not override the height).

The new sentinel value `kTextHeightNone` is currently set to `0.0`. This is because skparagraph internally uses 0 for "no height multiplier", so using 0 should minimize the behavior change: 
62f369c759/modules/skparagraph/src/Run.cpp (L65-L67)

This MAY still change the current behavior: for consistency setting `StructStyle.height` / `ParagraphStyle.height` to the sentinel value also unsets the height multiplier which may not be the current behavior.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-24 00:16:16 +00:00
Chinmay Garde
6b36f0f40b Cleanup propagation of codecvt warning suppression in FML. (flutter/engine#52966) 
Previously, because the suppression was local, every user of the the header had to manually add the flag. Now the flag will be propagated to the targets automatically. This linked issue still needs to be fixed but the fix can now be more isolated.
 2024-05-23 21:03:52 +00:00
skia-flutter-autoroll
69cfdf325c Roll Skia from 60ed6f47af08 to 2ef772706cda (3 revisions) (flutter/engine#53003) 
https://skia.googlesource.com/skia.git/+log/60ed6f47af08..2ef772706cda

2024-05-23 bwils@google.com Additional specifiction conformance updates
2024-05-23 robertphillips@google.com [graphite] Add HighContrast and Overdraw colorFilters to Precompilation system
2024-05-23 bungeman@google.com Add /Zc:lambda to Skia's msvc build

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-23 21:03:49 +00:00
Harry Terkelsen
08b343b90d Move pictures from deleted canvases to second-to-last canvas instead of last. (flutter/engine#51397) 
Previously, when the number of display canvases exceeded the maximum amount, we would augment the rendering to reduce the number of canvases to the maximum amount, and move the pictures from the deleted canvases to the last canvas. However, this would cause ugly rendering in cases where pictures would render on top of the platform views they were supposed to be underneath.

This is especially noticeable when reproducing this bug: https://github.com/flutter/flutter/issues/144854

This changes things slightly so that the pictures are moved to the second-to-last remaining canvas, so that platform views always render over the pictures they are supposed to.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-23 18:36:05 +00:00
skia-flutter-autoroll
464f017be0 Roll Skia from 8af1d36fbccb to 60ed6f47af08 (2 revisions) (flutter/engine#52999) 
https://skia.googlesource.com/skia.git/+log/8af1d36fbccb..60ed6f47af08

2024-05-23 robertphillips@google.com [graphite] Remove makeWithCTM from PrecompileShader
2024-05-23 robertphillips@google.com Update tolerances for ImageAsyncReadPixels/SurfaceContextWritePixels tests

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jlavrova@google.com,jonahwilliams@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-23 17:10:06 +00:00