DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
82,418 Commits 882 Branches 1,069 Tags
Commit Graph

29682 Commits

Author SHA1 Message Date
flutteractionsbot
ea7fb0a887
[CP-stable][web] robustify safaridriver launch sequence (#164191) 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/150023

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Improve safaridriver launch process in Flutter's CI testing.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Improve stability of Flutter's macOS web tests in CI. No impact to customers, only release team.

### Workaround:
Is there a workaround for this issue?

Rerun.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

N/A
 2025-02-27 21:34:02 +00:00
flutteractionsbot
22cc257872
[CP-stable]Reenable linux_web_engine mac tests on Mac-14 (#164119) 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

Part of https://github.com/flutter/flutter/issues/148887.

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Configuration changes to run test on macOS 14 for Flutter's CI.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Impacts what type of bot the test runs on for releases.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

N/A
 2025-02-26 16:08:50 +00:00
Jonah Williams
a8a9ded167
[CP][Impeller] ensure that OpenGL "flipped" textures do not leak via texture readback. (#163501) (#163667) 
Fixes https://github.com/flutter/flutter/issues/163315 Fixes https://github.com/flutter/flutter/issues/163521 Fixes https://github.com/flutter/flutter/issues/142641

OpenGL has an inverted coordinate system (bottom left is zero) compared to Metal/Vulkan (top left is zero). We handle this by rendering things upside down on OpenGL. Unfortunately this can leak out of the renderer via readback (toImage), so we need to make sure to undo the inversion.

This is not performed for the "TextureCoordinateSystem::kUploadFromHost" state as that indicates the texture is already "right side up".
 2025-02-26 05:06:04 +00:00
Jason Simmons
836b6fdfe8
[CP] Fixes for Impeller DrawVertices issues involving snapshots with empty sizes (#163261) 
See https://github.com/flutter/flutter/issues/162969

Includes https://github.com/flutter/flutter/pull/163099 and https://github.com/flutter/flutter/pull/163177
 2025-02-26 05:06:01 +00:00
Jonah Williams
7253c79e2c
[CP][Impeller] Fix text glitch when returning to foreground. (#163754) 
Fixes https://github.com/flutter/flutter/issues/163730
Fixes https://github.com/flutter/flutter/issues/163452
 2025-02-20 20:46:07 +00:00
Jonah Williams
703ef37a89
[CP][Impeller] disable Vulkan on known bad exynos SoCs. (#163236) (#163265) 
The common theme in:
  * https://github.com/flutter/flutter/issues/160854
  * https://github.com/flutter/flutter/issues/160804
  * https://github.com/flutter/flutter/issues/158091
  
Is that the Samsung exynos chipset has problems with AHB imports. Unfortunately some of the reported bugs are hard crashes/. While I couldn't reproduce the crash itself, it does indicate to me that attempting to feature detect if AHB imports work is probably too risky (and potentially slow, as we'd have to do a read back).
 
While the Vulkan drivers otherwise work, the deivces in question are not able to reliably import AHBs which prevents platform views from working.
 
This may not fix all issues as there could be different SoC models that also have problems. I considered removing 29 support as well, but there are a large number of APi 29 devices that work fine.
 2025-02-20 18:10:07 +00:00
Jonah Williams
de3ca3d603
[CP][iOS] always post new task during gesture dispatch. (#163666) 
CP for https://github.com/flutter/flutter/pull/163646

Fixes https://github.com/flutter/flutter/issues/163429
 2025-02-20 18:06:40 +00:00
gaaclarke
d73fc34a73
[CP] all jittery glyph fixes (#163058) 
This is a cherry-pick for all the changes that went into fixing https://github.com/flutter/flutter/issues/149652

It looks like a lot but most of it is testing and refactoring.

## PRs included
- https://github.com/flutter/flutter/pull/161625
- https://github.com/flutter/flutter/pull/162351
- https://github.com/flutter/flutter/pull/162415
- https://github.com/flutter/flutter/pull/162555
- https://github.com/flutter/flutter/pull/162824

## Impacted Users

All users of Impeller.

## Impact Description

Animating text with translations and scales can cause:
  - jitter between glyphs
  - jitter between glyphs and the baseline
  - artifacts when rendering glyphs at non integer scales

## Workaround

Use skia.

## Risk

Since this edits how text is rendered, the risk is pretty high.  The actual changes are small and there are unit tests for them.  Golden test coverage for cherry-picks is not complete and text rendering golden coverage for android is problematic.

## Test Coverage

Yes.

## Validation Steps

The reproduction code in https://github.com/flutter/flutter/issues/149652 is good.
 2025-02-20 04:49:11 +00:00
Jonah Williams
383d56ed91
[CP][Impeller] Fix crash when using BackdropFilters in certain GLES drivers. (#163581) 
This is a cherry picked of https://github.com/flutter/flutter/pull/163345 and https://github.com/flutter/flutter/pull/163327 combined, as they both are parts of the same bug.

The issues are:
  https://github.com/flutter/flutter/issues/163304
  https://github.com/flutter/flutter/issues/163421
  
And potentially others, though we don't have clear repros or stack traces for all of them.
 2025-02-19 23:21:55 +00:00
Jonah Williams
81e3a42c0b
[CP] Disable Vulkan on known bad Xclipse GPU drivrs (#163616) 
Cherry pick of https://github.com/flutter/flutter/pull/161981

Fixes https://github.com/flutter/flutter/issues/163466
 2025-02-19 21:28:02 +00:00
Jonah Williams
b29799c6e6
[CP][Impeller] Increase conical gradient precision. (#162543) (#162619) 
Fixes https://github.com/flutter/flutter/issues/162379

The IPConicalGradient function requires full float 32 precision, though this depends on the exact gpu behavior. To be safe, increase the general precision in all of these shaders.
 2025-02-06 19:50:32 +00:00
Jonah Williams
1d03bf20fe
[CP][Impeller] Disable Vulkan on Emulators. (#162454) (#162536) 
Forces known android emulators to use OpenGLES. This is a very conservative check that could be expanded over time if need be. For testing emulators can still use the debug flags.

Fixes https://github.com/flutter/flutter/issues/160442
Fixes https://github.com/flutter/flutter/issues/160439
Fixes https://github.com/flutter/flutter/issues/155973
 2025-02-05 23:38:18 +00:00
Jim Graham
5000ea89b5
[Impeller] Avoid NaN values when setting up for the fast squircle blu… (#162485) 
Fixes https://github.com/flutter/flutter/issues/162128

Zero dimensioned rectangle blurs were causing the setup code to generate NaN values. This condition could also happen for some very thin or short rectangles so rather than just rule out zero-dimensioned rectangles, the uniforms are checked for NaN values and the operation is skipped in those cases.
 2025-01-31 15:16:29 +00:00
Jonah Williams
6440935b09
[CP][Impeller] Skip clip entity replay that cannot impact current clip. (#162113) (#162195) 
Fixes https://github.com/flutter/flutter/issues/161262

Sometimes we end up with clip replay entities that have clip depth values substantially below the current depth. I suspect this is due to either mismatched save/restore or a bug in our code. Update: this isn't a bug/bug but its definitely a bug. We can have multiple clips per save, but the restore will remove at most one from the record/replay.

If a clip has a depth value that is less than the current clip depth, it cannot by definition impact anything that draws after it.
 2025-01-30 20:14:59 +00:00
Jonah Williams
593a51f73a
[CP][Impeller] when a command pool has many unused buffers, reset with release resources flag. (#162207) 
Fixes https://github.com/flutter/flutter/issues/161861

Resetting a command pool is not sufficient to reclaim memory.  Contrary to what you would expect, it appears that just resetting the pool, even if the cmd buffers are reclaimed, never frees any memory unless this flag is provided.
 2025-01-29 15:39:58 +00:00
Jonah Williams
d1e425d611
[CP][Impeller] Update partial repaint to use a fullsize onscreen. (#161626) (#162194) 
The existing technique of offsetting a smaller texture is very vunerable to bugs in the renderer. Rather than this approach, we can allocate a new offscreen that is full sized and then blit a smaller region. To reduce the allocation costs, we can also set up a transients cache which will reuse this texture. In total, this should be more performant than the existing partial repaint (due to lack of continual re-allocation) at the cost of higher peak memory usage.

Fixes https://github.com/flutter/flutter/issues/140877 Fixes https://github.com/flutter/flutter/issues/160588 Fixes https://github.com/flutter/flutter/issues/156113
 2025-01-29 15:39:55 +00:00
Jonah Williams
32620428e5
[CP][Impellerc] correctly pad arrays of vec3s in reflector. (#161697) (#162190) 
When processing the metadata for a struct with an array, incorporate the padding into the layout. Previously we would register a vec3[n] array as being 4*n bytes (including the padding), but when uploading this would result in us writing data into the padding and then leave the rest uninitialized. now we correctly insert a padding element between 3 byte elements.

Fixes https://github.com/flutter/flutter/issues/161645
 2025-01-29 15:37:55 +00:00
Jonah Williams
5ab0df4b7e
[CP][Impeller] when mips are disabled, also disable from sampler options (#161765) (#162193) 
If we have disabled mipmap generation on a platform due to GPU driver bugs, make sure that all sampling options used declare that only the base mip level should be read. Otherwise we can end up sampling from unpopulated mip levels.
 2025-01-29 15:37:51 +00:00
Jonah Williams
670206c4a3
[CP][Impeller] remove Adreno denylist entries. (#161740) (#162191) 
Fixes https://github.com/flutter/flutter/issues/161209

testing on a 540 and everything seems to work now that we have the Adreno specific workarounds added to the renderer. Its possible there are some bugs that only exist on the early 600s but I guess we'll find out.
 2025-01-29 15:37:48 +00:00
Jonah Williams
e77a96d975
[CP][Impeller] adjust coverage origin when rounding out SaveLayer bounds (#161838) (#162189) 
Fixes https://github.com/flutter/flutter/issues/161374

When we round out the texture size for a saveLayer, also round out the coverage so that the drawing origin is correct. Otherwise we may actually cut off the top left edge of rendering.
 2025-01-29 15:35:55 +00:00
Jonah Williams
920ce84605
[CP][impeller] prevent PowerVR from using Vulkan backend. (#161841) (#162188) 
Almost all remaining blackscreen or rendering bugs/crashes are PowerVR hardware. Based on common knowledge that several large engines prevent PowerVR completely, we'll also block PowerVR until we have time to accumulate the necessary workarounds.
 2025-01-29 15:35:54 +00:00
Jonah Williams
2c6c4dd7e6
[CP][Impeller] check both linear sampling props for AHBs. (#162043) (#162187) 
According to
https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/5806 , both eSampledImageYcbcrConversionLinearFilter and
eSampledImageFilterLinear properties are required to use a linear chromaFilter.
 2025-01-29 15:34:27 +00:00
Jim Graham
a10e25e727
[DisplayList] Migrate from SkRSXform to Impeller RSTransform (#161652) 
Fixes SkRSXform task in https://github.com/flutter/flutter/issues/161456

Removes (nearly) all uses of Skia SkRSXform object from DisplayList and
replaces it with a new Impeller RSTransform geometry object.

There are remaining uses in:
- Skia adapter code which needs to convert them back to SkRSXform when
using the Skia backend
- dl_rendering_tests which is waiting for a major conversion effort
- ?Fuchsia? code has an SkCanvas spy adapter used in its embedder code
(not DisplayList related)
- web_ui/skwasm
 2025-01-15 19:08:38 +00:00
Jason Simmons
1e79b65ea1
Manual roll of Skia to e7b8d078851f (#161609) 
The Skia->engine roller was disabled for a few weeks during the
migration to the monorepo.
 2025-01-15 15:14:23 +00:00
Jonah Williams
b515f829af
[Impeller] null check device buffer in image encoding. (#161194) 
Fixes https://github.com/flutter/flutter/issues/160652
 2025-01-15 00:34:53 +00:00
NabilaWorks
e0d7b588b6
Feature/twitter keyboard (#161025) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

Fixes https://github.com/flutter/flutter/issues/64801

Example :

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Centered TextField Example',
      theme: ThemeData(primarySwatch: Colors.blue),
      home: CenteredTextFieldScreen(),
    );
  }
}

class CenteredTextFieldScreen extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: Text('Centered TextField')),
      body: Center(
        child: Padding(
          padding: const EdgeInsets.all(16.0),
          child: TextField(
            keyboardType: TextInputType.twitter,
            decoration: InputDecoration(
              border: OutlineInputBorder(),
              hintText: 'Enter some text here',
            ),
          ),
        ),
      ),
    );
  }
}
```


https://github.com/user-attachments/assets/5a2a2a4a-6994-44b1-bb0e-395c24012ef8


https://github.com/user-attachments/assets/aefc7bc5-a997-4e0f-a74e-a39a4517c898

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Jenn Magder <magder@google.com>
 2025-01-15 00:15:15 +00:00
jesswrd
d8322207df
Fixed XiaoMi statusBar Bug (#161271) 
Updated usages of statusBar() to systemBar() to fix XiaoMi statusBar
bug.

Fixes #132831 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-15 00:12:58 +00:00
Michael Goderbauer
a328b36f39
Clean up engine's analysis_options.yaml (#161554) 
Now that we have a monorepo we can vastly simplify the engine's
`analysis_options.yaml` file: It can just import the general rule set
(instead of recreating it) and then we can apply the engine-specific
rules on top of it. This also makes it easier to tell where the engine
rule set differs from the general one.

No more `# DIFFERENT FROM FLUTTER/FLUTTER` comments. 🥳 

Depends on https://github.com/flutter/flutter/pull/161560, which has to
be submitted first.
 2025-01-15 00:08:24 +00:00
Devon Carew
b53181a01d
[deps] remove no-longer-used repo deps (#161605) 
Remove older repo references; remove older references to `yaml_edit`,
`yaml`, `watcher`, `term_glyph`, `string_scanner`, `stream_channel`,
`stack_trace`, and `watcher`.

Done as part of https://github.com/dart-lang/sdk/issues/56591.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 21:50:11 +00:00
Jim Graham
bce2e22231
[DisplayList] remove obsolete use of Skia goemetry objects in DL utils (#161553) 
Accomplishes the `AccumulationRect and MatrixClipTracker` task in
https://github.com/flutter/flutter/issues/161456

Remove legacy Skia geometry APIs from the DisplayList utils classes
(accumulation rect and matrix/clip state tracker) as well as the small
number of remaining uses of them (mostly from their own unit tests).
 2025-01-14 21:25:42 +00:00
Tong Mu
1b7cd83b57
[Engine] Support asymmetrical rounded superellipses (#161409) 
This PR allows rounded superellipses to have asymmetrical and uneven
radii, effectively supporting `BorderRadius` instead of mere `double` as
corner radius. Fixes https://github.com/flutter/flutter/issues/161207.


https://github.com/user-attachments/assets/6293028c-d14b-4ffb-b93e-d0602f5ca0ee

These features exist in SwiftUI: The `RoundedRectangle` class provides
an initializer with a `cornerSize` parameter, allowing different radii
for the horizontal and vertical directions, while the
`UnevenRoundedRectangle` class allows each corner to have a unique
radius. However, SwiftUI does not allow the corners to be asymmetrical
_and_ uneven at the same time, which is supported by this PR.

Additionally, this change allows rounded superellipses to use the same
API as rounded rectangles. This allows RSEs to be added as a style of
`RRect` (just like in SwiftUI), which will use much fewer changes than
adding it as a new shape (>1500 LOC according to my prototype).

This PR also improves performance by removing an intermediate cache for
flipping. Now the point list is only copied once for the triangle strip
rearrangement.

`RoundingRadii` is moved to a separate file, and the code to scale it
based on bounds now its method.

## Pre-launch Checklist


- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 21:15:13 +00:00
Harry Terkelsen
e5b1ab040e
[canvaskit] Fix GIF decode failure (#161536) 
Fixes an error when decoding GIFs to check if they are animated. The
decoder needs to be more resilient in the face of Special Purpose blocks
that are in the stream in places not specified in the GIF89a spec.

Fixes https://github.com/flutter/flutter/issues/161376

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 21:07:19 +00:00
Jonah Williams
80942d520d
[Impeller] fixes for AHB swapchains. (#161562) 
Fixes for a variety of speculative fixes for AHB swapchain issues.
Details TBD while some tests run...


1. Even If the SurfaceControl API is supported, there is no guarantee
that we can import the AHB as there may be a mismatch in the required
memory properties and what is available. Add a validity check to the
texture pool and bail from the swapchain if any are invalid.

2. Rather than submitting a dummy cmd buffer that does a layout
transition, use the final command buffer signal semaphore.

3. Import the render ready semaphore and use it to block the onscreen
command buffer.
 2025-01-14 20:58:07 +00:00
Michael Goderbauer
3da003c45e
Last Engine<>Framework lint sync (#161560) 
This is the last time we have to do this because in
https://github.com/flutter/flutter/pull/161554 I am refactoring the
engine's analysis_options.yaml to just import the one from the root of
the repository. When that lands, lints only have to be enabled in one
place to apply across framework and engine.

Before we can do that we have to do one last sync to make sure the
engine code base is ready. This PR implements that last sync and fixing
all lints that came up.
 2025-01-14 20:51:42 +00:00
gaaclarke
e683e1031c
Added special case for fat width arcs (#161255) 
fixes https://github.com/flutter/flutter/issues/158567

This draws arcs as oval sectors when the stroke width is large enough.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 16:55:30 +00:00
Matan Lurey
836fd6e567
Replace fetch with gclient sync. (#161565) 
Just continue to remove outdated instructions.
 2025-01-14 16:55:08 +00:00
Robert Ancell
c9923ca609
Remove unused method (#161572) 2025-01-14 14:35:36 +00:00
Harlen Batagelo
f2c15f9deb
Fix crash when closing a window with Alt+F4 in multi-win Flutter on Windows (#161375) 
Reopened from https://github.com/flutter/engine/pull/56501.

Fixes [#158450](https://github.com/flutter/flutter/issues/158450).

As mentioned in
[#158450](https://github.com/flutter/flutter/issues/158450), the crash
occurs because a destroyed object may be accessed if the window and view
have already been destroyed by the time `KeyEventCallback` is called.
This issue is not limited to the `Alt+F4` system key; it may also occur
if the window is closed using other key presses, such as pressing
`Enter` after navigating to a dialog's "Close" button.

This PR proposes a fix that checks whether the view ID is still valid
when the callback is invoked. If the view is invalid, the event is
skipped for that view.

A unit test has been added to assert that the `KeyEventCallback` is
invoked when the associated view is valid and not invoked when the view
is destroyed.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-14 13:32:36 +00:00
Siva
3f981117eb
Roll Dart to Version 3.7.0-323.0.dev (#161567) 
https://dart.googlesource.com/sdk.git/+log/dbe08d993b3fe700ed716fa068742e8fb80b0a0a..f6ed8d7df6bfdf6fb08b38dd93c2ee1eba476b5a


[f6ed8d7](https://dart.googlesource.com/sdk.git/+/f6ed8d7df6bfdf6fb08b38dd93c2ee1eba476b5a)
[Version
3.7.0-323.0.dev](https://dart.googlesource.com/sdk.git/+/f6ed8d7df6bfdf6fb08b38dd93c2ee1eba476b5a)
by Dart CI · 12 hours ago
[dev](https://dart.googlesource.com/sdk.git/+/refs/heads/dev)
[3.7.0-323.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-323.0.dev)

[8063ed1](https://dart.googlesource.com/sdk.git/+/8063ed194b781f4c44fe7c714b54f49654470ea4)
[[CFE] Spell checker
improvements](https://dart.googlesource.com/sdk.git/+/8063ed194b781f4c44fe7c714b54f49654470ea4)
by Jens Johansen · 14 hours ago

[86ff64c](https://dart.googlesource.com/sdk.git/+/86ff64c97d40bdcf5b5dfc114c8ed56540aa341e)
[[CFE] Fix weekly but needing
dart2js_platform_unsound.dill](https://dart.googlesource.com/sdk.git/+/86ff64c97d40bdcf5b5dfc114c8ed56540aa341e)
by Jens Johansen · 14 hours ago

[11a4a94](https://dart.googlesource.com/sdk.git/+/11a4a94b950db8d409c7c6eb7c571282c99ac0ce)
[[infra-ish] Fix compile_flutter.sh after flutter engine was merged into
flutter/flutter](https://dart.googlesource.com/sdk.git/+/11a4a94b950db8d409c7c6eb7c571282c99ac0ce)
by Jens Johansen · 15 hours ago

[c075d93](https://dart.googlesource.com/sdk.git/+/c075d939e095307c26986c599f2ecbf6748a0d4e)
[[parser/scanner] Remove ScannerConfig
`enableNonNullable`](https://dart.googlesource.com/sdk.git/+/c075d939e095307c26986c599f2ecbf6748a0d4e)
by Jens Johansen · 16 hours ago

[5dfce91](https://dart.googlesource.com/sdk.git/+/5dfce919cd04bae29ab2c002f1a38a8916ec031f)
[[parser/scanner] Remove ScannerConfig
`enableExtensionMethods`](https://dart.googlesource.com/sdk.git/+/5dfce919cd04bae29ab2c002f1a38a8916ec031f)
by Jens Johansen · 16 hours ago

[1482910](https://dart.googlesource.com/sdk.git/+/1482910747ad63ec1207d30b0d9127419f9b9f08)
[Version
3.7.0-322.0.dev](https://dart.googlesource.com/sdk.git/+/1482910747ad63ec1207d30b0d9127419f9b9f08)
by Dart CI · 28 hours ago
[3.7.0-322.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-322.0.dev)

[7d8c34c](https://dart.googlesource.com/sdk.git/+/7d8c34c42532eb2b6fc3dbda221fb5cb2063b95b)
[[analyzer] Refine type of
`InterfaceTypeImpl.element`](https://dart.googlesource.com/sdk.git/+/7d8c34c42532eb2b6fc3dbda221fb5cb2063b95b)
by Paul Berry · 32 hours ago

[2229972](https://dart.googlesource.com/sdk.git/+/2229972ec5d89c1d5abba1f369d7d6e1ba8cc98c)
[Version
3.7.0-321.0.dev](https://dart.googlesource.com/sdk.git/+/2229972ec5d89c1d5abba1f369d7d6e1ba8cc98c)
by Dart CI · 2 days ago
[3.7.0-321.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-321.0.dev)

[bdf8c21](https://dart.googlesource.com/sdk.git/+/bdf8c213fe7a53987046dc2fa1d675e3b24ca9d8)
[[analyzer] Use Impl types in
TypeProviderImpl.](https://dart.googlesource.com/sdk.git/+/bdf8c213fe7a53987046dc2fa1d675e3b24ca9d8)
by Paul Berry · 2 days ago

[adcc212](https://dart.googlesource.com/sdk.git/+/adcc21238329cb5fc70b0601b4784f05d2bc314a)
[[analyzer] Changes related to
ExecutableElementImpl._parameters.](https://dart.googlesource.com/sdk.git/+/adcc21238329cb5fc70b0601b4784f05d2bc314a)
by Paul Berry · 2 days ago

[f585c17](https://dart.googlesource.com/sdk.git/+/f585c1743efe450b89d4a69cd53fa427c72e1fdd)
[Version
3.7.0-320.0.dev](https://dart.googlesource.com/sdk.git/+/f585c1743efe450b89d4a69cd53fa427c72e1fdd)
by Dart CI · 3 days ago
[3.7.0-320.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-320.0.dev)

[082be8f](https://dart.googlesource.com/sdk.git/+/082be8f4eaf445167d15a95bdde611a9eabde1fa)
[Version
3.7.0-319.0.dev](https://dart.googlesource.com/sdk.git/+/082be8f4eaf445167d15a95bdde611a9eabde1fa)
by Dart CI · 3 days ago
[3.7.0-319.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-319.0.dev)

[8bbe6fb](https://dart.googlesource.com/sdk.git/+/8bbe6fbdfe03e31ac6773114140cd9565d88052a)
[Elements. Report analyzer_use_new_elements without any txt file, add
file
ignores.](https://dart.googlesource.com/sdk.git/+/8bbe6fbdfe03e31ac6773114140cd9565d88052a)
by Konstantin Shcheglov · 3 days ago

[dc37a77](https://dart.googlesource.com/sdk.git/+/dc37a77cf7f0f92dca6b6b595aa66a930935131b)
[[ddc] Add rejection for removed const
fields](https://dart.googlesource.com/sdk.git/+/dc37a77cf7f0f92dca6b6b595aa66a930935131b)
by Nicholas Shahan · 3 days ago

[9a47293](https://dart.googlesource.com/sdk.git/+/9a472930e5100baf0efb2d33369b7fd473b92951)
[[_fe_analyzer_shared] Renames to prepare for analyzer
refactoring.](https://dart.googlesource.com/sdk.git/+/9a472930e5100baf0efb2d33369b7fd473b92951)
by Paul Berry · 3 days ago

[357a919](https://dart.googlesource.com/sdk.git/+/357a91908bbf0f71c147ea387339380c26ca8950)
[Version
3.7.0-318.0.dev](https://dart.googlesource.com/sdk.git/+/357a91908bbf0f71c147ea387339380c26ca8950)
by Dart CI · 3 days ago
[3.7.0-318.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-318.0.dev)

[11d24d6](https://dart.googlesource.com/sdk.git/+/11d24d6d55a71656be6874218809e7007aeac589)
[Elements. TypeParameterElementImpl2.name3 is
nullable.](https://dart.googlesource.com/sdk.git/+/11d24d6d55a71656be6874218809e7007aeac589)
by Konstantin Shcheglov · 3 days ago

[f91050c](https://dart.googlesource.com/sdk.git/+/f91050ca91a9f07263b1db78706258e88d967054)
[[ddc] Add visitor for hot reload
deltas](https://dart.googlesource.com/sdk.git/+/f91050ca91a9f07263b1db78706258e88d967054)
by Nicholas Shahan · 3 days ago

[ef771d4](https://dart.googlesource.com/sdk.git/+/ef771d49537c79fccb1364ecbeca35f58116f30a)
[[tests] Enum shorthands - Import
prefixes.](https://dart.googlesource.com/sdk.git/+/ef771d49537c79fccb1364ecbeca35f58116f30a)
by Kallen Tu · 3 days ago

[912ffda](https://dart.googlesource.com/sdk.git/+/912ffda5ec8fb44472b76a353ca43f150cd36bbc)
[Version
3.7.0-317.0.dev](https://dart.googlesource.com/sdk.git/+/912ffda5ec8fb44472b76a353ca43f150cd36bbc)
by Dart CI · 3 days ago
[3.7.0-317.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-317.0.dev)

[0577ca0](https://dart.googlesource.com/sdk.git/+/0577ca064d9f782bd44918645cf93487e63990a2)
[[Migrate]
error_reporter_test.dart](https://dart.googlesource.com/sdk.git/+/0577ca064d9f782bd44918645cf93487e63990a2)
by Brian Wilkerson · 3 days ago

[04ab58b](https://dart.googlesource.com/sdk.git/+/04ab58b31902c83d4858e7f70000992ac7dbd518)
[Version
3.7.0-316.0.dev](https://dart.googlesource.com/sdk.git/+/04ab58b31902c83d4858e7f70000992ac7dbd518)
by Dart CI · 4 days ago
[3.7.0-316.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-316.0.dev)

[5862859](https://dart.googlesource.com/sdk.git/+/5862859ad86dccc4166416d4b98f133a7d28c9e4)
[[co19] Roll co19 to
2424cfed7eedf53a122f8bfdbb6319692f726ec8](https://dart.googlesource.com/sdk.git/+/5862859ad86dccc4166416d4b98f133a7d28c9e4)
by Sergey G. Grekhov · 4 days ago

[d704828](https://dart.googlesource.com/sdk.git/+/d704828c3461ad408c47800588fb802136f66bc7)
[[dart2wasm] Use Uint8List for representing
bytes](https://dart.googlesource.com/sdk.git/+/d704828c3461ad408c47800588fb802136f66bc7)
by Martin Kustermann · 4 days ago

[5d3d965](https://dart.googlesource.com/sdk.git/+/5d3d965cd357eb89c1f979a683147ff64eff70f4)
[[dart2wasm] Use Function.prototype.call.bind(Number.prototype.toString)
for small ints and
doubles](https://dart.googlesource.com/sdk.git/+/5d3d965cd357eb89c1f979a683147ff64eff70f4)
by Martin Kustermann · 4 days ago

[4bcd8c2](https://dart.googlesource.com/sdk.git/+/4bcd8c2b8ce56756dbe7dd762af7f9322a777402)
[[vm/compiler] Prune SSA during construction using
liveness](https://dart.googlesource.com/sdk.git/+/4bcd8c2b8ce56756dbe7dd762af7f9322a777402)
by Vyacheslav Egorov · 4 days ago

[c95568a](https://dart.googlesource.com/sdk.git/+/c95568aede3f26fda36b58b081ec697a74960815)
[[CFE] Fuzzer using
Dart.G](https://dart.googlesource.com/sdk.git/+/c95568aede3f26fda36b58b081ec697a74960815)
by Jens Johansen · 4 days ago

[b022eca](https://dart.googlesource.com/sdk.git/+/b022ecae7070d5e345f55f730799cd229868a85a)
[[CFE] Fix crash in
_computeOnClause](https://dart.googlesource.com/sdk.git/+/b022ecae7070d5e345f55f730799cd229868a85a)
by Jens Johansen · 4 days ago

[feb770f](https://dart.googlesource.com/sdk.git/+/feb770fdf16f87ea920c633e194b65d0db284729)
[Version
3.7.0-315.0.dev](https://dart.googlesource.com/sdk.git/+/feb770fdf16f87ea920c633e194b65d0db284729)
by Dart CI · 4 days ago
[3.7.0-315.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-315.0.dev)

[0c103f1](https://dart.googlesource.com/sdk.git/+/0c103f10398d6b0980a24d5a1a2cf8046f81fe21)
[Elements. Use TypeParameterElementImpl in
TypeParameterizedElementMixin.](https://dart.googlesource.com/sdk.git/+/0c103f10398d6b0980a24d5a1a2cf8046f81fe21)
by Konstantin Shcheglov · 4 days ago

[05e5306](https://dart.googlesource.com/sdk.git/+/05e53068f9e0b9056e47d10066cf11bf499afac8)
[Version
3.7.0-314.0.dev](https://dart.googlesource.com/sdk.git/+/05e53068f9e0b9056e47d10066cf11bf499afac8)
by Dart CI · 4 days ago
[3.7.0-314.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-314.0.dev)

[92ef752](https://dart.googlesource.com/sdk.git/+/92ef75281059f0f837fa27be9d721c6410243002)
[[dynamic-modules] Add pragma annotating implicitly extendable
types.](https://dart.googlesource.com/sdk.git/+/92ef75281059f0f837fa27be9d721c6410243002)
by Nate Biggs · 4 days ago

[2de8b5e](https://dart.googlesource.com/sdk.git/+/2de8b5efb0f8da71cc8add9a9cbd246817eb8f7e)
[Elements. Migrate
lib/src/utilities/navigation/navigation_dart.dart](https://dart.googlesource.com/sdk.git/+/2de8b5efb0f8da71cc8add9a9cbd246817eb8f7e)
by Konstantin Shcheglov · 4 days ago

[4be4ec7](https://dart.googlesource.com/sdk.git/+/4be4ec7d364984b658d99cc308e00d57d5660df3)
[Elements. Migrate
AnalyzerConverter.](https://dart.googlesource.com/sdk.git/+/4be4ec7d364984b658d99cc308e00d57d5660df3)
by Konstantin Shcheglov · 4 days ago

[5f24674](https://dart.googlesource.com/sdk.git/+/5f24674138b78a744250b518257e3d9940b6c416)
[[element model] migrate
`elements_base`](https://dart.googlesource.com/sdk.git/+/5f24674138b78a744250b518257e3d9940b6c416)
by pq · 4 days ago

[e4ce6e2](https://dart.googlesource.com/sdk.git/+/e4ce6e28d5d4fb886bd32fafc717e178e2685134)
[Drop pkg:js from "Web (Legacy)" docs
section](https://dart.googlesource.com/sdk.git/+/e4ce6e28d5d4fb886bd32fafc717e178e2685134)
by Kevin Moore · 4 days ago

[75882f9](https://dart.googlesource.com/sdk.git/+/75882f9bf73337aaef2fd73bc44a38332e6aa9b7)
[Elements. Migrate
CompletionTarget.](https://dart.googlesource.com/sdk.git/+/75882f9bf73337aaef2fd73bc44a38332e6aa9b7)
by Konstantin Shcheglov · 4 days ago

[26d9167](https://dart.googlesource.com/sdk.git/+/26d91675f92fb9116d3351660978e4d9b7fedb98)
[Elements. Migrate ElementSuggestionBuilder and
related.](https://dart.googlesource.com/sdk.git/+/26d91675f92fb9116d3351660978e4d9b7fedb98)
by Konstantin Shcheglov · 4 days ago

[7d5f0a6](https://dart.googlesource.com/sdk.git/+/7d5f0a650819da939bdfda8797852d5f7d18b6a7)
[DAS: Simplify fields in
AnalysisServer](https://dart.googlesource.com/sdk.git/+/7d5f0a650819da939bdfda8797852d5f7d18b6a7)
by Sam Rawlins · 4 days ago

[7cbec89](https://dart.googlesource.com/sdk.git/+/7cbec8916d37f17b23e0eb03d6aa215989b9043a)
[DAS: Privatize and finalize fields in
AbstractNotificationManager](https://dart.googlesource.com/sdk.git/+/7cbec8916d37f17b23e0eb03d6aa215989b9043a)
by Sam Rawlins · 4 days ago

[d8fd208](https://dart.googlesource.com/sdk.git/+/d8fd208a79f3ce7675693c1089b1a3152b797429)
[Elements. Migrate
test/src/utilities/change_builder/change_builder_dart_test.dart](https://dart.googlesource.com/sdk.git/+/d8fd208a79f3ce7675693c1089b1a3152b797429)
by Konstantin Shcheglov · 4 days ago

[4356eac](https://dart.googlesource.com/sdk.git/+/4356eacd87d9a3a6a51beffc4d73261cee3d819e)
[Elements. Migrate lib/utilities/completion/suggestion_builder.dart and
required.](https://dart.googlesource.com/sdk.git/+/4356eacd87d9a3a6a51beffc4d73261cee3d819e)
by Konstantin Shcheglov · 4 days ago

[81b1313](https://dart.googlesource.com/sdk.git/+/81b13136aa05000b07b553280533a99d1dcbda36)
[analyzer: rename docImports to docLibraryImports in a few
places](https://dart.googlesource.com/sdk.git/+/81b13136aa05000b07b553280533a99d1dcbda36)
by Sam Rawlins · 4 days ago

[83db399](https://dart.googlesource.com/sdk.git/+/83db3996f769f0993d174830c02aee9bd1fbd736)
[[dart2js] Fix DictionaryTypeMask hashCode and ==
consistency.](https://dart.googlesource.com/sdk.git/+/83db3996f769f0993d174830c02aee9bd1fbd736)
by Nate Biggs · 4 days ago

[85727ca](https://dart.googlesource.com/sdk.git/+/85727caf2a163d13aed673ccfd4e4eebb9b6526d)
[[element model] migrate
`least_greatest_closure`](https://dart.googlesource.com/sdk.git/+/85727caf2a163d13aed673ccfd4e4eebb9b6526d)
by pq · 4 days ago

[2766858](https://dart.googlesource.com/sdk.git/+/2766858fba19783eefd682fffedee8e0953bdb6e)
[Elements. Migrate
lib/utilities/change_builder/change_builder_dart.dart](https://dart.googlesource.com/sdk.git/+/2766858fba19783eefd682fffedee8e0953bdb6e)
by Konstantin Shcheglov · 4 days ago

[1790fb7](https://dart.googlesource.com/sdk.git/+/1790fb7908d5079daebdaec31b628fa3c242e955)
[DAS: Fix comment references in
refactoring/](https://dart.googlesource.com/sdk.git/+/1790fb7908d5079daebdaec31b628fa3c242e955)
by Sam Rawlins · 4 days ago

[66624da](https://dart.googlesource.com/sdk.git/+/66624dadb5482697105269e780e51f27def663b6)
[Elements. Update ExecutableElementImpl.parameters to return
List<ParameterElementImpl>.](https://dart.googlesource.com/sdk.git/+/66624dadb5482697105269e780e51f27def663b6)
by Konstantin Shcheglov · 4 days ago

[1eee8ba](https://dart.googlesource.com/sdk.git/+/1eee8bae3ad4f22d0683e3ce548d9c25365fde6e)
[[ DDS ] Allow for vm_service >=14.0.0 <16.0.0 for package:dds and
package:dds_service_extensions](https://dart.googlesource.com/sdk.git/+/1eee8bae3ad4f22d0683e3ce548d9c25365fde6e)
by Ben Konyi · 4 days ago

[9ab2316](https://dart.googlesource.com/sdk.git/+/9ab2316d32ad5fced73c6716b0b0cde9a55c2138)
[refactor dartdev
deps](https://dart.googlesource.com/sdk.git/+/9ab2316d32ad5fced73c6716b0b0cde9a55c2138)
by Devon Carew · 4 days ago

[2b1f956](https://dart.googlesource.com/sdk.git/+/2b1f956207c7ceac3723ff0b088503bffa4fe490)
[[element model] migrate
`driver`](https://dart.googlesource.com/sdk.git/+/2b1f956207c7ceac3723ff0b088503bffa4fe490)
by pq · 4 days ago

[f8f10b8](https://dart.googlesource.com/sdk.git/+/f8f10b84076e8628b893a158cc32585c75dd4176)
[[dart2wasm] Add annotations to member and static
intrinsics.](https://dart.googlesource.com/sdk.git/+/f8f10b84076e8628b893a158cc32585c75dd4176)
by Nate Biggs · 4 days ago

[3202683f](https://dart.googlesource.com/sdk.git/+/3202683fe47541d71721a73e592d1174ad28c317)
[Version
3.7.0-313.0.dev](https://dart.googlesource.com/sdk.git/+/3202683fe47541d71721a73e592d1174ad28c317)
by Dart CI · 4 days ago
[3.7.0-313.0.dev](https://dart.googlesource.com/sdk.git/+/refs/tags/3.7.0-313.0.dev)

[f49c620](https://dart.googlesource.com/sdk.git/+/f49c620ab34d13ead00fa3bb98b651f8db44484e)
[[analyzer][cfe] Share inference-using-bounds
routines](https://dart.googlesource.com/sdk.git/+/f49c620ab34d13ead00fa3bb98b651f8db44484e)
by Chloe Stefantsova · 5 days ago

[a6b99af](https://dart.googlesource.com/sdk.git/+/a6b99afdeaff69f1ca67baf34c90d47fdc355883)
[[cfe] Create fields through
SourcePropertyBuilder](https://dart.googlesource.com/sdk.git/+/a6b99afdeaff69f1ca67baf34c90d47fdc355883)
by Johnni Winther · 5 days ago

[ad562fd](https://dart.googlesource.com/sdk.git/+/ad562fdbbe1a260afbc8aeea8c0bc9dab1f1a2e1)
[[parser] Rename accidentally committed 'allowLazyFoo'
parameter](https://dart.googlesource.com/sdk.git/+/ad562fdbbe1a260afbc8aeea8c0bc9dab1f1a2e1)
by Jens Johansen · 5 days ago

[9b631bf](https://dart.googlesource.com/sdk.git/+/9b631bf33362be3bf359896fb4b1aa58a12ea602)
[[deps] Roll
dart-lang/native](https://dart.googlesource.com/sdk.git/+/9b631bf33362be3bf359896fb4b1aa58a12ea602)
by Liam Appelbe · 5 days ago

[6a1f9ed](https://dart.googlesource.com/sdk.git/+/6a1f9ed029c7d3c949dbadf0973e688ff7366d75)
[[analysis_server] Insert new arguments before last child/children
arguments](https://dart.googlesource.com/sdk.git/+/6a1f9ed029c7d3c949dbadf0973e688ff7366d75)
by Danny Tuppeny · 5 days ago

[e9a6d62](https://dart.googlesource.com/sdk.git/+/e9a6d62fa429d92ab300c16c3e24f05838572bd4)
[[analysis_server] Return EditableArguments in parameter
order](https://dart.googlesource.com/sdk.git/+/e9a6d62fa429d92ab300c16c3e24f05838572bd4)
by Danny Tuppeny · 5 days ago

[5d5d223](https://dart.googlesource.com/sdk.git/+/5d5d223b4ae197a312d6254d97846f3a34ad758e)
[linter: fix strict_top_level_inference
registry](https://dart.googlesource.com/sdk.git/+/5d5d223b4ae197a312d6254d97846f3a34ad758e)
by Sam Rawlins · 5 days ago

[302287e](https://dart.googlesource.com/sdk.git/+/302287eed2ec5b8bddfdd90c3af93175f9e87daa)
[[tests] Enum shorthands - Selector chain tests for cascades, ??,
collections and nested
contexts.](https://dart.googlesource.com/sdk.git/+/302287eed2ec5b8bddfdd90c3af93175f9e87daa)
by Kallen Tu · 5 days ago

[b9de4ae](https://dart.googlesource.com/sdk.git/+/b9de4ae02d47ae8fecf385753c5a114643c48062)
[[CQ] remove trailing whitespace from `unnecessary_underscores_test`
source](https://dart.googlesource.com/sdk.git/+/b9de4ae02d47ae8fecf385753c5a114643c48062)
by pq · 5 days ago

[c1ce43f](https://dart.googlesource.com/sdk.git/+/c1ce43fd8342d854f841edd6dcd4074326dc9fbf)
[[ddc] Remove unsound dart2js
dependency](https://dart.googlesource.com/sdk.git/+/c1ce43fd8342d854f841edd6dcd4074326dc9fbf)
by Nicholas Shahan · 5 days ago

[b69f6c1](https://dart.googlesource.com/sdk.git/+/b69f6c129480ea14ff16075b346ec1680f894308)
[[CQ] add missing `scope_util_test` to all test
suite](https://dart.googlesource.com/sdk.git/+/b69f6c129480ea14ff16075b346ec1680f894308)
by pq · 5 days ago

[edde039](https://dart.googlesource.com/sdk.git/+/edde03955b15c6a38c58fe2637dbc52439cb8686)
[[element model] migrate
`element_visitors_test`](https://dart.googlesource.com/sdk.git/+/edde03955b15c6a38c58fe2637dbc52439cb8686)
by pq · 5 days ago

[31d8adf](https://dart.googlesource.com/sdk.git/+/31d8adf1f3b9375e5a7af9fc81f8d28738d878e7)
[Elements. Migrate
lib/src/utilities/change_builder/change_builder_core.dart](https://dart.googlesource.com/sdk.git/+/31d8adf1f3b9375e5a7af9fc81f8d28738d878e7)
by Konstantin Shcheglov · 5 days ago

[11f53fd](https://dart.googlesource.com/sdk.git/+/11f53fd7d237d17ad940e35f43a2f963b4a5ed8c)
[[analysis_server] Preserve existing quote kinds when updating string
arguments](https://dart.googlesource.com/sdk.git/+/11f53fd7d237d17ad940e35f43a2f963b4a5ed8c)
by Danny Tuppeny · 5 days ago

[fc95268](https://dart.googlesource.com/sdk.git/+/fc95268a36197a2bf9976d7f1a96e2a83753ebe4)
[[ResidentFrontendServer] Cache the compiler options that were last
used](https://dart.googlesource.com/sdk.git/+/fc95268a36197a2bf9976d7f1a96e2a83753ebe4)
by Derek Xu · 5 days ago

[337e07f](https://dart.googlesource.com/sdk.git/+/337e07fab6b415e96d3554bc23a8da69507d7745)
[[VM/Service] Use the resident frontend server for hot reload when it's
available](https://dart.googlesource.com/sdk.git/+/337e07fab6b415e96d3554bc23a8da69507d7745)
by Derek Xu · 5 days ago

[8785c4e](https://dart.googlesource.com/sdk.git/+/8785c4e000167376f57aaed7ce1d016def2b11ff)
[Elements. Migrate
lib/utilities/range_factory.dart](https://dart.googlesource.com/sdk.git/+/8785c4e000167376f57aaed7ce1d016def2b11ff)
by Konstantin Shcheglov · 5 days ago

[8121b02](https://dart.googlesource.com/sdk.git/+/8121b02725d5412394841da173fb39ca27346de2)
[Elements. Migrate
test/support/abstract_context.dart](https://dart.googlesource.com/sdk.git/+/8121b02725d5412394841da173fb39ca27346de2)
by Konstantin Shcheglov · 5 days ago

[f3e68f2](https://dart.googlesource.com/sdk.git/+/f3e68f2d76c63318ad29ebea5a81acb724f4284e)
[[Migrate]
sdk_constraint_verifier.dart](https://dart.googlesource.com/sdk.git/+/f3e68f2d76c63318ad29ebea5a81acb724f4284e)
by Brian Wilkerson · 5 days ago

[491f4f4](https://dart.googlesource.com/sdk.git/+/491f4f48139c08c0be8ee6d346fe7e07922075fb)
[[CQ] Remove dead code from
ElementLocationImpl](https://dart.googlesource.com/sdk.git/+/491f4f48139c08c0be8ee6d346fe7e07922075fb)
by Brian Wilkerson · 5 days ago
 2025-01-14 05:54:34 +00:00
Michael Goderbauer
9cab4ffee1
Use wildcards (#161548) 
https://dart.dev/language/pattern-types#wildcard
 2025-01-14 05:13:41 +00:00
Matan Lurey
d102e1197e
Remove references to cirrus, mostly in doc comments. (#161529) 
Towards https://github.com/flutter/flutter/issues/161387.
 2025-01-13 23:49:04 +00:00
Jim Graham
366ed7f972
Fix paths when running clang-tidy on git diffs (#161496) 
The working directory was `engine/src/flutter` but all of the file names
already had those parent directories on them so we'd be trying to find
build commands for `engine/src/flutter/engine/src/flutter`. This change
tells the git commands to make the file names relative to the working
directory (which is already `engine/src/flutter`).

Someone more familiar with the `--lint-head` option should double check
its operation since I wasn't sure exactly what it was supposed to do,
but the list of files it generated looked correct.
 2025-01-13 23:49:03 +00:00
Yegor
0d906f5ecf
[web:a11y] treat empty tappables as buttons (#161360) 
The situation will improve even further when we have proper ARIA roles,
but for now if a node is a leaf node and has a tap action, present it to
semantics as a button even if the `isButton` flag is missing.

Fixes https://github.com/flutter/flutter/issues/157743
 2025-01-13 23:47:58 +00:00
Matan Lurey
1d38029c3b
Copy linux_host_engine as linux_host_engine_test, removing archives: [...]. (#161532) 
Towards https://github.com/flutter/flutter/issues/161406.

The goal is to, assuming this is WAI, move the `bringup: true` build
(the newly created one) to presubmit, and then in a follow-up PR, remove
the `tests: [...]` (and test dependencies) from
`linux_host_engine.json`, meaning that it would be a build/archive only
builder, and this _new_ builder would be a build/test one.

We talked about it being hypothetically better to _not_ build the engine
multiple times, and decided for now to depend on RBE and not try to
create stages or download artifacts created from another builder, but if
@zanderso has another suggestion here is the place to chime in :)

(Btw if we like this approach, I'll create a task list of every builder
that needs to be migrated)
 2025-01-13 23:45:41 +00:00
Matan Lurey
1d79946ecb
Remove last two references to Cirrus CI. (#161530) 
Towards https://github.com/flutter/flutter/issues/161387.
 2025-01-13 23:44:40 +00:00
Chinmay Garde
432843a0f3
[Impeller] Update guidance on prebuilt artifacts. (#161251) 2025-01-13 19:44:37 +00:00
Jim Graham
d80be471dd
Migrate DisplayList unit tests to DL/Impeller geometry classes (#161453) 
Address the first item in
https://github.com/flutter/flutter/issues/161456 (Unit tests in the
display_list/ directory)

Some new `DlPath::Make<Shape>` factories were added to make test writing
simpler.

`DlPath` is now bi-directional! You can construct one from either an
`SkPath` or an `impeller::Path` and it will auto-convert to the other as
needed. This allows unit tests with custom paths to rely on
`impeller::Path` for path construction instead of `SkPath` (as long as
only simple move/line/quad/curve verbs are needed).

`RoundRect` now normalizes the argument rect in all constructors to
match Flutter expectations and `SkRRect` legacy behavior. This behavior
was already being enforced in `ui.rrect` but the unit tests we have to
verify the behavior are written against the `RoundRect` object itself so
this was the simplest way to make the unit tests work right, while
ensuring that we maintain correct behavior for `ui` objects. Ideally
these issues would be tested at the `ui` native interface instead of as
unit tests on our internal objects and we should be allowed to decide
how we want our internal APIs to behave with regard to this concept.

Skia inverted path types are no longer allowed in `DlPath` and all use
of them should be eliminated in the engine (except to test if they crash
when used in a debug unit test)

A couple of unit tests for `DlOpSpy` and Impeller's interop package were
migrated here along for the ride even though this PR was focused
primarily on `display_list/` unit tests.
 2025-01-13 19:28:57 +00:00
Jonah Williams
ee8aab77fe
[Impeller] remove API 30 restriction for SurfaceControl testing. (#161438) 
In order to give a minimal repro for the AHB issues to folks, I need to
be able to show that while it _should_ work on API 29 it doesn't in a
number of places.. Since this AHB swapchain is off by default this will
have no impact on production applications.
 2025-01-13 17:41:50 +00:00
Robert Ancell
d14140f854
Provide monitor information. (#161359) 
Fixes https://github.com/flutter/flutter/issues/144230
 2025-01-12 21:20:40 +00:00
chunhtai
6b8b57913d
add semantics role and tab (#161260) 
fixes https://github.com/flutter/flutter/issues/157134

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-01-11 00:08:55 +00:00