DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
35,527 Commits 882 Branches 1,069 Tags
Commit Graph

27024 Commits

Author SHA1 Message Date
Matan Lurey
ea78cc7551 Move setting the logging level into the Logger constructor, refactor. (flutter/engine#52624) 
Based on @zanderso's feedback here: https://github.com/flutter/engine/pull/52619#discussion_r1592868979.

I think this is the most succinct way to setup logging, it also doesn't seem to make sense to allow the level to be configured at runtime, so boom.
 2024-05-07 21:00:54 +00:00
auto-submit[bot]
b607f660d1 Reverts "Add host_profile_arm64 and host_release_arm64 local engine configurations. (#52620)" (flutter/engine#52630) 
Reverts: flutter/engine#52620
Initiated by: zanderso
Reason for reverting: Builds timing out in post submit. I think we should try relanding this with `--no-lto` passed to `gn`.
Original PR Author: chinmaygarde

Reviewed By: {zanderso}

This change reverts the following previous change:
These are used on macOS hosts during local engine development.
 2024-05-07 20:34:51 +00:00
Matan Lurey
8618834019 Move verbose to environment.verbose, pass to ninja --verbose if provided. (flutter/engine#52619) 
Closes https://github.com/flutter/flutter/issues/147894.

While doing this PR I realized we were basically passing `(bool verbose, Envrionment)` as a tuple around, so I just moved the concept _into_ `Environment` directly, and made the necessary code changes across the tool and tests.

To clarify, this does _not_ mimic the output of `ninja --verbose` _today_, because we also don't stream the output directly, and instead do terminal magic. Combined with a hypothetical fix for https://github.com/flutter/flutter/issues/147903, this would work exactly the same as before.

/cc @loic-sharma @johnmccutchan
 2024-05-07 19:07:31 +00:00
Chinmay Garde
efda632b5e Add host_profile_arm64 and host_release_arm64 local engine configurations. (flutter/engine#52620) 
These are used on macOS hosts during local engine development.
 2024-05-07 18:52:22 +00:00
Chinmay Garde
0e83a760ef [Impeller] Wait for the previous AHB texture to be fully recyclable. (flutter/engine#52588) 
The Android surface transaction completion handler documentation states:

```
Buffers which are replaced or removed from the scene in the transaction
invoking this callback may be reused after this point.
```

However, this is NOT sufficient. One also needs to be obtain the previous release fence and perform a wait for the buffer to be safely reusable.

This patch adds a GPU side wait for this fence using available extensions.

Fixes https://github.com/flutter/flutter/issues/147758
 2024-05-07 18:33:50 +00:00
Jason Simmons
5b7970fdb3 Manual Skia roll to 2319f1ae8fe42525f8b6a1969a1cee67bdbee290 (flutter/engine#52615) 
This commit added a new source file (src/codec/SkJpegMetadataDecoderImpl.cpp)
 2024-05-07 18:21:05 +00:00
Jonah Williams
96584fbd2b [Impeller] allow cloning a rectangle packer with an increased size. (flutter/engine#52563) 
Work towards https://github.com/flutter/flutter/issues/138798

Allow cloning a rectangle packer with all existing skylines preserved, but the size increased. This will allow us to preserve the positioning and state of all glyphs when the atlas size is increased, which is necessary for the "blit contents to top right of new texture" approach for improving append performance.
EDIT: I mean top left!
 2024-05-07 18:09:54 +00:00
auto-submit[bot]
9c144b5c05 Reverts "Various documentation improvements (#52600)" (flutter/engine#52607) 
Reverts: flutter/engine#52600
Initiated by: zanderso
Reason for reverting: Failing to roll to the framework on a snippet analysis failure: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8748612253464522177/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout
Original PR Author: Hixie

Reviewed By: {jonahwilliams}

This change reverts the following previous change:
No description provided.
 2024-05-07 14:09:47 +00:00
Ian Hickson
a6ad5a09b2 Various documentation improvements (flutter/engine#52600) 2024-05-07 06:59:54 +00:00
dependabot[bot]
6b63ba17bf Bump actions/checkout from 4.1.4 to 4.1.5 (flutter/engine#52599) 
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.4 to 4.1.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.5</h2>
<h2>What's Changed</h2>
<ul>
<li>Update NPM dependencies by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1703">actions/checkout#1703</a></li>
<li>Bump github/codeql-action from 2 to 3 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1694">actions/checkout#1694</a></li>
<li>Bump actions/setup-node from 1 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1696">actions/checkout#1696</a></li>
<li>Bump actions/upload-artifact from 2 to 4 by <a href="https://github.com/dependabot"><code>@​dependabot</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1695">actions/checkout#1695</a></li>
<li>README: Suggest <code>user.email</code> to be <code>41898282+github-actions[bot]@users.noreply.github.com</code> by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1707">actions/checkout#1707</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.4...v4.1.5">https://github.com/actions/checkout/compare/v4.1.4...v4.1.5</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="44c2b7a8a4"><code>44c2b7a</code></a> README: Suggest <code>user.email</code> to be `41898282+github-actions[bot]<a href="https://github.com/users"><code>@​users</code></a>.norepl...</li>
<li><a href="8459bc0c7e"><code>8459bc0</code></a> Bump actions/upload-artifact from 2 to 4 (<a href="https://redirect.github.com/actions/checkout/issues/1695">#1695</a>)</li>
<li><a href="3f603f6d5e"><code>3f603f6</code></a> Bump actions/setup-node from 1 to 4 (<a href="https://redirect.github.com/actions/checkout/issues/1696">#1696</a>)</li>
<li><a href="fd084cde18"><code>fd084cd</code></a> Bump github/codeql-action from 2 to 3 (<a href="https://redirect.github.com/actions/checkout/issues/1694">#1694</a>)</li>
<li><a href="9c1e94e0ad"><code>9c1e94e</code></a> Update NPM dependencies (<a href="https://redirect.github.com/actions/checkout/issues/1703">#1703</a>)</li>
<li>See full diff in <a href="0ad4b8fada...44c2b7a8a4">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.4&new-version=4.1.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
 2024-05-07 06:39:06 +00:00
Jonah Williams
e0776c228d [Impeller] AHB swapchain mark frame start for tracer. (flutter/engine#52596) 
https://flutter-flutter-perf.skia.org/e/?begin=1713561746&end=1715051005&queries=device_type%3DPixel_7_Pro%26sub_result%3Daverage_gpu_frame_time%26test%3Dnew_gallery_impeller__transition_perf&requestType=0&selected=commit%3D40670%26name%3D%252Carch%253Dintel%252Cbranch%253Dmaster%252Cconfig%253Ddefault%252Cdevice_type%253DPixel_7_Pro%252Cdevice_version%253Dnone%252Chost_type%253Dlinux%252Csub_result%253Daverage_gpu_frame_time%252Ctest%253Dnew_gallery_impeller__transition_perf%252C 

still not fixed because I also forgot the start
 2024-05-07 05:32:29 +00:00
Jonah Williams
5a028e336d [Impeller] eagerly bootstrap content context. (flutter/engine#52590) 
![image](https://github.com/flutter/engine/assets/8975114/5238d169-a68b-4905-848b-3ee7a7972de8)

Work around for https://github.com/flutter/flutter/issues/143540 by running shader bootstrap as early as possible. I was looking at this code for unrelated reasons (include removal) and realized it would be a trivial change.

If we're using the KHR swapchain instead of the AHB swapchain, in theory the pixel format could change but since we hash the pixel format the only bad thing would be the wasted work.
 2024-05-07 03:05:18 +00:00
Jonah Williams
268bf3b9f1 [Impeller] add clip coverage stack to exp canvas. (flutter/engine#52215) 
Uses clip scissor and clip stack to update the clip state. This is working now!

https://github.com/flutter/flutter/issues/142054
 2024-05-07 00:06:21 +00:00
Chinmay Garde
53df9809c9 [Impeller] Document how to use Impeller as a standalone library with OpenGL ES and EGL. (flutter/engine#52473) 
Preview: https://github.com/chinmaygarde/flutter_engine/blob/impeller_gl_porting_guide/impeller/docs/standalone_gles.md
 2024-05-06 23:50:16 +00:00
Jonah Williams
3c4c7be89a [Impeller] remove compute tessellator. (flutter/engine#52584) 
We don't have any plans to use this in the near term. The algorithm works but can easily run out of memory, and would need to be entirely reworked to manage memory allocations.
 2024-05-06 21:27:55 +00:00
Jason Simmons
c1e5a9c1a3 Migrate third_party/android_tools to flutter/third_party (flutter/engine#52582) 
Continuation of https://github.com/flutter/engine/pull/52034
 2024-05-06 20:54:06 +00:00
skia-flutter-autoroll
a8a9d1dedc Roll Skia from a5c042cb4b12 to 869cacf2a3f1 (1 revision) (flutter/engine#52583) 
https://skia.googlesource.com/skia.git/+log/a5c042cb4b12..869cacf2a3f1

2024-05-06 michaelludwig@google.com [graphite] Call notifyInUse() on images not known until AddToKey is called

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 20:14:33 +00:00
Jonah Williams
afb9eb545c [Impeller] remove unused includes. (flutter/engine#52579) 
mostly removing unused fml/macros, but a few others that clangd surfaced. This compiled locally,hope it works on CI!
 2024-05-06 19:51:08 +00:00
skia-flutter-autoroll
68c3f04f94 Roll Skia from da772ace76ff to a5c042cb4b12 (6 revisions) (flutter/engine#52581) 
https://skia.googlesource.com/skia.git/+log/da772ace76ff..a5c042cb4b12

2024-05-06 bungeman@google.com Mark all Test-Fontations jobs as NativeFonts
2024-05-06 kjlubick@google.com Remove non-standard verb from SVG parsing
2024-05-06 michaelludwig@google.com [graphite] Remove unnecessary check in onNewImageSnapshot()
2024-05-06 michaelludwig@google.com [graphite] Don't rewrap TextureProxy in a new Image in RescaleImage()
2024-05-06 kjlubick@google.com Remove empty directory
2024-05-06 kjlubick@google.com Expand test coverage of partial SVG paths

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 19:12:21 +00:00
Jonah Williams
b35cbca6ed [Impeller] fix missing GPU probe. (flutter/engine#52580) 
Fixes https://github.com/flutter/flutter/issues/147723

The test that covers this is the benchmarks in the framework repo. Unfortunately emulators do not support the APIs needed to execute this code in the engine repo.
 2024-05-06 18:59:12 +00:00
skia-flutter-autoroll
8387629491 Roll Skia from 29e77cd14063 to da772ace76ff (2 revisions) (flutter/engine#52578) 
https://skia.googlesource.com/skia.git/+log/29e77cd14063..da772ace76ff

2024-05-06 kjlubick@google.com Add dedicated fuzzer for SVG parsing code
2024-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from b94ef82a4b1e to a87c5333bf91 (48 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 18:07:15 +00:00
skia-flutter-autoroll
48ace23439 Roll Fuchsia Linux SDK from Ieb4BPN0ZIRRgYl4y... to 27ZAbzJkEopmu0Emp... (flutter/engine#52576) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 16:53:49 +00:00
skia-flutter-autoroll
9358e08209 Roll Skia from 4754c3fd6b73 to 29e77cd14063 (3 revisions) (flutter/engine#52577) 
https://skia.googlesource.com/skia.git/+log/4754c3fd6b73..29e77cd14063

2024-05-06 bungeman@google.com [fontations] Treat sbix more like FreeType
2024-05-06 johnstiles@google.com Fix MSAN use-of-uninitialized-value error in libjpeg.
2024-05-06 kjlubick@google.com Make skunicode_icu for android depend only on icu headers

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 16:53:48 +00:00
Jason Simmons
6964119253 Skip files in the clang-tidy driver if clang-tidy crashes when processing the file (flutter/engine#52379) 
Recent versions of clang-tidy have been segfaulting when processing a few of the engine source files.  This patch skips over those errors so that the engine can roll Clang.

See https://github.com/flutter/flutter/issues/143178
 2024-05-06 14:48:53 +00:00
skia-flutter-autoroll
7c751d83b2 Roll Skia from 2da0f29636d3 to 3bc48d128d4b (1 revision) (flutter/engine#52574) 
https://skia.googlesource.com/skia.git/+log/2da0f29636d3..3bc48d128d4b

2024-05-06 rmistry@google.com Revert "Bump the npm_and_yarn group across 8 directories with 11 updates"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 14:45:18 +00:00
skia-flutter-autoroll
ecabda2c60 Roll Skia from 7f582d054385 to 2da0f29636d3 (1 revision) (flutter/engine#52573) 
https://skia.googlesource.com/skia.git/+log/7f582d054385..2da0f29636d3

2024-05-06 49699333+dependabot[bot]@users.noreply.github.com Bump the npm_and_yarn group across 8 directories with 11 updates

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 13:41:37 +00:00
skia-flutter-autoroll
45fff19c4b Roll Skia from 2365dff19ed4 to 1454154ed14e (1 revision) (flutter/engine#52571) 
https://skia.googlesource.com/skia.git/+log/2365dff19ed4..1454154ed14e

2024-05-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 252d184177c3 to 69c4b5eb737c (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,egdaniel@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-06 05:53:06 +00:00
skia-flutter-autoroll
cc53ce6d04 Roll Fuchsia Linux SDK from PqcaFvWlaz5ZrFcpC... to Ieb4BPN0ZIRRgYl4y... (flutter/engine#52569) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-05 15:07:18 +00:00
skia-flutter-autoroll
92eb43077e Roll Fuchsia Linux SDK from QDv0tal7_BgoZx0ju... to PqcaFvWlaz5ZrFcpC... (flutter/engine#52560) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-04 13:53:32 +00:00
skia-flutter-autoroll
0e280d9eb0 Roll Skia from f9409f6a7ad3 to 95302626a8df (1 revision) (flutter/engine#52554) 
https://skia.googlesource.com/skia.git/+log/f9409f6a7ad3..95302626a8df

2024-05-03 michaelludwig@google.com [graphite] Define ScratchResourceManager

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 23:38:22 +00:00
skia-flutter-autoroll
e4e2f912c4 Roll Skia from ad143675a4d2 to f9409f6a7ad3 (1 revision) (flutter/engine#52553) 
https://skia.googlesource.com/skia.git/+log/ad143675a4d2..f9409f6a7ad3

2024-05-03 bungeman@google.com [fontations] Correct CBDT glyph bounds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 22:26:50 +00:00
skia-flutter-autoroll
921439b072 Roll Skia from 82c0277acaf8 to ad143675a4d2 (1 revision) (flutter/engine#52552) 
https://skia.googlesource.com/skia.git/+log/82c0277acaf8..ad143675a4d2

2024-05-03 bungeman@google.com Fontations to vary font style with variation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 20:17:49 +00:00
skia-flutter-autoroll
65975504c9 Roll Skia from 1b72286d0319 to 82c0277acaf8 (1 revision) (flutter/engine#52551) 
https://skia.googlesource.com/skia.git/+log/1b72286d0319..82c0277acaf8

2024-05-03 bungeman@google.com Don't turn italic into oblique in FreeType

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 19:11:08 +00:00
skia-flutter-autoroll
ffd49f3d25 Roll Skia from 6ca5507db3e1 to 1b72286d0319 (2 revisions) (flutter/engine#52550) 
https://skia.googlesource.com/skia.git/+log/6ca5507db3e1..1b72286d0319

2024-05-03 michaelludwig@google.com [graphite] Pare down pipeline labels' texture info details
2024-05-03 johnstiles@google.com Ensure that fImage[] always has at least one element.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 18:06:33 +00:00
skia-flutter-autoroll
360dc9896b Roll Skia from 92d762cfe00b to 7b1e131050a0 (1 revision) (flutter/engine#52547) 
https://skia.googlesource.com/skia.git/+log/92d762cfe00b..7b1e131050a0

2024-05-03 ccameron@chromium.org Remove APP15-based gainmap support

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 16:09:24 +00:00
skia-flutter-autoroll
e5c8ef3e26 Roll Skia from 37b9f707ce96 to 92d762cfe00b (1 revision) (flutter/engine#52546) 
https://skia.googlesource.com/skia.git/+log/37b9f707ce96..92d762cfe00b

2024-05-03 kjlubick@google.com Roll ICU used for testing (and shipped with CanvasKit)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 15:05:49 +00:00
skia-flutter-autoroll
bd6faa1151 Roll Fuchsia Linux SDK from cScmnvKM3py9E2087... to QDv0tal7_BgoZx0ju... (flutter/engine#52543) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 11:46:21 +00:00
skia-flutter-autoroll
b5b17ff361 Roll Dart SDK from 138695ec00bd to 33bb0f4b0770 (1 revision) (flutter/engine#52542) 
https://dart.googlesource.com/sdk.git/+log/138695ec00bd..33bb0f4b0770

2024-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-129.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 08:12:03 +00:00
skia-flutter-autoroll
3833b53247 Roll Skia from d2f0fd0faf90 to 8f5808650129 (1 revision) (flutter/engine#52541) 
https://skia.googlesource.com/skia.git/+log/d2f0fd0faf90..8f5808650129

2024-05-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1092e40f5ba5 to 252d184177c3 (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 06:29:21 +00:00
skia-flutter-autoroll
5d228f845b Roll Dart SDK from 03b7868a71ae to 138695ec00bd (1 revision) (flutter/engine#52539) 
https://dart.googlesource.com/sdk.git/+log/03b7868a71ae..138695ec00bd

2024-05-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-128.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 04:09:19 +00:00
Dustin Green
561a3c968b [fuchsia] route fuchsia.sysmem2.Allocator pt 2 (flutter/engine#52509) 
Fuchsia's fake-display will be migrating to sysmem2, which requires
fuchsia.sysmem2.Allocator to be routed.

fixes https://github.com/flutter/flutter/issues/146858
 2024-05-02 18:43:30 -07:00
Jason Simmons
1b28d5a898 [et] Add Linux host_debug_unopt local engine builder (flutter/engine#52538) 2024-05-03 01:34:30 +00:00
Brandon DeRosier
5b35095a8e [et] Add ios_debug_unopt build config. (flutter/engine#52537) 
Resolves https://github.com/flutter/flutter/issues/147757
 2024-05-03 01:28:22 +00:00
Brandon DeRosier
7130c5c3b3 [Impeller] Remove Entity capture/AiksInspector. (flutter/engine#52526) 
Resolves https://github.com/flutter/flutter/issues/134748.

This was a really fun experiment. I learned a lot from it, and it genuinely helped me solve some coverage-related problems, but the reality is it was too little too late -- by the time we had this capture system, we had already solved most of the problems that would have benefitted from this.

It's been a few months since I've used or extended the capabilities of this capture system for something, and I don't have the spare time/energy to give it the love it needs to realize the vision I had for it. I still almost exclusively use a combination of native frame captures and print debugging to solve problems.

RIP in peace.
 2024-05-03 01:08:22 +00:00
skia-flutter-autoroll
c00314985f Roll Dart SDK from 0316fa44b401 to 03b7868a71ae (1 revision) (flutter/engine#52534) 
https://dart.googlesource.com/sdk.git/+log/0316fa44b401..03b7868a71ae

2024-05-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-127.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-03 00:03:21 +00:00
Harry Terkelsen
b28f8f5c42 [canvaskit] Round physical size to nearest whole number pixels (flutter/engine#52467) 
The physical size is computed by multiplying the browser's `innerWidth`
and `innerHeight` by the `devicePixelRatio`. The physical size should be
an integer number of pixels. However, there may be some imprecision and
the result of the multiplication is not quite an integer. This change
rounds the physical size to integers before using them for drawing the
scene.

Fixes https://github.com/flutter/flutter/issues/144869

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-05-02 16:16:50 -07:00
gaaclarke
3892592ee1 Updated RBE documentation for default credentials. (flutter/engine#52530) 
issue https://github.com/flutter/flutter/issues/147739

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-02 22:03:23 +00:00
Juanjo Tugores
3ec84538ca Put the view focus functionality behind a (disabled by default) flag (flutter/engine#52527) 
Put the view focus functionality behind a (disabled by default) flag

Should unblock https://github.com/flutter/flutter/pull/143259

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-05-02 21:27:23 +00:00
skia-flutter-autoroll
68f57e4fc2 Roll Skia from f9671ecda7da to 716e757c1ffb (5 revisions) (flutter/engine#52528) 
https://skia.googlesource.com/skia.git/+log/f9671ecda7da..716e757c1ffb

2024-05-02 jvanverth@google.com [graphite] Add option to DrawAtlas to allow use of storage textures
2024-05-02 nscobie@google.com Make ATrace backend record arguments as sub-events in Android framework
2024-05-02 bungeman@google.com [fontations] Use CBDT advances
2024-05-02 egdaniel@google.com [Graphite] Fix Emscripten build after label change.
2024-05-02 jvanverth@google.com [graphite] Change GraphiteDawnTestContext to use new devicelost setup

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,kjlubick@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-05-02 21:19:08 +00:00
Brandon DeRosier
89f27d1eda [Impeller] Remove checkerboard. (flutter/engine#52524) 
I added this feature a long time ago on a rainy afternoon, and @gaaclarke mentioned that it's being removed from the framework anyway. We should just remove this if that's the case.
 2024-05-02 20:28:35 +00:00