1232 Commits

Author SHA1 Message Date
Yegor
570b474728
Implement local, locales, and onLocaleChanged for the web (#18137)
* implement `locale`, `locales`, and `onLocaleChanged` in the web version of `Window.

Co-authored-by: Simon Lightfoot <simon@devangels.london>
2020-05-16 10:10:32 -07:00
nturgut
c39f859f03
fix the issue in the test and remove them from the blacklist for chrome (#18441) 2020-05-15 17:47:51 -07:00
Yegor
f6847b1c17
sync ui geometry.dart into web_ui geometry.dart; add null safety annotations (#18356)
sync ui geometry.dart into web_ui geometry.dart; add null safety
2020-05-15 17:09:14 -07:00
Chris Bracken
af2b806700
null-annotate native calls in lib/ui/semantics.dart (#18436)
Also covers counterparts of these calls in web_ui.
2020-05-15 16:28:00 -07:00
Chris Bracken
fb21b34f02
null-annotate native calls in lib/ui/window.dart (#18430) 2020-05-15 15:38:57 -07:00
Chris Bracken
430a107e20
Delete unused web_ui RuntimeDelegate, Engine (#18429)
These were part of the old compositor but no longer referenced anywhere
in the web engine.
2020-05-15 14:11:56 -07:00
Ferhat
c2347aad5a [web] Implement setPreferredOrientation (#18432)
* Implement preferred orientation
* update comments
2020-05-15 13:48:20 -07:00
nturgut
cb71dcd377
Run integration tests on luci, use cipd package for Chrome (#18180)
* try to run integration tests on luci

* adds extra logs to check if chrome is on lUCI

* use the cipd chrome package for integration tests in LUCI

* add driver version for chrome 83.(cipd package has 83 now)

* no headless mode didn't worked on the bots. try the other option

* On LUCI also use chrome driver as a cipd package

* change the directory name to fit the cpid package

* adding blacklist functionality

* remove logs added for troubleshooting. remove the check that blocks int-test runs on LUCI

* add more comments to blacklists

* also use CIPD package chrome for unit tests

* addressing reviewer comments

* run integration tests first, upon reviewer request

* fix bug. keep running integration tests after unit tests

* update the logs for LUCI

* fix todo comments
2020-05-15 12:46:53 -07:00
Chris Bracken
dc7e24e15a
null-annotate lib/ui/natives.dart (#18349) 2020-05-15 09:33:11 -07:00
Jason Simmons
73e9ce878e
Manual Dart roll to 95e11bc2d30f7c1b9c49a4fc97a44c4b32fe66d8 (#18398) 2020-05-14 19:47:02 -07:00
Yegor
b37427eaaf
null-annotate compositing.dart (#18351) 2020-05-14 19:16:28 -07:00
Yegor
609519ec14
release previous canvas when picture is not painted (#18404) 2020-05-14 18:25:13 -07:00
Ferhat
e24c1282d5
[web] Remap cupertino fonts to -apple-system (#18388)
* Remap cupertino fonts to -apple-system
* Update text tests for fallback checks
2020-05-14 17:22:34 -07:00
nturgut
8deea8ed04
[web] change viewinsets instead of physical size for keyboard (#18328)
* changing viewInsets instead of physicalSize during text editing on mobile devices

* fix indentation

* fixing rotation issues. recalculating insets after physical size change. addressing reviewer comments

* make ui.windowpadding abstract. adding windowpadding implementation to engine.
2020-05-14 16:59:31 -07:00
Chris Bracken
7e12824978
null-annotate lib/ui/pointer.dart (#18354) 2020-05-14 15:17:29 -07:00
Chris Bracken
4afc2b4d65
null-annotate lib/ui/plugins.dart (#18353) 2020-05-14 15:16:28 -07:00
Chris Bracken
b415c239f7
null-annotate lib/ui/isolate_name_server.dart (#18352) 2020-05-14 15:15:05 -07:00
Chris Bracken
08b61ce561
Delete unused decode UTF-8, JSON functions (#18360)
These were added in 7e5d63513a7ae854605dbd38582cead55594e9f0 for use in
_handleNavigationMessage. That function was deleted in
f37aafd456fc6a1c2dba5bc1b63123b0e665e6cd, but the support methods were
left in the code. `// ignore: unused` annotations were added to all
private native entry points by dnfield (to work around what is arguably
a bug) in 6179ac637724e8f93b7f3c8dcfda93a6b9b7995e, and were applied to
these two methods, I suspect unintentionally.

In any case, they appear entirely unused at present.
2020-05-14 09:12:28 -07:00
Yegor
bf1287c120
null-annotate lerp.dart, annotations.dart, channel_buffers.dart, hash_codes.dart (#18348) 2020-05-13 16:35:22 -07:00
Jason Simmons
9e3e3ba687
[web] Represent CSS identity transforms as 'none' instead of null (#18288) 2020-05-13 11:47:03 -07:00
Ferhat
21b4d2f1f8
[web] Fix paragraph positioning (#18329)
* Fix text positioning
* Update golden locks
2020-05-13 09:09:18 -07:00
Ferhat
ff6942f57b
Add fontFeatures and decorationThickness to textstyle (#18235) 2020-05-08 15:20:38 -07:00
Nurhan Turgut
1b3b4ec88f
skip font loading tests for safari (#18232) 2020-05-08 13:30:13 -07:00
Yegor
703525502b
make compiler worker count configurable (#17616)
* make compiler worker count configurable
2020-05-08 11:18:02 -07:00
Yegor
68bf137634
skip painting clipped out pictures (#18204) 2020-05-08 11:14:30 -07:00
Siva
9b905d3f03
Manual roll of Dart 617bc54b71...39e0e75fcf (#18215)
This roll unforks the Dart SDK to use the non nullable SDk,
the engine platform file is built with all the dart:* libraries
opted in except for dart:ui

dart-lang/sdk@617bc54b71 [dart2js] unit test patch for unfork cl.
dart-lang/sdk@ce5d18b0f0 [CFE] - Update exectations of CFE unit tests to account for NNBD unfork
dart-lang/sdk@be0c78a7cc [dart2js] Fix platform-binaries on bots.
dart-lang/sdk@03ce33f80c [BUILD] - Initial CL to unfork the NNBD Dart SDK
2020-05-07 20:58:44 -07:00
Ferhat
e7ee47d917
[web] Implement matrix parameter for linear gradient (#18208)
* Implement linear gradient matrix
* update golden locks
* Remove matrix check in RadialGradient
2020-05-07 17:22:54 -07:00
Nurhan Turgut
d6aa099de7
Autofill main part (#17986)
* changes for getting the configuration

* running autofill

* simplifications, remove unused map

* more changes

* make single autofill fields work. remove print messages

* remove an extra line

* remove extra file. also update chrome version

* addressing reviewers comments

* addressing reviewer comments

* addressing reviewer comments

* addressing reviewer comments

* changing comments

* changing comments

* adding a comment on subscriptions lifecycle

* fixing a bug which was failing the existing unit tests

* add unit tests for AutofillInfo and EngineAutofillForm. add autocomplete to textarea

* add unit tests for method channels

* remove json from the end of the file

* do not change the input type for the focused element

* check name instead of autocomplete for firefox

* check name instead of autocomplete for firefox in other methods as well

* fixing a bug in the autofillhints file, testing if firefox is failing for username hint or for all autocomplete values

* fix the breaking unit test
2020-05-06 12:58:46 -07:00
Ferhat
80c090d9ea
Fix path bounds for multiple rects. Implement winding rules (#18165) 2020-05-05 20:53:51 -07:00
Jason Simmons
905836d466
[web] Upgrade the test package to remove the dependency on package_resolver (#18135) 2020-05-05 10:57:02 -07:00
Ferhat
a0983d36f7
[web] Add support for ColorFilter on images (#18111)
* Implement Color filter for images
* Add blend modes
* complete set of blend modes
* Add golden test for blend modes, fix size setting when using drawImage instead of drawImageRect
* Add comments
* Update golden locks
* Fix analyzer errors
Co-authored-by: Harry Terkelsen <hterkelsen@users.noreply.github.com>
* fix blend group count in test
2020-05-05 10:22:16 -07:00
Ferhat
4b7380b55f
[web] Workaround for compositing bug in chrome/webkit (#18128)
* Fix compositing error when multiple canvas(s) are reused
* address review comments
* track all element counts
2020-05-05 10:11:56 -07:00
Mouad Debbar
b774f6a40b
[web] Add support for syncing unicode line break properties (#18040) 2020-05-04 20:59:41 -07:00
Cedric GESTES
db6fb7f1fd
[web] also hide scrollbars in text_editing (#18019) 2020-05-04 14:02:46 -07:00
Ferhat
989d910130
[web] Remove left/top/transform reset since all code paths now set ltwh (#17867)
* [web] Remove left/top/transform reset since all code paths now set ltwh
* Remove unused style var
* Handle path=null , address review comments
* Added comment for reset code
2020-05-04 08:46:21 -07:00
Ferhat
705fcac4eb
[web] Fix cachedLastStyle state leak across canvases. Reduce ctx.font reset calls. (#17980)
* Fix cachedLastStyle state leak across canvases. Reduce ctx.font reset calls.

* Remove font set test
2020-05-03 18:06:08 -07:00
Alexander Aprelev
1c8ee9856b
Introduce runtime check that it is root isolate that makes UI native calls. (#18050)
* Revert "Do not register UI-related native functions in secondary isolates (#6401)"

This reverts commit 69ae5694de54d2a163743dcec727fcea1c7bc8e1 as it doesn't work when root and secondary isolates run in the same isolate group.

* Confirm it is root isolate that makes UI native calls.

* Fix format, UIDartState reference from Fuchsia source

* No UI isolate check for fuchsia calls

* Fix typo. Remove redundant runtime calls
2020-05-01 09:05:41 -07:00
Mouad Debbar
3e975147fd
[web] First batch of unit tests for line breaker (#18034) 2020-04-30 10:50:51 -07:00
Yegor
590381a00a
soften shadows even more; fix shadow alpha (#18029)
* soften shadows even more; fix shadow alpha
2020-04-29 20:54:21 -07:00
Mouad Debbar
7c084c57bd
[web] Use correct shell operator to compare file limits (#18032) 2020-04-29 18:12:48 -07:00
Siva
aa695d4d7b
Revert all build changes made to test the Dart NNBD unfork CL. (#18033) 2020-04-29 12:32:30 -07:00
Jason Simmons
01cf8c36ce
Disable the import_internal_library analyzer check for dart:ui (#18009)
The latest version of dartanalyzer does not support disabling this for a
specific line of code.
2020-04-28 13:45:47 -07:00
Siva
494a63c411
Trial PR to enable null safety unfork in the Dart SDK. (#17818)
* Trial PR to enable null safety unfork in the Dart SDK.

* Fix web-sdk builds.

* Manua; Roll of Dart cab69e77066b0db305187fd6e618a4f524ae9efd...03429b20cd67f85d65cc589b529ab8c1a4780912

dart-lang/sdk@ cab69e7706 [BUILD] - Initial CL to unfork the NNBD Dart SDK NOTE: This is a trial submit and will be reverted immediately.
2020-04-27 19:51:23 -07:00
Mouad Debbar
aa00d50396
[web] Don't allow empty initial route (#17936) 2020-04-27 13:54:07 -07:00
Mouad Debbar
d132ac576b
[web] Fix exception when getting boxes for rich text range (#17933) 2020-04-24 14:30:32 -07:00
Ferhat
cade0e90ca
[web] Batch systemFontChange messages (#17885)
* Batch systemFontChange messages
* Update test for async
2020-04-24 14:10:22 -07:00
Ferhat
371a8a05b0
[web] When a canvas element is reused and is first element in child list, preserve zIndex. (#17906)
* Fix zIndex removal on reuse
* Move check after append call to simplify
2020-04-23 15:09:59 -07:00
Nurhan Turgut
8fff8da38d
[web] autofill hints (#17887)
* adding autofill hints map from flutter values to the browser values, which will  be used by the web engine:

* removing unused reverse map

* addressing reviewer comments

* changing licences
2020-04-23 10:00:56 -07:00
Ferhat
ace381d76c
[web] Speedup color to css string 25% (#17866)
* Speedup color to css string 25%
2020-04-22 12:28:29 -07:00
Yegor
deaf14ec7d
Use Float32List as Matrix storage inside the Web engine (#17856)
This change converts all Float64List matrices to Float32List at the dart:ui interface boundary. Internally, it only uses Float32List. Float32List requires less memory and is orders of magnitude faster to allocate, and it has sufficient precision as Flutter mobile engine and Skia use 32-bit floats anyway.

This change speeds up frame preroll by 50% on the bench_card_infinite_scroll benchmark.

For more details on Float64Array allocation in JS (which backs Float64List in Dart) see the following:

https://bugs.chromium.org/p/v8/issues/detail?id=9199
https://bugs.chromium.org/p/v8/issues/detail?id=2022
2020-04-22 11:08:23 -07:00