6051 Commits

Author SHA1 Message Date
Hans Muller
187c89b69d
Remove accentTextTheme from sliders and chips, tests and docs (#46801) 2019-12-12 15:14:01 -08:00
Dan Field
948e2b0101 Avoid exceptions for control flow (#46897) 2019-12-12 13:53:01 -08:00
Taufiq Rahman
c5f61ac3e8 Feature: ExpandIcon should use the size parameter (#45712)
* ExpandIcon should use the size parameter
2019-12-10 15:18:56 -05:00
Shi-Hao Hong
0bec3dc3d2
Add UniqueKey documentation regarding const constructor (#46647) 2019-12-10 13:24:58 -05:00
Shi-Hao Hong
ac9fefdfa6
Fix InputDecorator.isDense typo from true -> false (#46648) 2019-12-10 13:24:44 -05:00
Sebastian Döll
645c32311e Set modal bottom sheet barrier color (#45067) 2019-12-10 10:07:32 -08:00
Anthony
8a205f8194
Revert "Made the behavior for caching large images modular. (#46010)" (#46629)
This reverts commit 86dd664feffa1dc32d51845f1dbe82c3b15093bf.
2019-12-10 11:44:52 -05:00
Jonah Williams
81aa2710d2
[flutter_tool] add a vmservice API for hot ui requests (#45649) 2019-12-09 21:31:34 -08:00
Tong Mu
a4f7a0dfb9
Revert changes to TestPointer; MouseTracker no longer relies on Add events (#46285)
* Revert test pointer

* Synthesize new state
2019-12-09 15:12:11 -08:00
Tom Robinson
9233b53255 Update SliverPersistentHeader docs (#46081) 2019-12-06 14:17:29 -08:00
Tong Mu
ad20d368ff Fix null event crash in TapGestureRecognizer (#45943) 2019-12-05 19:33:01 -08:00
Greg Spencer
bc7ed36db5
Add visualDensity to checkbox, radio, icon button, and chip. (#46091)
This adds a visualDensity attribute to checkbox, radio, icon button, and chip.
2019-12-05 17:36:42 -08:00
Greg Spencer
e3005e6962
Fixes Focus and FocusScope's assignment of canRequestFocus. (#46168)
This fixes an issue where lines like this:

    focusNode.canRequestFocus = widget.canRequestFocus ?? focusNode.canRequestFocus;

Were causing the canRequestFocus bit to copy the status of the enclosing scope, since canRequestFocus also looks to the enclosing scope to decide if it can focus.
2019-12-05 15:33:05 -08:00
Chris Bracken
fa0c49d775
Dispatch hover events to PlatformViewController (#46124)
This adds support to PlatformViewLayer for handling hover events. Prior
to this, PlatformViewLayers only supported events forwarded by the
gesture recognizers associated with the PlatformViewRenderBox. Hover
events don't participate in gesture recognition and as such are dropped
in GestureBinding. That said, hover event processing in platform views
is expected for desktop and other platforms with hover event support.

This adds support for passing an optional MouseTrackerAnnotation to
PlatformViewLayer. PlatformViewRenderBox populates this with a mouse
tracker annotation that forwards hover events to
PlatformViewController.dispatchPointerEvent() for handling by users.
2019-12-05 13:31:50 -08:00
gaaclarke
86dd664fef
Made the behavior for caching large images modular. (#46010)
Introduced LargeImageHandler to ImageCache class.
2019-12-05 12:46:59 -08:00
Greg Spencer
c6fe7bb9e1
Normalizes all of the "See also" blocks in comments. (#46121)
This normalizes all of the "See also" blocks in comments so that they conform in style.

They all look like this now:

  /// See also:
  ///
  ///  * [MyFavoriteWidget], because it's cool.
  class Foo {}

I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.

This is my penance for adding so many bullets that are "-" instead of "*". :-)
2019-12-05 12:27:05 -08:00
Tong Mu
f8027a795d Only schedule callback when there is mouse (#46113) 2019-12-05 12:18:03 -08:00
Alexandre Ardhuin
649e188562
implicit-casts:false in flutter/lib/src/painting (#45621) 2019-12-05 09:41:49 +01:00
Greg Spencer
f7d1616173
Overridable default platform key bindings (#45102)
This adds actions and shortcuts arguments to WidgetsApp (and MaterialApp and CupertinoApp) to allow developers to override the default mappings on an application, and to allow for a more complex definition of the default mappings.

I've stopped using SelectAction here, in favor of using ActivateAction for all activations, but haven't removed it, to avoid a breaking change, and to allow a common base class for these types of actions. This is because some platforms use the same mapping (web) for both kinds of activations (both select and activate).
2019-12-04 16:07:01 -08:00
Kate Lovett
9011cece25
Pre-Submit Tryjobs for Flutter Gold (#44474) 2019-12-04 15:43:36 -08:00
Brian Egan
3ea8c87ce9
Api Samples and Diagrams for 10 more classes / functions (#45603)
* Api Samples and Diagrams for the following classes and methods:

  - AlertDialog
  - SimpleDialog
  - SingleChildScrollView
  - showDatePicker
  - RichText
  - InputDecoration
  - Divider
  - StreamBuilder
  - DataTable
  - BottomSheet
    - showBottomSheet
    - showModalBottomSheet

* Update packages/flutter/lib/src/material/divider.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/widgets/basic.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/data_table.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/bottom_sheet.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Update packages/flutter/lib/src/material/scaffold.dart

Co-Authored-By: Kate Lovett <katelovett@google.com>

* Move animation out of sample

* Remove "widget.size", replace with "60"
2019-12-04 13:27:23 +01:00
Alexandre Ardhuin
a5f9b3b036
implicit-casts:false in flutter/lib/src/rendering (#45720)
* implicit-casts:false in flutter/lib/src/rendering

* address review comments
2019-12-04 10:27:04 +01:00
Alexandre Ardhuin
166d422b05
implicit-casts:false in flutter/lib/src/widgets (#45728)
* implicit-casts:false in flutter/lib/src/widgets

* address review comments

* address review comment
2019-12-04 09:43:54 +01:00
Alexandre Ardhuin
4049460d31
implicit-casts:false in flutter/lib/src/semantics (#45722) 2019-12-04 08:59:19 +01:00
Alexandre Ardhuin
1c7a1c3873
implicit-casts:false in flutter/lib/src/services (#45723) 2019-12-04 07:51:54 +01:00
Sebastian Döll
417db34d35 Set track color in Cupertino Switch and Adaptive Switch (#45074) 2019-12-03 20:42:48 -08:00
Greg Spencer
185da9b0af
Add Density API to ThemeData, implement for buttons. (#43547)
* Add a density attribute to ThemeData

* Simplify tests

* Review changes (Hans)
2019-12-03 19:49:56 -08:00
Michael Goderbauer
1ac17c14fc Re-land "Add option to delay rendering the first frame (#45135)" (#45941) 2019-12-03 19:48:01 -08:00
Dan Field
b61dec79c7
Start fixing docs (#45977) 2019-12-03 13:59:19 -08:00
Sahand Akbarzadeh
f68cdacdd5 Add clip behaviour to Container (#44971) 2019-12-03 10:13:01 -08:00
Alexandre Ardhuin
1ae5d676e5
implicit-casts:false in flutter/lib/src/scheduler (#45721) 2019-12-03 09:32:03 +01:00
XinLei
9d574d2c22 Remove canTransitionFrom override from Material/CupertinoPageRoute (#45750) 2019-12-02 23:23:53 -08:00
Dan Field
c0283d85f5 Deprecate UpdateLiveRegionEvent (#45940) 2019-12-02 19:08:01 -08:00
Greg Spencer
37f86c3195
Clean up some things I noticed while doing another change (#45658)
This fixes some minor things I noticed while doing another change.

- Uncomments an old test that wants to be run, but can't be, and marked it as "skipped", so that the code won't rot anymore.
- Added the focus state to the short string version of a FocusNode
- Added a missing piece of information to findAncestorWidgetOfExactType
2019-12-02 17:10:09 -08:00
Kate Lovett
2a5e528a18 Fixing SliverOverlapAbsorber & SliverOverlapInjector child property (#44283) 2019-12-02 17:08:02 -08:00
Kate Lovett
cd052a56cb
Revert "Re-land "Add option to delay rendering the first frame (#45135)" (#45588)" (#45939)
This reverts commit c59151b1cdb70c77368c04aaed39ca4791cad539.
2019-12-02 15:08:35 -08:00
Michael Goderbauer
c59151b1cd Re-land "Add option to delay rendering the first frame (#45135)" (#45588) 2019-12-02 13:33:45 -08:00
Tong Mu
afb8f38211
Improve MouseTracker lifecycle: Move checks to post-frame (#44631)
This PR rewrites MouseTracker's lifecycle, so that mouse callbacks are all triggered in post frame, instead of the current one where some are triggered during the build phase. This PR also changes the onExit callback to MouseRegion, RenderMouseRegion, and MouseTrackerAnnotation, so that it is no longer triggered on dispose.
2019-12-02 13:00:48 -08:00
Michael Goderbauer
8954ee85dd
Add Sliver video to RenderSliver (#45708) 2019-12-02 12:58:04 -08:00
Gary Qian
d345a3b303
Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622)" (#45698)
This reverts commit 6b66d794360bb7d3ff7bf2f6dfbcbd58516c3f20.
2019-11-28 19:42:06 +09:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Chris Bracken
dc49fa2140
Eliminate commented-out code (#45726)
This appears to have been inadvertently added in #37497 (333c961).

The code in question already exists in `_PlatformViewGestureMixin`, which
`PlatformViewRenderBox` (where it was added) mixes in.
2019-11-27 14:50:15 -08:00
Ian Hickson
f87c5102af
Add more documentation around layers. (#45648) 2019-11-27 14:22:48 -08:00
Chris Bracken
b39949ff09
Fix parameter name: handlePointerEvent (#45717)
Removes an unnecessary leading underscore from a parameter name. The
parameter type is library private, but parameters cannot be 'private'.
2019-11-27 12:48:43 -08:00
liyuqian
264082f34f
Print clipBehavior while debugging ClipXXXLayer (#45716)
Fixes https://github.com/flutter/flutter/issues/45587
2019-11-27 12:48:03 -08:00
Alexandre Ardhuin
5ccd4f3430
implicit-casts:false in flutter/lib/src/physics (#45622) 2019-11-27 21:28:45 +01:00
LongCatIsLooong
37f9c54116
Use RenderSliverPadding to inset SliverFillViewport (#45432) 2019-11-27 11:33:38 -08:00
Takeshi Tsukamoto
876303b3f9 Fix comment (#45325) 2019-11-27 10:01:57 -08:00
Greg Spencer
245d1b51ce
Add macOS to TargetPlatform (#43457)
This PR adds TargetPlatform.macOS to the TargetPlatform enum. This allows us to begin implementation of some adaptive UI based on which target platform is desired.

I haven't updated the tests here, that will come in a follow-up PR.
2019-11-26 18:32:34 -08:00
Dan Field
2d3d220988
Implicit scrolling for pageview (#45598) 2019-11-26 14:12:34 -08:00