11294 Commits

Author SHA1 Message Date
Mouad Debbar
ea26f366af [web] Reland Support custom url strategies (flutter/engine#21702) 2020-10-08 14:30:02 -07:00
skia-flutter-autoroll
8077fe017d Roll Skia from 9c0b79a35489 to e17b0501963a (15 revisions) (flutter/engine#21707) 2020-10-08 14:17:01 -07:00
Jason Simmons
b285a0fd74 Clear the Minikin layout cache during engine destruction (flutter/engine#21473) 2020-10-08 13:53:04 -07:00
nturgut
68e27dd17f chrome driver for chrome 86 (flutter/engine#21705) 2020-10-08 13:41:05 -07:00
Chinmay Garde
4cadaece76 Fix engine Xcode projection for newer versions of Xcode. (flutter/engine#21701) 2020-10-08 11:40:16 -07:00
skia-flutter-autoroll
56ec7abe3d Roll Skia from 8d43858ed21a to 9c0b79a35489 (14 revisions) (flutter/engine#21698) 2020-10-08 11:37:02 -07:00
Kaushik Iska
9167812fc7 [macOS] Fix docs for loadAOTData and minor refactor (flutter/engine#21699) 2020-10-08 11:34:02 -07:00
Kaushik Iska
4ae2739912 Update PR template to include the presubmit flake form (flutter/engine#21697) 2020-10-08 11:32:05 -07:00
Kaushik Iska
6104a7e793 [macOS] flutter_desktop_darwin_unittests can be enabled for all runtime modes (flutter/engine#21681) 2020-10-08 10:12:03 -07:00
nturgut
97ab9440d6 fixing the autofill overlay problem (blue area for chrome) (flutter/engine#21610)
* fixing the autofill overlay problem (blue area for chrome)

* addression comments
2020-10-08 10:10:12 -07:00
Jason Simmons
8a6987441b Remove dependencies on _product variants of libdart from the Fuchsia release mode build (flutter/engine#21668) 2020-10-08 09:55:43 -07:00
Jonah Williams
127f3af9e0 Preserve specified AssetResolvers when performing a hot restart or updating the asset directory (flutter/engine#21611)
Follow up from #21436 . That PR works for all embeddings except for Android, which creates a special JNI AssetResolver. Since the shell cannot recreate this resolver, update the logic to preserve existing resolvers instead.
2020-10-08 09:22:01 -07:00
Dan Field
710a162790 Skip flaky test (flutter/engine#21694) 2020-10-08 08:25:48 -07:00
skia-flutter-autoroll
deedd8be98 Roll Skia from 38e6d226f24e to ac0723a06b53 (3 revisions) (flutter/engine#21688) 2020-10-08 00:17:01 -07:00
skia-flutter-autoroll
87c4390145 Roll Fuchsia Linux SDK from kr1tNtZvZ... to ZJHmp3INU... (flutter/engine#21684) 2020-10-07 23:02:01 -07:00
skia-flutter-autoroll
40a9d4b8de Roll Skia from 041fd0ad7d93 to 38e6d226f24e (1 revision) (flutter/engine#21683) 2020-10-07 22:57:05 -07:00
Chris Bracken
c2fab63106 Make TextInputModel::selection_start/end const (flutter/engine#21685)
Neither of these methods mutate the state of the model.
2020-10-07 22:04:02 -07:00
Dan Field
ad2f8cab17 Revert "[web] Support custom url strategies (#19134)" (flutter/engine#21687)
This reverts commit 17d107f94a2b08697da0a0984f2dfb4ad7ff7fb9.
2020-10-07 21:42:20 -07:00
Chris Bracken
cc9990f124 Store selection base/extent as integers (flutter/engine#21663)
Previously, the selection base and extent were stored internally as
iterators over text_. Since iterators must be treated as invalidated
whenever the underlying container changes, this requires that
selection_base_ and selection_extent_ be re-assigned after every change
to text_.

This is not currently particularly problematic, but once we add fields
to track the base and extent of the composing region for multi-step
input method support, as well as support for the sub-range within the
composing region to which edits/completions apply, we end up having to
regenerate a lot of iterators with each change, many of which are
logically unchanged in position.

A side benefit is that this simplifies inspection of these fields when
debugging.
2020-10-07 18:31:17 -07:00
Chinmay Garde
6937ec8760 Avoid leaking the FlutterEngineAOTData structure in FlutterEngineCollectAOTData. (flutter/engine#21680) 2020-10-07 17:57:04 -07:00
Pieter van Loon
3ce29048c0 Enabled metal on ios simulator (flutter/engine#17881) 2020-10-07 17:47:03 -07:00
Mouad Debbar
17d107f94a [web] Support custom url strategies (flutter/engine#19134) 2020-10-07 17:19:07 -07:00
skia-flutter-autoroll
6d05412a7e Roll Skia from a7f69c290667 to 041fd0ad7d93 (5 revisions) (flutter/engine#21676) 2020-10-07 16:42:02 -07:00
Emmanuel Garcia
2bd0e126a5 Ensure JNI is not called from raster thread (flutter/engine#21665) 2020-10-07 16:37:02 -07:00
Kaushik Iska
7287246cb2 [macOS] Allow loading of AOT snapshots and instructions from elf bundle (flutter/engine#21670) 2020-10-07 16:34:49 -07:00
Kaushik Iska
6db42cf2a9 Run desktop darwin tests in debug mode (flutter/engine#21660) 2020-10-07 16:32:01 -07:00
Jason Simmons
742b168680 Add an adjustment to currentLineWidth comparisons when pushing greedy line breaks (flutter/engine#21356)
This is similar to the workaround used for
https://github.com/flutter/flutter/issues/30347

The Minikin line breaker inserts greedy breaks based on a comparison of
postBreak width and currentLineWidth.  currentLineWidth is provided by
the framework based on previous calls to Layout::measureText.
That calculation may not exactly match the calculation of postBreak.

This change ensures that breaks are only added if the difference
between postBreak and currentLineWidth is significant.

Fixes https://github.com/flutter/flutter/issues/65419
2020-10-07 15:34:59 -07:00
skia-flutter-autoroll
d796880102 Roll Skia from 107114dd1d6e to a7f69c290667 (18 revisions) (flutter/engine#21666)
https://skia.googlesource.com/skia.git/+log/107114dd1d6e..a7f69c290667

*** Force-landing this with red checks so we don't fall too far behind. (All failures are flakes).

2020-10-07 egdaniel@google.com Add stencil formats to all the backends.
2020-10-07 brianosman@google.com Only include one variable per declaration statement
2020-10-07 johnstiles@google.com Remove accidentally repeated bit-index expression.
2020-10-07 mtklein@google.com refactor HashAndEncode
2020-10-07 robertphillips@google.com Centralize CreateLazyView helper in GrThreadSafeUniquelyKeyedProxyViewCache
2020-10-07 michaelludwig@google.com Update AutoLayerForImageFilter to use SkTCopyOnFirstWrite
2020-10-07 johnstiles@google.com Rename ChunkBits to kChunkBits.
2020-10-07 jvanverth@google.com Revert "Add a 2d cross product intrinsic to sksl"
2020-10-07 robertphillips@google.com Add customData capability to the thread-safe proxy cache ...
2020-10-07 johnstiles@google.com Fix data() method and add unit test.
2020-10-07 kjlubick@google.com [canvaskit] Add make rule to check types
2020-10-07 csmartdalton@google.com Add a 2d cross product intrinsic to sksl
2020-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from afe6ca45b6da to 635de036d766 (3 revisions)
2020-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 77e3d0ae97b6 to 3df629c55d89 (20 revisions)
2020-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 4259b6b6cb0f to 3c77521707c0 (463 revisions)
2020-10-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 326e14f34bb5 to 7e22b1c44fb0 (6 revisions)
2020-10-07 mtklein@google.com retry³ absl
2020-10-06 johnstiles@google.com Separate out SymbolTable aliases from regular Symbols.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-10-07 16:26:58 -04:00
David Worsham
34cb178b92 fuchsia: Don't send ViewportMetrics w/ 0 DPR (flutter/engine#21392) 2020-10-06 17:57:28 -07:00
Justin McCandless
30ff61de06 hasStrings Linux (flutter/engine#21388)
hasStrings method for clipboard status, Linux
2020-10-06 16:29:12 -07:00
nturgut
035d66a75f add api_conform_test to analyze step. remove build script. (flutter/engine#21633) 2020-10-06 15:39:18 -07:00
skia-flutter-autoroll
028536768d Roll Skia from 33b42e12ab71 to 107114dd1d6e (5 revisions) (flutter/engine#21634) 2020-10-06 14:52:02 -07:00
skia-flutter-autoroll
4b9ddfc29b Roll Fuchsia Linux SDK from HeAkKHbFY... to kr1tNtZvZ... (flutter/engine#21630) 2020-10-06 13:27:03 -07:00
nturgut
65d027b893 running web tests only on DEPS and web directories (flutter/engine#21613)
* running web tests only on DEPS and web directories

* adding more folders to skip tests
2020-10-06 13:16:03 -07:00
skia-flutter-autoroll
57e284c14d Roll Skia from c3bdd1c597dc to 33b42e12ab71 (6 revisions) (flutter/engine#21628) 2020-10-06 12:52:01 -07:00
George Wright
f4afab33d9 Use the gpu config for shell_unittests to declare SHELL_ENABLE_{GL,VULKAN} (flutter/engine#21603) 2020-10-06 12:47:02 -07:00
stuartmorgan
983e9db4f8 [linux] Allow engine flags via environment vars (flutter/engine#21497)
Adds the ability to pass engine switches temporarily at runtime via
environment variables. Uses the same approach recently added to
Windows and macOS.

This is enabled only for debug/profile to avoid potential issues with
tampering with released applications, but if there is a need for that in
the future it could be added (potentially with a whitelist, as is
currently used for Dart VM flags).

Fixes flutter/flutter#60393
2020-10-06 11:17:19 -07:00
Chris Bracken
ae54caed8c Separate mutators for text and selection (flutter/engine#21612)
Previously, TextInputModel's SetEditingState method was a 1:1 mapping of
the underlying protocol used on the text input channel between the
framework and the engine. This breaks it up into two methods, which
allows the selection to be updated independently of the text, and avoids
tying the API the the underlying protocol.

This will become more important when we add additional state to support
composing regions for multi-step input methods such as those used for
Japanese.

SetText resets the selection rather than making a best-efforts attempt
to preserve it. This choice was primarily to keep the code simple and
make the API easier to reason about. An alternative would have been to
make a best-effort attempt to preserve the selection, potentially
clamping one or both to the end of the new string. In all cases where an
embedder resets the string, it is expected that they also have the
selection, so can call SetSelection with an updated selection if needed.
2020-10-06 11:07:21 -07:00
skia-flutter-autoroll
ad8577e80d Roll Skia from e2c6940c36e4 to c3bdd1c597dc (4 revisions) (flutter/engine#21625)
https://skia.googlesource.com/skia.git/+log/e2c6940c36e4..c3bdd1c597dc

2020-10-06 robertphillips@google.com Separate mask creation from drawing in draw_shape_with_mask_filter
2020-10-06 kjlubick@google.com [canvaskit] Update to 0.18.1 (including typescript types/docs).
2020-10-06 kjlubick@google.com [canvaskit] Add docs/types for Skottie and Particles
2020-10-06 kjlubick@google.com [canvaskit] Add docs/types for paragraph

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-10-06 09:59:54 -07:00
skia-flutter-autoroll
3e24c53c81 Roll Skia from 00dc0bcb4d54 to e2c6940c36e4 (1 revision) (flutter/engine#21624) 2020-10-06 06:37:02 -07:00
skia-flutter-autoroll
1d400942b4 Roll Skia from fa5ff7d234b8 to 00dc0bcb4d54 (3 revisions) (flutter/engine#21622) 2020-10-06 00:22:02 -07:00
skia-flutter-autoroll
b5ede2378c Roll Fuchsia Linux SDK from DMUD0TMLr... to HeAkKHbFY... (flutter/engine#21621) 2020-10-05 23:12:02 -07:00
skia-flutter-autoroll
5f1d8fbfa1 Roll Skia from 347e5dc37127 to fa5ff7d234b8 (1 revision) (flutter/engine#21620) 2020-10-05 23:02:03 -07:00
Sanjay Chouksey
6b30b92077 Hookup view connected/disconnected events for platform view codepath (flutter/engine#21576)
This change adds support for forwarding scenic's viewConnected,
viewDisconnected and viewStateChanged events to flutter. The
corrensponding change on fuchsia side is at:
https://fuchsia-review.googlesource.com/c/topaz/+/434356

Test: Includes unittest to verify the events are forwarded.

Co-authored-by: Sanjay Chouksey <sanjayc@google.com>
2020-10-05 22:09:38 -07:00
skia-flutter-autoroll
79aa88c4ad Roll Skia from 05162812fd37 to 347e5dc37127 (1 revision) (flutter/engine#21617) 2020-10-05 20:57:01 -07:00
Yuqian Li
9fdea6bbbc Do not remove directories in purge (flutter/engine#21478)
Otherwise, the persistent cache may hold invalid directories and make
subsequent store fail.

The newly added unit tests would fail without the fix.
2020-10-05 20:05:00 -07:00
skia-flutter-autoroll
3b0ecde95a Roll Skia from 41d906752d13 to 05162812fd37 (1 revision) (flutter/engine#21615) 2020-10-05 19:37:01 -07:00
skia-flutter-autoroll
db82d482f1 Roll Skia from d30e9efdab5c to 41d906752d13 (2 revisions) (flutter/engine#21608) 2020-10-05 16:52:02 -07:00
skia-flutter-autoroll
b852cb451a Roll Skia from 0d31ed506863 to d30e9efdab5c (4 revisions) (flutter/engine#21607) 2020-10-05 15:22:03 -07:00
skia-flutter-autoroll
cc3f278d02 Roll Skia from e2c4999ec340 to 0d31ed506863 (5 revisions) (flutter/engine#21604) 2020-10-05 13:52:01 -07:00