auto-submit[bot]
ea0283f762
Reverts "Remove #if SHELL_ENABLE_METAL checks in iOS code ( #51636 )" ( flutter/engine#51941 )
...
Reverts: flutter/engine#51636
Initiated by: jmagman
Reason for reverting: This caused a slew of unexpected Scuba changes b/333039358
Original PR Author: jmagman
Reviewed By: {cbracken}
This change reverts the following previous change:
All physical iOS devices Flutter supports (iOS 12+) can run Metal. The only time Flutter doesn't use Metal afaik is for iOS simulators running < iOS 13, which is covered by a few `if (@available(iOS METAL_IOS_VERSION_BASELINE, *))` checks.
aef5775087/shell/platform/darwin/ios/rendering_api_selection.h (L37-L41)97b286ca62/shell/platform/darwin/macos/BUILD.gn (L18)97b286ca62/tools/gn (L673-L679)
2024-04-05 18:55:44 +00:00
skia-flutter-autoroll
13e5db8467
Roll Fuchsia Linux SDK from TAr6MCirveGvhZFHK... to EaKtmpePocJx6qaKg... ( flutter/engine#51940 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC matanl@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-05 18:48:10 +00:00
skia-flutter-autoroll
3fdd8eb47d
Roll Skia from 6d673cafb8d1 to 0424e59d3a08 (1 revision) ( flutter/engine#51939 )
...
https://skia.googlesource.com/skia.git/+log/6d673cafb8d1..0424e59d3a08
2024-04-05 kjlubick@google.com Remove unnecessary UIKit include
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-05 18:36:17 +00:00
Jonah Williams
1e9bd50f85
[Impeller] fail CI if validations are enabled but not available. ( flutter/engine#51378 )
...
Fixes https://github.com/flutter/flutter/issues/145041
Will test this by unsetting the VVL configuration
2024-04-05 17:28:21 +00:00
Jonah Williams
415c891023
[Impeller] batch up filter graph command buffers. ( flutter/engine#51912 )
...
The filter graph frequently creates and submits command buffers in serial. This has some unnecessary overhead, esp on Vulkan where submitting a command buffer has a non-trivial cost. While previously I had tried to batch up all submissions, doing this in a limited manner in the filter graph should be more straightforward.
For gaussians this makes a big difference, as there is a mipmap generation, downsample, then 2 render passes, so we can compress the 4 command buffers into 1.
https://github.com/flutter/flutter/issues/142545
2024-04-05 17:22:41 +00:00
Zachary Anderson
72ea5c99e3
[et] Fixup help text a bit ( flutter/engine#51930 )
...
The multiline string literal retains the newlines.
2024-04-05 09:23:12 -07:00
skia-flutter-autoroll
cc16f5d2da
Roll Skia from b3c27bb2d739 to 6d673cafb8d1 (1 revision) ( flutter/engine#51937 )
...
https://skia.googlesource.com/skia.git/+log/b3c27bb2d739..6d673cafb8d1
2024-04-05 michaelludwig@google.com [graphite] Track linked device on Images
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-05 15:17:50 +00:00
skia-flutter-autoroll
51b231e96d
Roll Skia from f8977f658b66 to b3c27bb2d739 (1 revision) ( flutter/engine#51936 )
...
https://skia.googlesource.com/skia.git/+log/f8977f658b66..b3c27bb2d739
2024-04-05 michaelludwig@google.com [graphite] Relax assert in ~Device
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-05 13:52:33 +00:00
skia-flutter-autoroll
96744fc6a7
Roll Skia from b1a37c7f4c75 to f8977f658b66 (2 revisions) ( flutter/engine#51935 )
...
https://skia.googlesource.com/skia.git/+log/b1a37c7f4c75..f8977f658b66
2024-04-05 bungeman@google.com [fontations] Fix return value of get_path
2024-04-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from dc643d9bec38 to 35c7e1860dd0 (12 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-05 09:06:24 +00:00
skia-flutter-autoroll
9e9cac2583
Roll Skia from 22ba9c040aa2 to 5a9d7e508e41 (1 revision) ( flutter/engine#51933 )
...
https://skia.googlesource.com/skia.git/+log/22ba9c040aa2..5a9d7e508e41
2024-04-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 596fa6121849 to 2176e2a82e43 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-05 06:51:38 +00:00
auto-submit[bot]
ee494ad4dd
Reverts "Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename ( #51921 )" ( flutter/engine#51927 )
...
Reverts: flutter/engine#51921
Initiated by: zanderso
Reason for reverting: This Dart roll is blocking the roll of the engine to the framework. Unblocking the rolls depends on addressing https://github.com/flutter/flutter/issues/146164 .
Original PR Author: jason-simmons
Reviewed By: {zanderso, jonahwilliams}
This change reverts the following previous change:
The Dart SDK is now only building an AOT snapshot for the frontend server (see https://dart-review.googlesource.com/c/sdk/+/359100 )
2024-04-05 02:27:25 +00:00
auto-submit[bot]
dd1513d0cd
Reverts "Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) ( #51924 )" ( flutter/engine#51926 )
...
Reverts: flutter/engine#51924
Initiated by: zanderso
Reason for reverting: The previous Dart roll is blocking the roll of the engine to the framework. Unblocking the rolls depends on addressing https://github.com/flutter/flutter/issues/146164 .
Original PR Author: skia-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
https://dart.googlesource.com/sdk.git/+log/0ac840ba1f0b..31ddd6924103
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-24.0.dev
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-23.0.dev
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-22.0.dev
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-21.0.dev
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-20.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-05 02:17:47 +00:00
skia-flutter-autoroll
f874c8a295
Roll Dart SDK from 0ac840ba1f0b to 31ddd6924103 (5 revisions) ( flutter/engine#51924 )
...
https://dart.googlesource.com/sdk.git/+log/0ac840ba1f0b..31ddd6924103
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-24.0.dev
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-23.0.dev
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-22.0.dev
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-21.0.dev
2024-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-20.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-05 00:53:22 +00:00
Jason Simmons
564fc1e2d4
Manual Dart roll to 0ac840ba1 and update frontend server snapshot filename ( flutter/engine#51921 )
...
The Dart SDK is now only building an AOT snapshot for the frontend server (see https://dart-review.googlesource.com/c/sdk/+/359100 )
2024-04-04 22:14:02 +00:00
Loïc Sharma
b0a3fb598e
[Windows] Prepare to add/remove views ( flutter/engine#51908 )
...
_This is a refactoring with no semantic changes._
Prepare the Windows embedder to add/remove views. In a multi-view world, the platform thread can remove a view while the raster thread presenting to the same view. A lock will be introduced to ensure this does not happen. This shuffles the code around so that the engine can acquire the lock before the compositor presents to the view.
Prepares for https://github.com/flutter/flutter/issues/138179
Part of https://github.com/flutter/flutter/issues/142845
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-04 21:33:05 +00:00
Tong Mu
7553282a55
Multiview backing store ( flutter/engine#51722 )
...
With this PR, backing stores are labeled with view IDs. When the engine requests the embedder to create a backing store, the engine will promise that it will only be used for a specific view.
This follows the design doc http://flutter.dev/go/backing-stores-for-multi-view-partial-repaint , so that backing stores can be used as a front surface that retains its content last frame.
The engine will create a render target cache for each view to cache backing stores separately.
### Alternative design
The separate render target cache for each view is not needed to implement the design doc, since all usages described in the design doc avoids the engine cache. Instead, we can make the engine still only manage one render target cache for all views, and backing stores in it are interchangeable across views. We might describe the behavior in this way:
* In general, the view ID is just provided to the creating callback as information. (This is how it is seen when the engine cache is avoided.)
* If the engine cache is used, then the created backing store might not be immediately collected, and might be reused for different views.
But it's really hard to explain the mechanism and the result is really confusing (as can be seen from my attempt). Why is there a view ID but it's not used, and if you enable the engine cache it's not even followed?
That's why I chose the current approach. Feel free to suggest otherwise for this.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-04 20:47:30 +00:00
skia-flutter-autoroll
d9f55093e6
Roll Skia from f9dfb0308594 to 8ad03dfe4e2e (2 revisions) ( flutter/engine#51915 )
...
https://skia.googlesource.com/skia.git/+log/f9dfb0308594..8ad03dfe4e2e
2024-04-04 kjlubick@google.com Minor fixes to skottielib app
2024-04-04 davidben@google.com Use sk_careful_memcpy in SkMemoryStream
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 20:17:12 +00:00
utzcoz
04f240de45
Bump Robolectric to 4.12.1 ( flutter/engine#51800 )
...
See https://github.com/robolectric/robolectric/releases/tag/robolectric-4.12 and https://github.com/robolectric/robolectric/releases/tag/robolectric-4.12.1 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-04 20:07:53 +00:00
John O'Neil
75fb13d333
#145421 Fix glyph padding in STB atlas impl. ( flutter/engine#51585 )
...
See the associated issue for description and screenshots.
Fixes issue #145421 [as described here.](https://github.com/flutter/flutter/issues/145421 )
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-04-04 20:06:02 +00:00
Jenn Magder
cb29abbd20
Remove #if SHELL_ENABLE_METAL checks in iOS code ( flutter/engine#51636 )
...
All physical iOS devices Flutter supports (iOS 12+) can run Metal. The only time Flutter doesn't use Metal afaik is for iOS simulators running < iOS 13, which is covered by a few `if (@available(iOS METAL_IOS_VERSION_BASELINE, *))` checks.
aef5775087/shell/platform/darwin/ios/rendering_api_selection.h (L37-L41)97b286ca62/shell/platform/darwin/macos/BUILD.gn (L18)97b286ca62/tools/gn (L673-L679)
2024-04-04 19:22:08 +00:00
John McCutchan
6b4db1f60a
Expand understanding of build targets in et ( flutter/engine#51868 )
...
- s/TestTarget/BuildTarget.
- Use a more informative way of querying for build targets from gn
- Port existing code to use new interfaces
- Replace 'query tests' with 'query targets' and a --testonly flag
- Extend 'et build' with support for build target selectors.
- Extend 'et query targets' with support for build target selectors.
2024-04-04 11:28:04 -07:00
skia-flutter-autoroll
6a8559d1e7
Roll Skia from 8caa3e2592d5 to d58a6dbaaadb (1 revision) ( flutter/engine#51909 )
...
https://skia.googlesource.com/skia.git/+log/8caa3e2592d5..d58a6dbaaadb
2024-04-04 michaelludwig@google.com [graphite] Adjust device registering/tracking to support more flexible lifetime
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 18:20:06 +00:00
skia-flutter-autoroll
2d781e3852
Roll Fuchsia Linux SDK from 5W6KVvHCGwWHBjm2m... to TAr6MCirveGvhZFHK... ( flutter/engine#51842 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 17:41:18 +00:00
skia-flutter-autoroll
ecd2c51ca1
Roll Skia from 4a9e0d0eaa9e to 8caa3e2592d5 (2 revisions) ( flutter/engine#51906 )
...
https://skia.googlesource.com/skia.git/+log/4a9e0d0eaa9e..8caa3e2592d5
2024-04-04 johnstiles@google.com Remove WGSL diagnostics from SkSL golden outputs.
2024-04-04 jvanverth@google.com [graphite] Fix some Viewer issues
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 17:17:10 +00:00
skia-flutter-autoroll
d2d4a911bc
Roll Skia from 3844fc48802d to 4a9e0d0eaa9e (1 revision) ( flutter/engine#51904 )
...
https://skia.googlesource.com/skia.git/+log/3844fc48802d..4a9e0d0eaa9e
2024-04-04 drott@chromium.org [Fontations] Roll Fontations libraries, add bytemuck
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 16:15:20 +00:00
skia-flutter-autoroll
d2abc15dcf
Roll Skia from 02b2800d216e to 3844fc48802d (3 revisions) ( flutter/engine#51903 )
...
https://skia.googlesource.com/skia.git/+log/02b2800d216e..3844fc48802d
2024-04-04 bungeman@google.com Remove SkMemoryStream::skipToAlign4
2024-04-04 roman@canva.com Fix SVG filter property propagation
2024-04-04 drott@chromium.org [Fontations-backend] Fix sbix scaling when `glyf` bounding box present
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 15:12:17 +00:00
Jason Simmons
84b23fcb89
Generate only one "Frame Request Pending" event for each pending call to BeginFrame ( flutter/engine#51857 )
...
Fixes https://github.com/flutter/flutter/issues/145853
2024-04-04 14:33:19 +00:00
skia-flutter-autoroll
fa120ff220
Roll Skia from 2cead39756d8 to 02b2800d216e (1 revision) ( flutter/engine#51901 )
...
https://skia.googlesource.com/skia.git/+log/2cead39756d8..02b2800d216e
2024-04-04 robertphillips@google.com [graphite] Add Lerp to the precompilation system
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 14:08:25 +00:00
skia-flutter-autoroll
7f7beceb8e
Roll Skia from bef4d9b44369 to 2cead39756d8 (1 revision) ( flutter/engine#51899 )
...
https://skia.googlesource.com/skia.git/+log/bef4d9b44369..2cead39756d8
2024-04-04 kjlubick@google.com Reland "Fix defines for icu_subset"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 13:04:21 +00:00
skia-flutter-autoroll
bf0d686ce3
Roll Skia from 57bc01affec1 to 5fdc2b47dfa4 (1 revision) ( flutter/engine#51894 )
...
https://skia.googlesource.com/skia.git/+log/57bc01affec1..5fdc2b47dfa4
2024-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2fe35697982b to 596fa6121849 (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-04 06:49:22 +00:00
Jonah Williams
e8b33af103
[Impeller] dont inc shared_ptr count for every command/pipeline in render_pass_vk ( flutter/engine#51874 )
...
We have to pay to inc/dec the shared_ptr, but all pipelines are persisted indefinitely so we shouldn't need to worry about dangling ptrs.
2024-04-04 02:45:35 +00:00
Jonah Williams
97b286ca62
[Impeller] cleanup auto usage in host_buffer ( flutter/engine#51875 )
...
Remove some autos, make some things const refs, move some shared_ptrs.
2024-04-03 23:30:21 +00:00
skia-flutter-autoroll
c44eed8805
Roll Skia from 82ae8ae5d3fb to fdbdb26b7029 (1 revision) ( flutter/engine#51886 )
...
https://skia.googlesource.com/skia.git/+log/82ae8ae5d3fb..fdbdb26b7029
2024-04-03 kjlubick@google.com Remove legacy Metal GrBackendTexture functions
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 23:12:18 +00:00
Matan Lurey
ff07b1f586
Remove the bringup 20x emulator config. ( flutter/engine#51885 )
...
I didn't end up learning much from this, other than I wish JSON had macros.
*Just kidding, sort of.
2024-04-03 22:47:23 +00:00
skia-flutter-autoroll
4070b03ae8
Roll Skia from 7d6dce620e46 to 82ae8ae5d3fb (2 revisions) ( flutter/engine#51883 )
...
https://skia.googlesource.com/skia.git/+log/7d6dce620e46..82ae8ae5d3fb
2024-04-03 bungeman@google.com [gn_to_cmake] Handle `group` better
2024-04-03 jvanverth@google.com [graphite] Add the ColorspaceXform for the YUV shader via Compose.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 22:13:04 +00:00
Jonah Williams
b951d15850
[scenarios] Use adb to take screenshot, block on screenshot operation. ( flutter/engine#51879 )
...
Use the screenshotUtil signal to have the runner take a screenshot with adb. Block the screenshotter until this has completed.
2024-04-03 22:11:22 +00:00
skia-flutter-autoroll
4059931118
Roll Dart SDK from 85adde7d4b5a to 5b812b9ec220 (2 revisions) ( flutter/engine#51884 )
...
https://dart.googlesource.com/sdk.git/+log/85adde7d4b5a..5b812b9ec220
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-18.0.dev
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-17.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 21:59:24 +00:00
skia-flutter-autoroll
f10717b549
Roll Skia from 8d7482b998d0 to 7d6dce620e46 (1 revision) ( flutter/engine#51878 )
...
https://skia.googlesource.com/skia.git/+log/8d7482b998d0..7d6dce620e46
2024-04-03 egdaniel@google.com [Graphite] Reduce resouce key size for vk desc sets.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 20:59:31 +00:00
Jackson Gardner
228c22e017
Be slightly more lenient about the assertion, as it differs on different backends. ( flutter/engine#51877 )
...
We shouldn't assume the exact format of the assertion string here, as the exact output is slightly different on dart2js vs ddc vs dart2wasm. They should all contain the message text, however.
2024-04-03 20:15:07 +00:00
skia-flutter-autoroll
0d4318275e
Roll Skia from afa233bb1979 to 8d7482b998d0 (2 revisions) ( flutter/engine#51876 )
...
https://skia.googlesource.com/skia.git/+log/afa233bb1979..8d7482b998d0
2024-04-03 jvanverth@google.com [graphite] Separate YUV sampling in shader from YUV-to-RGB conversion
2024-04-03 kjlubick@google.com Add GCC compile job to CQ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 19:55:59 +00:00
Chinmay Garde
22be0b9fa4
[Impeller] Enable logging a warning when the user opts out of using Impeller. ( flutter/engine#51849 )
...
Part of https://github.com/flutter/flutter/issues/144439
This does two things:
* Logs a warning when the embedder requests a non-Impeller preference when creating a shell.
* Makes the iOS embedder request a warning be logged when Impeller is not used.
I decided to put the warning logs in the shell so that as we get more opinionated about Impeller on other platforms, those platforms can just flip a flag with common log origin.
2024-04-03 19:52:51 +00:00
Jonah Williams
fc55cde395
[Impeller] delete unused code. ( flutter/engine#51871 )
...
This might not be linted due to side effects of the method.
2024-04-03 19:40:36 +00:00
Jonah Williams
958a9aa859
[Impeller] eliminate sub-render pass for blended color + texture vertices. ( flutter/engine#51778 )
...
Fixes https://github.com/flutter/flutter/issues/145707
Part of https://github.com/flutter/flutter/issues/131345
If we're drawing vertices with per-color, a non-advanced blend, and a texture (with or without coordinates), use the porter duff shader to perform the blend without creating a sub render pass. IN addition to being more performant, this eliminates any potential rendering bugs caused by overlapping vertices.
This is not yet fixed for advanced blends.
2024-04-03 19:34:57 +00:00
skia-flutter-autoroll
3b6a0eb693
Roll Skia from 67f7b4d08d1f to afa233bb1979 (5 revisions) ( flutter/engine#51872 )
...
https://skia.googlesource.com/skia.git/+log/67f7b4d08d1f..afa233bb1979
2024-04-03 bungeman@google.com [dm] Fix TSAN reports about "done"
2024-04-03 kjlubick@google.com [bazel] Fix Android gms and benchmark POC
2024-04-03 kjlubick@google.com Revert "Zero-initialize Vec components to avoid MSan warnings"
2024-04-03 dcheng@chromium.org Zero-initialize Vec components to avoid MSan warnings
2024-04-03 dcheng@chromium.org Zero initialize context var used to smuggle swizzle control bytes.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 19:00:52 +00:00
skia-flutter-autoroll
ce130dad17
Roll Skia from 1d9340cf193e to 67f7b4d08d1f (1 revision) ( flutter/engine#51865 )
...
https://skia.googlesource.com/skia.git/+log/1d9340cf193e..67f7b4d08d1f
2024-04-03 egdaniel@google.com [Graphite] Reduce key generation of vulkan descriptor sets.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 17:26:00 +00:00
Jonah Williams
483338a49e
[scenarios] dont do a weird invalidate on TextView. ( flutter/engine#51866 )
...
I am now investigating why this is needed.
2024-04-03 17:18:10 +00:00
skia-flutter-autoroll
1bf17c308d
Roll Skia from ce3b5e8eb59b to 5f6223a01ba4 (1 revision) ( flutter/engine#51863 )
...
https://skia.googlesource.com/skia.git/+log/ce3b5e8eb59b..5f6223a01ba4
2024-04-03 robertphillips@google.com [graphite] Use X-macro to get better UniqueKey printouts (take 2)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 15:11:42 +00:00
skia-flutter-autoroll
16a2e393fd
Roll Skia from a247f8cc2a66 to ce3b5e8eb59b (24 revisions) ( flutter/engine#51861 )
...
https://skia.googlesource.com/skia.git/+log/a247f8cc2a66..ce3b5e8eb59b
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 8f8193a59b53 to 98844beffb30 (17 revisions)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 432730a5288e to 43f849a0e433 (1 revision)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 5d294e6e34ff to ff03a7b193da (11 revisions)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from f3bc379a831a to 2fe35697982b (2 revisions)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from ff61926fcedb to 62c59c41e194 (1 revision)
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 66304f4f36ad to 2fe35697982b
2024-04-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Skia Infra from 58b480b2288d to f3bc379a831a (6 revisions)
2024-04-02 robertphillips@google.com [graphite] Implement RuntimeEffect toLinearSrgb/fromLinearSrgb handling
2024-04-02 armansito@google.com Revert "[vello] Enable the bump allocation estimator"
2024-04-02 bungeman@google.com [paragraph] Clean up tests
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 48184ca84103 to 432730a5288e (3 revisions)
2024-04-02 hitawala@chromium.org Reland "Add FCC, YDZDX, GBR, SMPTE240 color space support"
2024-04-02 armansito@google.com [vello] Enable the bump allocation estimator
2024-04-02 michaelludwig@google.com [graphite] Cache read view on DrawContext
2024-04-02 armansito@google.com [graphite][vello] Use ScratchBuffers for all bindings
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from defc2fa459b6 to 934b734ed72a (1 revision)
2024-04-02 johnstiles@google.com Add SkBitmap::setColorSpace.
2024-04-02 nicolettep@google.com [graphite] Allow backends to append information to graphite sampler keys
2024-04-02 johnstiles@google.com Fix GraphiteStartGM initialization.
2024-04-02 michaelludwig@google.com [graphite] Check for null recorder before caps
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 319732cc90e4 to 48184ca84103 (1 revision)
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from c6a6d3f9fa69 to 5d294e6e34ff (6 revisions)
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 58b480b2288d to 7d5d18ff3722
2024-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from df0949e75440 to 58b480b2288d (9 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,kjlubick@google.com,matanl@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 13:52:23 +00:00
skia-flutter-autoroll
6575603e21
Roll Dart SDK from 892ec6169844 to 36b6628190e2 (1 revision) ( flutter/engine#51860 )
...
https://dart.googlesource.com/sdk.git/+log/892ec6169844..36b6628190e2
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-15.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 10:49:23 +00:00
skia-flutter-autoroll
91ce1f10bc
Roll Dart SDK from 091dd9120d35 to 892ec6169844 (3 revisions) ( flutter/engine#51859 )
...
https://dart.googlesource.com/sdk.git/+log/091dd9120d35..892ec6169844
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-14.0.dev
2024-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-13.0.dev
2024-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-12.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,matanl@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-03 06:45:47 +00:00
