10749 Commits

Author SHA1 Message Date
Zachary Anderson
e9fcab4436 Revert "account for inline placeholders in longest line calculation (#20370)" (flutter/engine#20669)
This reverts commit fd97c2487f24ef5f82fe240b6bb19f9a48939922.

Landing on red to fix the build.
2020-08-20 12:35:48 -07:00
skia-flutter-autoroll
055944e768 Roll Skia from 17c5b7024297 to e1e240804211 (20 revisions) (flutter/engine#20656)
Manual land of roll - two bots on luci-engine are red due to flakes.

https://skia.googlesource.com/skia.git/+log/17c5b7024297..e1e240804211

2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from ff3c275665f9 to e45f0c4dce5a (503 revisions)
2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from b54c82ed3948 to eff9ef0f2212 (2 revisions)
2020-08-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 699bcde0b729 to 5dff6075d29f (19 revisions)
2020-08-20 mtklein@google.com Revert "Add utilities to SkGeometry for quad and cubic rotation angles"
2020-08-20 mtklein@google.com Revert "remove sksl interpreter guards"
2020-08-20 ethannicholas@google.com Revert "Added support for the 'inline' hint on SkSL functions"
2020-08-20 ethannicholas@google.com Revert "SkSL CPP and H backends no longer emitted in non-dev builds"
2020-08-20 ethannicholas@google.com Revert "SkSL now supports uniform array types"
2020-08-19 csmartdalton@google.com Move GrWangsFormula::nextlog2 to sk_float_nextlog2
2020-08-19 johnstiles@google.com Remove final vestiges of sk_InColor.
2020-08-19 ethannicholas@google.com SkSL now supports uniform array types
2020-08-19 csmartdalton@google.com Add utilities to SkGeometry for quad and cubic rotation angles
2020-08-19 mtklein@google.com update placeholder approx op count
2020-08-19 johnstiles@google.com Remove sk_InColor from unit tests.
2020-08-19 adlai@google.com Remove GrContext variant of SkImageGenerator::isValid
2020-08-19 johnstiles@google.com Fix simplification of switch statements with casts.
2020-08-19 reed@google.com pass 'nested' bool to approximateOpCount
2020-08-19 mtklein@google.com clean up SK_LATE_DITHER
2020-08-19 ethannicholas@google.com Added support for the 'inline' hint on SkSL functions
2020-08-19 mtklein@google.com remove sksl interpreter guards

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC stani@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2020-08-20 10:12:21 -04:00
Greg Spencer
a38b72119b Clean up scenario app scripts (flutter/engine#20641)
I just made a pass on the scenario scripts so that they can be more easily run from the scenario directory, set the ANDROID_HOME correctly, and generally fixed lint errors.

Also compile_android_aot.sh didn't appear to work, and I think I fixed it (it builds now).
2020-08-19 19:14:38 -07:00
David Worsham
3a6e0d47c6 fuchsia: Convert legacy permutations to build flag (flutter/engine#20647) 2020-08-19 19:09:51 -07:00
godofredoc
b731070351 Adds all the engine builders to the file used to validate tree status. (flutter/engine#20642)
Builders are read from a json file to get their last builds using
buildbucket and calculate the tree status. Some builders were not being
used for the tree status validation allowing rollers to land changes
even though some builders were failing.

Bug:
  https://github.com/flutter/flutter/issues/64061
2020-08-19 18:39:38 -07:00
Emmanuel Garcia
9192bb89fd Reland: Add android scenarios presubmit task. 2020-08-19 17:36:03 -07:00
James Clarke
a1d268a61b Fix flutter#40068 Redraw issues on resize/minimize/maximize on Windows and startup in release (flutter/engine#20357)
* Fix redraw issues

* Address CR feedback.

* Fix build

* CR feedback
2020-08-19 16:19:09 -07:00
skia-flutter-autoroll
10d08a4860 Roll Fuchsia Linux SDK from zbH5QA8Qz... to 57GPNeoZ7... (flutter/engine#20639) 2020-08-19 16:11:01 -07:00
Kaushik Iska
a8c392e6b8 [embedder] Add FBO callback that takes frame info (flutter/engine#20617) 2020-08-19 16:06:02 -07:00
Dan Field
5e03f90cdd fix build (flutter/engine#20644) 2020-08-19 14:35:45 -07:00
skia-flutter-autoroll
48c6da7f6d Roll Skia from 4a56f4c29ec5 to 17c5b7024297 (2 revisions) (flutter/engine#20631) 2020-08-19 14:16:01 -07:00
Jason Simmons
72dabb020d Release the AccessibilityBridge when destroying a legacy FlutterView (flutter/engine#20610) 2020-08-19 14:11:02 -07:00
chunhtai
df10c2b3b4 Missing default focus when navigating to a page with no SemanticsNode that sets namesRoute:true (flutter/engine#20516) 2020-08-19 14:06:03 -07:00
Dan Field
73490a2ca4 Hint freed (flutter/engine#19842)
* Hint the VM when a layer or picture goes out of scope
2020-08-19 14:04:31 -07:00
nturgut
2919c3bbef updating editing state after location change. focusing on the element (flutter/engine#20620) 2020-08-19 14:03:30 -07:00
nturgut
7d3b44dd47 [web] update chrome version (flutter/engine#20470)
* update chrome version, should be merged after recipe changes

* changing directory to use chrome driver in LUCI

* changing directory path's order

* add cipd packages's chrome version for mac

* addressing reviewer comments

* more documentation. update readme

* remove late since it didn't build. remove distinction in paths for local and LUCI.

* addressing reviewer comments. (non-null fields needs rechanging)

* addressing reviewer comments. adding 2.6 on files missing the notation
2020-08-19 12:28:44 -07:00
egdaniel
0ee7007d63 Remove use of ctors on Skia Vulkan struct (flutter/engine#20630)
Skia is removing the ctors on these structs so removing them.
2020-08-19 13:18:25 -04:00
Stas Parshin
fa3e19be27 Fix NPE in PlatformViewsController.checkInputConnectionProxy (flutter/engine#20622) 2020-08-19 08:34:04 -07:00
Chris Yang
72162b7a66 Ensure threads are merged when tearing down the Rasterizer (flutter/engine#19919) 2020-08-19 08:31:01 -07:00
stuartmorgan
bb04632eeb [windows] Allow delegation of top-level WindowProc (flutter/engine#20613)
Adds APIs for runners to delegate WindowProc handlers into the Flutter
engine, and for plugins to register as possible delegates.

This allows for plugins to alter top-level window behavior in ways that
can only be done from the WindowProc, such as resize control. This
functionality remains entirely on the native side, so is synchronous.

Part of https://github.com/flutter/flutter/issues/53168
2020-08-19 06:49:39 -07:00
skia-flutter-autoroll
8e45d2ed9e Roll Skia from 81eabce6a3af to 356838b9f8c0 (4 revisions) (flutter/engine#20623) 2020-08-19 00:46:02 -07:00
skia-flutter-autoroll
6912fd88bb Roll Fuchsia Linux SDK from Hx7fWXONL... to zbH5QA8Qz... (flutter/engine#20621) 2020-08-18 23:26:02 -07:00
skia-flutter-autoroll
eaa29167ff Roll Skia from 59a3c3be94f0 to 81eabce6a3af (1 revision) (flutter/engine#20618) 2020-08-18 23:21:01 -07:00
Dan Field
431323d512 Make const_finder work with implemented and extended classes (flutter/engine#20614) 2020-08-18 23:16:03 -07:00
Mouad Debbar
8f6c340c7b [web] Prepare for read-only input fields (flutter/engine#20520) 2020-08-18 23:11:02 -07:00
Greg Spencer
0764e7cf1a Remove doc comments in copied web interfaces (flutter/engine#20494)
* Remove doc comments in copied web interfaces

* Whitespace changes to improve readability
2020-08-18 17:15:16 -07:00
David Worsham
8b4e07c198 fuchsia: Increase timeout for flaky test (flutter/engine#20606) 2020-08-18 17:14:30 -07:00
Yegor
a18f17805c rename "compositor"/"surface" to "canvaskit"/"html"; document conventions (flutter/engine#20579)
* rename "compositor"/"surface" to "canvaskit"/"html"; document conventions
2020-08-18 13:30:58 -07:00
Greg Spencer
c001ea6f4a Convert format script to Dart (flutter/engine#20572)
This converts the ci/format.sh script to a Dart script that uses process_runner and isolates to multi-process the clang-format, diffs, and grepping needed to do the formatting changes.

It also will (by default) only check the formatting of changed files.

The user can optionally check all files (--all-files) or do only some types of checks with --check. --verbose prints the versions of the tools used for Clang format and Java format.

Specifying --fix will cause any formatting errors that would have been detected to be fixed.
2020-08-18 13:25:30 -07:00
Chase Latta
5f7105f763 convert zircon and fuchsia to null-safety (flutter/engine#20577) 2020-08-18 13:15:00 -07:00
skia-flutter-autoroll
ff3065a957 Roll Skia from a5a97b4858fb to 59a3c3be94f0 (3 revisions) (flutter/engine#20603) 2020-08-18 13:06:03 -07:00
skia-flutter-autoroll
f244d02e0b Roll Skia from afbf899cf1e2 to a5a97b4858fb (1 revision) (flutter/engine#20600) 2020-08-18 11:36:02 -07:00
skia-flutter-autoroll
beb63da9ac Roll Skia from a8b16365f92a to afbf899cf1e2 (7 revisions) (flutter/engine#20595) 2020-08-18 10:01:03 -07:00
godofredoc
8575bfbfd6 Revert "Add android scenarios presubmit task. (#20581)" (flutter/engine#20597)
This reverts commit 639cb1ea667adca6d97f5095d5f2e66ec63506c8.
2020-08-18 09:58:46 -07:00
skia-flutter-autoroll
2708696006 Roll Fuchsia Linux SDK from 4JYAs2BPb... to Hx7fWXONL... (flutter/engine#20592) 2020-08-18 09:36:03 -07:00
skia-flutter-autoroll
d2ec2f90ef Roll Skia from f9fb0716512d to a8b16365f92a (1 revision) (flutter/engine#20589) 2020-08-18 07:11:02 -07:00
skia-flutter-autoroll
a50646a342 Roll Skia from 688e0966cb16 to f9fb0716512d (3 revisions) (flutter/engine#20586) 2020-08-18 00:16:01 -07:00
skia-flutter-autoroll
7439478294 Roll Skia from e9d783c4d235 to 688e0966cb16 (1 revision) (flutter/engine#20584) 2020-08-17 22:51:01 -07:00
godofredoc
639cb1ea66 Add android scenarios presubmit task. (flutter/engine#20581)
Bug:
  https://github.com/flutter/flutter/issues/55326
2020-08-17 19:54:54 -07:00
Gary Qian
489c453c46 Update to android 30r2 and roll buildroot (flutter/engine#20479) 2020-08-17 16:33:48 -07:00
Emmanuel Garcia
a2732e0538 Reland: Create PlatformView instance right after method channel call from Dart (flutter/engine#20568) 2020-08-17 16:28:15 -07:00
skia-flutter-autoroll
8cd31d8c2c Roll Skia from f5931f3399e0 to e9d783c4d235 (1 revision) (flutter/engine#20576) 2020-08-17 16:26:01 -07:00
nturgut
ab6a3aa43a [web] Build unit tests with dart2js instead of build_runner (flutter/engine#20390)
* change from build_runner to dart2js

* add internalBootstrapBrowserTest to some of the tests

* add internalBootstrapBrowserTest to all remaining tests

* make tests build in paralel. Total time dropped from 586 to 177 seconds for 8 core MacBook

* change isolates with pool

* fixing analysis errors

* skipping canvaskit tests for ios-safari

* copy image files to the build directory

* adding internalBootstrapBrowserTest to newly added tests

* add internalBootstrapBrowserTest to faling path iterator test

* necessary changes to make chrome windows work

* in windows test in chrome instead of edge. our edge code was for legacy edge

* do not run golden unit tests on Windows LUCI bots for now

* addressing reviewer comments. Adding a method for deciding when to run integration tests.

* remove lines that I forgot to remove

* fixing analysis error. add issue for todo

* add bootstap to a test file

* adding bootstrap to another test

* add internalBootstrapBrowserTest to a golden test

* return test result in bat file. use archieve package to unzip

* fixing logs for chrome_installer

* use archieve and archieve entity instead of dynamic

* adding comments for windows platform archieve part

* addressing reviewer comments

* change readme file
2020-08-17 16:19:27 -07:00
skia-flutter-autoroll
e2d628f70c Roll Fuchsia Linux SDK from oNnqaiRXK... to 4JYAs2BPb... (flutter/engine#20571) 2020-08-17 14:26:02 -07:00
Greg Spencer
d737cca58e Clean up the CI scripts and make it so that they can be run from anywhere (flutter/engine#20538)
This cleans up the ci scripts so that they can be run from an arbitrary directory, and so that they don't have any bash lint issues, and are more explicit about which dart/pub/dartanalyzer executable they run.

I also fixed the format script to take a "--fix" argument that will fix all of the formatting issues found, including trailing whitespace and gn files.

I added a warning to the license script about untracked/ignored files in the fluttter repo because those so often trip up the license script.

I added missing license information to the ci scripts too.

There's now a bit of boilerplate at the beginning of each script (the follow_links function) in order to reliably find the actual location of the script: I'd put it into a common file, except that that code would be needed to reliably find the common location too, so I needed to duplicate it. It's the same boilerplate as what is used in the flutter/flutter repo for the flutter and dart scripts.

I deleted the ci/test.sh script, since it seems to be obsolete (the test it tries to run doesn't exist anywhere).
2020-08-17 14:03:01 -07:00
skia-flutter-autoroll
763277f6c0 Roll Skia from 37e6f530dc10 to f5931f3399e0 (2 revisions) (flutter/engine#20567) 2020-08-17 13:01:05 -07:00
Yegor
a1e5e33bda use anonymous in some deletable Sk classes (flutter/engine#20528) 2020-08-17 11:57:12 -07:00
skia-flutter-autoroll
40245ebf0c Roll Skia from ce1d885a576c to 37e6f530dc10 (1 revision) (flutter/engine#20565) 2020-08-17 11:41:04 -07:00
gaaclarke
9ef815d6dc Revert "Create PlatformView instance right after method channel call from Dart (#20500)" (flutter/engine#20564)
This reverts commit a87eaedcc22c1b96065222cdf6a05fe32c0b09f0.
2020-08-17 11:17:03 -07:00
skia-flutter-autoroll
9f1bb20fee Roll Skia from fdbd50a8dc87 to ce1d885a576c (3 revisions) (flutter/engine#20562) 2020-08-17 10:21:01 -07:00