We never paint scroll corners. The only thing we need them
for is so that the vertical and horizontal scrollbars don't
overlap each other. So, that's the only place left that
still computes a scroll corner rect.
We don't support resizers. Remove the code for them as well
as the CSS resize property.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/689283003
These are values for text-align that align blocks in addition to
inline content. You can get the same centering affect with margin:auto.
If we want this functionality, we should implement it with the
same alignment APIs that we use for flexbox.
Delete unused methods/arguments from RenderBlockFlow.
No change in behavior. Just deleting dead code.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/708843002
The two are unrelated, but it was easier to just grep for grid
and remove them all. Aside from the media query change, there
isn't any change in behavior since grid was behind a flag.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/689853003
This just removes a random subset of vertical writing mode bits
that I grepped for. There's a ton more to do, but it seems best to
do it in chunks.
The key things for understanding this patch, isWritingModeRoot is
always false and isHorizontalWritingMode is always true. Also,
we're never flipped* modes of any kind, so we can undo any flipping.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/688213002
Also removed a bunch of trace() methods which
I touched by accident. Turns out they're
all very interconnected sadly.
I re-wrote Supplement to not use templates
in an earlier version of this patch
but hit some trouble with vtables
and decided to table that work
for a later time once more of oilpan
has been unwound.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/683703003
Nothing in heap/ is called anymore, but it
still has its claws deep into many of the
base classes for the rest of Sky, so I've left
the (largely unmodified) headers for now.
We'll trim the headers further in later patches.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/681963002
The goal here was to delete all the oilpan
conversion types and then as well all the calls
into trace(). In the process of attempting
to get it compiling I removed some trace()
calls from the font system before finding the
one stray trace() call I had missed in handle
causing the link errors.
TBR=abarth@chromium.org
Review URL: https://codereview.chromium.org/679113005
I used do-webcore-rename from Blink/WebKit
which is very good at doing this kind
of search-replace.
Also removed toRefPrtNativeArray after
conversion since it previously had two
separate flavors. Both versions are no longer
used so I've removed the code until we
need one again.
https://www.irccloud.com/pastebin/5C16p5cE
is the diff I used to do-webcore-rename
TBR=abarth@chromium.org
This was the last complicated piece of removing
platform/heap, the rest should be trivial to delete
after removing :trace overrides and mass-renaming
the various WillBe types to their old versions.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/683593002
This makes Sky never call into the
Heap::init/shutdown methods and removes
most Heap:: and ThreadState:: calls throughout
the rest of Sky.
There is a *ton* more to remove after this.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/678003003
I also fixed several errors in our BUILD.gn files
including bad script dependencies found by
missing_from_gn and gn check.
Still need to figure out how best to handle
:libraries deps being private to :core, etc.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/678703004
I accidentally broke border parsing when
removing CSS color keyword hacks.
While debugging this I also ran into a
race condition in the debugger, which
is fixed here.
Add --gdb argument to skydb
Makes it trivial to drop into gdb having launched
mojo_shell/sky with the right arguments.
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/673073002
