314 Commits

Author SHA1 Message Date
Carlo Bernaschina
e7cd520490 Add waitUIThreadIdle service RPC (flutter/engine#3898)
In https://github.com/flutter/engine/pull/3833 the `_flutter.listViews` RPC moved from thread based to lock based synchronization.
The thread based synchronization side effect was used by flutter benchmarks in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/vmservice.dart#L1223 and
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/run_hot.dart#L156 to ensure the completeness of the restart/reload and so correct timing.

A new RPC `_flutter.flushUIThreadTasks` is introduced to allow the flutter benchmarks to reintroduce thread based synchronization.

Related https://github.com/flutter/flutter/issues/11241
2017-07-19 15:48:32 -07:00
Todd Volkert
27c20427cc Add PluginRegistry.Registrar#view() (flutter/engine#3900)
Sometimes, plugin instances need access to the `FlutterView`.
They can currently cast the `messenger()`, but that's fragile.
This adds API support for getting the view from the registry.
2017-07-18 19:16:15 -07:00
Chinmay Garde
d531cc9819 Enable the “Highlight Vsync” option in the timeline viewer on Android. (flutter/engine#3901) 2017-07-18 18:11:35 -07:00
Chinmay Garde
9dbdc4bee6 Fix Mac desktop platform for use with std::weak_ptr in the PlatformView. (flutter/engine#3897) 2017-07-18 14:29:36 -07:00
Brian Osman
1a126078de Revert "Revert "Reland "Run Flutter on iOS and Android with color correct Skia (#3826)" (#3878)" (flutter/engine#3895)
This reverts commit 849b700434fdcd3fc24f05640582b127654aa7d8.
2017-07-18 15:58:35 -04:00
Brian Osman
c193d71868 Revert "Revert "Switch to new encode API on SkPixelSerializer"" (flutter/engine#3896)
* Revert "Accumulate a batch of Skia objects that will be destructed later on the IO thread (#3888)"

This reverts commit 29bacddb699c6f996bf9f6a241d35bd4cf650df4.

* Revert "Revert "Switch to new encode API on SkPixelSerializer (#3892)" (#3894)"

This reverts commit 8648dd3b82ddf58ab4b0230d019219eb890ed173.
2017-07-18 15:44:13 -04:00
Brian Osman
8648dd3b82 Revert "Switch to new encode API on SkPixelSerializer (#3892)" (flutter/engine#3894)
This reverts commit 78023f7ae74df1c543e253ff9ad427ef1f131652.
2017-07-18 13:58:56 -04:00
Brian Osman
78023f7ae7 Switch to new encode API on SkPixelSerializer (flutter/engine#3892)
Previous API is deprecated, soon to be deleted.
2017-07-18 13:04:51 -04:00
Michael Goderbauer
c4f8806a1d Wire up SemanticsAction Increase and Decrease on Android (flutter/engine#3876) 2017-07-17 16:48:50 -07:00
Chris Bracken
1622edea30 Set iOS text field autocorrection type (flutter/engine#3880)
Adds handling for the autocorrect field on TextField on iOS devices.
2017-07-14 12:43:45 -07:00
Jason Simmons
d5cca395b2 Invert the autocorrect flag (flutter/engine#3875)
See https://github.com/flutter/engine/pull/3866
2017-07-13 15:33:08 -07:00
Collin Jackson
849b700434 Revert "Reland "Run Flutter on iOS and Android with color correct Skia (#3826)" (flutter/engine#3878)
This reverts commit 3cfb2821b9aa7f288d6aedd9f90c51b11bf451ad.

Fixes a regression with semitransparent images (flutter/flutter#11169)
2017-07-13 14:22:25 -07:00
Michael Goderbauer
f5e0e245ea Fix engine on iOS (flutter/engine#3871)
Related to https://github.com/flutter/engine/pull/3870.
2017-07-12 16:45:45 -07:00
Jason Simmons
a17f541da0 Hold the TestRunner's platform view through a shared_ptr (flutter/engine#3870)
flutter_tester was throwing a bad_weak_ptr while setting up the engine
because the PlatformViewTest was held in a unique_ptr
2017-07-12 16:37:47 -07:00
Michael Goderbauer
e1232ee771 a11y: Add SemanticsAction "showOnScreen" (flutter/engine#3856)
This action is triggered when the user swipes (in accessibility mode) to the last visible item of a scrollable list to bring that item fully on screen.

iOS implementation to follow.
2017-07-12 15:52:30 -07:00
Jason Simmons
59b447a5fe Enable text autocorrect on Android with a flag to disable it (flutter/engine#3866)
See https://github.com/flutter/flutter/issues/11168
2017-07-12 14:44:20 -07:00
Carlo Bernaschina
c9286a9e4d Add missing virtual methods in PlatformView (flutter/engine#3867) 2017-07-12 13:06:02 -07:00
Carlo Bernaschina
dc20dc0cec Avoid to freeze the system if hot reloading during debug (flutter/engine#3833) 2017-07-12 10:25:42 -07:00
Jason Simmons
e0315eb27d Do not enter text for key events that are not associated with a character (flutter/engine#3860)
Fixes https://github.com/flutter/flutter/issues/10723
2017-07-10 17:41:14 -07:00
Jason Simmons
49102a88dd Do not try to apply selections outside the length of the text (flutter/engine#3845)
See https://github.com/flutter/flutter/issues/11041
2017-06-30 14:50:01 -07:00
Michael Goderbauer
d42e03959b Fix a11y scroll direction (flutter/engine#3841)
See also https://github.com/flutter/engine/pull/3701
2017-06-29 15:56:17 -07:00
Jason Simmons
29885427b8 Remove warning about a deprecated accessibility API (flutter/engine#3837) 2017-06-28 12:47:15 -07:00
Brian Osman
3cfb2821b9 Reland "Run Flutter on iOS and Android with color correct Skia (flutter/engine#3826)
* Revert "Revert "Reland "Run Flutter on iOS and Android with color correct Skia" (#3818)" (#3823)"

This reverts commit fdaab5c38fa82de669347508817b377285733946.

* Fix test code to match internal API change
2017-06-27 13:30:10 -04:00
Brian Osman
fdaab5c38f Revert "Reland "Run Flutter on iOS and Android with color correct Skia" (#3818)" (flutter/engine#3823)
This reverts commit cadd2d3fca1103ea0cbfb9f23dbc54907acac759.
2017-06-23 20:28:24 -04:00
Brian Osman
cadd2d3fca Reland "Run Flutter on iOS and Android with color correct Skia" (flutter/engine#3818)
* Revert "Revert "Run Flutter on iOS and Android with color correct Skia (#3743)" (#3775)"

This reverts commit c49f348d7c4238d653e7f3bbb8ce7cfab0996ad1.

* Enable sRGB on IO thread, too

* Add 4444 as a fallback rendering mode

* Use bare ptr to SkColorSpace (not sk_sp) in PrerollContext
2017-06-23 20:21:29 -04:00
Jason Simmons
529ee0bb76 Catch exceptions during invocations of updateSemantics from native code (flutter/engine#3813) 2017-06-22 11:19:32 -07:00
Jason Simmons
56a63675a8 Revert to API level 16 compatible variant of AccessibilityNodeInfo.addAction (flutter/engine#3810)
Fixes https://github.com/flutter/flutter/issues/10855
2017-06-21 12:31:08 -07:00
Jason Simmons
e041ba9cd8 Do not call restartInput twice when setting a new text input client. (flutter/engine#3808)
If restartInput is called twice in quick succession, then the IME may output
warnings related to usage of the obsolete connection resulting from the first
call.

Fixes https://github.com/flutter/flutter/issues/10730
2017-06-21 10:47:02 -07:00
Todd Volkert
cf8a46f24d Remove FlutterActivity#onFlutterReady() (flutter/engine#3806)
Fixes https://github.com/flutter/flutter/issues/10571
2017-06-21 10:03:04 -07:00
Sarah Zakarias
85cb53fac9 Fix compile error in FlutterViewController (flutter/engine#3807) 2017-06-21 15:20:52 +02:00
Sarah Zakarias
e0d7204728 Send AppLifecycleState notifications on FlutterViewController lifecycle events. (flutter/engine#3801) 2017-06-21 14:39:05 +02:00
P.Y. Laligand
96ec6f66a4 Update to newer version of the FTL. (flutter/engine#3804) 2017-06-20 16:53:14 -07:00
Chris Bracken
1fd2bd9850 Revert libtxt integration (flutter/engine#3802)
* Revert "Fix licenses_lib golden file (#3798)"

This reverts commit d8ac43c3c9123fead15af3004d1e445834115bbd.

* Revert "Remove ParagraphConstriants (#3796)"

This reverts commit 2358613f9b6e3f3eee70f1cbfd2af92d3c049475.

* Revert "Reland "Initial integration of libtxt with Flutter alongside Blink." (#3793)"

This reverts commit d9bc2f5604e5cfef7deef2f813751e0cd46a515d.
2017-06-20 09:59:56 -07:00
Chris Bracken
22674ba9e6 Eliminate ASL stdout forwarding on iOS (flutter/engine#3797)
ASL was deprecated in iOS 10 and started causing SIGPIPE issues in iOS
10.3. Under the iOS 8 SDK, syslog() stopped working as of iOS 10.3
devices, with the result that ASL stdout/stderr forwarding was the only
means of logging. The engine now builds against the iOS 10 SDK, with
deployment target of iOS 8. Under this SDK, syslog() works correctly
across all supported OS versions.

NOTE: This is a temporary fix to get developers unblocked. While this
does fix the SIGPIPE issue and put iOS logging on par with the Android
solution, the intent is to move to a dedicated communication channel
with flutter_tools that isn't log-based.
2017-06-19 18:10:30 -07:00
Jason Simmons
c95fc6fd28 Set the initial route before launching the Dart app (flutter/engine#3795)
See https://github.com/flutter/flutter/issues/10813
2017-06-19 15:25:47 -07:00
Gary Qian
d9bc2f5604 Reland "Initial integration of libtxt with Flutter alongside Blink." (flutter/engine#3793)
* Transition to Hybrid lib/txt and blink text system.
2017-06-19 15:21:41 -07:00
Chris Bracken
ec07bed91f Revert "Update to newer version of the FTL. (#3786)" (flutter/engine#3792)
This reverts commit f757c49416d39e74c5c11bdbd9659aed362a8e32.
2017-06-19 15:02:52 -07:00
P.Y. Laligand
f757c49416 Update to newer version of the FTL. (flutter/engine#3786) 2017-06-19 12:48:23 -07:00
Ian McKellar
756341be6e Revert "Initial integration of libtxt with Flutter alongside Blink." (flutter/engine#3785)
* Revert "Enable line join styles and miter limit. (#3777)"

This reverts commit cafd4b93a06b6d327f1bc59e296bf2c618eb34e4.

* Revert "Revert "Update switches to use StringView." (#3784)"

This reverts commit 5ffa5ef3a6b2c8689c7d12cd67b6823ba25783a5.

* Revert "Initial integration of libtxt with Flutter alongside Blink. (#3771)"

This reverts commit b4a9f9c6d5008f677400826dfa3a0ab30de3db23.
2017-06-16 15:15:48 -07:00
P.Y. Laligand
5ffa5ef3a6 Revert "Update switches to use StringView." (flutter/engine#3784)
* Revert "Initial integration of libtxt with Flutter alongside Blink. (#3771)"

This reverts commit b4a9f9c6d5008f677400826dfa3a0ab30de3db23.

* Revert "Call Selection.removeSelection if the framework has cleared the selection (#3782)"

This reverts commit 2a34ee9a676b0049a18fc9e131ad1b311e1ea848.

* Revert "Update switches to use StringView. (#3781)"

This reverts commit 6adf58135e16dfb0ff04b00672abe6f0876c91b4.
2017-06-16 14:32:09 -07:00
Gary Qian
b4a9f9c6d5 Initial integration of libtxt with Flutter alongside Blink. (flutter/engine#3771) 2017-06-16 14:15:53 -07:00
Jason Simmons
2a34ee9a67 Call Selection.removeSelection if the framework has cleared the selection (flutter/engine#3782)
Fixes https://github.com/flutter/flutter/issues/10748
2017-06-16 14:01:45 -07:00
P.Y. Laligand
6adf58135e Update switches to use StringView. (flutter/engine#3781)
See https://fuchsia-review.googlesource.com/#/c/31931/.
2017-06-16 12:51:26 -07:00
Mikkel Nygaard Ravn
da3ae8fc95 Add alignment padding to floats in std codec (flutter/engine#3780) 2017-06-15 21:22:18 -07:00
Jason Simmons
156f123b12 Align doubles to 8 bytes in the StandardMessageCodec (flutter/engine#3779)
See https://github.com/flutter/flutter/issues/10701
2017-06-15 21:15:25 -07:00
Michael Goderbauer
c49f348d7c Revert "Run Flutter on iOS and Android with color correct Skia (#3743)" (flutter/engine#3775)
This reverts commit bac6502d62a3ab3157147b3d53776c3f16000a31.
2017-06-14 16:26:20 -07:00
Jason Simmons
f77a01eaca Simplify state management in the Android text editing plugin (flutter/engine#3769)
In particular, this avoids some unnecessary calls to InputMethodManager.restartInput
that caused noticeable lag when moving the cursor.

Fixes https://github.com/flutter/flutter/issues/9928
2017-06-14 10:24:41 -07:00
Todd Volkert
e69672b40a Add support for application:openURL:options: in FlutterPlugin (flutter/engine#3766)
Both the following, which we also support, are deprecated in UIKit:

* `application:handleOpenURL:`
* `application:openURL:sourceApplication:annotation:`
2017-06-12 20:57:12 -07:00
Mehmet Fidanboylu
f38ab73dab Expose performActionForShortcutItem call to all registered plugins so we can handle quick actions (flutter/engine#3763)
* Expose performActionForShortcutItem call to all registered plugins so we can handle quick actions

* Should return BOOL not void

* clang-formatted
2017-06-09 17:55:48 -07:00
Michael Goderbauer
89ab65beea Adding SemanticsFlag.isSelected (flutter/engine#3764)
* Adding SemanticsFlag.isSelected

* typo
2017-06-09 15:58:30 -07:00