6987 Commits

Author SHA1 Message Date
Ian Hickson
e768c92fbc
Add many more global analyses. (#47875)
* Update packages.

* Add many more global analyses.

* Catch trailing spaces and trailing newlines in all text files.
  Before we were only checking newly added files, but that means we
  missed some.

* Port the trailing spaces logic to work on Windows too.

* Correct all the files with trailing spaces and newlines.

* Refactor some of the dev/bots logic into a utils.dart library.
  Notably, the "exit" and "print" shims for testing are now usable
  from test.dart, analyze.dart, and run_command.dart.

* Add an "exitWithError" function that prints the red lines and
  then exits. This is the preferred way to exit from test.dart,
  analyze.dart, and run_command.dart.

* More consistency in the output of analyze.dart.

* Refactor analyze.dart to use the _allFiles file enumerating logic
  more widely.

* Add some double-checking logic to the _allFiles logic to catch
  cases where changes to that logic end up catching fewer files
  than expected (helps prevent future false positives).

* Add a check to prevent new binary files from being added to
  the repository. Grandfather in the binaries that we've already
  added.

* Update all the dependencies (needed because we now import crypto in
  dev/bots/analyze.dart).
2019-12-30 17:12:19 -08:00
Kate Lovett
4fbef2a4a9
Revert "Testing tryjob triage (#47893)" (#47985)
This reverts commit 659dc8129d4edb9166e9a0d600439d135740933f.
2019-12-30 13:09:14 -08:00
Kate Lovett
659dc8129d
Testing tryjob triage (#47893) 2019-12-30 09:24:47 -08:00
Devon Carew
43a8c24344
fix an analysis ignore for the missing_required_param hint (#47956) 2019-12-29 12:28:57 -08:00
神楽坂花火
b28dd0c296 Reland "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47855) 2019-12-27 18:33:01 -08:00
LongCatIsLooong
ae24f18414
Reland 39919 CupertinoPicker (#47837) 2019-12-26 17:26:55 -08:00
Jonathan White
1fe05983e6 Fix typos in DefaultTabController.of documentation (#46907)
Fix error in `DefaultTabController.of` documentation

Co-authored-by: Shi-Hao Hong <shihaohong@google.com>
2019-12-26 09:45:25 -08:00
LongCatIsLooong
b7af5e714d
Revert "Add brightness to CupertinoNavigationBar (fixes #46216) (#47521)" (#47805) 2019-12-25 23:49:55 -08:00
神楽坂花火
2cbf126fe8 Add brightness to CupertinoNavigationBar (fixes #46216) (#47521) 2019-12-25 21:54:12 -08:00
Shi-Hao Hong
6e72facad1
Fix Icon.color docs (#47691) 2019-12-24 10:54:04 -08:00
Chen Yumin
0265cb6849 Make tab's icon margin configurable (Fix #47363) (#47364)
Adds the `iconMargin` parameter to Tab
2019-12-23 15:37:16 -08:00
Alexandre Ardhuin
4adad2c652
update list of lints (#47661) 2019-12-23 18:40:56 +01:00
Jim Graham
fcaf9c4070 Support for ImageFiltered widget to apply ImageFilter to children. (#47489) 2019-12-21 14:03:01 -08:00
Lau Ching Jun
ef398d9e87 Disable most screenshot tests for web until we understand the flakes. (#47554) 2019-12-20 18:43:01 -08:00
gaaclarke
72a3d914ee
Added a code sample for replacing the image cache. (#47467) 2019-12-20 08:50:42 -08:00
Dan Field
93f718b386 Fix requestExistingInputState response (#47472) 2019-12-20 03:33:01 -08:00
Matt Sullivan
f6922d57fc Fixed incorrect offsetting when applying ShaderMasks (#45654) 2019-12-19 19:48:01 -08:00
LongCatIsLooong
e3c8ecaf7f
Reland "Fix sliver geometry assert (#47027)" 2019-12-19 14:27:35 -08:00
Gary Qian
b011ea5468
Pass _caretPrototype to prevent cache miss (#46720) 2019-12-20 06:46:49 +09:00
Dan Field
4ad8271bf5 Reland text state (#47464) 2019-12-19 13:43:02 -08:00
Justin McCandless
92c21a5701
Fix a typo in the docs (#47391)
Just a docs text change.
2019-12-19 09:40:01 -08:00
Alexandre Ardhuin
78db965642 Reland implicit-casts: false (#47431) 2019-12-19 02:23:01 -08:00
Lau Ching Jun
a4858782da
Revert "implicit-casts: false (#47199)" (#47428)
This reverts commit c235998acf17206c6ce411af235faf439d9ff7b2.
2019-12-18 23:53:00 -08:00
Alexandre Ardhuin
c235998acf implicit-casts: false (#47199) 2019-12-18 23:23:01 -08:00
Lau Ching Jun
d51956a9ea
Revert "Call setEditingState when text changes. (#47177)" (#47397)
This reverts commit d4b49ce9fc47885b1f634aad6b124a48917a81dc.
2019-12-18 18:03:24 -08:00
Lau Ching Jun
f32dee6e30
Revert "Fix sliver geometry assert (#47027)" (#47390)
This reverts commit 117dfaf2871908d55f73e390c6a3ce4b70010fc8.
2019-12-18 17:02:11 -08:00
Gary Qian
f05ab50370
Detect and dump flaky LineMetrics test data (#46213) 2019-12-19 09:28:02 +09:00
Michael Goderbauer
beb86d2cc4 Revert "Simplify Chip slightly (#47254)" (#47353) 2019-12-18 14:03:01 -08:00
KalilDev
b39ebcb55f Fix CupertinoContextMenuAction color behavior (#47151)
"destructive" color wasn't working for ContextMenuAction, this PR fixes it.
2019-12-18 13:57:40 -08:00
Lau Ching Jun
bc67d22449
Revert "iOS UITextInput autocorrection prompt (#45354)" (#47373)
This reverts commit 0f8c0da0a9ded2a9b7aa3bd01fcc29db80bbab0a.
2019-12-18 13:56:44 -08:00
Shi-Hao Hong
bde351eea2
Make AlertDialog scrollable through AlertDialog.scrollable parameter (#45079)
* Add AlertDialog.scrollable

* Add deprecation notice

* Ignore deprecation warning in dialog.dart with TODO
2019-12-18 12:31:16 -08:00
Alex Vincent
f546aa7def Fix buildCounter returns a widget when set to return null. (#45749)
When buildCounter returns null it no longer produces a widget that takes up space.
2019-12-18 10:45:28 -08:00
Scott Hyndman
ceef460a64 Correct name in DecorationImage error string (#47260) 2019-12-18 00:23:02 -08:00
神楽坂花火
0ec73510ec Add textScaleFactor to SelectableText (#44682) 2019-12-17 19:38:01 -08:00
Michael Goderbauer
b7d221227c
Simplify Chip slightly (#47254) 2019-12-17 16:23:05 -08:00
LongCatIsLooong
0f8c0da0a9
iOS UITextInput autocorrection prompt (#45354) 2019-12-17 16:22:28 -08:00
Dan Field
d4b49ce9fc
Call setEditingState when text changes. (#47177) 2019-12-17 14:03:04 -08:00
LongCatIsLooong
a82a399733
remove mediaQuery bottom padding when the tab scaffold has an opaque navbar (#46106) 2019-12-16 23:28:02 -08:00
LongCatIsLooong
117dfaf287
Fix sliver geometry assert (#47027) 2019-12-16 18:19:23 -08:00
Shi-Hao Hong
7874bca248
Move localization executables to bin folder (#46251) 2019-12-16 17:30:57 -08:00
Shi-Hao Hong
7f56a61417
Fix isDense default for DropdownButtonFormField (#47160) 2019-12-16 16:40:15 -08:00
Alexandre Ardhuin
dfbd585668 implicit-casts:false in flutter/test (#46245) 2019-12-16 15:03:02 -08:00
Alexandre Ardhuin
aa071efd17 implicit-casts:false in flutter/lib/src/cupertino (#45502) 2019-12-16 14:58:03 -08:00
Dan Field
467f3d49ec remove duplicative checks (#47026) 2019-12-16 12:38:02 -08:00
Kate Lovett
b0b8b91b97
RenderProxySliver (#45942) 2019-12-16 12:37:57 -08:00
Kate Lovett
9024231030 SliverVisibility (#45582) 2019-12-16 12:23:03 -08:00
Yuwen Yan
fba96809f4 Add enableDrag configuration for showModalBottomSheet (#46685) 2019-12-16 12:14:24 -08:00
Justin McCandless
c06bf6503a
iOS smart quote/dash configuration (#44923)
smartDashesType and smartQuotesType params for text fields to control iOS's smart punctuation feature.
2019-12-13 17:42:35 -05:00
Dan Field
1bca434cdd
Check for NaN in sliver constraints, improve error messaging (#46995) 2019-12-13 14:39:07 -08:00
Dan Field
82f6d43bf1
Avoid NaN for shrinkwrapping viewports (#46265) 2019-12-13 14:36:53 -08:00