1645 Commits

Author SHA1 Message Date
Ferhat
15ac139f1a Revert "[web] Reland - Switch web-render option default to auto (#23313)" (flutter/engine#23321)
This reverts commit f6effe1f317b028919a0e9eed39b814bbd7420fa.
2020-12-28 16:27:10 -08:00
Ferhat
a2b5e4837d [web] Prevent recycling canvas twice due to paint queue (flutter/engine#23315) 2020-12-28 12:26:38 -08:00
nturgut
bef022f841 fixes text area transitions both for mobile and desktop (flutter/engine#23256)
* fixes text area transitions both for mobile and desktop

* add a fix for safari desktop

* remove focus related changes

* change text editing a11y tests. enable them in all browsers

* remove unused variables

* remove debug print
2020-12-28 11:15:14 -08:00
Ferhat
f6effe1f31 [web] Reland - Switch web-render option default to auto (flutter/engine#23313) 2020-12-28 11:10:38 -08:00
Dan Field
470a59d5ab cache closures from hooks.dart (flutter/engine#23230) 2020-12-28 09:34:13 -08:00
nturgut
db5506339c Revert "Re-merge Switch web-render option default to auto. Add documentation (#23187)" (flutter/engine#23246)
This reverts commit f357d3b5e54ca0613eb99566c74cbbb455f2f645.
2020-12-22 12:02:26 -08:00
Dan Field
dedf9bd1af Reland path volatility tracker, disabling it if deterministic rendering is requested (flutter/engine#23226)
* Reland path volatility tracker (#23063)" (#23220)

This reverts commit b56fc25561417f96e17dacab375e66f474a54c94.

* allow disabling based on whether deterministic rendering is needed
2020-12-22 08:25:20 -08:00
Dan Field
b56fc25561 Revert "Reland path volatility tracker (#23063)" (flutter/engine#23220)
This reverts commit 77c7096efb0b1392acc9793c386561a3c36012ba.
2020-12-21 13:53:18 -08:00
nturgut
f357d3b5e5 Re-merge Switch web-render option default to auto. Add documentation (flutter/engine#23187) 2020-12-21 09:56:02 -08:00
Zachary Anderson
0e13440547 Revert "[web] Switch web-render option default to auto (#23090)" (flutter/engine#23161)
This reverts commit b9b87cba3c4d099e288f268837cd85532422776e.
2020-12-17 18:22:36 -08:00
Mouad Debbar
5f3eef06c8 [web] Rich text painting on bitmap canvas (flutter/engine#23136) 2020-12-17 18:19:02 -08:00
Paul Berry
75573ad6f9 Fix engine in preparation for implementing https://github.com/dart-lang/language/issues/1274 (flutter/engine#23131)
When https://github.com/dart-lang/language/issues/1274 (Infer
non-nullability from local boolean variables) is implemented, flow
analysis will detect that code like this no longer needs to perform a
null check:

    final bool hasIdentityTransform =
        transform == null || isIdentityFloat32ListTransform(transform);
    ...
    if (!hasIdentityTransform) {
      ... transform! ... // Null check unnecessary
    }

To avoid a build failure due to the unnecessary null check, we need to
temporarily write it in a way that we can ignore it.  Once the feature
is complete and rolled into flutter, I'll remove the null check
entirely.
2020-12-17 11:59:07 -08:00
Mouad Debbar
b5c5015ee1 [web] Rich paragraph getPositionForOffset (flutter/engine#23133) 2020-12-17 11:27:34 -08:00
Siva
ae14ea248a Add missing sdk constriant in pubspec.yaml files. (flutter/engine#23124)
* Add missing sdk constriants in pubspec.yaml files.

* Update tools/android_lint/pubspec.yaml

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2020-12-17 09:45:26 -08:00
Mouad Debbar
184f46c9d6 [web] Rich paragraph getBoxesForRange (flutter/engine#23098) 2020-12-16 18:09:48 -08:00
Chris Bracken
5adca322f1 Rename PointerState.isDown as per style guide (flutter/engine#23120)
Renames from isDown to is_down in accordance with the C++ style guide.
2020-12-16 17:09:18 -08:00
Mouad Debbar
f3d95ad5f7 [web] Tests for rich paragraph DOM (flutter/engine#23097) 2020-12-16 17:05:04 -08:00
Ferhat
b9b87cba3c [web] Switch web-render option default to auto (flutter/engine#23090) 2020-12-16 16:43:13 -08:00
Yegor
e42f24fbb2 Fix recursive access to SkImage in image resurrector (flutter/engine#23115) 2020-12-16 14:31:24 -08:00
Chris Bracken
4ea49c62fa Correct button state on synthetic pointer events (flutter/engine#23111)
This corrects the button state emitted on synthetic pointer move and
hover events generated by the engine.

When an embedder notifies the engine of a pointer up or down event, and
the pointer's position has changed since the last move or hover event,
`PointerDataPacketConverter` generates a synthetic move or hover to
notify the framework of the change in position. In these cases, the
current event from the embedder contains the new button state *after*
the pointer up/down event, but the move/hover needs to be synthesized
such that it occurs *before* the pointer up/down, with the previous
button state.

This patch stores the button state after each pointer down, up, move, or
hover event such that it can be used by the next event if a synthetic
event must be issued.

The bug in the previous logic was revealed by the release of macOS 11
(Big Sur), which appears to issue move events between mouse down and
mouse up, which did not use to be the case.

This fixes https://github.com/flutter/flutter/issues/64961, which is the
desktop-specific tracking bug for the more general Big Sur mouse click
umbrella issue https://github.com/flutter/flutter/issues/71190.
2020-12-16 11:57:42 -08:00
Ferhat
c689b12d7c Prevent recycling of canvas multiple times (flutter/engine#23089) 2020-12-15 16:42:40 -08:00
Mouad Debbar
91b4a07214 [web] Calculate height and baseline for rich text (flutter/engine#23064) 2020-12-15 15:48:34 -08:00
Yegor
4c725519d5 [canvaskit] cache and reuse platform view overlays (flutter/engine#23061) 2020-12-15 14:57:05 -08:00
Yegor
c10759140f upgrade Firefox to 83 (flutter/engine#22829) 2020-12-15 12:12:06 -08:00
Dan Field
77c7096efb Reland path volatility tracker (flutter/engine#23063)
* Revert "Revert "Set SkPath::setIsVolatile based on whether the path survives at least two frames (#22620)" (#23044)"

This reverts commit feda80cb42f99e2588a9a6b9ab3dd1f812d0f45b.

* Fix tracing
2020-12-14 17:21:55 -08:00
Yegor
6d0fe946e2 [canvaskit] improve image error handling and messaging (flutter/engine#22951) 2020-12-14 14:46:15 -08:00
Mouad Debbar
6373f1dd08 [web] Align offset for lines of rich text (flutter/engine#23043) 2020-12-14 13:23:03 -08:00
Mouad Debbar
270b8d9836 [web] Separate the height ruler from the other rulers (flutter/engine#22964) 2020-12-14 13:13:02 -08:00
Harry Terkelsen
82c73e3bcb CanvasKit fix embedded view clipping (flutter/engine#22937) 2020-12-14 13:08:03 -08:00
Harry Terkelsen
b080ed1880 Pass angles for SweepGradient in degrees, not radians (flutter/engine#21677) 2020-12-11 16:54:54 -08:00
Harry Terkelsen
eac028036e Implement pushColorFilter in CanvasKit (flutter/engine#22838)
* Implement pushColorFilter in CanvasKit

* Add test

* Update goldens lock
2020-12-11 16:54:28 -08:00
Dan Field
feda80cb42 Revert "Set SkPath::setIsVolatile based on whether the path survives at least two frames (#22620)" (flutter/engine#23044)
This reverts commit 2d52a3c87c97660a050e4bf5559091d0cec262f3.
2020-12-11 15:39:24 -08:00
Yegor
3a38b167e6 [canvaskit] reuse canvases when window resizes (flutter/engine#22966) 2020-12-11 15:05:11 -08:00
Mouad Debbar
7bd531481c [web] Add complex rich text test cases and fix them (flutter/engine#22948) 2020-12-11 11:28:49 -08:00
Mouad Debbar
e6407ec378 [web] Introduce flag to enable new rich text implementation (flutter/engine#22942) 2020-12-11 09:28:37 -08:00
Mouad Debbar
be382beadb [web] Fix regression in foreground style (flutter/engine#22999) 2020-12-10 16:30:09 -08:00
David Iglesias
289570c8d8 [web] Do not reset 'cursor' in PersistedPlatformView. (flutter/engine#22977) 2020-12-10 16:03:02 -08:00
Jim Graham
8d66065e9a Allow Tile mode for blur filter and add new decal TileMode (flutter/engine#22982)
Add a new TileMode.decal enum value and allow TileMode in ImagerFilter.blur() constructor
2020-12-10 14:37:17 -08:00
Dan Field
2d52a3c87c Set SkPath::setIsVolatile based on whether the path survives at least two frames (flutter/engine#22620)
This patch defaults the volatility bit on SkPaths to false, and then flips it to true if the path survives at least two frames.
2020-12-10 13:57:23 -08:00
nturgut
3a18d39693 Fix ios voiceover (for safari >13.4) (flutter/engine#22965)
* fixes voice over for higher ios-safari versions

* change enable conditions for webkit

* adding click event for removal. adding unit tests

* run the mobile semantics enabler test on mobile browsers

* remove test method that gave different result on LUCI.(further inv. needed)
2020-12-10 11:59:44 -08:00
Ferhat
86f6fe0ef2 [web] Fix drag failure when RMB pointer up event is not received (flutter/engine#22946) 2020-12-10 10:32:04 -08:00
Ferhat
6270a627a9 [web] Optimize BitmapCanvas. Fixes overallocation of canvas elements (flutter/engine#22856) 2020-12-10 09:08:29 -08:00
Harry Terkelsen
0b6969a889 Fix platform view transforms in CanvasKit (flutter/engine#22945) 2020-12-09 16:13:02 -08:00
Mouad Debbar
e4b87fc364 [web] Cache CSS font string instead of the style object (flutter/engine#22939) 2020-12-09 16:08:03 -08:00
nturgut
6211412f85 [web] For Firefox focusing on the DOM element after blur propagates (flutter/engine#22953)
* For Firefox focusing on the DOM element after blur propagates

* modify the unit tests. remove webkit skip

* change async testing to a more common usage
2020-12-09 16:07:06 -08:00
nturgut
d928bf3645 update browser changing docs (flutter/engine#22968) 2020-12-09 15:13:55 -08:00
Mouad Debbar
809c8dbadc [web] Default styles for rich text (flutter/engine#22941) 2020-12-08 15:22:20 -08:00
Mouad Debbar
ebb7ea5f1b [web] Fix edge cases when force-breaking lines (flutter/engine#22910) 2020-12-08 13:30:41 -08:00
Yegor
2f6c8a9865 [canvaskit] fix TransformLayer.preroll (flutter/engine#22890) 2020-12-08 12:04:58 -08:00
nturgut
0bd65ac681 [web] sharding change is merged. re-enable tests (flutter/engine#22884)
* sharding change is merged. re-enable tests

* fix file name for image loading. re-block auto
2020-12-08 09:54:10 -08:00