With the update to HEAD of the Fuchsia buildtools repo, the new clang
toolchain picked up caused link-time breakage in android x86_64
libFlutter.so builds.
Sample log:
https://build.chromium.org/p/client.flutter/builders/Linux%20Engine/builds/1974/steps/build%20android_debug_x64/logs/stdio
Sample failure:
FAILED: libflutter.so libflutter.so.TOC lib.stripped/libflutter.so
../../third_party/android_tools/ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64/lib/gcc/x86_64-linux-android/4.9.x/../../../../x86_64-linux-android/bin/ld.gold: error: obj/flutter/shell/platform/android/libflutter/android_context_gl.o: unsupported reloc 42 against global symbol std::__ndk1::num_put<char, std::__ndk1::ostreambuf_iterator<char, std::__ndk1::char_traits<char> > >::id
This reverts commit 8ad42f0dae3cb1267c2b9ab99db80e4696ddbc3d.
* Roll garnet to b3ba6b6d6ab8ef658278cc43c9f839a8a8d1718e
Also includes a buildroot patch to pick up new dependency:
build/config/fuchsia/sdk.gni
This fixes a build breakage in
garnet/public/lib/fxl/strings/string_view_unittest.cc wherein a variable
'sw5' was declared but the test erroneously tested against 'sw4' from
the previous test.
* Update license script for garnet
Reflects structural changes in directories we do not depend on. This
filters out the following directories in addition to what was already
filtered:
garnet/drivers
garnet/packages
garnet/public/build/
garnet/public/rust/
* Update licenses
* Roll Fuchsia buildtools to 85907c59e97527d79bbfdfd849d8e85c24959cc5
This also updates Flutter buildroot to a6e52dbb776c45cc8c57d7143b8eb8b2e762fdfb
which disables -Wtautological-constant-compare temporarily until
https://reviews.llvm.org/D39462 lands in clang. This is in line with
Fuchsia's compiler options.
* Apply clang-format diffs
No logical changes. This applies clang-format from the latest Fuchsia
buildtools to the engine codebase.
The hermetic Xcode tooling in that repo is not yet easily usable for
Xcode 9. There are two main issues:
1. The tooling currently assumes that macOS host builds should use
Xcode 8, whereas iOS builds should use Xcode 9. Flutter builds should
use Xcode 9 in all cases.
2. The tooling currently includes a bail-out condition for iOS builds
that exits non-zero immediately (Chrome hasn't yet migrated its iOS
build to this tooling).
In the meantime, I've manually updated the bot infra with Xcode 9 and
we'll continue to use the current find_xcode.py tooling until Chrome's
new Mac/iOS tooling is ready.
* Roll dart to pick up fix for diagnostic server
* Fix runUnaryGuarded, runBinaryGuarded calls
* Revert changes to runUnaryGuarded, runBinaryGuarded as they seem to be local-only, perhaps dependent on version of analyzer
* Update third_party license hash. No changes to licenses
* Add dependency on chromium/src/build for Mac/iOS build
Preparation for migrating to mac_toolchain.py for installing/configuring
Xcode versions on the Mac build bots.
* Exclude third_party/chromium_build from licence script
It's used only at build time to fetch and install the correct Xcode
version.
This reverts commit a89f46696d4bc16d814f6697f46e9514b1193b0e.
Doing the synchronized roll of Dart into engine as well as into Fuchsia
to prevent Fuchsia breakage.
* Roll dart to pick up change where platform.dill was removed
* Fix flutter patch sdk generation
* Update license hash. No changes to license text.
* Roll dart to pick up a fix for zero-rebuild problem
* Update license hash
This reverts commit 0d2f0cb64819f7669b6134994a4ba6d7211480fa.
Attempting to roll into the framework causes analysis errors with
mock classes implementing HTTP-related classes previously in dart:io:
[error] Classes can only implement other classes. (packages/flutter_tools/test/base/net_test.dart, line 94, col 41)
[error] Classes can only implement other classes. (packages/flutter_tools/test/base/net_test.dart, line 62, col 33)
[error] Classes can only implement other classes. (packages/flutter_tools/test/base/net_test.dart, line 78, col 40)
[error] Classes can only implement other classes. (packages/flutter_tools/test/src/context.dart, line 249, col 46)
and dartdoc failures:
dartdoc:stdout: [error] Target of URI doesn't exist: 'dart:_http'. at /home/travis/build/flutter/flutter/bin/cache/pkg/sky_engine/lib/io/io.dart, line 206.
* Revert "Include _http into sky_engine libraries for analyzer (#4154)"
This reverts commit b930f107c3d6648423c42ed10b54f36a92edcbc8.
It is dependent upon the Dart roll, which breaks the engine.
* Revert "Roll dart to ade37f931e90b0fdb8fe16d6bf6f089545da55b6 (#4151)"
This reverts commit 6f1264fb3e11d25a26bc7c44246110ecb5159011.
This Dart roll breaks the engine build on Travis.
