1593 Commits

Author SHA1 Message Date
Greg Spencer
e4b574d3d3
Cupertino Dialog Changes (#17676)
This replaces abandoned PR #14824 by @ekbiker, and gives it some love.
2018-05-17 22:36:16 -07:00
Ryan Macnak
2e24351fb1
Roll engine to 4374ccc1be46f0f5e0d86b44a76cc3e1f1af8bb0. (#17669) 2018-05-17 10:53:00 -07:00
Dan Field
85cb38e71a
Fix consolidate HTTP response and add test (#17082)
* Fix consolidate response and add test

* Update AUTHORS

* ignore content-length

* fix formatting/update comment

* more commas

* Fix consolidate response and add test

* Update AUTHORS

* ignore content-length

* fix formatting/update comment

* more commas

* remove extra newline
2018-05-17 07:04:05 -04:00
Hans Muller
60272ee5bd
Restore the ListTile layout updates (#17661)
restored https://github.com/flutter/flutter/pull/17496
restored https://github.com/flutter/flutter/pull/17580
2018-05-16 12:33:07 -07:00
Sam Rawlins
1f76f7f9d2 Migrate to Mockito 3's anyNamed (#17632) 2018-05-16 10:19:05 -07:00
Jason Simmons
bb35bc3627
Add a background paint property to TextStyle (#17586)
See https://github.com/flutter/flutter/issues/11961
2018-05-16 09:19:28 -07:00
Greg Spencer
f38743593d
Add Spacer Widget (#16642)
This adds a simple spacer widget first suggested by Scott Stoll (@ScottS2017) in the abandoned PR #15802

This PR replaces that one, cleans it up, and adds a test.
2018-05-15 19:37:21 -07:00
Hans Muller
6dcb0d62c3
Change kRadialReactionRadius from 24 to 20 (#17620) 2018-05-15 15:06:03 -07:00
Hans Muller
b7fc015f0a
Revert "Updated ListTile layout" (#17612)
This reverts commit ee019c0bca05c9d2293599e88aa2da0fdb9a76ce.
2018-05-15 14:08:13 -07:00
Hans Muller
c169136eff
Revert "Fixing list tile size in the presence of a large subtitle" (#17611) 2018-05-15 11:52:34 -07:00
David Shuckerow
5159ab3513
Add the ability to limit Draggables to a single axis (#17587)
* Add a draggable axis restrictor and tests
2018-05-15 10:09:25 -07:00
Greg Spencer
a25bbc7bfc
Fixing list tile size in the presence of a large subtitle (#17580)
Take into account the subtitle height when adjusting the height of the widget. Added a test.
2018-05-14 15:51:12 -07:00
Hans Muller
ee019c0bca
Updated ListTile layout (#17496) 2018-05-14 08:18:17 -07:00
Jason Simmons
2f122f7d2a
Add a golden image test for centered text (#17517) 2018-05-11 12:17:18 -07:00
xster
e42c50cf20
Post libtxt/post iOS 11 fidelity fine tuning (#17366) 2018-05-10 17:35:18 -07:00
Greg Spencer
c2c64a5a4c
Add onChangeStart and onChangeEnd to slider. (#17298)
This fixes #17169 by adding onChangeStart and onChangeEnd to the slider. These will be called when the user starts a change, and when they end a change, regardless of whether that change is a tap or a drag.

These differ from onChanged, in that they only report when the user starts and ends an interaction, not at every slight change.
2018-05-10 17:29:43 -07:00
Greg Spencer
a365c41cb5
Fix handling of null body2 text style for chip and slider (#17311)
Before this change, if you specified a non-null textTheme, but the theme you specified didn't have a body2 defined, then creating a ChipTheme would assert (which means creating a ThemeData would fail).

This adds handling for this corner case to default to reasonable values in that case. The slider had the same problem, but for accentTextTheme, so I fixed that too.

While I had the patient open, Hans and I noticed that TextTheme.merge wasn't doing the right thing in the case where some members were null either, so I fixed that, and added some examples, since merge/copyWith are common operations that are not always well understood.

Fixes #17251
2018-05-10 14:37:14 -07:00
Zachary Anderson
bb4afb0472 Roll engine to 37e20af6a324cd4cfa1324b8c644712ef8224359 (#17481) 2018-05-10 14:36:54 -07:00
Ian Hickson
ca94bfdfc6 Factor our common Paint-building code used with BoxShadow (#17363) 2018-05-09 22:42:38 -07:00
Hans Muller
a02568b3ca
Added MediaQuery.textScaleFactorOf() (#17450) 2018-05-09 17:08:22 -07:00
Michael Goderbauer
7809651c74
Put cursor at end of field if textfield is focused (#17367) 2018-05-09 16:05:47 -07:00
Michael Goderbauer
dcb47f62ec
A11y fixes and tests for PopUpMenu (#17446) 2018-05-09 16:05:20 -07:00
Anatoly Pulyaevskiy
50a1d91ff3 Allow customization of TextSpan in EditableText (#16909)
* Allow customization of TextSpan in EditableText

* Addressed PR comments

* Added test with custom-styled EditableText subclass

* More code style fixes
2018-05-08 17:40:54 -07:00
Hans Muller
f8d0d877f5
Textfield InputDecorator height can grow to accomodate error text (#17292) 2018-05-04 13:26:46 -07:00
Michael Goderbauer
7984f6e043
Implicit a11y scrolling for iOS (and caching in Viewports) (#17021) 2018-05-04 10:48:06 -07:00
Chris Bracken
322eb81a79
Revert longPress/Tap and Gallery changes (#17269)
Revert longPress/Tap and Gallery changes
2018-05-03 16:51:45 -07:00
Jonah Williams
50bd39a913
Add longPress/Tap event to SemanticService (#16945) 2018-05-03 11:04:43 -07:00
Konstantin Scheglov
9fe53b0d2b
Export @required from src/widgets/framework.dart (#17208) 2018-05-03 08:50:40 -07:00
Todd Volkert
65079ad5f2
Add Flutter-repo-specific golden comparator (#17205)
In order to avoid checking binaries into flutter/flutter,
this comparator can be used to retrieve golden files from
a sibling flutter/goldens repository.

https://github.com/flutter/flutter/issues/16859
2018-05-03 07:39:41 -07:00
xster
4e6045883c
Fix front layer can be tapped through bug on gallery (#17181) 2018-05-02 14:31:59 -07:00
Adrian Secord
1680e55c02 Updated links to Material design guidelines to use short links. (#17077) 2018-04-30 20:29:46 -07:00
Todd Volkert
b2c67e88d4
Make Layer.toImage() accept bounds rather than size (#17129)
It allows callers to account for things like shadows that paint
outside the bounds of the widget.

https://github.com/flutter/flutter/issues/16859
2018-04-30 15:26:17 -07:00
Ian Hickson
ca35ddd439
Add some Transform constructors (#16553)
See https://github.com/flutter/flutter/pull/15383
2018-04-26 16:06:17 -07:00
Hans Muller
e62a6451f7
Fixed (#17010) 2018-04-26 10:29:44 -07:00
Yegor
a7d7652a5f
Set text direction in semantics along with Directionality (#16907)
* Set text direction in semantics along with Directionality

* update tests for the extra SemanticsNode
2018-04-24 18:29:26 -07:00
Yegor
d354096299
a11y traversal: sort locally; use new sorting algorithm (#16253)
New a11y traversal:

- sort direct sibling SemanticsNodes only
- use new sorting algorithm
- implement RTL
- test semantics in traversal order by default
- add AppBar traversal test
- breaking: remove nextNodeId/previousNodeId from the framework
- breaking: remove DebugSemanticsDumpOrder.geometricOrder
2018-04-23 14:23:49 -07:00
Hans Muller
d3d4976f63
InputDecorator input and hint widgets have the same width (#16894) 2018-04-23 13:53:15 -07:00
debuggerx01
ff58db4ac3 Fix hue to 0.0 when red == green == blue. (#16872)
When passing a Color object with same R/G/B code ( e.g. [new Color.fromRGBO(100, 100, 100, 1.0)] ) to HSVColor.fromColor(Color color) , the hue in return will be NaN .
2018-04-23 13:47:47 -07:00
Emmanuel Garcia
d43b4d0ad8 Fix #16247: SizeTransition clamps negative size factors (#16579)
As pointed out in the bug, the issue is fixed by just clamping sizeFactor.value.

Fixes #16247
2018-04-23 13:47:07 -07:00
Greg Spencer
a043ac41f6
Adding an API for capturing an image of a RenderRepaintBoundary. (#16758)
This adds a toImage function to RenderRepaintBoundary that returns an uncompressed raw image of the RenderRepaintBoundary and its children. A device pixel ratio different from the physical ratio may be specified for the captured image. A value of 1.0 will give an image in logical pixels.
2018-04-23 12:28:17 -07:00
Greg Spencer
037df5f2ff
Remove unneeded assert in UnconstrainedBox (#16778)
This addresses #16593 by removing the unneeded assert in the setter for constrainedAxis. Null was meant to be allowed there.

This replaces #16599 and fixes #16593, reported by @maksimr
2018-04-23 12:27:33 -07:00
Todd Volkert
a742b11a50
Roll engine to cb3376c5dedb71cec7a88b8a8904acc5dd6c6ba1 (#16841)
This contains the following commit:

flutter/engine@cb3376c Support different encodings in Image.toByteData() (#16635)
2018-04-21 16:10:39 -07:00
xster
90ca815242
Make bottom app bar safe area friendly (#16820) 2018-04-20 17:14:03 -07:00
Michael Goderbauer
2eb290e718
Wire up SemanticsFlag.isHidden (#16772) 2018-04-20 17:10:40 -07:00
Jonah Williams
e7cd5d3867
Throw FlutterError when calling setState in State constructor (#16759)
* log error when calling setState in constructor
2018-04-19 18:00:38 -07:00
Jonah Williams
034a663d33
Semantics object support for edge triggered semantics (#16081)
Semantics object support for edge triggered semantics
2018-04-19 17:59:19 -07:00
Greg Spencer
b83eb465fd
Updating the Chip demo in the Gallery to include all the new types of chips. (#16522)
This chip demo is more interactive than the last one, trying to exercise all of the types of chips for a demo that lets you select different types of "chips" (like tortilla, wood, micro, etc.), and then filter them and select an action on them.
2018-04-19 16:43:22 -07:00
xster
133c98a85b
Fine-tune iOS's scroll start feel (#16721)
* Fine-tune iOS's scroll start feel

* remove negations in doc

* Our own dart-side gesture arena also contributes to the 'jerk'. Make sure that snap is accounted as well.

* Added more code comments from review.
2018-04-19 16:17:44 -07:00
Michael Goderbauer
1ba99b94f2
SliverList works with changing children that are keyed (#16724)
Fixes #14590.
2018-04-19 16:05:41 -07:00
Greg Spencer
0b389fc92e
Change CircleAvatar to use BoxFit.cover for images (#16649)
This is a PR giving some love to the abandoned PR #16263 by @harrisonturton

I've added a test, and formatted it to be readable.

Currently the CircleAvatar does not set a fit property on the DecorationImage it uses to paint images. This causes non-square images to not fully cover the circle, which looks pretty bad. This PR sets it to BoxFix.cover.

Fixes #13478.
2018-04-19 15:52:40 -07:00