This caused us to lose our gn check certification. :(
Turns out gn check was just ignoring all the header
paths it didn't understand and so gn check passing
for sky wasn't meaning much. I tried to straighten
out some of the mess in this CL, but its going to take
several more rounds of massaging before gn check
passes again. On the bright side (almost) all of
our headers are absolute now. Turns out my script
(attached to the bug) didn't notice ../ includes
but I'll fix that in the next patch.
R=abarth@chromium.org
BUG=435361
Review URL: https://codereview.chromium.org/746023002
ScrollableArea only has one subclass now. Make all it's virtual
methods be pure virtual and delete any methods that
RenderLayerScrollableArea overrides.
Eventually we should probably merge the two classes into one,
but ScrollableArea is in platform and RenderLayerScrollableArea
is in core/rendering, so it's non-trivial figuring out what the
end result should look like. Hopefully it will become more clear
as we delete more of the scrolling code.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/711483003
We never paint scroll corners. The only thing we need them
for is so that the vertical and horizontal scrollbars don't
overlap each other. So, that's the only place left that
still computes a scroll corner rect.
We don't support resizers. Remove the code for them as well
as the CSS resize property.
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/689283003
No change in behavior. Just deleting dead code.
Also removes ScrollAnimatorNone since it's unused.
We'll need to bring some of this back, but we'll
do that when we get rid of composited scrolling.
R=esprehn@chromium.org
Review URL: https://codereview.chromium.org/682363002
FrameView doesn't really need to know about the child widgets,
which are just Scrollbars now.
I also deleted some dead code from Widget and removed FrameWidget
since we don't need that abstraction now.
R=ojan@chromium.org
Review URL: https://codereview.chromium.org/685593005
We only allow overflow scrolling. The frame isn't special.
This is a first step in making that happen. There's a lot of
code to remove after this patch, but this gets rid of
ScrollView and a bunch of frame-level scrolling code.
Had to add in a FrameWidget class so that Scrollbar.cpp had
a way of getting to FrameView::removeChild without pulling
a core class into platform. This might go away when we rip
out the Widget tree if we made it so that FrameView didn't
keep a list of Scrollbar instances.
Modified scrollbar.html to use overflow scrolling instead of
frame level scrolling. Once we get rid of the split between
Document and documentElement, we'll be able to make the root
element in the page scrollable as well (i.e. any child of the
Document).
R=abarth@chromium.org
Review URL: https://codereview.chromium.org/646273006
