1357 Commits

Author SHA1 Message Date
Ian Hickson
e48efdca15 Merge pull request #982 from Hixie/fewer-bit-updates
Less tree walking for compositing bits updates.
2015-12-21 11:33:11 -08:00
Ian Hickson
543a7df0f6 Update RenderPositionedBox documentation. 2015-12-19 21:07:36 -08:00
krisgiesing
b53ab6485d Merge pull request #995 from krisgiesing/minor_cleanup
Remove redundant typedef
2015-12-18 13:48:02 -08:00
Kris Giesing
3b3315f46e Remove redundant typedef 2015-12-18 13:40:59 -08:00
Hixie
ab01c7bf73 Less tree walking for compositing bits updates.
Use the same technique for updating compositing bits as layout and
painting. This avoids walking the entire rendering tree when all you
need to update is a small subtree.
2015-12-17 13:55:53 -08:00
Hans Muller
65dca5b578 Correct the TabBarView swipe selection change animation
The TabBarSelection change animation needs to start where the fling's drag gesture ended rather than from zero.  The intial vlaue of progress for the TabBarSelection's performance is now converted from the range used during an interactive drag, to the range used when animating from the previously selected tab to the new one.

TabBarSelection now requires a maxIndex parameter.
2015-12-16 15:30:45 -08:00
Ian Hickson
1327be6908 Merge pull request #968 from Hixie/scaffold-without-navigator
Make Navigator.canPop handle the no-navigator case
2015-12-16 14:58:00 -08:00
Hixie
a0d6572977 Make Navigator.canPop handle the no-navigator case
Scaffold calls this to see if it should show a back arrow when there's
no drawer. With this change, everything continues to work.

Fixes styled_text and probably others.
2015-12-16 14:34:24 -08:00
Hixie
b5e7e1ce7a Close some sentences. (rendering dartdocs) 2015-12-16 13:30:33 -08:00
Jason Simmons
e880bd92fb Support application lifecycle state change events in the framework 2015-12-16 12:38:40 -08:00
Ian Hickson
7dad780f13 Merge pull request #946 from Hixie/pointerExceptions
Catch exceptions in pointer handling
2015-12-16 09:42:15 -08:00
Ian Hickson
7ea5879e88 Merge pull request #920 from Hixie/renderView-non-null
Be clearer about whether renderView can be null.
2015-12-16 09:42:04 -08:00
Ian Hickson
1d39db6959 Merge pull request #950 from Hixie/dropdown-asserts
Aggressively try to catch misuse of DropDownButton
2015-12-15 21:54:17 -08:00
Hixie
0c6e3416d8 Canceling a dropdown menu selects null value
Previously we didn't distinguish between canceling the menu (which
popped the route with no return value, i.e. null) and explicitly
selecting an item whose value is null (pop with value null). Both fired
onChange(null).

Now we box the return value so we can distinguish the two cases.

I would have preferred to just disallow "null" as a value but it turns
out people like being able to use "null" as a value for much the same
reason we do, and it seems best for us to pay the complexity cost of
boxing than having everyone else do it. :-)
2015-12-15 16:52:58 -08:00
Hixie
a87351ad88 Aggressively try to catch misuse of DropDownButton
Fixes https://github.com/flutter/flutter/issues/948.
I hope.
2015-12-15 16:30:04 -08:00
Hixie
4e23ecd668 Catch exceptions in pointer handling
If we don't catch these exceptions, we get confused about what's going
on with the pointers, and the app basically stops working.
2015-12-15 15:24:56 -08:00
Hans Muller
bcbfdf8f59 Tabs should only scroll on a horizontal TabBarView fling 2015-12-15 14:38:30 -08:00
Hixie
6047c6da37 Be clearer about whether renderView can be null. 2015-12-15 13:49:04 -08:00
Hixie
768268ad3f Workaround to re-enable test
This is a workaround for:
   https://github.com/dart-lang/sdk/issues/25246
2015-12-15 13:38:45 -08:00
Hans Muller
0d983cd87a CustomMultiChildLayout and CustomOneChildLayout now use their delegate's shouldRelayout() method instead of a "token" to decide if layout is needed.
MultiChildLayoutDelegate and OnChildLayoutDelegate are now expected to be stateless, i.e. they'll typically be built each time their custom layout widget is built. If the identical layout delegate is provided to a new custom layout, layout will not happen.

Revised the bottom sheet implementation per the new custom layout classes. Removed a SizeObserver.

Fixes #899
2015-12-15 12:37:42 -08:00
Devon Carew
d9cab80c8a Merge pull request #939 from devoncarew/update_service_extensions
remove todos for service extension params
2015-12-15 11:57:47 -08:00
Kris Giesing
54cec3f13f Export dependent class from newton package 2015-12-15 11:09:33 -08:00
Devon Carew
4226b6008e remove todos for service extension params 2015-12-15 11:08:42 -08:00
Devon Carew
7d651af4f5 Merge pull request #911 from devoncarew/service_extensions
expose flutter debug functionality using VM service extensions
2015-12-15 10:53:50 -08:00
Devon Carew
cde14ab649 more checked mode guards; more types; fewer todos 2015-12-14 19:04:34 -08:00
Devon Carew
211aeabb87 review comments 2015-12-14 12:51:39 -08:00
Hans Muller
7ebb6412a9 Only set tolerance if simulation is non-null 2015-12-14 12:27:50 -08:00
Hans Muller
80c5e6a3c2 Support TabBarView swipe
Swiping left or right in a TabBarView now changes the selected tab in the way it's supposed to.

Currently swipe gestures that start while the selection change is underway are ignored. Will fix that in a separate change.
2015-12-14 11:23:12 -08:00
Devon Carew
ce6b330a80 expose flutter debug functionality using VM service extensions 2015-12-14 10:22:20 -08:00
Devon Carew
9ad9422007 Merge pull request #907 from devoncarew/mini_fab
support mini fabs
2015-12-14 09:52:21 -08:00
Devon Carew
a858222839 support mini fabs 2015-12-14 09:46:06 -08:00
Ian Hickson
d29970df8b Rename Pointerer to Gesturer. 2015-12-14 07:54:54 -08:00
Ian Hickson
ade93651ac Refactor bindings. 2015-12-13 23:34:41 -08:00
Ian Hickson
9487197502 Merge pull request #895 from Hixie/overlays
Avoid rebuilding entire app when an overlay needs updating
2015-12-11 21:55:11 -08:00
Ian Hickson
e78d6cbc6b Merge pull request #857 from Hixie/hashCodes
Use hashValues instead of hard-coded hashCode getters
2015-12-11 21:46:32 -08:00
Ian Hickson
76319df5df Avoid rebuilding entire app when an overlay needs updating 2015-12-11 21:35:10 -08:00
Ian Hickson
cb39108146 Minor fixes in comments and style. 2015-12-11 20:25:08 -08:00
Ian Hickson
d1364643db applyPaintTransform() improvements
Previously, applyPaintTransform() had to know how it was positioned in
its parent, even though that's really the parent's responsibility.

Now, applyPaintTransform() is given a child and applies the transform
that it would give the child during paint.

This makes it possible for applyPaintTransform() to work across
coordinate system boundaries (e.g. box to sector, or view to box --
previously, view to box only worked because we explicitly skipped that
step -- since view doesn't actually apply a transform, it doesn't
really matter).
2015-12-10 22:22:00 -08:00
Ian Hickson
5996d381a7 Check for cycles in our various tree structures. 2015-12-10 19:30:46 -08:00
Adam Barth
2a2784e822 Merge pull request #882 from abarth/image_docs
Add dartdoc for image classes
2015-12-10 18:52:03 -08:00
Adam Barth
40dda1ed4b Add dartdoc for image classes
- Adds dartdoc for all the `of` functions.
 - Renames Image to RawImage. This widget is rarely used and shouldn't take up
   such a nice global name.

Fixes #361
2015-12-10 18:34:56 -08:00
Florian Loitsch
e8367f5346 Merge pull request #881 from floitschG/remove_scheduler_from_animation
Remove reference to scheduler in animation.
2015-12-10 16:27:39 -08:00
Florian Loitsch
86dbf9431f Remove reference to scheduler in animation. 2015-12-10 15:38:39 -08:00
Adam Barth
87e6a5cc12 Add more dartdoc for basic widgets 2015-12-10 14:58:57 -08:00
Hans Muller
54f2d4cb94 Merge pull request #878 from HansMuller/pageable_list_tabs
TabBarView is-a PageableList, doesn't need itemExtent

Base TabBarView on PageableList so that itemExtent and its SizeObserver aren't needed.

TabBarView scrolling is still TBD.
2015-12-10 12:34:32 -08:00
Adam Barth
ffad464c96 Merge pull request #877 from abarth/better_asserts
Improve asserts when performLayout missing
2015-12-10 12:23:36 -08:00
Hans Muller
55f6593017 tabs scroll duration is 300ms 2015-12-10 12:20:29 -08:00
Hans Muller
9651db22df TabBarView is-a PageableList, doesn't need itemExtent 2015-12-10 12:20:29 -08:00
Adam Barth
2edb6807b8 Improve asserts when performLayout missing
Fixes #566
2015-12-10 12:15:07 -08:00
Ian Hickson
335f583564 Merge pull request #866 from Hixie/debugDoingPaint
Remove debugDoingPaint setter.
2015-12-10 11:17:09 -08:00