5767 Commits

Author SHA1 Message Date
Dan Field
1602be6ab6
Live image cache (#50318)
Track images available on screen
2020-02-14 15:03:05 -08:00
creativecreatorormaybenot
08c835913e
Expose showButtonMenu of PopupMenuButtonState (#50670) 2020-02-14 14:51:19 -08:00
Greg Spencer
18984101d9
Fix the spelling of manditory (#50746) 2020-02-14 08:43:02 -08:00
Taufiq Rahman
d1185337cc
Feature: Allow minLines in SelectableText (#50750)
* Feature: allow minLines in SelectableText
2020-02-14 06:38:13 -08:00
Yegor
b34046903b
Fix stack trace parsing on non-debug builds; add e2e tests (#50652)
* Fix stack trace parsing on non-debug builds; add e2e tests
2020-02-13 18:34:08 -08:00
Dan Field
766bd70598
Image tracing (#50648) 2020-02-13 14:04:02 -08:00
Gary Qian
8769f94cf6
Add textHeightBehavior and textWidthBasis to AnimatedDefaultTextStyle (#50748) 2020-02-13 16:52:31 -05:00
Shi-Hao Hong
1f3d423f92
Step 1: SnackBarBehavior.floating offset fix - Soft breaking change (#50597)
* Adds an opt-in flag to fix floating snackbar's offset when no floating action button is present. This flag will be removed once the migration for the fix is complete.

Co-authored-by: filaps <filip1997.28@mail.ru>
2020-02-13 10:04:31 -08:00
Shi-Hao Hong
a833effbc7
Reland Alert dialog overflow spacing (#50675)
* Add ButtonBar.overflowButtonSpacing

* Add AlertDialog overflow button spacing functionality
2020-02-13 10:00:15 -08:00
Greg Spencer
232063e5c3
Changed ThemeData DiagnosticProperties to DiagnosticLevel.debug (#50589) 2020-02-13 09:53:02 -08:00
Greg Spencer
d57d493507
Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672)
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.

The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.

- Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
2020-02-12 16:22:01 -08:00
Greg Spencer
b2a7ff36a9
Fix lack of ancestor notification when a focus node is unfocus… (#50319)
This fixes a problem when unfocusing focus nodes where the ancestor focus nodes and scopes don't receive notification that a child was unfocused.

Fixes #43497
2020-02-12 16:20:08 -08:00
Jenn Magder
24017e761e
Revert "AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)" (#50674) 2020-02-12 15:20:13 -08:00
Michel Feinstein
508c35940b
Added linking to viewInsets and viewPadding in MediaQuery padding docs (#50659) 2020-02-12 14:58:05 -08:00
Shi-Hao Hong
23d61a81dc
AlertDialog.actionsOverflowButtonSpacing and ButtonBar.overflowButtonSpacing (#50609)
* Add ButtonBar.overflowButtonSpacing

* Add AlertDialog overflow button spacing functionality
2020-02-12 14:53:59 -08:00
chunhtai
7168421e9f
fixes route name annoucement in navigator (#50495) 2020-02-12 14:53:05 -08:00
Jacob Richman
7820641a05
Fix Diagnostics subclasses that had the wrong default value for the named parameter. (#50645) 2020-02-12 14:52:50 -08:00
Greg Spencer
c132c0faa9
Revert "Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50660)
This reverts commit 8ef5e2f046ed18ca32827e1a715ca5e405c646ac because it breaks some semantics tests.
2020-02-12 13:37:36 -08:00
Josh Burton
2b16202ea2
Adds shadowColor property to the Card widget (#47273) 2020-02-12 13:23:02 -08:00
Arthur Denner
d3e1e29375
SimpleDialogOption: support custom padding (#50035) 2020-02-12 08:58:03 -08:00
Anthony Mansour
4c1045c0f8
Fixed preferredSize getter in TabBar (#41299) 2020-02-12 08:53:02 -08:00
Gary Qian
cad08149ca
Remove invalid assert for TextHeightBehavior (#50603) 2020-02-11 19:08:05 -05:00
Jonah Williams
953df281ea
Revert "Revert "Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480)" (#50502)" (#50512)
This reverts commit 9bc0e6a991cbbe2bfe8328eacb62f6320b8d6812.
2020-02-11 16:05:53 -08:00
Jason Simmons
324e20de09
Update TextStyle.hashCode to handle list fields (#50520) 2020-02-11 14:38:03 -08:00
LongCatIsLooong
48d5fcabbd
evict _SliverFractionalPadding cache on constraint change (#50523) 2020-02-11 12:52:53 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Lamonte
fd1062debd
Exposed optional scrollController property in ReorderableListView (#49148) 2020-02-11 10:58:02 -08:00
Greg Spencer
8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00
Gary Qian
f769bcc5c4
Reland "Track lastKnownRemoteTextEditingValue separately from received data" (#50307) 2020-02-10 20:55:48 -05:00
Mouad Debbar
bf551a31fe
EditableText's autofocus:true should not crash (#50372) 2020-02-10 15:58:02 -08:00
Shi-Hao Hong
67826bdce5
Revert "Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616)" (#50516)
This reverts commit 801a6a7e5e2c16525d3c2856a43ed34b5ff536a3.
2020-02-10 14:59:32 -08:00
Greg Spencer
18f8002ec8
Make FocusManager a ChangeNotifier that notifies when the prim… (#50392)
This makes FocusManager a ChangeNotifier that notifies when the primaryFocus changes so that an app can track the current focus.

Fixes #50501
2020-02-10 14:33:31 -08:00
Michael Goderbauer
6d87337f51
Remove some obsolete // ignore: (#50481) 2020-02-10 14:08:09 -08:00
Jonah Williams
9bc0e6a991
Revert "Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480)" (#50502)
This reverts commit 902064277265daced4a79bcdaae157a310cc13c8.
2020-02-10 13:26:59 -08:00
Per Classon
5f4658973b
Update RefreshIndicator documentation to clarify the need for the child for be scrollable (#50345) 2020-02-10 10:08:02 -08:00
liyuqian
b277534026
Assert cache hints are not set for null painters (#49771) 2020-02-10 10:03:03 -08:00
Greg Spencer
9fb781a54a
Update samples to work with Dartpad, and convert all that make… (#50377)
This PR modifies the existing API docs samples to use DartPad so that all of the samples are now interactive apps on the API docs site.

It also removes the restriction for the max width of the description area so that the dartpad region can expand horizontally.

I updated the first paragraph on the API docs to indicate that Flutter is more than just mobile now (same text as the README.md at the top level).

I modified a few of the examples so that they looked nicer, and fit better on the page.

I added the sample description text above each DartPad instance, since that often defines the context of the example.

I removed animations and images when they were redundant with the sample content. There were a few that made sense to keep, so I did.
2020-02-10 10:00:20 -08:00
Jonah Williams
2a6bc617b8
[framework] minimize performance effect of stateless/stateful swap (#50394) 2020-02-10 10:00:11 -08:00
Prerak Mann
9020642772
Reduced code duplication in ink_splash.dart, ink_ripple.dart (#49480) 2020-02-10 09:58:04 -08:00
Shi-Hao Hong
6dc3bfaa98
Fix Dropdown 'itemHeights' was called on null crash (#50366) 2020-02-07 18:28:02 -08:00
Michael Goderbauer
95d6ef741c
Nested TickerMode cannot turn tickers back on (#50355) 2020-02-07 18:23:02 -08:00
filaps
801a6a7e5e
Fix SnackBar clipping when it is floating due to FloatingActionButton positioning (#47616) 2020-02-07 16:08:02 -08:00
jimshepherd
92a335e465
Use state value in DropdownButtonFieldForm (#37145)
The current implementation of DropdownButtonFormField does not pass the initial value to _DropdownButtonFormFieldState. As a result changes made through the child DropdownButton are not made to the FormFieldState and the widget is not updated unless a onChanged function is provided to the DropdownButtomFormField constructor.

This change modifies DropdownButtonFormField to behave more consistently with other FormField widgets in how the Form state is handled.
2020-02-07 15:50:37 -08:00
Tong Mu
324a2168cd
Change definition of offset to object (#50157) 2020-02-07 13:08:02 -08:00
Dan Field
2627122324
Throw when trying to load an empty file (#50325) 2020-02-07 10:08:02 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Dan Field
8735ab1e35
Make onImage re-entrant safe (#50316) 2020-02-06 23:36:59 -08:00
David Shuckerow
2032760509
Explain how the scroll controller behaves under tests (#50129) 2020-02-06 15:58:02 -08:00
YizhePKU
f8b286dce0
Updated documentation for CupertinoPicker (#50264) 2020-02-06 15:53:07 -08:00
Dan Field
d94ff4bdbe
Fix LRUness of ScrollAwareImageProvider (#50242) 2020-02-06 13:19:46 -08:00