DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,372 Commits 882 Branches 1,069 Tags
Commit Graph

24545 Commits

Author SHA1 Message Date
Jason Simmons
e40bd4d3dd [Impeller] Fix leak of framebuffers used in GLES MSAA rendering (flutter/engine#47362) 2023-10-27 14:37:29 +00:00
auto-submit[bot]
fa847e083e Reverts "Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions)" (flutter/engine#47380) 
Reverts flutter/engine#47357
Initiated by: zanderso
This change reverts the following previous change:
Original Description:

Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7

2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-65.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-64.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-63.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-62.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-61.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-59.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev
2023-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,aam@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 14:13:17 +00:00
skia-flutter-autoroll
f433c373d6 Roll Skia from 0122c0e18d26 to fe9959acc5e0 (1 revision) (flutter/engine#47379) 
https://skia.googlesource.com/skia.git/+log/0122c0e18d26..fe9959acc5e0

2023-10-27 jvanverth@google.com [graphite] Add per-edge AA quad shaders.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 14:05:32 +00:00
skia-flutter-autoroll
34f1b9cb0e Roll Fuchsia Linux SDK from 37VxdxlPfdkek7mwC... to gPQSfYJVLOgXjxQce... (flutter/engine#47375) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 09:58:05 +00:00
skia-flutter-autoroll
24822888df Roll Skia from fbdd7d97b26e to fe61b3467547 (1 revision) (flutter/engine#47370) 
https://skia.googlesource.com/skia.git/+log/fbdd7d97b26e..fe61b3467547

2023-10-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 50a46e8932cc to ac82f8a7da91 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 05:26:23 +00:00
Jim Graham
cc929700b6 [Impeller] Add FilterContents::GetSourceCoverage to enable filtered saveLayer clipping. (flutter/engine#47183) 
The new method allows a caller to ask for the coverage of the input pixels required to produce an output that spans a given area. This allows the code to clip a saveLayer that has an image filter applied to it.
 2023-10-27 01:16:23 +00:00
John McCutchan
632d65292d Don't re-initialize the default RenderSurface when returning from hybrid composition mode (flutter/engine#47358) 
When we enter hybrid composition mode we 'pause' the default RenderSurface (implemented by SurfaceView or TextureView) and swap to an ImageReader based RenderSurface.

When we return from hybrid composition mode we recreate and re-initialize the real RenderSurface as if it was being used for the first time.

This broke Platform Views in an internal app b/306122497 because we would incorrectly tell the texture to attach when it was never detached.

This CL changes the protocol so that when we return from hybrid composition mode we only swap the RenderSurface and do not re-create it. This avoids doing a bunch of unnecessary work and fixes the logic error of re-attaching textures that were never detached.

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-27 00:33:23 +00:00
skia-flutter-autoroll
9572116d73 Manual roll Dart SDK from 360370ff93b0 to 18678a3eddb7 (9 revisions) (flutter/engine#47357) 
Manual roll requested by aam@google.com

https://dart.googlesource.com/sdk.git/+log/360370ff93b0..18678a3eddb7

2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-65.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-64.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-63.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-62.0.dev
2023-10-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-61.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-59.0.dev
2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev
2023-10-24 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-57.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,aam@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-27 00:12:58 +00:00
skia-flutter-autoroll
2396d6ef3a Roll Skia from 93a0ad4d7ca6 to bc8ca57868d2 (2 revisions) (flutter/engine#47359) 
https://skia.googlesource.com/skia.git/+log/93a0ad4d7ca6..bc8ca57868d2

2023-10-26 rmistry@google.com Change espn page set and recapture archives
2023-10-26 drott@chromium.org [Fontations] Add a suffix to font names to identify when backend is used

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 23:52:54 +00:00
Tong Mu
a98c3dc263 Skip invalid renders in Dart (flutter/engine#47323) 
With this PR, invalid renders are skipped in Dart in both release build and debug build.

Part of https://github.com/flutter/flutter/issues/137073 and part of relanding https://github.com/flutter/engine/pull/45555.

Unit tests will be relanded in a following PR once this PR is confirmed performance-safe.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 22:09:10 +00:00
Chris Bracken
987dac0ae1 [macOS] Reuse NSWindow instance across unit tests (flutter/engine#47350) 
Adds a gtest test fixture mixin and convenience class that instantiates an NSAutoreleasePool at the beginning of each test and flushes it at the end; this allows Objective-C tests using ARC to free  allocations at the end of each test.

Adds a subclass for the macOS accessibility bridge tests that instantiates and re-uses an NSWindow* across any tests that use it. This is because instantiating, closing, and immediately collecting an NSWindow results in a crash.

Prior to this patch, tests started failing (on my machine) around the 855th iteration, and issued the following warning on the 101st iteration:

```
2023-10-26 13:02:45.390829-0700 flutter_desktop_darwin_unittests[40837:1509026] [Window] WARNING: NSWindow has detected an excessive live window count of 101. Window 0x1423 of class 'NSWindow' created after passing the threshold of 100. This window is not necessarily the cause, and this warning will only be shown once per window class. (
  0   AppKit                              0x0000000192820d28 -[NSWindow _setWindowNumber:] + 684
  1   AppKit                              0x00000001933050e4 _NXCreateWindow + 284
  2   AppKit                              0x0000000192901ae0 -[NSWindow _commonAwake] + 672
  3   AppKit                              0x000000019281ff00 -[NSWindow _commonInitFrame:styleMask:backing:defer:] + 972
  4   AppKit                              0x000000019281f798 -[NSWindow _initContent:styleMask:backing:defer:contentView:] + 796
  5   AppKit                              0x000000019281f470 -[NSWindow initWithContentRect:styleMask:backing:defer:] + 48
  6   flutter_desktop_darwin_unittests    0x0000000100001e3c _ZN7flutter7testing89AccessibilityBridgeMacTest_SendsAccessibilityCreateNotificationToWindowOfFlutterView_Test8TestBodyEv + 328
```

See: http://www.openradar.me/FB13291861

Issue: https://github.com/flutter/flutter/issues/104789
Issue: https://github.com/flutter/flutter/issues/127441
Issue: https://github.com/flutter/flutter/issues/124840

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 21:17:01 +00:00
skia-flutter-autoroll
269225124c Roll Skia from fb72136c9325 to 93a0ad4d7ca6 (1 revision) (flutter/engine#47352) 
https://skia.googlesource.com/skia.git/+log/fb72136c9325..93a0ad4d7ca6

2023-10-26 fmalita@chromium.org Add SK_API to SkVertices::Builder

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 21:15:06 +00:00
skia-flutter-autoroll
47cebcc239 Roll Fuchsia Linux SDK from akT2HxdLNPWSG-gbV... to 37VxdxlPfdkek7mwC... (flutter/engine#47351) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 21:13:07 +00:00
John O'Neil
58bb0adf2c Fix for undefined uint8_t seen on Clang-15+GCC13 (flutter/engine#47288) 
This PR is to address an issue we're seeing compiling flutter+impeller in certain configurations. Specifically:

1. Compiling with `clang-15`
2. using the GCC 13 backend to provide headers and cstdlib.

Via the `clang-15` version flag:

```
clang-15 -v
Debian clang version 15.0.7
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/11
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/12
Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/13
Selected GCC installation: /usr/bin/../lib/gcc/x86_64-linux-gnu/13
Candidate multilib: .;@m64
Candidate multilib: 32;@m32
Candidate multilib: x32;@mx32
Selected multilib: .;@m64
```

We were building using the gcc 12 backend for a while, but picked up an update that forced us to 13, and then saw this issue.

The issue is seen as `uint8_t` being undefined as in the following partial messages:

```
hex_codec.cc:18:5: error: unknown type name 'uint8_t'
base32.cc:29:32: error: unknown type name 'uint8_t'
```

I'm not sure this is the cleanest fix, or if it might be better handled by adding some compile time switches, but I wanted to provide this to start conversation.

I'm also hoping to get a better idea of tests run against a PR. If there's any I should run manually we can discuss that here.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 21:10:04 +00:00
auto-submit[bot]
24debb363e Reverts "[Impeller] Disable layer tree screenshots." (flutter/engine#47356) 
Reverts flutter/engine#46171
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
The "rasterizer screenshot" VM service API uses the Skia software backend, even when running with impeller. At best, this leads to confusing half working screenshots that are missing images.

See https://github.com/flutter/flutter/issues/135052

We should disable this functionality when running with impeller. Perhaps this could be reworked to use picture toImage instead of the offscreen so that it uses the "real" backend regardless of the platform it is running on.

Fixes https://github.com/flutter/flutter/issues/135052
 2023-10-26 20:34:17 +00:00
Loïc Sharma
f06b89215e [Windows] Refactor high contrast mode detection (flutter/engine#47314) 
This refactors how high contrast is implemented on Windows:

1. Added a test to verify accessibility features are updated when a view is created. This prevents staleness issues as the Windows embedder isn't notified of accessibility changes while in headless mode.
1. Moved high contrast mode detection to `WindowsProcTable` from `FlutterWindow` to remove engine to view to window plumbing.
1. `FlutterWindow` and `FlutterWindowsEngine` now share their `WindowsProcTable` (which is used for mocking and polyfilling win32 APIs) to reduce redundant dynamic loading.

This pull request contains no functional changes.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 20:22:15 +00:00
Jonah Williams
912c891a1d [Impeller] Disable layer tree screenshots. (flutter/engine#46171) 
The "rasterizer screenshot" VM service API uses the Skia software backend, even when running with impeller. At best, this leads to confusing half working screenshots that are missing images.

See https://github.com/flutter/flutter/issues/135052

We should disable this functionality when running with impeller. Perhaps this could be reworked to use picture toImage instead of the offscreen so that it uses the "real" backend regardless of the platform it is running on.

Fixes https://github.com/flutter/flutter/issues/135052
 2023-10-26 20:16:09 +00:00
Jason Simmons
6ef260d4b5 [Impeller] Fix the transform and geometry criteria for an optimization in TiledTextureContents (flutter/engine#47341) 
TiledTextureContents::RenderToSnapshot should only create a snapshot directly from the texture if the geometry is an axis-aligned rectangle.

Fixes https://github.com/flutter/flutter/issues/136504
 2023-10-26 20:08:21 +00:00
Jason Simmons
5316d75378 Roll HarfBuzz to 8.2.2 (flutter/engine#47284) 
Fixes https://github.com/flutter/flutter/issues/132327
 2023-10-26 20:03:07 +00:00
skia-flutter-autoroll
b0af8b059f Roll Skia from 19e9ccf5f820 to fb72136c9325 (2 revisions) (flutter/engine#47346) 
https://skia.googlesource.com/skia.git/+log/19e9ccf5f820..fb72136c9325

2023-10-26 egdaniel@google.com Revert "Fix checking of power of 2 for scratch buffer caching."
2023-10-26 jamesgk@google.com [graphite] Limit DrawPass size by number of RenderSteps

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 19:10:16 +00:00
Jonah Williams
1db210a686 [Impeller] remove giant closure in EntityPass. (flutter/engine#47343) 
I find it difficult to track what parts of this method are part of the closure and which aren't. Lets hoist this data into a private method and remove some unused imports.
 2023-10-26 18:51:01 +00:00
godofredoc
7f6c801cd4 Adds firebase test lab tests. (flutter/engine#47320) 
The FTL tests were not migrated during the v2 migration.

Bug: https://github.com/flutter/flutter/issues/136767

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-26 18:39:49 +00:00
gaaclarke
c0cbd1ebaf [Impeller] added missing openplayground (flutter/engine#47338) 
Not sure how this ended up left off.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-26 10:11:06 -07:00
skia-flutter-autoroll
17f8149068 Roll Skia from ebae76679a04 to bc5c938ccff4 (1 revision) (flutter/engine#47337) 
https://skia.googlesource.com/skia.git/+log/ebae76679a04..bc5c938ccff4

2023-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from f97537ebdada to 1227163dbdb7 (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 16:20:07 +00:00
gaaclarke
96c4710bd3 [Impeller] Improved documentation of the gaussian blur. (flutter/engine#47283) 
Just trying to capture some of my thoughts as I look into some blur
bugs.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-26 08:59:53 -07:00
skia-flutter-autoroll
637d2ce989 Roll Skia from fb63b86f7bb8 to ebae76679a04 (1 revision) (flutter/engine#47336) 
https://skia.googlesource.com/skia.git/+log/fb63b86f7bb8..ebae76679a04

2023-10-26 egdaniel@google.com Fix checking of power of 2 for scratch buffer caching.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 15:26:07 +00:00
skia-flutter-autoroll
bbe197c894 Roll Skia from 3b84335bf181 to fb63b86f7bb8 (2 revisions) (flutter/engine#47335) 
https://skia.googlesource.com/skia.git/+log/3b84335bf181..fb63b86f7bb8

2023-10-26 nicolettep@google.com [graphite] Rename graphite's AdoptTextureFrom to WrapTexture to reflect actual functionality
2023-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from a1d9a5858b7b to f97537ebdada (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 14:43:56 +00:00
skia-flutter-autoroll
7666c93858 Roll Fuchsia Linux SDK from zTq0jH2Y3Fl0uUUSa... to akT2HxdLNPWSG-gbV... (flutter/engine#47331) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 08:00:09 +00:00
skia-flutter-autoroll
fdad9151f2 Roll Skia from 94e67b76fd2d to 14c3cf9efb44 (1 revision) (flutter/engine#47328) 
https://skia.googlesource.com/skia.git/+log/94e67b76fd2d..14c3cf9efb44

2023-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 1565797d107b to 50a46e8932cc (5 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 05:26:23 +00:00
skia-flutter-autoroll
299f4179da Roll Skia from a5da4435bb5c to 94e67b76fd2d (1 revision) (flutter/engine#47327) 
https://skia.googlesource.com/skia.git/+log/a5da4435bb5c..94e67b76fd2d

2023-10-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 1323db7bd0b4 to a1d9a5858b7b (1 revision)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-26 02:51:23 +00:00
Jason Simmons
2e776add85 Revert Dart SDK to 360370ff93b053253343832432f8329a11372ffc (flutter/engine#47326) 
The latest Dart SDK contains a change to "dart fix" that caused a regression in some customer tests.

See https://github.com/flutter/flutter/issues/137298
 2023-10-26 00:56:06 +00:00
Jonah Williams
9cd50d1229 [Impeller] Cache location in metadata. (flutter/engine#46640) 
Hacky mutable stuff, but avoids recomputing string keys and hashing them multiple times per draw call. [See also
](https://docs.google.com/document/d/1msDN8D4_Hi2zR5JFaFLWDb0IHD3MekuuiaYLJ3Tt6to/edit?resourcekey=0-bZbENKIpXKtrnzU6kkLXcQ)

While we cache the uniform location, looking up this value requires computing a string key for every single uniform value on every single command. We can speed this up by stashing the uniform location in the shader metadata, which shouldn't change for the app lifetime. This avoids both the string computation and the hashmap usage.
 2023-10-25 22:52:19 +00:00
skia-flutter-autoroll
ec61e7cb8c Roll Skia from 8492914821fa to fb979d0ce053 (1 revision) (flutter/engine#47324) 
https://skia.googlesource.com/skia.git/+log/8492914821fa..fb979d0ce053

2023-10-25 herb@google.com Add modules/bentleyottmann to IWYU

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-25 22:48:59 +00:00
Loïc Sharma
acadeba222 [Windows] Introduce FlutterWindowsViewController (flutter/engine#47242) 
This change begins the migration to the Windows embedder's new ownership model:

1. Renames `FlutterDesktopViewControllerState` to `FlutterWindowsViewController`
2. Moves ownership of the `FlutterWindowsEngine` from the `FlutterWindowsView` to the `FlutterWindowsViewController`

For more information, refer to: [flutter.dev/go/windows-multi-view-ownership-updates](https://flutter.dev/go/windows-multi-view-ownership-updates)

Part of https://github.com/flutter/flutter/issues/137267

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-25 22:06:16 +00:00
skia-flutter-autoroll
3922dc0c6f Roll Dart SDK from 73fa7b3e048a to 7745c140d1fe (1 revision) (flutter/engine#47321) 
https://dart.googlesource.com/sdk.git/+log/73fa7b3e048a..7745c140d1fe

2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-60.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-25 21:44:07 +00:00
Zachary Anderson
14a7db93d1 Cleanup Dart package dependencies a bit (flutter/engine#47306) 
Removes package:quiver, and an older second copy of package:file
 2023-10-25 13:09:30 -07:00
skia-flutter-autoroll
0ed515cf80 Roll Skia from d511fa1f1533 to 773abacc1581 (1 revision) (flutter/engine#47312) 
https://skia.googlesource.com/skia.git/+log/d511fa1f1533..773abacc1581

2023-10-25 nicolettep@google.com [graphite] Add memory barriers before and after updating intrinsic constant uniform buffer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-25 19:52:21 +00:00
gaaclarke
c2cc73e3e6 Missed linter argument comment violations (flutter/engine#47310) 
## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2023-10-25 11:26:11 -07:00
Chinmay Garde
04a5b59d59 [Impeller] Remove use of FML_DISALLOW_<FOO> macros in Impeller. (flutter/engine#47307) 
Really not convinced this is easier to read but maybe I just need to get used to it. Besides, good to just stick to the style guide uniformly.

Followup from https://github.com/flutter/engine/pull/47278#discussion_r1371971876

Can do this for the rest of the engine and remove the macros if this is fine.
 2023-10-25 17:43:24 +00:00
gaaclarke
2b28dc130d Adds lint for checking argument commments (flutter/engine#47305) 
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2023-10-25 17:21:09 +00:00
skia-flutter-autoroll
9443edb1bd Roll Skia from 4848dd9b5dab to 0748053419cd (2 revisions) (flutter/engine#47302) 
https://skia.googlesource.com/skia.git/+log/4848dd9b5dab..0748053419cd

2023-10-25 michaelludwig@google.com Add mask filter support to AutoLayerForImageFilter
2023-10-25 johnstiles@google.com Ensure SkCodec headers are accounted for in GN.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-25 16:40:54 +00:00
skia-flutter-autoroll
077344a624 Roll Dart SDK from 57661d5dbc1e to 2791495ed583 (1 revision) (flutter/engine#47298) 
https://dart.googlesource.com/sdk.git/+log/57661d5dbc1e..2791495ed583

2023-10-25 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-58.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-25 13:38:23 +00:00
skia-flutter-autoroll
fc4766443c Roll Fuchsia Linux SDK from tqukMrdJ6j-845-57... to vX5n99OIWgLX6bObI... (flutter/engine#47293) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-25 05:51:52 +00:00
skia-flutter-autoroll
d1649a9662 Roll Skia from 0d4fcf388a6f to f98fc9536c43 (1 revision) (flutter/engine#47292) 
https://skia.googlesource.com/skia.git/+log/0d4fcf388a6f..f98fc9536c43

2023-10-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 9d4aae810901 to 1565797d107b (4 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-25 05:37:11 +00:00
Chinmay Garde
4b9e254019 [Impeller] Update shader compilation pipeline documentation to detail multi-arch archives. (flutter/engine#47289) 2023-10-24 23:29:54 +00:00
Matan Lurey
3e118237e3 OpenGL <4.x does not support stencil-only formats, so delete the TODO (flutter/engine#47286) 
Closes https://github.com/flutter/flutter/issues/137094.
 2023-10-24 16:27:02 -07:00
Matan Lurey
07e83e3f94 [Impeller] Unconditionally dither in gradient shader fragments. (flutter/engine#46746) 
Partial work towards https://github.com/flutter/flutter/issues/112498.

Won't land this until https://github.com/flutter/engine/pull/46745 is
merged, so expect some redness until then.
 2023-10-24 16:23:04 -07:00
skia-flutter-autoroll
f3eeadadae Roll Skia from f491209e969d to 076a9dd0094f (1 revision) (flutter/engine#47285) 
https://skia.googlesource.com/skia.git/+log/f491209e969d..076a9dd0094f

2023-10-24 herb@google.com Add implementation for SweepLine

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-24 22:50:04 +00:00
Chinmay Garde
a6ea96ab20 [Impeller] Add support for multi-rendering-backend fat shader archives. (flutter/engine#47278) 
Existing shader archive ctors have been made private. Instead a factory is used to check to see if the blob is a single or multi-archive and do the right thing. This allows us to keep the existing code the same. But, when multi-archives are encountered, the right shaders libraries will be picked.

Creating multi-archives will be done in ImpellerC in an upcoming patch.

Towards https://github.com/flutter/flutter/issues/123741
 2023-10-24 22:38:49 +00:00
skia-flutter-autoroll
5b9d95a248 Roll Skia from 502277be15cf to f491209e969d (1 revision) (flutter/engine#47281) 
https://skia.googlesource.com/skia.git/+log/502277be15cf..f491209e969d

2023-10-24 johnstiles@google.com Fix dm/viewer startup to avoid loading images unnecessarily.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,rmistry@google.com,robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-10-24 22:00:22 +00:00