420 Commits

Author SHA1 Message Date
Gary Qian
489d0ce708 Remove currentLocale prepend on iOS (flutter/engine#18379) 2020-05-19 19:10:35 -07:00
liyuqian
256ab19662 Automatically remove old persistent cache dir (flutter/engine#18244)
Fixes https://github.com/flutter/flutter/issues/53445
2020-05-15 14:15:59 -07:00
Emmanuel Garcia
35306af829 Add screenshots for Android view (flutter/engine#18367) 2020-05-15 13:03:39 -07:00
Kaushik Iska
686b4af73f Update the observatory thread name for profiling thread (flutter/engine#18199) 2020-05-15 12:28:10 -07:00
Kaushik Iska
900ca8419e [fuchsia] Remove log dumping to prevent timeouts (flutter/engine#18409)
See: https://github.com/flutter/flutter/issues/57273
2020-05-14 21:10:49 -07:00
Kaushik Iska
834cfb021e Add ocmock to iOS unit tests xcode project (flutter/engine#18396) 2020-05-14 19:42:02 -07:00
godofredoc
a823e647fd Disable flow tests. (flutter/engine#18405)
seems like flow tests are leaving devices in a bad state.
2020-05-14 19:04:10 -07:00
godofredoc
32382161fd Re-enable Fuchsia tests (flutter/engine#18392)
This reverts commit 3f2ced919df85b318ca2261af82130b64c0f4e63.
2020-05-14 14:56:14 -07:00
Jason Simmons
91f67b420c Move FlutterLoader disk I/O to a background thread to comply with Android strict mode (flutter/engine#18241) 2020-05-13 14:17:03 -07:00
Emmanuel Garcia
15e32296f2 Fix scenario platform view tests on Android (flutter/engine#18332) 2020-05-13 13:33:38 -07:00
Kaushik Iska
3f2ced919d Revert "Re-enable Fuchsia tests (#18342)" (flutter/engine#18345)
This reverts commit 8a8fe6e81f6163b934cbcbd4750f0e6dc018176a.
2020-05-13 10:21:25 -07:00
Kaushik Iska
8a8fe6e81f Re-enable Fuchsia tests (flutter/engine#18342)
Co-authored-by: Kaushik Iska <kaushikiska@google.com>
2020-05-13 09:21:34 -07:00
Kaushik Iska
31d2a40029 Completely disable paving the device on Fuchsia (flutter/engine#18340) 2020-05-13 07:42:22 -07:00
Kaushik Iska
627585f58f Disable all fuchsia tests temporarily (flutter/engine#18326) 2020-05-12 17:31:50 -07:00
Kaushik Iska
b7e69d849a Disable flow tests on Fuchsia (flutter/engine#18323) 2020-05-12 16:36:42 -07:00
Kaushik Iska
85724df40c Temporarily disabling the fuchsia shell, runtime tests (flutter/engine#18319)
see: https://github.com/flutter/flutter/issues/57061
2020-05-12 15:57:36 -07:00
Marcus Tomlinson
7d5268265e Add new FlutterEngineAOTData argument to FlutterProjectArgs (flutter/engine#18146)
Added a new `FlutterEngineAOTData` argument to `FlutterProjectArgs`. Embedders can instantiate and destroy this object via the new `FlutterEngineCreateAOTData` and `FlutterEngineCollectAOTData` methods provided.

If an embedder provides more than one source of AOT data to `FlutterEngineInitialize` or `FlutterEngineRun` (e.g. snapshots as well as `FlutterEngineAOTData`), the engine will error out.

Resolves: https://github.com/flutter/flutter/issues/50778
2020-05-10 10:24:56 -07:00
Emmanuel Garcia
a9b1a8bd6a Add support for screenshot testing in the scenario app on Android (flutter/engine#18115) 2020-05-09 10:34:55 -07:00
liyuqian
b50499d50d Reland again "Remove layer integral offset snapping #17112" (flutter/engine#18160)
This reverts commit 74823c212d418597775d332d8c272673c83f6f63 and relands our reland https://github.com/flutter/engine/pull/17915.

Additionally, we fixed the cull rect logic in `OpacityLayer::Preroll` which is  the root cause of https://github.com/flutter/flutter/issues/56298. We've always had that root problem before but it did not trigger performance issues because we were using the OpacityLayer's `paint_bounds`, instead of its child's `paint_bounds` for preparing the layer raster cache. A correct handling of the cull rect should allow us to cull at any level.

It also turns out that our ios32 (iPhone4s) performacne can regress a lot
without snapping. My theory is that although the picture has a
fractional top left corner, many drawing operations inside the picture
have integral coordinations. In older hardwares, keeping those
coordinates integral seems to be performance critical.

To avoid flutter/flutter#41654, the snapping
will still be disabled if the matrix has non-scale-translation
transformations.
2020-05-07 17:19:30 -07:00
Robert Ancell
10cf694c5a Add first Linux shell tests (flutter/engine#18159) 2020-05-06 15:33:11 +12:00
liyuqian
74823c212d Revert again "Remove layer integral offset snapping" (flutter/engine#18132) 2020-05-04 16:39:03 -07:00
liyuqian
0e1cdfdcf5 Reland "Remove layer integral offset snapping" (flutter/engine#17915)
This reverts commit c72ff4a and relands #17712.

Fixes flutter/flutter#53288 and flutter/flutter#41654.

Together with #17791, this reland addresses some of Jim's concerns in the original PR #17712.

The major part of this PR is still the same as the original PR, and the performance / golden image impacts should be the same.
2020-05-01 15:01:42 -07:00
Emmanuel Garcia
142a859137 Populate window.locale in Dart (flutter/engine#18043) 2020-04-29 19:24:16 -07:00
xster
1db782cbf6 skip TextSemanticsFocusTest for flake (flutter/engine#18015) 2020-04-28 16:00:37 -07:00
gaaclarke
03db531cb6 Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews (flutter/engine#17988)
* Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews

* ran formatter

* made an alternative version of the assertion

* removed log statements, seems to mess with the buildbot's xcpretty
2020-04-27 23:53:22 -07:00
godofredoc
4d8813b219 Reenable flutter scenic test to identify crashes and follow up on fixes. (flutter/engine#17979) 2020-04-27 15:14:04 -07:00
Emmanuel Garcia
f6c5bdea96 Add initial unit tests for the android embedding (flutter/engine#17921) 2020-04-26 20:45:28 -07:00
xster
664700007c Fix accessibility focus loss when first focusing on text field (flutter/engine#17803) 2020-04-24 15:44:54 -07:00
godofredoc
9bf14b44f4 Pass amber-files directory to tests. (flutter/engine#17815)
* Pass amber-files directory to tests.

Bug:
  https://github.com/flutter/flutter/issues/50249
  https://github.com/flutter/flutter/issues/55165

* Redirect tar stdout to dev/null and fix param name.

* Keep scenic tests disabled.
2020-04-21 18:54:21 -07:00
Gary Qian
887c1a875e PlatformResolvedLocale localization message channel (flutter/engine#17755) 2020-04-21 15:34:44 -07:00
Brian Osman
1a6e99b23d Remove legacy version of SkCanvas::didConcat44 (flutter/engine#17828)
Builds flags have been switched, so the old versions aren't needed any
longer.
2020-04-21 08:46:57 -04:00
Brian Osman
948065c3a7 Convert semantics_node from SkMatrix44 to SkM44 (flutter/engine#17763)
* Convert semantics_node from SkMatrix44 to SkM44
2020-04-17 07:24:40 -04:00
Brian Osman
4b424c1296 Guard canvas virtuals so we can remove legacy didConcat44 (flutter/engine#17756)
* Guard canvas virtuals so we can remove legacy didConcat44

SkMatrix44 is also deprecated, so start transitioning to SkM44.

* Fix formatting
2020-04-16 13:40:22 -04:00
gaaclarke
43dffbd739 Added some tests after the fact for #17499 (flutter/engine#17714) 2020-04-15 11:52:52 -07:00
godofredoc
b07a6e8e0b Updates to use predefined keys. (flutter/engine#17716)
* Updates to use predefined keys.

It starts using:
  * timeouts for paving.
  * timeouts for ssh commands.
  * timeouts for tests.

https://github.com/flutter/flutter/issues/54416

* Update key location and autogenerate public key.

* Use ssh-keygen instead of openssl.

* Fix typo on test name.
2020-04-14 18:29:13 -07:00
Alexander Aprelev
d58d893dec In tests run dart code on ui(rather than on platform) thread. (flutter/engine#17686) 2020-04-13 16:50:11 -07:00
gaaclarke
3849b114d4 Made it so unit tests can be written against all ios engine code. (flutter/engine#17624) 2020-04-13 12:34:54 -07:00
liyuqian
6c93145ef5 Read SkSLs from asset (flutter/engine#17601)
Fixes https://github.com/flutter/flutter/issues/53117

Test added:
- ShellTest.CanLoadSkSLsFromAsset
2020-04-10 00:16:33 -07:00
gaaclarke
bbae0c06d4 Enabled hiding the home indicator with SystemChrome.setEnabledSystemUIOverlays (flutter/engine#17574) 2020-04-09 09:43:38 -07:00
Dan Field
d5f40cc11e set -e on assemble_apk.sh (flutter/engine#17588)
* set -e on assemble_apk.sh

* build the necessary artifacts
2020-04-08 14:52:14 -07:00
godofredoc
e894999885 Add logs between fuchsia test steps. (flutter/engine#17584)
* Add logs between fuchsia test steps.

Adding logs and date time in between steps will simplify finding the
steps that are failing during the fuchsia tests.

https://github.com/flutter/flutter/issues/54253

* Use date command instead of DATE..

* Remove extra log line.

* Same spacer lenght for all the log lines.
2020-04-08 12:50:17 -07:00
Emmanuel Garcia
36c79c8a65 Change the directory to the scenario app (flutter/engine#17583) 2020-04-08 08:40:04 -07:00
LongCatIsLooong
d6d4f376a1 iOS UITextInput autocorrection prompt (flutter/engine#13959) 2020-04-07 14:45:59 -07:00
stuartmorgan
7b222c8310 Remove JSON codec from C++ client wrapper (flutter/engine#17312)
The JSON codec is awkward to use in the wrapper (since the client has to build and link one of the JSON libraries to do so). Since it would be very cumbersome to wrap in a C API, and there's essentially no reason to use it instead of the standard codec, this removes it from the wrapper entirely.

Since some system channels (internal to the engine) still use it, it's moved into common/cpp instead of being eliminated entirely. Internally we always use RapidJSON though, so the jsoncpp implementation is removed. Also adds some unit test coverage, since there wasn't any.

Fixes #30669
2020-04-02 14:57:46 -07:00
Dan Field
904a84fee3 Roll to clang11, mark 4 (flutter/engine#17483)
* "Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 4 (#17467)" (#17482)"

This reverts commit d7bbf2e70c8cb86823f1ec7a310d6ab0b9a610db.

* format code

* Roll buildroot to 3a27de1c5bb0f50be7d3efe3e00de4f6068c9f30
2020-04-02 13:04:49 -07:00
Dan Field
a04ba4f15e Initialize locale from FlutterEngine (flutter/engine#17473)
* Initialize locale from FlutterEngine
2020-04-02 10:06:06 -07:00
Dan Field
d7bbf2e70c Revert "Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 (#17467)" (flutter/engine#17482)
This reverts commit 31eab31f771363d9c4fc9799449859abe0e464f2.
2020-04-02 10:01:26 -07:00
Dan Field
31eab31f77 Reland Clang 11, roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c, take 3 (flutter/engine#17467)
* Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)" (#17464)

This reverts commit 6083cda709c194ec81d2092c70a0151a10f0c922.

* Skip more image tests, use newer dsymutil, add missing symbols
2020-04-01 20:55:27 -07:00
liyuqian
474e90ba76 Add build_and_test_linux_release presubmit test (flutter/engine#17073) 2020-04-01 18:46:04 -07:00
Dan Field
6083cda709 Revert "Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c (#17457)" (flutter/engine#17464)
This reverts commit fe77c763691277d3194269f30d9a8c915e437852.
2020-04-01 17:50:57 -07:00