skia-flutter-autoroll
e2ac598da8
Roll Fuchsia Linux SDK from 3JmrIr49bTV2DIWsW... to dCjN58uZQBmAFWSxN... ( flutter/engine#46700 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 05:48:15 +00:00
skia-flutter-autoroll
2eadc2e15e
Roll Skia from f4f3c909993d to 4378ce41f461 (1 revision) ( flutter/engine#46699 )
...
https://skia.googlesource.com/skia.git/+log/f4f3c909993d..4378ce41f461
2023-10-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2e3e38a84286 to f9f3328bcef8 (8 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 05:30:55 +00:00
skia-flutter-autoroll
97803f90d7
Roll Dart SDK from 078162ecf493 to a471147f6237 (1 revision) ( flutter/engine#46695 )
...
https://dart.googlesource.com/sdk.git/+log/078162ecf493..a471147f6237
2023-10-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-4.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-10 01:30:13 +00:00
skia-flutter-autoroll
3939588f34
Roll Dart SDK from a6e43b0b9e0c to 078162ecf493 (1 revision) ( flutter/engine#46691 )
...
https://dart.googlesource.com/sdk.git/+log/a6e43b0b9e0c..078162ecf493
2023-10-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-3.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 21:35:14 +00:00
skia-flutter-autoroll
71ec5b83b0
Roll Skia from e56387226035 to f45ac4569300 (1 revision) ( flutter/engine#46690 )
...
https://skia.googlesource.com/skia.git/+log/e56387226035..f45ac4569300
2023-10-09 herb@google.com Add slope comparison for Segments
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 21:33:31 +00:00
Chinmay Garde
e53f10f782
Remove obsolete tests that were time sensitive. ( flutter/engine#46686 )
...
These were always filtered away. On Fuchsia, where the filters were not
in place, there was an ifdef guard.
Followup to
https://github.com/flutter/flutter/issues/80457#issuecomment-1753419263
---------
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
2023-10-09 13:39:21 -07:00
skia-flutter-autoroll
b4579a5fb3
Roll Skia from bd77f099b4f9 to e56387226035 (1 revision) ( flutter/engine#46687 )
...
https://skia.googlesource.com/skia.git/+log/bd77f099b4f9..e56387226035
2023-10-09 kjlubick@google.com Remove #ifdef SK_VULKAN from GrDirectContext by moving MakeVulkan factories
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 20:37:17 +00:00
skia-flutter-autoroll
0762396b58
Roll Skia from 26d70e6999f6 to bd77f099b4f9 (3 revisions) ( flutter/engine#46685 )
...
https://skia.googlesource.com/skia.git/+log/26d70e6999f6..bd77f099b4f9
2023-10-09 johnstiles@google.com Revert "Disable color type RG_88 on Apple M1 GPUs."
2023-10-09 johnstiles@google.com Disable color type RG_88 on Apple M1 GPUs.
2023-10-09 johnstiles@google.com Disable indirect draws in ANGLE + D3D.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 19:49:11 +00:00
Jim Graham
c97916810d
[Impeller] Run DisplayList render tests. ( flutter/engine#46422 )
...
Revisiting this project as it may help with [attribute] X [rendering op] matrix testing of Impeller. It's not an exhaustive combinatorial test of all combinations of rendering attributes, but it attempts each op with each attribute both default and non-default.
For Impeller it only tests that the rendering produced output (i.e wasn't a NOP due to missing implementation), that the output changed if the given attribute was supposed to change the output, and that it rendered within the computed bounds that the rest of the engine will be assuming.
These changes will not result in any automatic CI testing of Impeller as is since they are only run on the Metal backend which is not enabled by default. Running `out/host_[variant]/display_list_rendertests --enable-metal` manually on a Mac host, though, will run the tests through Impeller and there will be a lot of error output. Also, there is one known crash as reported in https://github.com/flutter/flutter/issues/135766
2023-10-09 19:10:05 +00:00
skia-flutter-autoroll
92590c5464
Roll Skia from ef4c093143d2 to 26d70e6999f6 (1 revision) ( flutter/engine#46684 )
...
https://skia.googlesource.com/skia.git/+log/ef4c093143d2..26d70e6999f6
2023-10-09 kjlubick@google.com Move third_party/vulkanmemoryallocator -> src/gpu/vk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 19:03:13 +00:00
ColdPaleLight
4411d278fc
[Impeller] Optionally support SamplerAddressMode::kDecal on the OpenGLES backend ( flutter/engine#46650 )
...
fix https://github.com/flutter/flutter/issues/129358
2023-10-09 17:21:30 +00:00
skia-flutter-autoroll
f33ddd1e3f
Roll Skia from 4135182b6a56 to ef4c093143d2 (2 revisions) ( flutter/engine#46680 )
...
https://skia.googlesource.com/skia.git/+log/4135182b6a56..ef4c093143d2
2023-10-09 nscobie@google.com Force RRectEffect to always use scale when in reduced shader mode
2023-10-09 robertphillips@google.com [graphite] Update remaining childless Blocks to be AddBlock-style
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 17:13:24 +00:00
skia-flutter-autoroll
a819caa9ed
Roll Skia from c5541e2bd213 to 4135182b6a56 (1 revision) ( flutter/engine#46677 )
...
https://skia.googlesource.com/skia.git/+log/c5541e2bd213..4135182b6a56
2023-10-09 michaelludwig@google.com [skif] Refactor Functors,ContextInfo,Context into virtual Backend, and Context
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 15:38:07 +00:00
skia-flutter-autoroll
09e1503ca9
Roll Dart SDK from a88ed8cafd27 to a6e43b0b9e0c (1 revision) ( flutter/engine#46674 )
...
https://dart.googlesource.com/sdk.git/+log/a88ed8cafd27..a6e43b0b9e0c
2023-10-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-2.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 13:32:18 +00:00
skia-flutter-autoroll
003ff93577
Roll Skia from 0507cc73ca2a to c844143823fb (1 revision) ( flutter/engine#46664 )
...
https://skia.googlesource.com/skia.git/+log/0507cc73ca2a..c844143823fb
2023-10-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8d9cef29be25 to 2e3e38a84286 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-09 06:04:51 +00:00
Jonah Williams
a92072c571
[Impeller] Add IMPELLER_DEBUG around group. ( flutter/engine#46642 )
...
These tracing functions aren't free!
2023-10-07 15:32:05 +00:00
skia-flutter-autoroll
f0db641850
Roll Skia from 6ce883877068 to 99d9d571f4dd (1 revision) ( flutter/engine#46652 )
...
https://skia.googlesource.com/skia.git/+log/6ce883877068..99d9d571f4dd
2023-10-07 yangguang@jwzg.com support compression textures in webgl
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 14:44:09 +00:00
skia-flutter-autoroll
4db91398d4
Roll Fuchsia Linux SDK from a-BbzDtY3w8UXYgbK... to nX88TgPdoM6PK1wBq... ( flutter/engine#46651 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 14:32:20 +00:00
skia-flutter-autoroll
0b33d42515
Roll Dart SDK from 46bad70d0f7e to 7ba556c43d35 (1 revision) ( flutter/engine#46645 )
...
https://dart.googlesource.com/sdk.git/+log/46bad70d0f7e..7ba556c43d35
2023-10-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-0.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 04:54:21 +00:00
skia-flutter-autoroll
f9f09134d6
Roll Fuchsia Linux SDK from K7K76tME-CSGhYlFm... to a-BbzDtY3w8UXYgbK... ( flutter/engine#46641 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 01:47:00 +00:00
skia-flutter-autoroll
cdae151167
Roll Dart SDK from 368fd3846df0 to 46bad70d0f7e (7 revisions) ( flutter/engine#46639 )
...
https://dart.googlesource.com/sdk.git/+log/368fd3846df0..46bad70d0f7e
2023-10-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-238.0.dev
2023-10-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-237.0.dev
2023-10-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-236.0.dev
2023-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-235.0.dev
2023-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-234.0.dev
2023-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-233.0.dev
2023-10-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-232.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-07 01:02:06 +00:00
skia-flutter-autoroll
90cad5e5d4
Roll Skia from d86da2a029d8 to 2f67f1f18562 (36 revisions) ( flutter/engine#46636 )
...
Roll Skia from d86da2a029d8 to 2f67f1f18562 (36 revisions)
https://skia.googlesource.com/skia.git/+log/d86da2a029d8..2f67f1f18562
2023-10-06 kjlubick@google.com Add dedicated function to calculate length of Base64 encoded string
2023-10-06 bungeman@google.com [pathops] Simplify trivial paths to empty
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 44a79902f2c1 to 01742293d0f2 (11 revisions)
2023-10-06 johnstiles@google.com Add fuzzer for SkSL-to-WGSL.
2023-10-06 johnstiles@google.com Add fuzzer for runtime blenders.
2023-10-06 johnstiles@google.com Add fuzzer for runtime color filters.
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from a42cebae4e42 to ac72499c0a8a (91 revisions)
2023-10-06 kjlubick@google.com Split codec-related parts out of tools/Resources.h
2023-10-06 drott@chromium.org [Fontations] Borrow glyph mask flag implementation from FreeType
2023-10-06 jvanverth@google.com Try to fix Dawn roll again.
2023-10-06 drott@chromium.org [Fontations] FFI Interface for accessing CPAL and COLRv0 info
2023-10-06 jvanverth@google.com Disable Tint's use of //build directory to fix Dawn roll
2023-10-06 johnstiles@google.com Add workaround for dropped clear in VKDMSAA.
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3d75b794df0f to 8c341cfdef74 (3 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 46c5d45d5955 to 44a79902f2c1 (15 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from e12f70e0a324 to 8d9cef29be25 (3 revisions)
2023-10-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 535363447183 to 8d9cef29be25
2023-10-06 jvanverth@google.com [graphite] Revise PathAtlas::onAddShape interface.
2023-10-05 lovisolo@google.com [bazel] BazelBenchmarkRunner.cpp: Write results.json output file in Perf's new JSON format.
2023-10-05 johnstiles@google.com Factor out FuzzCreateValidInputsForRuntimeEffect to FuzzCommon.
2023-10-05 johnstiles@google.com Disable broken GMs on Adreno 5xx/6xx + Vulkan.
2023-10-05 kjlubick@google.com Split ToolUtils into a few files for easier modularization
2023-10-05 kjlubick@google.com Enforce IWYU on ToolUtils.h
2023-10-05 bungeman@google.com Revert "[pdf] Simplify filled paths"
2023-10-05 johnstiles@google.com Outset the rect passed to SkMesh::MakeIndexed.
2023-10-05 kjlubick@google.com Use buildifier to reformat all Bazel files
2023-10-05 robertphillips@google.com [graphite] Short circuit key generation for simple paints
2023-10-05 johnstiles@google.com Add saturate to list of supported WGSL intrinsics.
2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 404a76d9bf0e to 46c5d45d5955 (1 revision)
2023-10-05 bungeman@google.com [pdf] Simplify filled paths
2023-10-05 kjlubick@google.com Make SkReadBuffer *not* call SkImages::DeferredFromEncodedData by default
2023-10-05 armansito@google.com [graphite][dawn][viewer] Support turning vsync off
2023-10-05 lovisolo@google.com [bazel] BazelBenchmarkRunner.cpp: Add more flags and better validation.
2023-10-05 robertphillips@google.com [graphite] Add CoeffBlenderBlock::AddBlock
2023-10-05 robertphillips@google.com [graphite] Add ColorSpaceTransformBlock::AddBlock
2023-10-05 johnstiles@google.com Enable child effects in SkMesh programs.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
...
2023-10-06 23:30:23 +00:00
skia-flutter-autoroll
1a2c32d8fe
Roll Skia from 0f2af25f15ee to d86da2a029d8 (7 revisions) ( flutter/engine#46587 )
...
https://skia.googlesource.com/skia.git/+log/0f2af25f15ee..d86da2a029d8
2023-10-05 brianosman@google.com Fix link errors in shared-library
builds when using SkRuntimeEffect inner classes
2023-10-05 johnstiles@google.com Incorporate child effects into the mesh
key and proxy handlers.
2023-10-05 johnstiles@google.com Set up texture bindings for SkMesh
child effects.
2023-10-05 johnstiles@google.com Emit shader code and uniforms for a
mesh's child processors.
2023-10-05 rmistry@google.com Sync depot_tools to HEAD to fix
RecreateSKPs bot sync failures
2023-10-05 jvanverth@google.com [graphite] Progress towards caching
rasterPathAtlas masks.
2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll
vulkan-deps from ff2054861dc4 to 404a76d9bf0e (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com
on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-06 15:25:01 -07:00
Alexander Aprelev
eb374b3881
[fuchsia] Remove hardcoded fuchsia-imported packages 2.12 sdk version ( flutter/engine#46629 )
...
Use sdk version from imported package pubspec.yaml instead.
This unblocks dart->engine roll that currently is failing
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Fuchsia/83386/overview .
2023-10-06 14:01:28 -07:00
Kevin Lubick
5d70f10ebb
Add Base64::EncodedSize to tidy up allocations ( flutter/engine#46624 )
...
As a follow-up to #46543 , this adds a dedicated function to compute the
size of the buffer needed to encode data using Base64 instead of calling
the encode function with nullptr.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-06 16:50:20 -04:00
Jonah Williams
f29ce2aa7a
[Impeller] Ensure known geometry has simple bounds computation. ( flutter/engine#46623 )
...
Computing the bounds of an RRect can be really slow if you don't actually know that it is an RRect, and shows up in the traces for flutter gallery on wembly. This change should be semantically equivalent and is only an optimization to avoid recomputing the same value we already know.
2023-10-06 20:49:08 +00:00
Jonah Williams
fe78d18716
[Impeller] Refactor CapabilitiesGLES into a Capabilties. ( flutter/engine#46621 )
...
From https://github.com/flutter/engine/pull/46585
For Framebuffer fetch and other changes we should refactor the CapabilitiesGLES into a regular capabilities.
2023-10-06 19:03:11 +00:00
Brandon DeRosier
096c45ad3f
[Impeller] Track clip coverage per-pass when not collapsing. ( flutter/engine#46597 )
...
Resolves https://github.com/flutter/flutter/issues/135916 .
Big credits to @gaaclarke for the repros and investigation around this.
Moves back to tracking clip coverage per-pass when not collapsing. This is especially important for SaveLayers with MatrixImageFilters, which can transform the rendered layer texture and thereby move elements inside or outside of existing parent clips.
This should have little to no performance impact, since we should already be generating correct minimal subpass textures based on correct subpass coverage computation.
Before:
<img width="679" alt="Screenshot 2023-10-05 at 1 25 29 PM" src="https://github.com/flutter/engine/assets/919017/fe63808a-6353-4969-8225-120fd5ee0949 ">
https://github.com/flutter/engine/assets/919017/9284f055-bee1-40cd-8b7e-f478b00d01da
After:
<img width="679" alt="Screenshot 2023-10-05 at 1 24 17 PM" src="https://github.com/flutter/engine/assets/919017/066b1e25-9611-4e14-a383-cc3a866dbe36 ">
https://github.com/flutter/engine/assets/919017/0fbd1f96-8920-472c-bb0e-4414187fc72d
2023-10-06 16:05:20 +00:00
skia-flutter-autoroll
8fe1f0c054
Roll Fuchsia Linux SDK from eI_FBTaRgvoBQaK5n... to K7K76tME-CSGhYlFm... ( flutter/engine#46614 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-06 10:19:22 +00:00
skia-flutter-autoroll
3f74b956bd
Roll Fuchsia Linux SDK from bnd4FFub2R9Q4mlAC... to eI_FBTaRgvoBQaK5n... ( flutter/engine#46599 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 21:28:15 +00:00
skia-flutter-autoroll
d5c45015f9
Roll Skia from 09c71755bc6c to 0f2af25f15ee (2 revisions) ( flutter/engine#46586 )
...
https://skia.googlesource.com/skia.git/+log/09c71755bc6c..0f2af25f15ee
2023-10-05 robertphillips@google.com [graphite] Add BlendModeBlenderBlock::AddBlock
2023-10-05 michaelludwig@google.com Reland "Reland "[skif] Draw FilterResults directly for layer restoration""
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 14:57:24 +00:00
Kevin Lubick
ec62430ff1
Replace use of Skia's Base64 Encoding/Decoding logic with a copy of the equivalent code ( flutter/engine#46543 )
...
Skia would like to remove SkBase64.h from its public API. This ports the
same functionality into Flutter's codebase with tests.
The implementation was copied from
[Skia](387853af19/src/utils/SkBase64.cpphttps://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-10-05 10:21:39 -04:00
skia-flutter-autoroll
2e02f6e6ee
Roll Skia from 2be211c972d5 to 09c71755bc6c (1 revision) ( flutter/engine#46584 )
...
https://skia.googlesource.com/skia.git/+log/2be211c972d5..09c71755bc6c
2023-10-05 robertphillips@google.com [graphite] Deduplicate the paint color uniform
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 14:11:24 +00:00
skia-flutter-autoroll
ae2bde183b
Roll Fuchsia Linux SDK from z_GRSMyHRsHjrpY48... to bnd4FFub2R9Q4mlAC... ( flutter/engine#46580 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 08:40:23 +00:00
skia-flutter-autoroll
0f46365721
Roll Skia from 7e025304e846 to e9b5e455ff8d (1 revision) ( flutter/engine#46575 )
...
https://skia.googlesource.com/skia.git/+log/7e025304e846..e9b5e455ff8d
2023-10-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c97b5ae9f547 to e12f70e0a324 (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 05:28:30 +00:00
skia-flutter-autoroll
33a98127c8
Roll Skia from 10b86aa8d8b7 to 0206ca4badc0 (1 revision) ( flutter/engine#46572 )
...
https://skia.googlesource.com/skia.git/+log/10b86aa8d8b7..0206ca4badc0
2023-10-05 armansito@google.com [graphite][viewer] Context options and UI for path renderer strategy
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 03:10:24 +00:00
skia-flutter-autoroll
79e76c5a3f
Roll Skia from 073737b7f4ab to 10b86aa8d8b7 (1 revision) ( flutter/engine#46570 )
...
https://skia.googlesource.com/skia.git/+log/073737b7f4ab..10b86aa8d8b7
2023-10-04 jvanverth@google.com Disable GrTessellationPathRenderer on webgl with intel driver
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-05 00:55:24 +00:00
Robert Ancell
53d379bfac
Use GdkEvent methods to access values, direct access is removed in GTK4. ( flutter/engine#46526 )
...
This should have no effect on the current implementation, and will be
one less thing needed when we migrate to GTK4.
2023-10-05 13:46:51 +13:00
Chris Yang
4ccef45a9a
[ios] Link PlatformView back to semantics tree ( flutter/engine#46471 )
...
The PlatformView does not have a semantics container when added to semantics tree, this PR gives it a semantics container to ensure accessibility traversal works.
This fixes https://github.com/flutter/flutter/issues/135504 , which is a regression of 738b1ad94d738b1ad94d738b1ad94dhttps://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-10-04 21:41:53 +00:00
skia-flutter-autoroll
93336de8dc
Roll Skia from d061d21eed0d to 073737b7f4ab (2 revisions) ( flutter/engine#46563 )
...
https://skia.googlesource.com/skia.git/+log/d061d21eed0d..073737b7f4ab
2023-10-04 egdaniel@google.com Make sure not to share texture allocations for offscreens going to a Vk SecondaryCB.
2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from d9ae2b91952e to 548271dcec9f (11 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-04 21:22:20 +00:00
skia-flutter-autoroll
e546f821df
Roll Dart SDK from 49561debc8d4 to b8fceaea291c (1 revision) ( flutter/engine#46559 )
...
https://dart.googlesource.com/sdk.git/+log/49561debc8d4..b8fceaea291c
2023-10-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.2.0-230.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC chinmaygarde@google.com ,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-04 20:01:23 +00:00
skia-flutter-autoroll
e93228e61f
Roll Fuchsia Linux SDK from tpiob-Qyh6oYiIznS... to z_GRSMyHRsHjrpY48... ( flutter/engine#46557 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-04 19:51:14 +00:00
skia-flutter-autoroll
abd2c03ede
Roll Skia from f6b7864d0325 to b3d65351b9ae (1 revision) ( flutter/engine#46556 )
...
https://skia.googlesource.com/skia.git/+log/f6b7864d0325..b3d65351b9ae
2023-10-04 robertphillips@google.com [graphite] Remove initial colorshader from PaintKey
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-04 19:26:00 +00:00
skia-flutter-autoroll
10705b9fba
Roll Skia from 49657f39d457 to f6b7864d0325 (5 revisions) ( flutter/engine#46554 )
...
https://skia.googlesource.com/skia.git/+log/49657f39d457..f6b7864d0325
2023-10-04 kjlubick@google.com Disable `__google_cxa_guard_acquire` on Windows as it is POSIX specific
2023-10-04 robertphillips@google.com [graphite] Allow zero Paint uniforms
2023-10-04 robertphillips@google.com [graphite] Add SolidColorShader::AddBlock
2023-10-04 drott@chromium.org Enable VSCode rust-analyzer to find Fontations project
2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from c572662924c3 to d9ae2b91952e (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-04 18:42:00 +00:00
skia-flutter-autoroll
0e412f42d1
Roll Skia from 387853af198f to 49657f39d457 (1 revision) ( flutter/engine#46544 )
...
https://skia.googlesource.com/skia.git/+log/387853af198f..49657f39d457
2023-10-04 robertphillips@google.com [graphite] Add ImageShaderBlock::AddBlock
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-04 14:22:24 +00:00
Brandon DeRosier
1cbd273449
[Impeller] Clarify coverage space. ( flutter/engine#46524 )
...
Update the coverage docstrings to clarify which space the coordinates are given in. Up until now, I've been using the phrase "screen space" to convey that coverage is counted in framebuffer pixels and is unaffected by the subpass transform basis. But a more accurate way to describe this would be "pass space", since it counts pixels relative to the top left corner of the framebuffer that the Entity is being drawn to during rendering.
2023-10-04 06:27:23 +00:00
skia-flutter-autoroll
d051a85e47
Roll Skia from 417a6383c59a to 8d45e7f1d4a4 (2 revisions) ( flutter/engine#46537 )
...
https://skia.googlesource.com/skia.git/+log/417a6383c59a..8d45e7f1d4a4
2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c97b5ae9f547 to e12f70e0a324
2023-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 0387aac67124 to c97b5ae9f547 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-04 06:16:05 +00:00
skia-flutter-autoroll
01f56591bd
Roll Fuchsia Linux SDK from SQrHxRVqMo5arcS3p... to tpiob-Qyh6oYiIznS... ( flutter/engine#46532 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-04 04:34:19 +00:00
Jia Hao
c2eecba786
[Impeller] Don't define CanvasRecorder if IMPELLER_TRACE_CANVAS is not set. ( flutter/engine#46476 )
...
Internal bug: b/303067268
https://github.com/flutter/engine/pull/46376 is causing a breakage to the internal engine build because of 543348a044/impeller/aiks/canvas_recorder.h (L58-L62)https://stackoverflow.com/questions/5246049/c11-static-assert-and-template-instantiation points us to the spec. In the later version (ISO/IEC 14882:2017(E)):
> The program is ill-formed, no diagnostic required, if ... no valid specialization can be generated for a template or a substatement of a constexpr if statement (9.4.1) within a template and the template is not instantiated,
<details>
<summary>The relevant section</summary>
</details>
Interpretation: the compiler can either choose to emit the error caused by the `static_assert` or not. Currently the compiler used by the build here on LUCI does not; internally it does.
For example, the following links shows that simply changing the Clang version affects whether the error appears or not for a minimal template.
- ok: https://godbolt.org/z/n9nYrcvcP
- not ok: https://godbolt.org/z/fWcvdcn35
Hence, `#ifdef` out the class instead of using a `static_assert` for more consistent behavior across these two toolchains.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2023-10-04 02:29:17 +00:00
skia-flutter-autoroll
aba0fcf6c5
Roll Skia from c66c89c56549 to 4cc56b6b3453 (1 revision) ( flutter/engine#46525 )
...
https://skia.googlesource.com/skia.git/+log/c66c89c56549..4cc56b6b3453
2023-10-03 jvanverth@google.com Move some functionality for PathAtlas into Compute and Raster.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,chinmaygarde@google.com,djsollen@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-10-03 22:51:04 +00:00
