Correctly handle the case where the TextEditingController associated
with a TextField is set to null. Due to a typo (= vs ==), previously
this was a no-op and the existing TextEditingController was retained,
rather than copied.
* Add IconThemeData adjustment to ListTile trailing element (makes consistent with leading element)
* Add test for ListTile theme changes
* Pull out and share IconThemeData variable between leading and trailing
* remove extra comma
* fix style nit
* Record original pointer event timestamp
* review
* review
* review
* Matched motions with iOS. Didn’t add overscroll spring clamps and fix tests yet.
* clamp max overscroll transfer
* Add test
* review notes, moved things around
* remove function passing indirection
* review
* Replace stopwatch with timestamp from #11988
* move static
* Review
This will enable both to be RTL'ed.
Also, factor out common border painting code into paintBorder.
Also, make Border paint uniform non-rounded borders using drawRect.
Also, add some documentation about an issue that wasted an hour of my life.
Also, factor out all the border painting code into TableBorder.paint.
* Allow FloatingActionButton to not have a heroTag.
* Allow FloatingActionButton to not have a child.
* Allow Tooltip to not have a child.
* Improve the debug output of the default FloatingActionButton hero tag.
* Improve the error message in the Hero clashing-tag case.
* Improve the debug output of the Hero widget.
* Improve the debug output of gesture-related widgets.
* Minor improvements to documentation.
* Fix some typos in comments.
* Fix some style nits.
* Allow apps to change the title margin in app bar.
* Fix documentation links and the shouldLayout function in the _ToolbarLayout
* Rename margin to spacing
* review comments
* Test fixes. Now we also test the width to make sure enough space is left for trailing widget
* Expose the middle spacing default and use it in app bar.
* Fix analyzer break
* Doc fixes due to review
* Make an app's supported locales configurable
* Added an supportedLocales.isNotEmpty assert
* WidgetsApp no longer const because supportedLocales.isNotEmpty
* updated per review feedback
* tweaked dartdoc to restart the build
* updated per review feedback
* Updated per review feedback
* Rename BannerLocation enum values
* topLeft -> topStart
* topRight -> topEnd
* bottomLeft -> bottomStart
* bottomRight -> bottomEnd
These names will make it easier for us to adjust the location of the
banner in right-to-left mode.
See the discussion on flutter-dev.
* Add RTL support for Banner
Fixes#11905
* Selectively apply margin between middle and leading
If ToolbarLayout does not have a leading widget, we should not put a margin between leading and middle areas since it ends up being blank space that looks odd. Fixes https://github.com/flutter/flutter/issues/11963
* Fix the failing test which is a good test case for missing leading widget
This patch just fixes the next and previous buttons to be in the proper
place. There might be other issues with the DatePicker, but this one was
obvious.
See #11377
* getOffsetToReveal deals with pinned slivers
If a Sliver can potentially be pinned at the edge of a viewport, getOffsetToReveal will take that into account and scroll further up/down to ensure that the object to reveal doesn't end up covered by a pinned sliver.
This is important for accessibility scrolling with app bars.
Since how much a pinned sliver is covering is dynamic (it can change with scroll offset, etc), getOffsetToReveal deals with the worst case and tries to ensure that the object to uncover is visible when the pinned slivers are at their max pinned extent.
* name fixes
* review feedback
* typos
* renaming
* fix analyzer
* fix test
* analyzer fixes
