DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
38,448 Commits 882 Branches 1,069 Tags
Commit Graph

13685 Commits

Author SHA1 Message Date
Jonah Williams
e263222f14 [Impeller] reland: switch Pipeline to use raw ptr instead of shared ptr for recorded references. (flutter/engine#57086) 
Prev: https://github.com/flutter/engine/pull/57015

There is a unit test that is clearing out the pipeline storage, manually null out captured PipelineRef.
 2024-12-10 21:18:46 +00:00
skia-flutter-autoroll
d8cdd81d3e Roll Skia from bd7d952398d5 to d541f1aa0c9b (3 revisions) (flutter/engine#57098) 
https://skia.googlesource.com/skia.git/+log/bd7d952398d5..d541f1aa0c9b

2024-12-10 kjlubick@google.com Reapply "Move SkJSON.h to //modules/jsonreader"
2024-12-10 tikuta@google.com add missing includes for the build with use_libcxx_modules
2024-12-10 kjlubick@google.com Make SkAAClip not reject large paths if clip is small enough.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jonahwilliams@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 19:17:11 +00:00
skia-flutter-autoroll
7df25145cc Roll Dart SDK from 1a28e6c86b09 to dd92932823d1 (1 revision) (flutter/engine#57096) 
https://dart.googlesource.com/sdk.git/+log/1a28e6c86b09..dd92932823d1

2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-231.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 17:44:29 +00:00
skia-flutter-autoroll
44532171ba Roll Dart SDK from d3a963b2f237 to 1a28e6c86b09 (3 revisions) (flutter/engine#57091) 
https://dart.googlesource.com/sdk.git/+log/d3a963b2f237..1a28e6c86b09

2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-230.0.dev
2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-229.0.dev
2024-12-10 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-228.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,jonahwilliams@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 13:31:31 +00:00
skia-flutter-autoroll
a2ffd3b55a Roll Fuchsia Linux SDK from tVShMDVFeKJFcDFHJ... to 5taAI9-tnFN84ZJvr... (flutter/engine#57090) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jonahwilliams@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 13:07:14 +00:00
skia-flutter-autoroll
8d24e8a0c7 Roll Dart SDK from 9694974b6d41 to d3a963b2f237 (1 revision) (flutter/engine#57072) 
https://dart.googlesource.com/sdk.git/+log/9694974b6d41..d3a963b2f237

2024-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-227.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 07:52:24 +00:00
skia-flutter-autoroll
66c89e1b8e Roll Skia from 949557697922 to bd7d952398d5 (3 revisions) (flutter/engine#57087) 
https://skia.googlesource.com/skia.git/+log/949557697922..bd7d952398d5

2024-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from ca6066d7097c to a42d0274444b (4 revisions)
2024-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from d91e98d1aa3f to 7e54d43d6905 (1 revision)
2024-12-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 22a8762fea90 to 6f3bd8a864bf (13 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 07:33:07 +00:00
skia-flutter-autoroll
2e891742b6 Roll Skia from 3a58be4817a8 to e11d70745224 (2 revisions) (flutter/engine#57082) 
https://skia.googlesource.com/skia.git/+log/3a58be4817a8..e11d70745224

2024-12-09 lukasza@chromium.org [rust png] Support for encoding `tEXt` chunks.
2024-12-09 kylechar@chromium.org Set FragmentState::constants

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-10 04:01:17 +00:00
gaaclarke
33306239b4 Revert "[Impeller] switch Pipeline to use raw ptr instead of shared ptr for recorded references." (flutter/engine#57079) 
Reverts flutter/engine#57015
fixes https://github.com/flutter/flutter/issues/160004
 2024-12-09 17:30:26 -08:00
gaaclarke
2695e35d9d moved device buffer to an untracked handle (flutter/engine#57021) 
fixes: https://github.com/flutter/flutter/issues/159745

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-09 23:00:57 +00:00
Jonah Williams
81d3d7fbca [Impeller] switch Pipeline to use raw ptr instead of shared ptr for recorded references. (flutter/engine#57015) 
Fixes https://github.com/flutter/flutter/issues/159566

We don't need recorded commands to keep pipelines alive as the context does that already.
 2024-12-09 20:42:03 +00:00
Brandon DeRosier
4b87db55c6 Roll Skia to 14f8f6d984ff (flutter/engine#57068) 
Resolves https://github.com/flutter/engine/pull/57068.

Set args `skia_use_libpng_decode=true` and `skia_use_rust_png_decode=false`.

https://skia.googlesource.com/skia.git/+log/e78dd0265002..14f8f6d984ff

2024-12-09 kjlubick@google.com Update GN build to allow for rust PNG decoding only
2024-12-09 lukasza@chromium.org [rust png] Update Skia => `png` dependency to version 0.17.15.
2024-12-09 kjlubick@google.com Add placeholder files for jsonreader
 2024-12-09 20:29:19 +00:00
skia-flutter-autoroll
15af0c4f83 Roll Dart SDK from 264c0c6f5894 to 9694974b6d41 (1 revision) (flutter/engine#57066) 
https://dart.googlesource.com/sdk.git/+log/264c0c6f5894..9694974b6d41

2024-12-09 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-226.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 18:21:06 +00:00
skia-flutter-autoroll
4037bf256a Roll Skia from afa77852dcde to e78dd0265002 (1 revision) (flutter/engine#57063) 
https://skia.googlesource.com/skia.git/+log/afa77852dcde..e78dd0265002

2024-12-09 kjlubick@google.com Reland "Remove JSON output from public API of SkSLDebugTrace"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 16:50:27 +00:00
skia-flutter-autoroll
9ff9419e6d Roll Fuchsia Linux SDK from BFJjwUVtBDA2mqqpH... to tVShMDVFeKJFcDFHJ... (flutter/engine#57058) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 11:47:23 +00:00
skia-flutter-autoroll
01c681d9b1 Roll Skia from c80d6609b95b to ac432c094232 (1 revision) (flutter/engine#57056) 
https://skia.googlesource.com/skia.git/+log/c80d6609b95b..ac432c094232

2024-12-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 48b61740d60f to ca6066d7097c (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,kjlubick@google.com,maxhudnell@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-09 07:33:32 +00:00
skia-flutter-autoroll
a9c77c889f Roll Fuchsia Linux SDK from __h1RRphItwU5H0tL... to BFJjwUVtBDA2mqqpH... (flutter/engine#57050) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-08 10:39:11 +00:00
skia-flutter-autoroll
fd266b33d7 Roll Skia from b37f1430f87a to d1e261ca7f6f (1 revision) (flutter/engine#57039) 
https://skia.googlesource.com/skia.git/+log/b37f1430f87a..d1e261ca7f6f

2024-12-07 jie.a.chen@intel.com [Graphite]: Use DawnTexelCopyBufferRowAlignment

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-07 10:26:23 +00:00
skia-flutter-autoroll
99c5f6e7f2 Roll Dart SDK from 67ce49b905f7 to 838ed940b056 (2 revisions) (flutter/engine#57037) 
https://dart.googlesource.com/sdk.git/+log/67ce49b905f7..838ed940b056

2024-12-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-223.0.dev
2024-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-222.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-07 02:05:05 +00:00
skia-flutter-autoroll
897529e800 Roll Fuchsia Linux SDK from DDdLABVLcqOv_axv-... to __h1RRphItwU5H0tL... (flutter/engine#57028) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-07 00:19:14 +00:00
skia-flutter-autoroll
849bf8bd37 Roll Skia from 0d94e966268b to c9e9ce277b80 (3 revisions) (flutter/engine#57024) 
https://skia.googlesource.com/skia.git/+log/0d94e966268b..c9e9ce277b80

2024-12-06 lokokung@google.com [dawn][headers] Update uses to new APIs and enums in buffer/queue.
2024-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 11d17e6bd029 to 94052ee8a2fb (2 revisions)
2024-12-06 danieldilan@google.com Reland "Initialize decompress struct with libjpeg-turbo's API"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-06 23:06:47 +00:00
skia-flutter-autoroll
0e4fafd629 Roll Skia from c9647f13cded to 0d94e966268b (36 revisions) (flutter/engine#57023) 
Roll Skia from c9647f13cded to 0d94e966268b (36 revisions)

https://skia.googlesource.com/skia.git/+log/c9647f13cded..0d94e966268b

2024-12-06 alecmouri@google.com Support PNG gainmaps
2024-12-06 danieldilan@google.com Revert "Initialize decompress struct with libjpeg-turbo's API"
2024-12-06 danieldilan@google.com Initialize decompress struct with libjpeg-turbo's API
2024-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 1e61e82b1b7a to 92c3ee90cfff (9 revisions)
2024-12-06 lukasza@chromium.org Reapply "[rust png] Extract `SkPngEncoderBase::onEncodeRows`."
2024-12-06 jvanverth@google.com Revert "Remove JSON output from public API of SkSLDebugTrace"
2024-12-06 jvanverth@google.com Revert "Move SkJSON.h to //modules/jsonreader"
2024-12-06 jvanverth@google.com Revert "[rust png] Extract `SkPngEncoderBase::onEncodeRows`."
2024-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 38268c8df30d to 1e61e82b1b7a (6 revisions)
2024-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 73c103d87739 to 48b61740d60f (9 revisions)
2024-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 0846b50db6b1 to 11d17e6bd029 (6 revisions)
2024-12-05 kjlubick@google.com Move SkJSON.h to //modules/jsonreader
2024-12-05 kjlubick@google.com Remove JSON output from public API of SkSLDebugTrace
2024-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 3ee07d9e3ba7 to 38268c8df30d (12 revisions)
2024-12-05 jamesgk@google.com [graphite] Add a test for unused target surface on replay
2024-12-05 jamesgk@google.com [graphite] Allow providing unused target surface on replay
2024-12-05 jamesgk@google.com Ignore all deferred canvas tests in Protected configs
2024-12-05 lukasza@chromium.org [rust png] Integrate Rust `png` crate into `SkPngRustEncoderImpl`.
2024-12-05 lukasza@chromium.org [rust png] Extract `SkPngEncoderBase::onEncodeRows`.
2024-12-05 briansalomon@gmail.com Show timer queries for Graphite/Dawn in Viewer stats
2024-12-05 lukasza@chromium.org [rust png] Extract `SkPngEncoderBase::getTargetInfo`.
2024-12-05 lukasza@chromium.org [rust png] Test that can detect encoding RGB vs RGBA mismatch.
2024-12-05 michaelludwig@google.com [ganesh] Check index count for overflow for good measure
2024-12-05 robertphillips@google.com Address some numerical instability in SkRRect::transform
2024-12-05 jamesgk@google.com [graphite] Support mipmapped deferred canvases
2024-12-05 kjlubick@google.com Add graphite-specific version of tools/DisplayParams
2024-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 0bb109aa3311 to e42047f0bbac (16 revisions)
2024-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ef19ac786024 to 0846b50db6b1 (6 revisions)
2024-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 2d420a4dcfc4 to 73c103d87739 (7 revisions)
2024-12-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from e0d7445de8cd to 3ee07d9e3ba7 (18 revisions)
2024-12-04 kjlubick@google.com Slightly improve readability of SkSwizzler_opts
2024-12-04 kjlubick@google.com Help type deduction for old compilers
2024-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 7adbb3e81110 to 0bb109aa3311 (14 revisions)
2024-12-04 jvanverth@google.com Catch some excessive loop cases in GrTriangulator.
2024-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 04ad645c0403 to 32e4afed6d80
2024-12-04 fmalita@chromium.org [svg] Conditional debugging

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...
 2024-12-06 21:38:39 +00:00
skia-flutter-autoroll
87af85b89c Roll Dart SDK from 9c9a333c496c to 67ce49b905f7 (2 revisions) (flutter/engine#57013) 
https://dart.googlesource.com/sdk.git/+log/9c9a333c496c..67ce49b905f7

2024-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-221.0.dev
2024-12-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-220.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-06 19:32:24 +00:00
Michael Goderbauer
75f9549553 Bump Dart SDK to 3.7 (flutter/engine#56989) 2024-12-06 01:41:03 +00:00
skia-flutter-autoroll
0773b06391 Roll Fuchsia Linux SDK from CCKZcL47N_2_vxAtS... to DDdLABVLcqOv_axv-... (flutter/engine#56988) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-05 22:14:05 +00:00
Tong Mu
f5325bf597 [Impeller] Add rounded superellipse (flutter/engine#56726) 
Support rounded superellipse.

Part of https://github.com/flutter/flutter/issues/139321 and
https://github.com/flutter/flutter/issues/13914, also related to
https://github.com/flutter/flutter/issues/91523.

### Open questions

* Alternative names:
  * Round**ed**Superellipse
  * Squircle
  * ContinuousBorderRectangle (or something like this...)
* I chose rounded superellipse because this name, albeit its length,
precisely describe this shape. "Squircle" is not strictly defined but
generally refers any shape intermediate between a rectangle and a
circle.
* Alternative definition for `corner_radius`:
* Currently the `corner_radius` corresponds to SwiftUI parameters. To
make the shape definition more generalized, we can instead define the
`corner_radius` to be the radius of the corner circles, and make the
framework do a look up table.
* The down side is, not only the work to re-calculate the table, but
also that it doesn't completely eliminates the relationship with
SwiftUI, since currently the degree of the superellipse (`n`) is also
mapped from the SwiftUI `cornerRadius`, which is not necessary for the
shape per se.
* To some extent it boils down to the question of whether we'd like this
shape to support anything beyond SwiftUI.

### Demo


https://github.com/user-attachments/assets/806ac0e9-d62f-4b04-ab6a-83436a11f6f3

Low ratio: (900, 900, 445)

<img width="520" alt="image"
src="https://github.com/user-attachments/assets/54087467-85cd-4021-91cc-a948866ab5a8">

Mid ratio: (900, 650, 180)

<img width="508" alt="image"
src="https://github.com/user-attachments/assets/460a4927-0396-462b-948d-0846a781c92c">

High ratio: (900, 650, 17)

<img width="490" alt="image"
src="https://github.com/user-attachments/assets/8d7f625d-8a3b-4aba-b3f9-f292b874b606">


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-12-05 11:27:20 -08:00
gaaclarke
4931dd81fb Moved gles pipelines to untracked handles. (flutter/engine#56955) 
issue: https://github.com/flutter/flutter/issues/159745

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-05 19:21:18 +00:00
skia-flutter-autoroll
5cb8e71fd5 Roll Dart SDK from a2a9428e761f to 56bbedca60f9 (7 revisions) (flutter/engine#56980) 
https://dart.googlesource.com/sdk.git/+log/a2a9428e761f..56bbedca60f9

2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-216.0.dev
2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-215.0.dev
2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-214.0.dev
2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-213.0.dev
2024-12-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-212.0.dev
2024-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-211.0.dev
2024-12-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-210.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC bdero@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-05 18:41:21 +00:00
Alexander Aprelev
e05a44277f Manual roll dart to 470117150f34d712ee6d8c4558b3c656d973f656 (flutter/engine#56915) 
Roll dart to 470117150f34d712ee6d8c4558b3c656d973f656

Changes since last roll

```
470117150f3 Version 3.7.0-208.0.dev
10867627709 CHANGELOG: move AOT invocation bits to the end of the 3.7 section
83863711d3b Migrate NotImportedCompletionPass.
e01bbdfd1f4 Deprecate completions from plugins api.
2a2905228fb Add extension on Completer to simplify code.
05696d50ccf Migrate postfix_completion.dart, statement_completion.dart.
ed49d04e2e0 [analysis_server] Extract some shared code from editableArguments to be used by editArgument
c54255fe9db [element model] migrate `prefer_asserts_in_initializer_lists`
eaf3912b5d6 [deps] rev core, ecosystem, glob, http_multi_server, lints, markdown, package_config, pool, protobuf, pub_semver, shelf, source_maps, source_span, stack_trace, stream_channel, string_scanner, sync_http, term_glyph, test, test_descriptor, test_process, test_reflective_loader, tools, vector_math, watcher, web, web_socket_channel, webdriver, webkit_inspection_protocol, yaml, yaml_edit
11a11259724 Switch boringssl to the pre-generated GN source list.
a635ccf2f57 [analysis_server] Only mark positional arguments as editable if they wouldn't require inserting additional values
619c8511aba [analysis_server] Add tests for formatter language version for legacy protocol
a8f5e64a330 Roll Fuchsia Test Scripts from 6FgM4KTbxxmyYoiOs... to VilXq4eGH5A24wRWA...
623c574b817 [vm] Clean up few isolate fields.
bfb507a3af9 Migrate utilities.dart
06caa3fa11e [DAS] Adds new import with show option
0197beaa8e0 [flow analysis] Remove _typeContains method.
56b6e5b9f60 Json codable no type assumption in custom fromJson
e013a4c9bfa [analysis_server] Add some notes on how to use the CPU Profiler for the analysis server hosted by VS Code
0f723b3ef3c [vm] Fix build on gcc 14.2.0.
```

This is manual roll because dart_boringssl_gen_rev is no longer present
in dart sdk DEPS has to be removed from flutter engine DEPS manually.
 2024-12-04 17:03:02 +00:00
skia-flutter-autoroll
97585bd038 Roll Skia from 4ad05fb042c5 to c9647f13cded (2 revisions) (flutter/engine#56933) 
https://skia.googlesource.com/skia.git/+log/4ad05fb042c5..c9647f13cded

2024-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 667c4e94b4a5 to 2d420a4dcfc4 (3 revisions)
2024-12-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ecd0b68434f4 to e0d7445de8cd (17 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-04 07:45:06 +00:00
Robert Ancell
dcc250c8a5 Split keyevent channel into own class (flutter/engine#56911) 
Split the channel messaging out of the system channels to make them
simpler to understand and refactor.

The new channel classes could be automatically generated in a second
phase, e.g. using Pigeon to reduce code usage.
    
The new classes don't have tests as they will already be covered by the
existing code.
 2024-12-04 11:57:05 +13:00
skia-flutter-autoroll
ffeb7d4629 Roll Skia from 8dc8bdc364f5 to e02d856f86fb (3 revisions) (flutter/engine#56926) 
https://skia.googlesource.com/skia.git/+log/8dc8bdc364f5..e02d856f86fb

2024-12-03 kjlubick@google.com Reland "Minor cleanups with AutoSTArray and AutoSTMalloc"
2024-12-03 jlavrova@google.com SkFontMgr_Android refactoring
2024-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from f7cac0bb8d2f to 7adbb3e81110 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC bdero@google.com,jvanverth@google.com,kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 20:56:06 +00:00
skia-flutter-autoroll
4b8d901453 Roll Fuchsia Linux SDK from j424tGVlulTUzBtPj... to CCKZcL47N_2_vxAtS... (flutter/engine#56921) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC bdero@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 17:32:36 +00:00
skia-flutter-autoroll
32443d0305 Roll Skia from 3db026d62805 to d6d1feba94d9 (2 revisions) (flutter/engine#56917) 
https://skia.googlesource.com/skia.git/+log/3db026d62805..d6d1feba94d9

2024-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 963fb6511438 to 667c4e94b4a5 (4 revisions)
2024-12-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from dbff5894310b to ecd0b68434f4 (18 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jvanverth@google.com,kjlubick@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 07:07:41 +00:00
skia-flutter-autoroll
3cb4a84de6 Manual roll Dart SDK from c579d193341d to 61bfa9bbb91d (1 revision) (flutter/engine#56909) 
Manual roll requested by asiva@google.com

https://dart.googlesource.com/sdk.git/+log/c579d193341d..61bfa9bbb91d

2024-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-207.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC asiva@google.com,dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-03 00:39:26 +00:00
skia-flutter-autoroll
a7db4d6b56 Roll Skia from d7751d3d6ff4 to 2c4ce1d953ba (5 revisions) (flutter/engine#56901) 
https://skia.googlesource.com/skia.git/+log/d7751d3d6ff4..2c4ce1d953ba

2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from 5a657da0d714 to dbff5894310b (35 revisions)
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from d4f01d560853 to b2e692629c1f (1 revision)
2024-12-02 jvanverth@google.com [graphite] Missed one WebGPU adapter change
2024-12-02 kjlubick@google.com Revert "Minor cleanups with AutoSTArray and AutoSTMalloc"
2024-12-02 jvanverth@google.com [graphite] Fix issue with combining clips.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC jvanverth@google.com,kjlubick@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 20:16:08 +00:00
Tristan Ross
3ca2049252 [ci] use env for format and support arm64 hosts (flutter/engine#56268) 
Fixes running x64 binaries on arm64 hosts, this fixes systems like Raspberry Pi's, Apple Silicon, and Ampere.

Before, I would get something like:
```
Checking GN formatting...
Completed checking 0 GN files with no formatting problems.
Checking Java formatting...
No Java files with changes, skipping Java format check.
Checking Python formatting...
All python files formatted correctly.
Checking for trailing whitespace on 1 source file...
No trailing whitespace found.
No header files with changes, skipping header guard check.
Checking C++/ObjC/Shader formatting...
ERROR: Formatter command '/home/ross/flutter-engine/src/flutter/buildtools/linux-x64/clang/bin/clang-format --style=file shell/platform/linux/fl_application_test.cc' failed with exit code 255. Command output follows:

qemu-x86_64: Could not open '/lib64/ld-linux-x86-64.so.2': No such file or directory

Completed checking 0 C++/ObjC/Shader files with no formatting problems
```

Now it just works, I also changed the shell script to use env since `/bin/bash` doesn't exist on NixOS so using env is a more portable solution.

*List which issues are fixed by this PR. You must list at least one issue.*

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-12-02 19:04:32 +00:00
gaaclarke
e40835cb89 [impeller] makes UniformBindData 15% faster and adds unit test (flutter/engine#56844) 
issue: https://github.com/flutter/flutter/issues/159177

The improvements come from using absl::flat_hash_map.

measurements with std vs absl (`host_profile_arm64`):
```
# Std
0.041124
0.0398002
0.0396546
0.0405552
0.0397742

# Absl
0.0353708
0.0336834
0.0338616
0.033050
0.0331976
```

Benchmark used
```c++
TEST(BufferBindingsGLESTest, BindUniformDataMicro) {
  BufferBindingsGLES bindings;
  absl::flat_hash_map<std::string, GLint> uniform_bindings;
  uniform_bindings["SHADERMETADATA.FOOBAR"] = 1;
  bindings.SetUniformBindings(std::move(uniform_bindings));
  std::shared_ptr<MockGLES> mock_gl = MockGLES::Init();
  MockAllocator allocator;
  Bindings vertex_bindings;

  ShaderMetadata shader_metadata = {
      .name = "shader_metadata",
      .members = {ShaderStructMemberMetadata{.type = ShaderType::kFloat,
                                             .name = "foobar",
                                             .offset = 0,
                                             .size = sizeof(float),
                                             .byte_length = sizeof(float)}}};
  std::shared_ptr<ReactorGLES> reactor;
  std::shared_ptr<Allocation> backing_store = std::make_shared<Allocation>();
  ASSERT_TRUE(backing_store->Truncate(Bytes{sizeof(float)}));
  DeviceBufferGLES device_buffer(DeviceBufferDescriptor{.size = sizeof(float)},
                                 reactor, backing_store);
  BufferView buffer_view(&device_buffer, Range(0, sizeof(float)));
  vertex_bindings.buffers.push_back(BufferAndUniformSlot{
      .slot =
          ShaderUniformSlot{
              .name = "foobar", .ext_res_0 = 0, .set = 0, .binding = 0},
      .view = BufferResource(&shader_metadata, buffer_view)});
  Bindings fragment_bindings;
  int32_t count = 5'000'000;
  auto start = std::chrono::high_resolution_clock::now();
  for (int32_t i = 0; i < count; ++i) {
    bindings.BindUniformData(mock_gl->GetProcTable(), allocator,
                             vertex_bindings, fragment_bindings);
    if (i % 100 == 0) {
      mock_gl->GetCapturedCalls();
    }
  }
  auto end = std::chrono::high_resolution_clock::now();
  auto duration =
      std::chrono::duration_cast<std::chrono::microseconds>(end - start)
          .count();
  std::cout << "Execution time: " << duration / static_cast<double>(count)
            << " microseconds" << std::endl;
}
```

This is one of our hottest symbols on the raster thread:

<img width="1528" alt="Screenshot 2024-11-27 at 2 27 54 PM"
src="https://github.com/user-attachments/assets/a9029d6f-ee96-4612-83f1-6b69f24e6ce8">

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-12-02 10:46:29 -08:00
skia-flutter-autoroll
f92abcbbbe Roll Skia from dd70c8e1c38f to d7751d3d6ff4 (36 revisions) (flutter/engine#56898) 
Roll Skia from dd70c8e1c38f to d7751d3d6ff4 (36 revisions)

https://skia.googlesource.com/skia.git/+log/dd70c8e1c38f..d7751d3d6ff4

2024-12-02 kjlubick@google.com Minor cleanups with AutoSTArray and AutoSTMalloc
2024-12-02 fmalita@google.com Update SkVideoEncoder for new ffmpeg
2024-12-02 jvanverth@google.com [graphite] Update GraphiteDawnTestContext to new Adapter interface
2024-12-02 kjlubick@google.com Add Rust-based PNG decoder tests to CQ
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a2d76f039918 to f7cac0bb8d2f (6 revisions)
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 846022101a6f to 963fb6511438 (2 revisions)
2024-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d897b7ac1f75 to e0222e69ea90 (1 revision)
2024-11-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ef4dc615f82d to d897b7ac1f75 (1 revision)
2024-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2dc072ec71cc to a2d76f039918 (10 revisions)
2024-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from dad165201f86 to ef4dc615f82d (3 revisions)
2024-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b24f37dbbe4a to 846022101a6f (2 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b7e10ed68dd0 to dad165201f86 (3 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 2e25ea1e727e to 2dc072ec71cc (8 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 594fe3cae8c3 to b24f37dbbe4a (5 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 01354c07cdb2 to 5a657da0d714 (18 revisions)
2024-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ecc3cdc4d28b to b7e10ed68dd0 (10 revisions)
2024-11-27 epeev@google.com Reland "Reland "SkCodec: Remove the sysprop guard for SkCrabbyAvifCodec""
2024-11-27 kjlubick@google.com Remove redundant SkDoubleIsNaN function
2024-11-27 kjlubick@google.com Fix SIMD compilation error for GCC 8.x and below
2024-11-27 kjlubick@google.com Make SK_NO_SANITIZE more compatible with GCC
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 2c7a7bff0512 to d4f01d560853 (1 revision)
2024-11-27 kjlubick@google.com Remove sk_path_analyze_verbs() from include/private
2024-11-27 kjlubick@google.com Squelch warning with microhttplib and newer GCC versions
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from cecefe53430a to 2e25ea1e727e (8 revisions)
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 08d21277b1a1 to ecc3cdc4d28b (1 revision)
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from dbdf344026c9 to 594fe3cae8c3 (7 revisions)
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 27f9f8696a43 to 01354c07cdb2 (21 revisions)
2024-11-27 briansalomon@gmail.com Enable gpu timer query for Graphite/Dawn
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from 52028e548417 to bd94aa86becd
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 7bdb025e3cbb to 9481c3eb25d2
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 99d4627f212e to fb2d48f7af98
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 9e05eb5b9edb to e9a6ea69ff3d
2024-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 915d114daeb2 to 08d21277b1a1 (3 revisions)
2024-11-26 lukasza@chromium.org [rust png] Delete `SkPngRustDecoder.h` from the old location.
2024-11-26 lukasza@chromium.org [rust png] Revert adding `png_codec_base_...` to `skia_codec_rust_png`.
2024-11-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 10c2dc7a1b4b to cecefe53430a (29 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,jvanverth@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

...
 2024-12-02 18:39:10 +00:00
skia-flutter-autoroll
0a4305b5d4 Roll Dart SDK from 5785058c9bb1 to 46630dbefbbd (12 revisions) (flutter/engine#56897) 
https://dart.googlesource.com/sdk.git/+log/5785058c9bb1..46630dbefbbd

2024-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-205.0.dev
2024-12-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-204.0.dev
2024-12-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-203.0.dev
2024-11-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-202.0.dev
2024-11-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-201.0.dev
2024-11-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-200.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-199.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-198.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-197.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-196.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-195.0.dev
2024-11-28 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.7.0-194.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 17:44:56 +00:00
Jason Simmons
d28811c8f3 Roll Dart SDK from 0740ded7b9bf to 5785058c9bb1 (5 revisions) (flutter/engine#56886) 
Includes updates to licenses_flutter related to the roll of BoringSSL

https://dart.googlesource.com/sdk.git/+log/0740ded7b9bf..5785058c9bb1

2024-11-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-193.0.dev
2024-11-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-192.0.dev
2024-11-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-191.0.dev
2024-11-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-190.0.dev
2024-11-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.7.0-189.0.dev
 2024-12-02 08:16:29 -08:00
skia-flutter-autoroll
fbbac70e24 Roll Fuchsia Linux SDK from pc49rc4B22IXqigQ-... to j424tGVlulTUzBtPj... (flutter/engine#56889) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 16:15:57 +00:00
skia-flutter-autoroll
d78fb06705 Roll Skia from f149f852c70a to dd70c8e1c38f (4 revisions) (flutter/engine#56814) 
https://skia.googlesource.com/skia.git/+log/f149f852c70a..dd70c8e1c38f

2024-11-26 lukasza@chromium.org [rust png] Extract a separate `src/codec:png_codec_base` Bazel target.
2024-11-26 kjlubick@google.com Inline GpuToolUtils MakeTextureImage
2024-11-26 kjlubick@google.com Extract tools/graphite/GraphiteToolUtils as its own files
2024-11-26 kjlubick@google.com Reland "Change window::DisplayParams to be immutable and passed by pointer"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,danieldilan@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-12-02 16:13:57 +00:00
skia-flutter-autoroll
c60b625dce Roll Fuchsia Linux SDK from oJzuSXcrUmaw5Ck2g... to pc49rc4B22IXqigQ-... (flutter/engine#56876) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-29 13:16:34 +00:00
skia-flutter-autoroll
8b237d39d5 Roll Fuchsia Linux SDK from u0agumUB4Ag6cTiKk... to oJzuSXcrUmaw5Ck2g... (flutter/engine#56853) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-28 04:03:18 +00:00
Chris Bracken
2afb790cad Reland: iOS: Migrate PlatformViewsController to Objective-C (flutter/engine#56828) 
This migrates PlatformViewController from C++ to Objective-C. Generally, we try to keep the embedder interfaces and components written in Objective-C except for the few places where C++ interfaces are requried to interface with engine APIs such as Shell and PlatformView (e.g. the PlatformViewIOS subclass). Now that the implementation is Objective-C, the class and file are renamed to match Objective-C naming conventions.

This allows us to take advantage of ARC and weak references, which eliminates the need for std::shared_ptr, fml::WeakPtr etc. Further, this eliminates some particularly unintuitive behaviour wherein this class was owned via a std::shared_ptr held by FlutterEngine, and injected into many other classes (e.g. AccessibilityBridge) via a std::shared_ptr& reference -- such that only one instance of the std::shared_ptr actually ever existed, presumably to avoid std::shared_ptr refcounting overhead. Given that this overhead was only incurred a single time at engine initialisation, this seems like overkill. One might ask why it wasn't therefore held in a `std::unique_ptr` and a `std::unique_ptr&` reference passed around. Likely, this was because we wanted to take a `fml::WeakPtr` reference on it.

Regardless, none of this is necessary any longer now that we can inject `__weak FlutterPlatformViewsController*` instances to classes that use it.

To be clear, this patch makes no attempt whatsoever to simplify or clean up the interface or implementation of this class. This class ties together far too many concepts and is injected into far too many places, and we should break it up and simplify it. However, the goal of this patch was simply to port to an Objective-C interface that plays nicely with the rest of the iOS embedder. This does include a couple minor cleanups in `#include`/`#import` order and usage to match our style guide.

This is a reland with a one-line fix of a lambda-capture block to ensure `self` and any local variables are captured by value rather than by reference:
* In the case where this method is called on the platform thread (i.e. where the UI and platform thread are merged), we use the latch to pause the calling thread until the lambda completes, in which case all locals could be passed by reference since the locals are guaranteed to hang around until the lambda completes and signals the latch.
* In the case where this method is called from the UI thread (i.e. where UI and platform thread are not merged), locals may have gone out of scope by the time the lambda executes, leading to undefined behaviour if passed by reference; thus we always pass by value to be sure; since `latch` must be shared between threads, it's passed held in a `std::shared_ptr` so the underlying latch/mutex is shared but it's kept live until it goes out of scope in both threads.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-27 04:11:25 +00:00
skia-flutter-autoroll
7510d84598 Roll Fuchsia Linux SDK from 50xtjbMWWrqay_7m_... to u0agumUB4Ag6cTiKk... (flutter/engine#56823) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-27 00:14:34 +00:00
Jim Graham
0c245ce56b [DisplayList] Delete (publicly) unused DlColorColorSource (flutter/engine#56825) 
While recently updating the DlColorSource sources I noticed some questionably implementation choices in the Color variant of the color sources.

I then realized that there was no public use of these classes (other than mostly their own unit tests) and so they should be deleted to focus on implementing the variants that are actually used by Flutter.
 2024-11-27 00:13:22 +00:00
Jim Graham
2a55c9edd8 [DisplayList] migrate DlColorFilter objects to new source layout (flutter/engine#56785) 
A new source code/header structure was introduced when the DlColorSource and DlImageFilter objects were migrated to Impeller geometry classes. Even though the DlColorFilter objects did not depend on Skia geometry objects, they need to be updated to the new source layout for consistency.
 2024-11-26 20:48:20 +00:00
Chris Bracken
52661e51c0 Revert "iOS: Migrate PlatformViewsController to Objective-C (#56790)" (flutter/engine#56817) 
This is a combination of 3 reverts, required to get back to the revert that caused `ios_platform_view_tests` to start failing in the framework repo. In reverse chronological order, this reverts two trivial commits plus the non-trivial commit that likely caused the breakage:

* Revert "iOS: Eliminate global in platformviews controller (#56805)" This reverts commit cea4600caa7098fa7ec109d18b869db46cda726a.
* Revert "iOS: Delete FlutterPlatformViewsController.layerPoolSize (#56806)" This reverts commit 80fa8a590876e0d29055b9ddbfa8670c1f83759e.
* Revert "iOS: Migrate PlatformViewsController to Objective-C (#56790)" This reverts commit afd05afc406deb79fbe9c16684aeeeb19322b288.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-11-26 19:52:13 +00:00