Pierre-Louis
15aa3bfda3
turn on curly_braces_in_flow_control_structures for develop-facing code ( #105113 )
2022-06-02 11:25:40 +02:00
Hans Muller
9cf042ec74
Revert "Added MaterialStatesController, updated InkWell et al. ( #103167 )" ( #105138 )
...
This reverts commit 180566f2e59928912c893cc0e8a12f97e653c206.
2022-06-01 17:19:16 -07:00
Pierre-Louis
5d10cf550f
Add actionsPadding to dialog theme ( #105109 )
...
* add actionsPadding to dialog theme and refactor
* fix typo
* remove trailing spaces
2022-06-01 15:52:18 +02:00
Pierre-Louis
51b2c488c7
Fix actions padding for M3 alert dialogs ( #105008 )
...
* update docs
* use correct actions padding for dialogs
* remove trailing spaces
* Update dialog_theme.dart
* Update packages/flutter/lib/src/material/dialog.dart
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
Co-authored-by: Taha Tesser <tessertaha@gmail.com>
2022-06-01 10:43:16 +02:00
Jason Simmons
116d6579c7
Remove remaining uses of hashValues in the framework ( #105046 )
2022-05-31 15:48:14 -07:00
Taha Tesser
ee274fde1d
Fix showSearch query text field doesn't show toolbar initially when field is empty. ( #105023 )
2022-05-31 14:48:10 -07:00
Alexandre Ardhuin
552c50e67c
more const immutable classes ( #104988 )
...
* more const immutable classes
* more const constructors in dev/ and examples/
2022-05-31 21:56:24 +02:00
Greg Spencer
16b7348155
Switch debugAssertNotDisposed to be a static ( #104772 )
...
This reverts part of the change made in #103456 to expose a debug check for subclasses of ChangeNotifier to avoid code duplication. Instead of making debugAssertNotDisposed a public instance function, it is now a public static function. It makes it harder to call, slightly, but it means that everyone who implemented ChangeNotifier instead of extending it doesn't get broken.
2022-05-31 10:33:46 -07:00
Jonas Uekötter
f9ac22a426
Improve PlatformException#stacktrace docs for Android ( #104331 )
2022-05-31 09:33:12 -07:00
Taha Tesser
71a9ccbf2c
InheritedModel: Add a complete interactive example and update snippet for null safety (#104174 )
2022-05-30 06:13:10 -07:00
Bruno Leroux
c68fd6a31a
Add troubleshooting doc for MediaQueryData.size ( #104828 )
2022-05-28 23:43:06 -07:00
Justin McCandless
c135cd340d
MacOS transpose keyboard shortcut ( #104457 )
...
Implements ctrl-T to transpose characters on Mac and iOS
2022-05-27 16:10:32 -07:00
爱折腾的小竹同学
40e7e9ad8e
fix: assert does not match annotation ( #104606 )
2022-05-27 15:18:07 -07:00
Markus Aksli
62eebb4922
Hide SelectableRegion text selection toolbar when orientation changes ( #104841 )
2022-05-27 13:13:13 -07:00
Jonah Williams
8d2978af64
use immutable buffer for loading asset images ( #103496 )
2022-05-27 12:23:12 -07:00
Kate Lovett
2aa7317296
Revert "Add error message and documentation when a SnackBar is off screen" ( #104843 )
2022-05-27 11:58:14 -07:00
Justin McCandless
b7a425f196
Right click on selection when unfocused should re-focus ( #104666 )
...
Bug fix for focusing a field with right click on existing selection (Mac and iOS)
2022-05-27 09:41:03 -07:00
chunhtai
d09e454889
Fixes a bug when dragging selection handle sends events in wrong coor… ( #104739 )
...
* Fixes a bug when dragging selection handle sends events in wrong coordinates system
* remove comments
* addressing comments
2022-05-27 09:29:50 -07:00
Hans Muller
180566f2e5
Added MaterialStatesController, updated InkWell et al. ( #103167 )
2022-05-27 08:38:42 -07:00
chunhtai
6a88c221d5
SelectableRegion does not merge child semantics nodes ( #104659 )
2022-05-26 15:40:09 -07:00
Greg Spencer
3e7e01c893
Remove extraneous InheritedWidget ( #104676 )
...
When I removed Shortcuts.of and Shortcuts.maybeOf, I forgot to also remove the associated InheritedWidget. This does that.
2022-05-26 15:25:48 -07:00
Justin McCandless
91836d6a62
its => it ( #104730 )
...
Just a small grammar fix in the PipelineOwner docs.
2022-05-26 12:59:03 -07:00
Bruno Leroux
bc53e6202e
Add error message and documentation when a SnackBar is off screen ( #102073 )
2022-05-26 05:15:07 -07:00
Nils Reichardt
5764b5dd67
Fix typo "technicallv" in editable_text.dart ( #104701 )
2022-05-26 13:22:47 +02:00
Pierre-Louis
2aa348b940
Use curly_braces_in_flow_control_structures for widgets ( #104609 )
...
* Use `curly_braces_in_flow_control_structures` for `widgets`
* fix comments
* fix comments
2022-05-26 09:48:09 +02:00
Pierre-Louis
332c22f391
Update links to material library docs ( #104392 )
...
* Update links to `material` library docs
* outsmart bot heuristics
2022-05-26 08:56:35 +02:00
gaaclarke
20a9f1d8d7
Added option for Platform Channel statistics and Timeline events ( #104531 )
2022-05-25 18:43:11 -07:00
Taha Tesser
a9c71d7e23
[Reland]: Fix DropdownButton menu clip ( #104251 )
2022-05-25 14:58:09 -07:00
Greg Spencer
406d86b4ba
PlatformMenuBar changes to bring it into line with upcoming MenuBar implementation ( #104565 )
...
When I was doing the MenuBar implementation, I made some changes to the PlatformMenuBar to allow it to understand shortcuts a little more, and to deprecate the body parameter rename it to child to match most other widgets.
These are those changes, separated out because they are separable, and I'm trying to make the MenuBar PR smaller.
2022-05-25 14:48:28 -07:00
xubaolin
6efdf0ae7b
fix a _DraggableScrollableSheetScrollPosition update bug ( #103328 )
2022-05-25 14:48:10 -07:00
Jonas Uekötter
9f856ac182
Improve PlatformMenu MenuItem documentation ( #104321 )
2022-05-25 14:43:12 -07:00
Kate Lovett
fe04647651
Include forceElevated for scrolledUnder in new SliverAppBar variants ( #104536 )
2022-05-25 14:23:13 -07:00
Tomasz Gucio
2e7cea6dfe
Dispose ValueNotifier instances in RenderEditable ( #104591 )
2022-05-25 13:13:11 -07:00
Tomasz Gucio
aa1c43bbde
Dispose ValueNotifier in EditableTextState ( #104590 )
2022-05-25 13:08:11 -07:00
Markus Aksli
b05741cbad
Hide the text selection toolbar on mobile when orientation changes ( #103512 )
2022-05-25 13:03:16 -07:00
xubaolin
5a9196737d
[Slider]The initial value of discrete slider should respect the discrete values ( #103966 )
...
Fixes #103965
2022-05-25 12:55:13 -07:00
Tomasz Gucio
7a2b187c7b
Dispose ValueNotifier instances in LicensePage state classes ( #104589 )
2022-05-25 11:23:11 -07:00
Pierre-Louis
a0248ebdf2
Use curly_braces_in_flow_control_structures for services, scheduler, semantics ( #104616 )
2022-05-25 19:58:22 +02:00
Pierre-Louis
e71eb183d8
Use curly_braces_in_flow_control_structures for rendering ( #104611 )
...
* Use `curly_braces_in_flow_control_structures` for `rendering`
* fix comments
* fix dangling
2022-05-25 19:57:57 +02:00
Pierre-Louis
b0aa50255b
Use curly_braces_in_flow_control_structures for animations, cupertino ( #104612 )
...
* Use `curly_braces_in_flow_control_structures` for `animation`
* Use `curly_braces_in_flow_control_structures` for `cupertino`
* fix comments
2022-05-25 19:56:20 +02:00
Pierre-Louis
9cc72df781
Use curly_braces_in_flow_control_structures for foundation, gestures, painting, physics ( #104610 )
...
* Use `curly_braces_in_flow_control_structures` for `foundation`
* Use `curly_braces_in_flow_control_structures` for `gestures`
* Use `curly_braces_in_flow_control_structures` for `painting`
* Use `curly_braces_in_flow_control_structures` for `physics`
* fix comments
* remove trailing space
* fix TODO style
2022-05-25 19:55:22 +02:00
Greg Spencer
da24f105bd
Removing Shorcuts.of and Shortctus.maybeOf ( #104215 )
...
This removes Shorcuts.of and Shortctus.maybeOf because they're not especially useful, since the only thing you can really set on a ShortcutManager is the shortcuts, and the Shortcuts widget that you give it to manages those, so if it rebuilds, it overwrites what you set.
Also, adds a Shortcuts.manager constructor and removes the manager argument to the Shortcuts widget.
Removing these will also eliminate an InheritedWidget for each Shortcuts widget, improving memory usage.
2022-05-25 10:16:08 -07:00
Greg Spencer
0a417c3b49
A bunch of cleanups and a missing ShortcutRegistar in WidgetsApp ( #104560 )
...
A bunch of random cleanup things I found while doing MenuBar development.
Changes an if test to an assert in binding.dart, since the if should always be true.
Adds the default ShortcutRegistrar that should have been in the ShortcutRegistry PR.
Moves a debug message in the FocusManager to print the result after the focus change instead of before.
Reorders the test parameters in theme_data_test.dart to match the order of the theme data fields everywhere else.
2022-05-25 09:32:46 -07:00
Taha Tesser
78a0d3d4e2
[reland] Migrate ListTile TextTheme TextStyle references to Material 3 ( #102167 )
2022-05-25 07:28:12 -07:00
Pierre-Louis
cb9a1d623c
Use curly_braces_in_flow_control_structures for material ( #104499 )
...
* Use `curly_braces_in_flow_control_structures` for `material`
* include test/material
* add back removed comments
2022-05-25 13:17:06 +02:00
Taha Tesser
97452d1a10
Switch: Add an interactive example (#103045 )
...
* `Switch`: Add an interactive examples
* Update docs
* Update doc
2022-05-25 10:40:31 +02:00
Jonah Williams
680a8192b0
[framework] ensure ink sparkle is disposed ( #104569 )
2022-05-24 21:23:09 -07:00
Yang Chao
b5adbee145
Fix an issue that clearing the image cache may cause resource leaks ( #104527 )
2022-05-24 16:58:09 -07:00
Bruno Leroux
1e0a1a2661
Add an example and update GestureDetector documentation ( #102360 )
2022-05-24 16:38:09 -07:00
chunhtai
efb9368573
Supports global selection for all devices ( #95226 )
...
* Support global selection
* addressing comments
* add new test
* Addressing review comments
* update
* addressing comments
* addressing comments
* Addressing comments
* fix build
2022-05-24 13:53:55 -07:00