114 Commits

Author SHA1 Message Date
Alexandre Ardhuin
218d98f4d8
Operator equals (#19303)
* use Object for operator==

* apply style guide for operator==
2020-06-30 23:16:31 +02:00
nturgut
d758e069da
collect logs using the new web_installers repo (#19298) 2020-06-25 10:27:53 -07:00
nturgut
2c04b9ab8e
skip ios safari tests on felt level (#19280)
* skip ios safari tests on felt level

* instead of skipping use the new web_installers repo

* re-skip the test. led run failed with another error

* remove led json
2020-06-24 20:51:38 -07:00
nturgut
3fcf5463b9
Run IOS unit tests on LUCI (#19141)
* change the version of simulator. luci bots only has 13.0

* skip failing pointer binding tests

* skip path_metrics (canvaskit) and a method from surface_test

* fix analyzer errors

* remove extra added touch event context test

* removing left overs for screenshot debugging

* apply reviewers suggestion for skipping tests
2020-06-23 15:22:01 -07:00
nturgut
683cc1594d
Enable firefox integration tests (#19164)
* firefox integration tests enable

* addressing reviewer comments
2020-06-22 13:16:57 -07:00
nturgut
a358e99a6e
[web] Running integration tests on Safari on Local (#18488)
* rebase. carry driver functionality to drivermanager

* rebase. nabling integration tests on Safari on MacOS

* addressing reviewer comments, updating web_drivers dependency commit number

* addressing reviewer comments

* addressing reviewer comments
2020-06-18 16:48:04 -07:00
Yegor
00aa0bc071
take web_ui to null safety (#19027)
move web_ui to NNBD syntax
2020-06-16 15:28:06 -07:00
nturgut
965fbbed17
renaming variables on integration tests manager (#18975) 2020-06-10 16:33:52 -07:00
nturgut
a6435210ac
Update firefox.dart (#18939) 2020-06-10 11:29:19 -07:00
nturgut
eaa2f7f90f
[web] running ios unit tests from felt … (#18856)
* running ios unit tests from felt by booting/shutingdown simulators. create simulator with felt

* changing the readme file for ios,mac,xcode spellings

* addressing reviewer comments

* fix analyse error

* fixing cleanup issue. solution: adding and await and using for loop instead of foreach
2020-06-10 09:33:17 -07:00
nturgut
201dc00cb9
[web] Adding profile parameter to firefox (#18792)
* opening firefox with a given profile

* use .dart_tool for temporary directory. delete the directory if exits before creation
2020-06-04 13:22:13 -07:00
nturgut
6d169b8bbd
add driver for chrome 83 (#18722) 2020-06-01 19:07:25 -07:00
nturgut
ffe82a77a7
[web] runs ios unit tests (#18650)
* runs ios unit tests, if the simulator is already booted.

* address reviewer comments

* changing comments for the Safari desktop tests

* addressing reviewer comments. removing the timeout.

* change mobile browsers ver name for safari.dart

* removing then calback on browser exit, only leaving the exception callback
2020-06-01 16:52:27 -07:00
Ferhat
cf899edecd
[web] Fix nineslice assertion (#18542)
* Fix nineslice assertion
2020-06-01 11:12:34 -07:00
Yegor
f49bd05014
implement SkPath.computeMetrics (#18667)
* implement SkPath.computeMetrics
2020-06-01 09:43:15 -07:00
Ferhat
7f69f0d7a9
[web] Fix arc rendering when it starts a new sub path. (#18535)
* Fix Path.addArc failure due to incorrect start position
2020-05-20 16:46:28 -07:00
Yegor
2cabca4405
compensate for DPR in canvas blur (#18484)
* compensate for DPR in canvas blur
2020-05-19 12:37:29 -07:00
Yegor
03b5f2cfd3
implement MaskFilter.blur as shadow on Safari (#18216)
* implement MaskFilter.blur as shadow on Safari
2020-05-18 11:58:49 -07:00
nturgut
c39f859f03
fix the issue in the test and remove them from the blacklist for chrome (#18441) 2020-05-15 17:47:51 -07:00
nturgut
cb71dcd377
Run integration tests on luci, use cipd package for Chrome (#18180)
* try to run integration tests on luci

* adds extra logs to check if chrome is on lUCI

* use the cipd chrome package for integration tests in LUCI

* add driver version for chrome 83.(cipd package has 83 now)

* no headless mode didn't worked on the bots. try the other option

* On LUCI also use chrome driver as a cipd package

* change the directory name to fit the cpid package

* adding blacklist functionality

* remove logs added for troubleshooting. remove the check that blocks int-test runs on LUCI

* add more comments to blacklists

* also use CIPD package chrome for unit tests

* addressing reviewer comments

* run integration tests first, upon reviewer request

* fix bug. keep running integration tests after unit tests

* update the logs for LUCI

* fix todo comments
2020-05-15 12:46:53 -07:00
Ferhat
21b4d2f1f8
[web] Fix paragraph positioning (#18329)
* Fix text positioning
* Update golden locks
2020-05-13 09:09:18 -07:00
Yegor
703525502b
make compiler worker count configurable (#17616)
* make compiler worker count configurable
2020-05-08 11:18:02 -07:00
Ferhat
e7ee47d917
[web] Implement matrix parameter for linear gradient (#18208)
* Implement linear gradient matrix
* update golden locks
* Remove matrix check in RadialGradient
2020-05-07 17:22:54 -07:00
Nurhan Turgut
d6aa099de7
Autofill main part (#17986)
* changes for getting the configuration

* running autofill

* simplifications, remove unused map

* more changes

* make single autofill fields work. remove print messages

* remove an extra line

* remove extra file. also update chrome version

* addressing reviewers comments

* addressing reviewer comments

* addressing reviewer comments

* addressing reviewer comments

* changing comments

* changing comments

* adding a comment on subscriptions lifecycle

* fixing a bug which was failing the existing unit tests

* add unit tests for AutofillInfo and EngineAutofillForm. add autocomplete to textarea

* add unit tests for method channels

* remove json from the end of the file

* do not change the input type for the focused element

* check name instead of autocomplete for firefox

* check name instead of autocomplete for firefox in other methods as well

* fixing a bug in the autofillhints file, testing if firefox is failing for username hint or for all autocomplete values

* fix the breaking unit test
2020-05-06 12:58:46 -07:00
Ferhat
80c090d9ea
Fix path bounds for multiple rects. Implement winding rules (#18165) 2020-05-05 20:53:51 -07:00
Jason Simmons
905836d466
[web] Upgrade the test package to remove the dependency on package_resolver (#18135) 2020-05-05 10:57:02 -07:00
Ferhat
a0983d36f7
[web] Add support for ColorFilter on images (#18111)
* Implement Color filter for images
* Add blend modes
* complete set of blend modes
* Add golden test for blend modes, fix size setting when using drawImage instead of drawImageRect
* Add comments
* Update golden locks
* Fix analyzer errors
Co-authored-by: Harry Terkelsen <hterkelsen@users.noreply.github.com>
* fix blend group count in test
2020-05-05 10:22:16 -07:00
Yegor
590381a00a
soften shadows even more; fix shadow alpha (#18029)
* soften shadows even more; fix shadow alpha
2020-04-29 20:54:21 -07:00
Mouad Debbar
7c084c57bd
[web] Use correct shell operator to compare file limits (#18032) 2020-04-29 18:12:48 -07:00
Ferhat
753514cefb
Canvas regression (#17738)
* Change backdrop filter element location based on ancestor clip. Add test.
* update test
* Addressed review comments. updated goldens
* Check ancestor on retain
* addressed review comments
2020-04-20 18:59:17 -07:00
Nurhan Turgut
ca3b36357f
[web] fix ulimit issues on Mac (#17767)
* check the max user limit before changing the limits

* more detailed changes in the file/user limit increase

* addressing pr reviews
2020-04-17 17:55:52 -07:00
Ferhat
4a1085a6f2
[web] Fix compositing order when adding paragraph tags (#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
Nurhan Turgut
deef2663ac
Run integration tests on ci (#17598)
* changing felt script to fetch flutter

* changing the clone_flutter.sh code

* running integration tests with felt on cirrus. fetch framework in CI (not in local).

* only run cirrus tests on chrome. fix a comma in the flutter command path

* adding comments to public flags

* use local engine parameter for flutter pub get

* change flutter executable used for flutter drive command

* fix a cleanup issue. address comments. add toolException. enable web in flutter

* address reviwer comments. fix issue with local-engine

* address reviwer comments. fix issue with local-engine

* using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage

* clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set

* fixing typos. updating readme for the new flag.

* fix directory error

* addressing reviewer comments
2020-04-13 09:54:54 -07:00
Nurhan Turgut
6245149b41
[web] using pkill to quit safari (#17533)
* adding an apple script to quit safari

* making changes to utils and adding cleanup after unit tests failed

* switch saai quit to pkill instead of applescript

* adding toolexception

* adding a cleanup function option to felt.

* removing unnecassary await's added for the previos version of the PR

* removing unnecassary async

* fix analyze error
2020-04-08 17:35:10 -07:00
Ferhat
c779894d08
[web] Fix canvas z-index leaking across repaints when element is reused. (#17378)
* Fix z-index leak. Add test for canvas reuse
* add regression test
* update golden locks
* fix analysis errors
2020-03-30 12:54:06 -07:00
Yegor
7bd8dee5be
fix implicit dynamic and two lints everywhere; implicit cast in dev/ (#17372) 2020-03-29 19:23:37 -07:00
Nurhan Turgut
a973ade331
change chrome version (#17382)
* change chrome version

* change chrome version
2020-03-27 16:52:02 -07:00
Yegor
b2a7470748
Reland "add limited analysis options (#17332)" (#17374)
* Reland "add limited analysis options (#17332)"

This time I'm starting without Cirrus. Will add Cirrus serpartely from code changes.

This reverts commit 6d33ee1a2ca7d404ebd5cb434d8ab859bf8ac0b7.

* disable Cirrus analysis check
2020-03-27 11:06:10 -07:00
Chinmay Garde
6d33ee1a2c
Revert "add limited analysis options (#17332)" (#17368)
This reverts commit 5389159643fa26342580208b6a9de547ef4de406.
2020-03-27 02:38:50 -07:00
Yegor
5389159643
add limited analysis options (#17332)
add limited analysis options
2020-03-26 14:38:59 -07:00
Nurhan Turgut
44fc6760d7
[web] improving felt: running target unit tests, cleaning up used proccesses (#17339)
* improving felt: running target unit tests, cleaning up used proccesses

* removing null check
2020-03-26 14:01:36 -07:00
Nurhan Turgut
af440db830
[web] use web drivers as a library only. do not fetch/clone web_installers (#17299)
* use web drivers as a library only. do not fetch/clone web_installers

* fixing comments

* addressing reviewer comments

* adding a trim to output. otherwise last fails
2020-03-24 15:37:33 -07:00
Yegor
2f769be663
Soften shadows (#17231)
* Soften shadows

* update goldens
2020-03-20 19:50:00 -07:00
Nurhan Turgut
48902d146a
Felt add integration (#17190)
* adding arguments to felt for running different type of tests

* adding test type enums to felt

* more changes to felt for testing branches

* more additions to code

* more changes to felt

* adding code for cloning web_drivers

* validating test directories. running the integration tests. update the readme file partially

* Removing todo lists used for development

* addressing reviewers comments

* remove unused imports

* addressing more reviewer comments

* addressing more reviewer comments

* addressing reviewer comments.

* addressing reviewer comments.

* fixing typos

* using chromedriverinstaller as a library. Fixing the commit number used from web_installers repo

* clean drivers directory after tests finish

* addressing more reviewer comments

* throwing all critical exceptions instead of logging and returning boolean flags

* adding todos for items we can do for making felt easier to use for local development

* do not run integration tests on CIs. Added an issue to the TODO.

* changing todo's with issues.
2020-03-20 19:24:13 -07:00
Nurhan Turgut
9a3016fbed
increasing user limits for macos (#17097) 2020-03-11 12:15:47 -07:00
Yegor
d41e25b549
Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (#17040)
This reverts 619acd58ca55b2a85cf70d0f7861e3c98058972d and re-lands 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1. The 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1 was good. The screenshot changes were expected.

Fixes https://github.com/flutter/flutter/issues/32215
2020-03-09 20:32:59 -07:00
Ferhat
7f942f273b
Add support for firefox mac installer. Update web_ui pubspec for http.wq (#17044)
* Add support for firefox mac installer. Update web_ui pubspec for http.wq
* Addressed review comment 'final'
2020-03-09 18:13:37 -07:00
Chris Bracken
619acd58ca
Revert "fix shadows and mask filter blurs (#16963)" (#17008)
Broke golden file tests in the framework. Reverting to unblock the
engine roll to the framework.

This reverts commit 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1.
2020-03-07 10:18:10 -08:00
Yegor
6cfa7fcad6
fix shadows and mask filter blurs (#16963)
* fix shadows and mask filter blurs

* update goldens

* clarify the choice to min the shadows
2020-03-05 22:07:57 -08:00
Nurhan Turgut
9ac76ad5ad
[web] changing user limits for macos (#16797)
* changing user limits for macos

* check kernel name instead
2020-02-25 15:04:07 -08:00