455 Commits

Author SHA1 Message Date
Mehmet Fidanboylu
1d395c5e18
Revert "Add clipBehavior to widgets with clipRect (#55977)" (#58344)
This reverts commit cd593dae1961ca2bc5c045a310f16e6cdffc8294.
2020-05-31 07:41:50 -07:00
liyuqian
cd593dae19
Add clipBehavior to widgets with clipRect (#55977)
* Add clipBehavior to RenderFlex

* Add clipBehavior to FittedBox

* Add clipBehavior to Flex and FittedBox

* Add clipBehavior to UnconstrainedBox

* Add clipBehavior to Stack and Wrap

* Add clipBehavior to TextEditable

* Add clipBehavior to ListWheelScrollView

* Add clipBehavior to SingleChildScrollView

* Add clipBehavior to RenderViewportBase's widgets

Those widgets are NestedScrollView and ShrinkWrappingViewport.

* Fix tests

* Remove enum Overflow and fix typo

* Remove clipToSize

* Analyze fix

* Remove Mixin and other small fixes

* Fix tests and respect Stack's default clipBehavior

* Add Overflow back to make it non-breaking

* Restore clipBehavior to make it non-breaking

* Small fixes

* Fix rebase
2020-05-29 15:38:50 -07:00
Hansol Lee
e853155c7e
Error message when size has not been set in RenderBox's performLayout should be well versed (#58151) 2020-05-28 15:03:01 -07:00
Tong Mu
5fa1c60b17
MouseCursor uses a special class instead of null to defer (#57094)
* Uses a special cursor value MouseCursor.defer to mark deferring. MouseTrackerAnnotation.cursor is now non-null. The mouseCursor argument of widgets or render objects can be null, which indicates using the default value.
* Moves SystemMouseCursors.uncontrolled to MouseCursor.uncontrolled.
* Changes how MouseCursor.debugDescription is defined. Previously MouseCursor.toString returns $runtimeType($debugDescription), while now it returns $debugDescription. Implementations of classes are updated, except for the ones of MouseCursor.defer and MouseCursor.uncontrolled are simply "defer" and "uncontrolled".
2020-05-14 15:54:26 -07:00
LongCatIsLooong
1c13d665ea
remove redundant transform (#57085) 2020-05-14 11:17:03 -07:00
Tong Mu
7f8cb7f830
System mouse cursors (#54171)
Adds the basic framework for the mouse cursor system. 

* Adds MouseRegion.cursor
* Adds SystemMouseCursors
* Adds mouseCursor to some widgets
2020-05-11 13:34:20 -07:00
Ian Hickson
3cb79079bf
Fix silent test failure in image cache tests (#56492) 2020-05-07 18:19:03 -07:00
Mjk
3f0024e164
Fix compute intrinsic size for wrap (#55469) 2020-05-06 13:16:01 -07:00
Gary Qian
bef3512d14
DoubleTap recognizer support and improved error message (#56328) 2020-05-06 13:06:02 -07:00
stuartmorgan
1cad96a63e
Handle surrogate pairs in RenderEditable (#55246)
The arrow key and delete handling in RenderEditable was using single
index values, which made it possible to move the cursor into the middle
of a surrogate pair (allowing things like adding text at that insertion
point), or to delete half of a surrogate pair. Since unpaired surrogate
pairs aren't valid UTF-16, doing so would cause assertions in the text
field.

This makes the arrow key and delete key handling surrogate-aware
(although not grapheme-cluster-aware, which is a larger fix that is out
of scope here).

Part of #55014
2020-04-22 12:21:03 -07:00
chunhtai
96a3b2ae0b
disable hit testing if the CompositedTransformFollower is hidden when… (#54981)
* disable hit testing if the CompositedTransformFollower is hidden when there is no leader layer

* update comment
2020-04-20 14:46:38 -07:00
chunhtai
baafc66817
Enable gesture recognizer in selectable rich text (#54479) 2020-04-16 10:05:02 -07:00
Michael Goderbauer
d47ad7ec0d
Reverse dependency between services and scheduler (#54212) 2020-04-08 09:12:03 -07:00
LongCatIsLooong
4af5fe2c37
Reland "iOS UITextInput autocorrection prompt (#45354)" (#54119) 2020-04-07 12:11:14 -07:00
cjng96
d62c7ecce5
Ignore key events on edit control on web platform (#52656) (#52661) 2020-04-01 00:31:03 -07:00
chunhtai
13fa5734f8
Reland fixes sliver list child layout offset calculation (#53187) 2020-03-25 11:06:02 -07:00
Tong Mu
bbc0cc07f6
Move mouse_tracking.dart to rendering (#52781)
* Move mouse_tracking to rendering

* Move test
2020-03-20 11:22:02 -07:00
chunhtai
3998549d52
Revert "fixes sliver list child layout offset calculation (#42703)" (#52923)
This reverts commit 11efa00f9f51d0f42fea4f206651ea974f59e42b.
2020-03-20 06:07:25 -07:00
chunhtai
11efa00f9f
fixes sliver list child layout offset calculation (#42703) 2020-03-19 14:51:04 -07:00
Yegor
7b4c195f99
Fix web test flakiness; enable web golden tests (#52789)
* Fix web test flakiness; enable web golden tests

The fix is three-part:

- Only allow one test to load _and_ test at any point in time.
- Use a fresh Chrome instance for each test file.
- Increase Cirrus resources.

The first two changes only fix the "Unknown error loading" error, but not hanging tests. The resource increase also prevents hanging tests.

Other minor changes:

- Remove test batching (it's no longer necessary)
- Fix the Chrome class, which was using the wrong Completer.
2020-03-18 15:11:48 -07:00
LongCatIsLooong
fe0a669cc9
fix sign (#51679) 2020-03-02 09:54:02 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Tong Mu
324a2168cd
Change definition of offset to object (#50157) 2020-02-07 13:08:02 -08:00
liyuqian
2ccf3f877d
Print more layer debug info (#49679) 2020-01-30 09:33:01 -08:00
Anthony
6a74be53b3
[a11y] Re-land Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#49708)
Re-land Make sure RenderFractionalTranslation updates its semantics after the translation field is set
2020-01-29 13:05:49 -05:00
Tong Mu
da0a7d8b2e
MouseTracker no longer requires annotations attached (#48453) 2020-01-28 15:03:01 -08:00
Dan Field
8b2993337a
revert #48985 (#49572) 2020-01-27 14:36:02 -08:00
Tong Mu
10649ac42a Fix TransformLayer with perspective transform (#49441) 2020-01-25 10:58:02 -08:00
Hans Muller
bc5c46438a Migrate TextTheme to 2018 APIs (#48547) 2020-01-24 19:03:01 -08:00
Alexandre Ardhuin
3800bb7b10 fix missing spaces in adjacent strings (#49159) 2020-01-21 16:43:03 -08:00
Anthony
b67d5ec6e9 [a11y] Make sure RenderFractionalTranslation updates its semantics after the translation field is set (#48985) 2020-01-17 15:13:01 -08:00
Greg Spencer
bf1d822198 Add TargetPlatform.macOS tests to cupertino, foundation, rendering, and services libraries. (#45644) 2020-01-16 19:38:01 -08:00
Alexandre Ardhuin
003541499b use isA<Xxx>() matcher (#48482) 2020-01-16 12:43:03 -08:00
Tianguang
d7d642653a
Add asserts requiring BoxConstraints' parameters to be non-null (#48295) 2020-01-13 21:34:30 +01:00
Kate Lovett
f974c295b5 SliverFadeTransition (#45950) 2020-01-07 11:58:01 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each (#47724) 2020-01-07 16:32:04 +01:00
Lau Ching Jun
ef398d9e87 Disable most screenshot tests for web until we understand the flakes. (#47554) 2019-12-20 18:43:01 -08:00
Lau Ching Jun
bc67d22449
Revert "iOS UITextInput autocorrection prompt (#45354)" (#47373)
This reverts commit 0f8c0da0a9ded2a9b7aa3bd01fcc29db80bbab0a.
2019-12-18 13:56:44 -08:00
LongCatIsLooong
0f8c0da0a9
iOS UITextInput autocorrection prompt (#45354) 2019-12-17 16:22:28 -08:00
Alexandre Ardhuin
dfbd585668 implicit-casts:false in flutter/test (#46245) 2019-12-16 15:03:02 -08:00
Dan Field
467f3d49ec remove duplicative checks (#47026) 2019-12-16 12:38:02 -08:00
Dan Field
1bca434cdd
Check for NaN in sliver constraints, improve error messaging (#46995) 2019-12-13 14:39:07 -08:00
Dan Field
82f6d43bf1
Avoid NaN for shrinkwrapping viewports (#46265) 2019-12-13 14:36:53 -08:00
Lau Ching Jun
535526b03c
Enable web for some of the golden tests (#46820)
* Make golden test timeout longer, some tests are flaky if the timeout is too short

* Enable some golden tests for web
2019-12-12 10:36:41 -08:00
Chris Bracken
fa0c49d775
Dispatch hover events to PlatformViewController (#46124)
This adds support to PlatformViewLayer for handling hover events. Prior
to this, PlatformViewLayers only supported events forwarded by the
gesture recognizers associated with the PlatformViewRenderBox. Hover
events don't participate in gesture recognition and as such are dropped
in GestureBinding. That said, hover event processing in platform views
is expected for desktop and other platforms with hover event support.

This adds support for passing an optional MouseTrackerAnnotation to
PlatformViewLayer. PlatformViewRenderBox populates this with a mouse
tracker annotation that forwards hover events to
PlatformViewController.dispatchPointerEvent() for handling by users.
2019-12-05 13:31:50 -08:00
Greg Spencer
c6fe7bb9e1
Normalizes all of the "See also" blocks in comments. (#46121)
This normalizes all of the "See also" blocks in comments so that they conform in style.

They all look like this now:

  /// See also:
  ///
  ///  * [MyFavoriteWidget], because it's cool.
  class Foo {}

I removed some useless "See also" blocks, and added commentary to ones that were just "bare" references.

This is my penance for adding so many bullets that are "-" instead of "*". :-)
2019-12-05 12:27:05 -08:00
Gary Qian
d345a3b303
Revert "Track and use fallback TextAffinity for null affinity platform TextSelections. (#44622)" (#45698)
This reverts commit 6b66d794360bb7d3ff7bf2f6dfbcbd58516c3f20.
2019-11-28 19:42:06 +09:00
Ian Hickson
449f4a6673
License update (#45373)
* Update project.pbxproj files to say Flutter rather than Chromium

Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.

* Update the copyright notice checker to require a standard notice on all files

* Update copyrights on Dart files. (This was a mechanical commit.)

* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.

Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).

* Clean up the copyrights in non-Dart files. (Manual edits.)

Also, make sure templates don't have copyrights.

* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
liyuqian
264082f34f
Print clipBehavior while debugging ClipXXXLayer (#45716)
Fixes https://github.com/flutter/flutter/issues/45587
2019-11-27 12:48:03 -08:00
Dan Field
e766ae740e
Automatically caching viewport (#45327) 2019-11-25 21:05:46 -08:00