175 Commits

Author SHA1 Message Date
Adam Barth
243a49f7d0 Merge pull request #2992 from abarth/reactive_build
Reactivating a StatefulElement should imply a build
2016-03-29 16:12:01 -07:00
Adam Barth
b841e868f1 Reactivating a StatefulElement should imply a build
Fixes #2901
2016-03-29 16:02:10 -07:00
Ian Hickson
663164339d Merge pull request #2984 from Hixie/table
More table fixes
2016-03-29 15:54:57 -07:00
Andrew Wilson
fad5df4c5e Merge pull request #2948 from apwilson/image
Add keys to ResourceImages.
2016-03-29 14:16:18 -07:00
Hixie
bdfeaaa47a More table fixes 2016-03-29 14:10:17 -07:00
Andrew Wilson
ed00f3ed5c Add keys to ResourceImages. 2016-03-29 14:02:49 -07:00
Hixie
baf06515e5 Table widget
- Add x and y to the parent data, in case it's useful. In point of fact,
  I ended up not needing it.

- Make columnWidths settable rather than having a setter so that the
  code in the widgets layer is more idiomatic.

- Teach setFlatChildren about avoiding unnecessary drop/adopt loops.

- Assert that the child list length is correct more aggressively so that
  we catch the dumb bug I had more quickly next time.

- Improve the toString() to handle empty tables better.

- Resort the imports in framework.dart.

- Introduce a LocalKey for cases where you don't want to allow use of
  GlobalKey.

- Make inflateWidget and deactivateChild public for subclass use.

- Table widget.

- Cell widget.

- TableRow fake widget.
2016-03-29 12:43:19 -07:00
Andrew Wilson
8ff1982776 Allow Draggables to drop through DragTargets that don't accept them to one that does. 2016-03-29 10:31:04 -07:00
Adam Barth
1ba539a661 Add constants for FractionalOffsets
Adds some names for common FractionalOffset values.
2016-03-28 22:51:06 -07:00
Matt Perry
641604ad94 Merge pull request #2850 from mpcomplete/form
Added a Form widget to manage multiple Input widgets.
2016-03-28 13:55:08 -04:00
Hixie
6af9e6c96b RenderTable 2016-03-25 18:40:18 -07:00
Matt Perry
a7b28a3ede Added a Form widget to manage multiple Input widgets. 2016-03-25 17:55:38 -04:00
Andrew Wilson
3a84cef248 Merge pull request #2907 from apwilson/velocity_drop
Add a callback when a Draggable is dropped without being accepted.
2016-03-25 14:28:14 -07:00
Andrew Wilson
f90ccf4825 Add a callabck when a Draggable is dropped without being accepted. 2016-03-25 14:18:24 -07:00
Adam Barth
3c6d4f660e Add a default MediaQuery value
Now MediaQuery.of always returns a non-null value. By default, you get the
values associated with the current ui.Window.

Fixes #2894
2016-03-25 13:07:42 -07:00
krisgiesing
cef24293b7 Merge pull request #2839 from krisgiesing/offscreen_layout
Allow independent rendering pipelines
2016-03-24 16:26:36 -07:00
Adam Barth
c8c325d095 Replace EdgeInsets.TRBL with EdgeInsets.fromLTRB
This matches the pattern from Rect. I've left EdgeInsets.TRBL marked as
deprecated to give clients a chance to update.

Fixes #2860
2016-03-24 15:19:40 -07:00
Kris Giesing
bb5a82a726 Allow independent rendering pipelines
Fixes #2723
2016-03-24 14:59:21 -07:00
Adam Barth
dff356fcf8 Merge pull request #2872 from abarth/fix_inherited
Inherited widgets should work across reactivations
2016-03-24 12:11:00 -07:00
Adam Barth
e361c0b096 Inherited widgets should work across reactivations
Previously we updated only the reactivated element's inherited widgets. Now we
update all the inherited widgets for the whole subtree that's being
reactivated. We need to visit the whole subtree anyway, so there isn't much of
a loss.

Fixes #2733
Fixes #2438
Fixes #1701
2016-03-24 10:54:08 -07:00
Adam Barth
3ebbabdc0c Remove incorrect comment
This test is no longer disabled.

Fixes #2827
2016-03-24 10:00:30 -07:00
Ian Hickson
da88f1d01f Merge pull request #2828 from Hixie/lru
Replace use of LruMap with a pure LinkedHashMap
2016-03-22 23:24:40 -07:00
Ian Hickson
ea04c910e7 Replace use of LruMap with a pure LinkedHashMap
...so that we can shed the quiver dependency in flutter's framework.
2016-03-22 23:01:31 -07:00
Ian Hickson
9356c19dce Handle NaNs in constraints, just in case. 2016-03-22 22:53:40 -07:00
Hixie
34cc0c4728 Rationalise the overflow render boxes
New RenderAligningShiftedBox abstract class for render boxes with
"alignment", which as of now is:

 - RenderPositionedBox
 - RenderConstrainedOverflowBox (ex RenderOverflowBox)
 - RenderSizedOverflowBox
 - RenderFractionallySizedOverflowBox (ex RenderFractionallySizedBox)

(The respective widgets are Align, OverflowBox, SizedOverflowBox, and
FractionallySizedBox. They haven't been renamed.)

Also I added some toString details.
2016-03-22 14:06:49 -07:00
Hixie
71976b306b Fix RenderFractionallySizedBox's constraints logic
Fixes https://github.com/flutter/flutter/issues/2735
2016-03-22 10:29:43 -07:00
Hans Muller
70550a7a9a Fix _LazyWidgetProvider indexing, move Ali Connors 2016-03-21 12:20:09 -07:00
Andrew Wilson
861423876d Refactor CheckedModeBanner into something more reusable. 2016-03-18 19:03:16 -07:00
Hixie
7e3bef1163 Replace WidgetError and RenderingError with FlutterError 2016-03-18 15:40:38 -07:00
Adam Barth
502a4ae078 Use FractionalOffset for gradients
These were using Offsets, but they're really FractionalOffsets.

Fixes #2318
2016-03-15 19:30:41 -07:00
Adam Barth
a710676d5f Tapping drawer during animation causes it to stick
The problem was we were using a tap gesture to stop the motion of the
drawer and a drag gesture to settle it. That can cause a broken
lifecycle. Now we use a single drag recognizer to drive the whole
lifecycle.

Fixes #775
Fixes #1276
2016-03-15 16:43:34 -07:00
Adam Barth
3ebd4c58b6 Let RenderObjectWidgets use inherited properties
This prepares us for depending on the LTR/RTL inherited property in
RenderObjectWidgets.
2016-03-14 16:56:56 -07:00
Hixie
797e27edd3 Add @override annotations to flutter framework 2016-03-14 14:02:26 -07:00
Adam Barth
89987fc040 [rename fixit] TwoLevelSublist left->leading, center->title 2016-03-14 12:24:58 -07:00
Hixie
4e6b287881 Remove some more 'dynamic's 2016-03-14 11:11:41 -07:00
Adam Barth
d5b2e2a01c [rename fixit] Flex alignments
* justifyContent -> mainAxisAlignment
* alignItems -> crossAxisAlignment
* FlexJustifyContent -> MainAxisAlignment
* FlexAlignItems -> CrossAxisAlignment

Fixes #231
2016-03-12 18:33:47 -08:00
Adam Barth
5e1af2f37e [rename fixit] DismissDirection left -> endToStart, right -> startToEnd
Removes an LTR bias in DismissDirection.

Fixes #2562
2016-03-12 18:33:47 -08:00
Adam Barth
e48c822ce3 [rename fixit] left -> leading, right -> trailing
The terms "left" and "right" have an LTR bias. Instead, we now use
"leading" and "trailing", for these list and grid decorations so that
we can later rearrange them to match the reading order.

Fixes #2540
Fixes #2548
2016-03-12 17:31:01 -08:00
Adam Barth
9b9ad3db17 [rename fixit] RouteBuilder -> BuildContext
Fixes #2353
2016-03-12 17:18:31 -08:00
Adam Barth
95fc5ae070 [rename fixit] *Component* -> *Widget*
This patch renames StatelessComponent to StatelessWidget and
StatefulComponent to StatefulWidget.

Fixes #2308
2016-03-12 12:34:05 -08:00
Adam Barth
726eff4953 [rename fixit] *OneChild* -> *SingleChild*
Fixes #1482
2016-03-12 12:33:39 -08:00
Adam Barth
e71bd77e4f [rename fixit] EdgeDims -> EdgeInsets
Fixes #1382
2016-03-12 12:33:38 -08:00
Adam Barth
b5923f9282 [rename fixit] Painter -> RenderObjectPainter
Fixes #774
2016-03-12 11:37:39 -08:00
Adam Barth
e9b8f4450b [rename fixit] scrollDirection -> mainAxis
Fixes #581
2016-03-12 11:35:24 -08:00
Adam Barth
19f615fc2f [rename fixit] MultiChildLayoutDelegate#isChild -> hasChild
Fixes #459
2016-03-12 11:13:10 -08:00
Adam Barth
44c4e930d1 [rename fixit] GestureArena -> GestureArenaManager
Also, change the keys to be explicitly pointer ids.

Fixes #202
2016-03-12 11:13:02 -08:00
Hixie
6795efacab Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-12 00:37:31 -08:00
Ian Hickson
43b0104114 Revert "Merge pull request #2639 from Hixie/always_specify_types"
This reverts commit f41b3411da35929b09009e47cb52474389e42874, reversing
changes made to e33d8d96212f3e337a6660f1eb1118bffc945bf5.

This was a bad check-in due to my mangling uploading a new version of the branch from a different machine.

This reverts https://github.com/flutter/flutter/pull/2639 and will be replaced by https://github.com/flutter/flutter/pull/2640
2016-03-12 00:34:37 -08:00
Hixie
d162d98c79 Enable always_specify_types lint
And fix the zillion issues that uncovered.
2016-03-11 18:27:32 -08:00
Adam Barth
9c08836273 Handle the case of reparenting while updating children
Instead of trying to flush the detached children from the child list, we keep
the set of detached children up to date and query on every read.
2016-03-11 16:34:22 -08:00