1321 Commits

Author SHA1 Message Date
gaaclarke
f8e9a4fff2
Added option to specify you want the keyboard to be dismissed when you scroll. (#52068) 2020-03-13 09:44:24 -07:00
Dan Field
73b2895ff1
Add errorBuilder to Image widget (#52481) 2020-03-12 16:21:01 -07:00
Gary Qian
fed6ce17f8
Directionality formatter to move whitespace bidi handling into framework (#51964) 2020-03-11 16:25:12 -07:00
Gary Qian
d56266375b
Reland "Improve text formatter repeat filter logic (#52055)" (#52366) 2020-03-11 13:36:43 -07:00
Gary Qian
ac6ea52b37
Revert "Add missing features to DefaultTextStyleTransition and AnimatedDefaultTextStyle (#51517)" (#52352) 2020-03-10 14:11:03 -07:00
Michael Goderbauer
ade6a1b3c5
Fix a11y scrolling for reversed lists (#52332) 2020-03-10 13:04:22 -07:00
renyou
847280f72f
Revert "Improve text formatter repeat filter logic (#52055)" (#52274)
This reverts commit 91b0bcf1a8a192e8135a9289310d81deba5824ec.
2020-03-09 16:26:48 -07:00
Gary Qian
91b0bcf1a8
Improve text formatter repeat filter logic (#52055) 2020-03-09 13:05:07 -07:00
Darren Austin
1c3ebad904
Fix for negative padding from a curve in AnimatedPadding. (#52072)
* Fix for negative padding from a curve in AnimatedPadding.

* Added a EdgeInsets.clamp function that would return an EdgeInsets instance instead of a _MixedEdgeInsets used by the base class. This was causing some tests to fail that didn't have a text direction.
2020-03-06 14:14:03 -08:00
Alexandre Ardhuin
c2ae654ddf
enable avoid_single_cascade_in_expression_statements (#51944) 2020-03-05 08:03:26 +01:00
Flutter GitHub Bot
b0381df11f
Unlooping Golden File Tests (#51883) 2020-03-04 15:21:01 -08:00
Flutter GitHub Bot
d0c4357338
Keep render tree and element tree in sync when re-used elements move in a MultiChildRenderObjectElement's child list (#51674) 2020-03-04 11:46:03 -08:00
Shi-Hao Hong
d2c734a36f
Simple repeating word fixes (#51871) 2020-03-03 11:13:07 -08:00
Greg Spencer
1ba4f1f509
Add Linux and Windows target platforms (#51519)
This PR adds the linux and windows target platform enum values, along with automatically setting the defaultTargetPlatform to the appropriate value on those platforms.

Fixes #31366
2020-03-03 04:38:04 -08:00
Gary Qian
b4cf20380e
Add missing features to DefaultTextStyleTransition and AnimatedDefaultTextStyle (#51517) 2020-03-02 16:24:02 -08:00
Remi Rousselet
c742c19891
Add debugDoingBuild flag (#51428) 2020-03-02 09:55:37 -08:00
stuartmorgan
6a337a76dd
Revert "Fix handling backspace on macos with text selection (#49760)" (#51577)
This reverts commit 9375377fa99e8faae8a573e9fe92b8712d33e82d.

Fixes #51511
2020-02-28 14:28:34 -08:00
Dan Field
646d2b0139
properties (#51650) 2020-02-28 12:01:03 -08:00
Jason Simmons
ae027c194f
Use strut box heights to calculate selection rectangles in order to ensure that they remain within visible bounds (#50354) 2020-02-28 09:36:03 -08:00
Greg Spencer
d4226566d4
Change Focus.unfocus to take a disposition for where the focus… (#50831)
When Focus.unfocus is called, the caller usually just thinks about wanting to remove focus from the node, but really, unfocus is a request to automatically pass the focus to another (hopefully useful) node.

This PR removes the focusPrevious flag from unfocus, and replaces it with a disposition enum that indicates where the focus should go from here.

The other value of the UnfocusDisposition enum is UnfocusDisposition.scope.

UnfocusDisposition.previouslyFocusedChild is closest to what focusPrevious used to do: focus the nearest enclosing scope and use its focusedChild field to walk down the tree, finding the leaf focusedChild. This PR modifies it slightly so that it walks up to the nearest focusable enclosing scope before trying to focus the children. This change addresses #48903

A new mode: UnfocusDisposition.scope will focus the nearest focusable enclosing scope of this node without trying to use the FocusScopeNode.focusedChild value to descend to the leaf focused child. This is useful as a default for both text field finalization and for what happens when canRequestFocus is set to false. It allows the scope to stay focused so that nextFocus/previousFocus still work as expected, but removes the focus from primary focus.

In addition to those changes, unfocus called on a FocuScope that wasn't the primary focus used to unfocus the primary focus instead. I removed that behavior, since it was buggy: if the primary focus was inside of a child scope, and you called unfocus on the parent scope, then the child scope could have focused another of its children instead, leaving the scope that you called unfocus on with hasFocus returning true still. If you want to remove the focus from the primary focus instead of the scope, that's easy enough to do: just call primaryFocus.unfocus().

Fixes #48903
2020-02-26 18:04:32 -08:00
Dan Field
444b13b895
Colored box and container optimization (#50979) 2020-02-26 16:04:35 -08:00
Dan Field
c75db98337
Live image cache (#51485)
* Reland "Live image cache" (#51441)

This reverts commit 419a2853a8e4ac846524afeb49b866d4cdaa7d9d.

* Make evict safer
2020-02-26 16:01:56 -08:00
Miguel Beltran
7ff3a50fe7
Set highContrast value from AccessibilityFeatures into MediaQueryData (#48811) 2020-02-26 13:36:02 -08:00
Dan Field
419a2853a8
Revert "Live image cache" (#51441)
* Revert "Live image cache (#51249)"

This reverts commit e2dcdb60e327f80d414d3d1e72e2863bf4c9252c.

* fix tests for other commit
2020-02-25 16:52:47 -08:00
Dan Field
e2dcdb60e3
Live image cache (#51249)
* Revert "Revert "Live image cache (#50318)" (#51131)"

This reverts commit 2f09d601b5a1632468714adb051d7f1e5a816ce4.

* Fix eviction of a pending image
2020-02-24 13:47:53 -08:00
Shi-Hao Hong
6d4121c075
Fix tests that rely on FadeTransition incorrectly and depend on implementation details of FadeUpwardsTransitionBuilder (#51150) 2020-02-22 16:54:02 -08:00
Dan Field
2f09d601b5
Revert "Live image cache (#50318)" (#51131)
This reverts commit 1602be6ab6529732b59cdc5ac36ec8439690329b.
2020-02-20 13:20:28 -08:00
Alexandre Ardhuin
7d7ac7c32b
start multiline strings with newline (#50825) 2020-02-20 10:16:28 +01:00
Tjong Anthony
e7c90057c7
[Form] Add is valid to FormState (#48948) 2020-02-19 13:31:05 -08:00
Dan Field
8aa67610f7
Avoid including a potentially animated invisible image (#50842)
* Avoid including a potentially animated invisible image
2020-02-18 11:29:55 -08:00
Dan Field
1602be6ab6
Live image cache (#50318)
Track images available on screen
2020-02-14 15:03:05 -08:00
Taufiq Rahman
d1185337cc
Feature: Allow minLines in SelectableText (#50750)
* Feature: allow minLines in SelectableText
2020-02-14 06:38:13 -08:00
Gary Qian
8769f94cf6
Add textHeightBehavior and textWidthBasis to AnimatedDefaultTextStyle (#50748) 2020-02-13 16:52:31 -05:00
Greg Spencer
d57d493507
Reland: Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50672)
This re-lands #49235 with the addition of includeSemantics flag on the Focus widget so that the FocusTraversalGroup can create a Focus widget without affecting the semantics tree.

The FocusTraversalGroup uses the Focus widget to create a grouping of descendants for traversal, but doesn't actually participate in focus (canRequestFocus is always false), so we don't want it to add a Semantics widget in that case, since that can cause semantics changes. The canRequestFocus attribute can also be used when a widget is disabled, so we do sometimes want to include Semantics even if that is false, but not in the case where it is always false, as for FocusTraversalGroup.

- Added a test to make sure that FocusTraversalGroup doesn't add any semantics information.
2020-02-12 16:22:01 -08:00
Greg Spencer
b2a7ff36a9
Fix lack of ancestor notification when a focus node is unfocus… (#50319)
This fixes a problem when unfocusing focus nodes where the ancestor focus nodes and scopes don't receive notification that a child was unfocused.

Fixes #43497
2020-02-12 16:20:08 -08:00
chunhtai
7168421e9f
fixes route name annoucement in navigator (#50495) 2020-02-12 14:53:05 -08:00
Jacob Richman
7820641a05
Fix Diagnostics subclasses that had the wrong default value for the named parameter. (#50645) 2020-02-12 14:52:50 -08:00
Greg Spencer
c132c0faa9
Revert "Add OrderedFocusTraversalPolicy and FocusTraversalGrou… (#50660)
This reverts commit 8ef5e2f046ed18ca32827e1a715ca5e405c646ac because it breaks some semantics tests.
2020-02-12 13:37:36 -08:00
LongCatIsLooong
48d5fcabbd
evict _SliverFractionalPadding cache on constraint change (#50523) 2020-02-11 12:52:53 -08:00
Alexandre Ardhuin
f15c887c63
change quote to avoid escapes (#50368) 2020-02-11 20:58:27 +01:00
Greg Spencer
8ef5e2f046
Add OrderedFocusTraversalPolicy and FocusTraversalGroup to all… (#49235)
This change adds a way to provide explicit focus order for a part of the widget tree.

It adds FocusTraversalPolicyGroup, which in many ways is similar to DefaultFocusTraversal, except that it groups a widget subtree together so that those nodes are traversed as a group. DefaultFocusTraversal doesn't work as one would expect: If there is more than one DefaultFocusTraversal inside of a focus scope, the policy can change depending on which node was asked to move "next", which can cause unexpected behavior. The new grouping mechanism doesn't have that problem. I deprecate DefaultFocusTraversal in this PR.

It also adds OrderedFocusTraversalPolicy, which is a policy that can be supplied to FocusTraversalPolicyGroup to set the policy for a sub-tree. It looks for FocusTraversalOrder inherited widgets, which use a FocusOrder to do the sorting. FocusOrder has two subclasses: NumericalFocusOrder (which sorts based on a double), and LexicalFocusOrder, which sorts based on a String.

As part of doing this, I refactored the way FocusTraversalPolicy is implemented so that it has more default implementation methods, and exposes a new protected member: sortDescendants, which makes it easier for developers to make their own policy subclasses: they only need to implement sortDescendants to get a new ordering behavior, but can also still override any of the default implementation behaviors if they need different behavior.

I was able to do this without breaking the API (AFAICT).
2020-02-11 09:18:39 -08:00
Gary Qian
f769bcc5c4
Reland "Track lastKnownRemoteTextEditingValue separately from received data" (#50307) 2020-02-10 20:55:48 -05:00
Mouad Debbar
bf551a31fe
EditableText's autofocus:true should not crash (#50372) 2020-02-10 15:58:02 -08:00
Greg Spencer
18f8002ec8
Make FocusManager a ChangeNotifier that notifies when the prim… (#50392)
This makes FocusManager a ChangeNotifier that notifies when the primaryFocus changes so that an app can track the current focus.

Fixes #50501
2020-02-10 14:33:31 -08:00
Dan Field
9cb2953e10
Fix image tests that make faulty assumptions about lifecycle of image provider (#50297) 2020-02-10 14:23:01 -08:00
Dan Field
ffc85591c8
more gradle upgrades (#50388) 2020-02-10 14:16:49 -08:00
liyuqian
b277534026
Assert cache hints are not set for null painters (#49771) 2020-02-10 10:03:03 -08:00
Michael Goderbauer
95d6ef741c
Nested TickerMode cannot turn tickers back on (#50355) 2020-02-07 18:23:02 -08:00
Alexandre Ardhuin
b953c3e5a8
use raw strings to avoid escaping (#50322) 2020-02-07 16:35:55 +01:00
Dan Field
8735ab1e35
Make onImage re-entrant safe (#50316) 2020-02-06 23:36:59 -08:00