DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
26,910 Commits 882 Branches 1,069 Tags
Commit Graph

4813 Commits

Author SHA1 Message Date
Zachary Anderson
daeb8316d7 Only build analyze_snapshot on Linux host (flutter/engine#39129) 2023-01-25 08:35:57 -08:00
Loïc Sharma
6de1c715fb Manually roll ANGLE, vulkan-deps, SwiftShader (flutter/engine#38650) 2023-01-25 00:53:25 +00:00
Loïc Sharma
3119b5c02b Improve crashes if messenger APIs are used incorrectly (flutter/engine#39041) 
* Clarify messenger APIs

* Feedback
 2023-01-24 23:22:51 +00:00
Ahmed Ashour
51c0a9ec65 Remove superfluous words from comments (flutter/engine#39068) 
* Remove superfluous words.

* Format

* Duplicate in consecutive lines.
 2023-01-24 09:54:19 -08:00
Constantine Shablya
a38bdae396 [embedder] Fix getting vkGetInstanceProcAddr (flutter/engine#39051) 2023-01-24 01:22:38 +00:00
Chris Yang
353f0b5b32 [ios_platform_view] MaskView pool to reuse maskViews. (flutter/engine#38989) 
* reuse maskView

reuse mask view

format

format

draft

draft

fixes

test

* comments

* fix comment

* test for releasing maskView

* updates

* fix
 2023-01-21 04:26:04 +00:00
Ben Konyi
002fce29e0 Revert "Remove references to Observatory (#38919)" (flutter/engine#39035) 
Reason for revert: breaking Flutter -> plugins roll

This reverts commit 1f603711c7b7afe52dff3872a5035789e3ddba02.
 2023-01-20 12:33:40 -05:00
Bruno Leroux
258cde6cd2 [macos] Synthesize modifier keys events on pointer events (flutter/engine#37870) 
* [macos] Synthesize modifier keys events on pointer events

* Move test to FlutterViewControllerTest

* Simplify by using 'for in'

Co-authored-by: Bruno Leroux <bruno.leroux@gmail.com>
 2023-01-20 10:43:16 +00:00
Chris Bracken
1dd1f02bc4 Extract WideToUTF16String/UTF16StringToWide to FML (flutter/engine#39020) 2023-01-19 22:55:47 -08:00
Robert Ancell
3b47df5adf Fix invalid Unix locale to Flutter locale (BCP-47) mapping (flutter/engine#36512) 
Flutter locales use the BCP-47 format
(https://www.rfc-editor.org/rfc/bcp/bcp47.txt), and Unix locales use a POSIX
format. There is not a perfect mapping between them, see
https://wiki.openoffice.org/wiki/LocaleMapping

The current implementation is not correctly setting the appropriate optional
fields, so remove that.

There are likely some Unix locales that should set these fields, but these are
best fixed by adding special cases for them as they are discovered.

Fixes: https://github.com/flutter/flutter/issues/111341
 2023-01-19 22:53:59 +00:00
Nayuta403
0626a035ce Remove unused variables and import (flutter/engine#38971) 2023-01-19 21:06:53 +00:00
yaakovschectman
7ed656d596 Merge MSAA alert functionality with UIA (flutter/engine#38745) 
* Use AXFragmentRootWin for MSAA functionality.

Some unused code remains to be removed.

Merge MSAA to AXFragmentRootWin

* Removing unused code

* Remove unused files

* Flip macro

* Formatting

* Licenses

* Make reference

* Disable copy constructor/assignment

* Unused import

* Formatting

* Relocate alert logic

* Remove comment and unused mock

* Fix unit test

* Idempotency

* Formatting

* PR feedback

* Doc comments

* Undo string change for now

* Couple fragment root and alert node

* Formatting

* Add comments

* Pointer to reference

* Typo fix
 2023-01-19 13:28:27 -05:00
Ben Konyi
1f603711c7 Remove references to Observatory (flutter/engine#38919) 
Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags.

See https://github.com/dart-lang/sdk/issues/50233
 2023-01-19 09:20:46 -05:00
Chris Yang
1284ee8f45 [ios_platform_view] more precision when determine if a clip rrect is necessary (flutter/engine#38965) 
* draft

fix

rename

unittest

* update scenario

* test
 2023-01-18 22:19:13 +00:00
Chris Bracken
42fd13c246 [windows] Eliminate unnecessary iostream imports (flutter/engine#38824) 
In 491db72 I replaced use of direct writes to cerr and replaced them
with FML_LOG calls but may have missed removing some iostream #includes,
or they may have been missed in previous cleanups. This removes any
remaining #includes of iostream that are unused.
 2023-01-12 18:05:20 -08:00
Chris Bracken
bcfa08f532 [windows] Use FML_DCHECK in place of C assert (flutter/engine#38826) 
Now that the embedders depend on FML, migrate assertions to FML_DCHECK,
which allows for an explanatory log message to be emitted along with the
assertion.

No tests since no semantic changes are made.
 2023-01-12 18:03:19 -08:00
luckysmg
598fb62a0b Correct FrameTimingRecorder's raster start time. (flutter/engine#38674) 
* ++

* ++

* Add tests

* Add missing trace

* ++

* ++

* ++
 2023-01-13 01:38:17 +00:00
Matej Knopp
86c5ce8349 [macOS] Do not block raster thread when shutting down (flutter/engine#38777) 2023-01-12 22:28:06 +01:00
Pierrick Bouvier
3811a350df Add CI builder for windows-arm64. (#38394) (flutter/engine#38739) 
* Generate zip archives for Windows following target platform.

* Add CI builder for windows-arm64.

All packages can be cross compiled from an x64 machine.
Unittests are disabled, as they require an arm64 machine.

* Add windows-arm64 to CI.
 2023-01-11 23:01:08 +00:00
Rich Kadel
e43616416f [fuchsia] Replace deprecated AddLocalChild (flutter/engine#38788) 
`AddLocalChild(LocalComponent*)` is deprecated.

It was replaced by:

`AddLocalChild(LocalComponentFactory)`, which is a type alias for a
lambda that returns a `std::unique_ptr<LocalComponentImpl>`.

This change addresses problems that arised due to object lifetime
management of the components, and allows RealmBuilder to model the
component lifecycle of local components in a way that's more consistent
with other components.

The RealmBuilder-built `Realm` now owns the lifetime of the local
components, instead of the client, and those objects are valid until
the `Realm` is destroyed.

Bug: fxbug.dev/109804
 2023-01-11 16:54:22 -05:00
Jim Graham
eb615c6cc4 delete include of private GrMtlTypes header (flutter/engine#38783) 2023-01-11 19:57:47 +00:00
gaaclarke
85eaa970e2 removed forbidden skia include (flutter/engine#38761) 
* removed forbidden skia include

* jason feedback
 2023-01-10 20:33:31 -08:00
yaakovschectman
717c8724c6 Mark nodes as kIsLineBreakingObject by default, TODO further distinctions (flutter/engine#38721) 
* Line breaks

* Formatting

* Update shell/platform/common/accessibility_bridge.cc

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

* Test line breaking object

* Formatting

* Format

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2023-01-10 11:13:44 -05:00
Kate Lovett
be9ae4793d Undo axes flip on Mac when shift+scroll-wheel (flutter/engine#38338) 
* Undo axes flipping when using scroll wheel with shift key

* Formatting

* ++

* Fix test

* Fix for test

* Update shell/platform/darwin/macos/framework/Source/FlutterViewControllerTest.mm

* ++

* Fix format

* Review feedback
 2023-01-10 00:18:12 +00:00
Loïc Sharma
5e35f2ab74 Revert "Add CI builder for windows-arm64. (#38394)" (flutter/engine#38729) 
This reverts commit 35810a873b59c8d738f1f3661854572cc3aa2215.
 2023-01-09 22:35:13 +00:00
Pierrick Bouvier
35810a873b Add CI builder for windows-arm64. (flutter/engine#38394) 
* Generate zip archives for Windows following target platform.

* Add CI builder for windows-arm64.

All packages can be cross compiled from an x64 machine.
Unittests are disabled, as they require an arm64 machine.

* Add windows-arm64 to CI.
 2023-01-09 21:51:12 +00:00
JiaJian
5a17cf21d2 iOS FlutterTextureRegistry should be a proxy, not the engine itself (flutter/engine#37666) 
* feat: add texture registry relay.

* fix: add test.

* fix: format

* fix: add comment.

* fix: remove useless import.

* fix: remove

* fix: file name order.

* fix.

* add test for retain cycle.

* fix compile

* Add comments.

* remove relay.

* add FlutterTextureRegistryRelay in gn

* add golden files.

* add

* add comments.
 2023-01-09 18:51:13 +00:00
Jaeheon Yi
0720c7f6dc [fuchsia][scenic] Use infinite hit region (flutter/engine#38647) 
fxbug.dev/118729
 2023-01-09 15:40:51 +00:00
yaakovschectman
c2d59665dd Limit selection change to focused node on Windows (flutter/engine#38634) 
* Limit selection change to focused node on Windows

* Focus fix

* Test document selection change

* Comment

* Formatting

* Update shell/platform/windows/accessibility_bridge_windows.cc

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2023-01-06 16:36:11 -05:00
Erik
010e710512 Remove strict equality check for SkMatrix comparison (flutter/engine#38665) 
* Remove strict equality check for SkMatrix comparison

* Address PR comments
 2023-01-05 21:44:50 +00:00
Kevin Lubick
ecd5ad9c7c SkBudgeted -> skgpu::Budgeted (flutter/engine#38660) 
* SkBudgeted -> skgpu::Budgeted

* colon

* format

* fix GN rules

* undo includes
 2023-01-05 21:42:34 +00:00
Nayuta403
4ebc681b23 Reduce the size of Overlay FlutterImageView in HC mode (flutter/engine#38393) 
* intersect

* add

* test fix

* fix test

* modify

* typo

* modify

* test
 2023-01-05 17:01:55 +00:00
yaakovschectman
2f6724c5bf Update FlutterPlatformNodeDelegate (flutter/engine#38615) 
* Update FlutterPlatformNodeDelegate

* Unit test
 2023-01-04 10:27:24 -05:00
Jason Simmons
226cf8354c Roll quiver to 3.2.1 (flutter/engine#38617) 
Need to roll quiver to a version that doesn't depend on BidirectionalIterator, which is being removed in https://dart-review.googlesource.com/c/sdk/+/276741?tab=checks.
 2023-01-04 02:04:38 +00:00
yaakovschectman
6c12d1292d Make AccessibilityBridge a AXPlatformTreeManager (flutter/engine#38610) 
* Make Accessibility Bridge a tree manager

* Add FlutterPlatformNodeDelegate::GetPlatformNode

* Add unit test

* Formatting

* PR
 2023-01-03 15:18:04 -05:00
Loïc Sharma
757b6d8cb1 [Windows] Make the engine own the cursor plugin (flutter/engine#38570) 2023-01-03 17:26:06 +00:00
Loïc Sharma
fa208d2285 [Windows] Add engine builder to simplify tests (flutter/engine#38546) 
* [Windows] Add engine builder to simplify tests

* Format
 2022-12-29 21:32:23 +00:00
Emircan Uysaler
8528d4f572 [fuchsia] Add trace flow for Flatland::Present (flutter/engine#38565) 2022-12-29 15:52:09 -05:00
Emircan Uysaler
4667a310d0 [fuchsia] Set presentation interval (flutter/engine#38549) 2022-12-29 13:02:56 -05:00
Brandon DeRosier
52788a1e67 [Impeller Scene] Add ColorSourceContents for drawing a node (flutter/engine#38485) 2022-12-28 20:57:14 -08:00
Alexander Biggs
72c5b1eee5 [fuchsia] Debugging code for crash. (flutter/engine#38518) 2022-12-27 20:26:47 +00:00
Matej Knopp
bc41422fb1 [macOS] Update FlutterView layer scale when backing properties change (flutter/engine#38402) 2022-12-20 01:05:26 +01:00
gaaclarke
a76ec8c965 reland: Started using FlutterEngineGroups by default on Android (flutter/engine#38367) 
* Revert "Revert "Started using FlutterEngineGroups by default on Android  (#37822)" (#38351)"

This reverts commit b0a282e0cc7e0ceb22ce75258c2b9c22266b7f47.

* fixed the entrypoint test

* updated old test

* coldpalelight's suggestion

* added entrypoint args
 2022-12-19 11:26:36 -08:00
Chris Bracken
cf89f3ff75 Even though the file is pure C code, it's useful to use a C++ or Objective-C++ filename in order to use FML (assertions) in the implementation. (flutter/engine#38365) 
Three implementation changes:
* Since the file is now C++, some implicit void* conversions now require
  an explicit cast.
* A malloc/free of a buffer has been replaced with a std::vector.
* An `assert()` was changed to `FML_DCHECK` for consistency with the
  rest of the embedder.

No test changes since there are no semantic changes.

Existing tests are in:
https://github.com/flutter/engine/blob/main/shell/platform/darwin/common/framework/Source/flutter_standard_codec_unittest.mm
 2022-12-16 23:28:01 -08:00
Chris Bracken
1571befea8 [iOS, macOS] Migrate from assert to FML_DCHECK (flutter/engine#38368) 
Eliminates raw C asserts in the iOS and macOS embedders, replacing them
with FML_DCHECK for consistency with the rest of the codebase.

No semantic change so no changes to tests.
 2022-12-16 19:07:16 -08:00
gaaclarke
29c3e97f45 Sped up FlutterStandardCodec writing speed. (flutter/engine#38345) 
* Sped up FlutterStandardCodec writing speed.

* added clear division of reader and writer helpers

* updated doxygen comment
 2022-12-16 22:43:55 +00:00
Chris Bracken
dc3033d922 Clarify semantics action dispatch id parameter (flutter/engine#38356) 
Previously the embedder API documented this as an action ID, but it's
actually the semantics node ID. This fixes the docs and renames the
parameter to clarify its purpose.

This callback is registered in the framework render bindings:
9102f2fe0b/packages/flutter/lib/src/rendering/binding.dart (L43)

Handled by `_handleSemanticsAction`:
9102f2fe0b/packages/flutter/lib/src/rendering/binding.dart (L360-L366)

Which invokes `SemanticsOwner.performAction`, where the node is looked up by ID:
9102f2fe0b/packages/flutter/lib/src/semantics/semantics.dart (L3258-L3277)
 2022-12-16 13:40:48 -08:00
Erik
5262e76f26 Port touch-based tests from embedder integration test (flutter/engine#38234) 
* Port touch-based tests from embedder integration test

* Remove RegisterTouchScreen and related variables

* Update embedded child view size
 2022-12-16 20:54:07 +00:00
Jason Simmons
b0a282e0cc Revert "Started using FlutterEngineGroups by default on Android (#37822)" (flutter/engine#38351) 
This reverts commit 91655b80d28ed70adf4e7f4d82a807a9ede8f885.

This commit caused a regression in the entrypoint_dart_registrant test.
 2022-12-16 08:22:44 -08:00
gaaclarke
cf3c286780 Sped up reading with FlutterStandardCodec. (flutter/engine#38327) 
* Sped up reading with FlutterStandardCodec.

* added missing license diff

* put the IsStandardType in the header so it's closer to where it should change

* added unittest for subclassing codecs

* fixed lints
 2022-12-16 01:40:56 +00:00