1914 Commits

Author SHA1 Message Date
Chinmay Garde
0dfd3c2144 Remove absolute path in new Fuchsia SDK based runner target dependency. (flutter/engine#8888)
Only ran into this as I was wiring up the bots to build the new targets.
2019-05-07 17:26:45 -07:00
Chinmay Garde
8ef9d87c66 Copy the Flutter Runner from //topaz into the engine. (flutter/engine#8886)
Build rules and include paths have been updated as necessary.
No other functional change.
2019-05-07 17:24:18 -07:00
Dan Field
c96714ac5d new lints (flutter/engine#8849)
Dart lints added:
* Avoid optional new
* Avoid optional const
* Prefer single quotes
* Prefer default assignment `=`
2019-05-07 16:10:21 -07:00
Chinmay Garde
8462054c5b Copy //dart-pkg/zircon|fuchsia from Topaz into the engine. (flutter/engine#8884)
Build rules and include paths have been updated as necessary. No other functional change.
2019-05-07 15:06:15 -07:00
Chinmay Garde
fa8b1de1c0 Copy //runtime/dart/utils from Topaz into the engine. (flutter/engine#8871)
Build rules and include paths have been updated as necessary. No other functional change.
2019-05-07 13:59:43 -07:00
Dan Field
6b5249e33d Log instead of throwing (flutter/engine#8881) 2019-05-07 11:08:38 -07:00
Chinmay Garde
56e7bf84b1 Wire up Fuchsia SDK related updated for shell dependencies. #8869
This does not actually import the runners into the engine. It only sets up the targets so they need no modifications are necessary when the migration is done. The engine has been verified to build in both buildroots.
2019-05-06 18:01:59 -07:00
stuartmorgan
fe6ed0bd72 Add resize functions to GLFW shell (flutter/engine#8864)
Adds methods to get and set the window size, as well as to query the
window's scale factor. This is useful both for custom clients, and for
building a window resize plugin to prototype what will eventually likely
be a system channel.
2019-05-06 16:22:40 -04:00
stuartmorgan
71903838b8 Provide access to GLFW window in plugins (flutter/engine#8806)
Plugins may need to be able to access functions affecting the GLFW
window (e.g., a plugin to resize the window). This restructures the API
to create a distinction at both the C and C++ level between the window
controller, which provides access to high-level behaviors driving the
Flutter application, and the window, which provides access to functions
to affect the UI state of the window (i.e., wrapped GLFWwindow
functions).

Also provides a PluginRegistrar extension for plugins that need access
to GLFW-specific functionality.
2019-05-06 15:37:02 -04:00
Dan Field
71fc6ad699 Remove static leaks (flutter/engine#8825) 2019-05-03 16:57:04 -07:00
Matt Carroll
d5f3268c0c Cause crash in FlutterJNI if invoked on non-main thread (#31263). (flutter/engine#8830) 2019-05-03 14:55:28 -07:00
Dan Field
5fc7feffe7 Guard Android logs (flutter/engine#8824) 2019-05-03 14:32:29 -07:00
Jonah Williams
a76c6e3df4 Add flutter settings channel and window brightness to macOS shell (flutter/engine#8810) 2019-05-02 20:42:51 -07:00
Dan Field
a6fc20e278 Remove asserts and add BuildConfig (flutter/engine#8821) 2019-05-02 17:30:19 -07:00
Dan Field
66f76e2c0e remove legacy build deps (flutter/engine#8820)
* remove legacy build deps
2019-05-02 16:03:05 -07:00
Matt Carroll
77981e55ed Allow FlutterEngine to be used on back-to-back screens (#31264). (flutter/engine#8808) 2019-05-02 13:19:11 -07:00
Kaushik Iska
08a3eedf0d Re-create texture from pixel buffer onGrContextCreate (flutter/engine#8792)
* Re-create texture from pixel buffer onGrContextCreate

OnGrContextDestroy we destroy the texture, this is because
we can not access it from the potentially new context that
we get on bringing the app back to foreground.

To show a valid texture on fg, we need to preserve the pixel
buffer, using which we will create the new texture.

* ensure texture cache exists

* only reset pixel buffer if not null.
2019-04-30 15:25:20 -07:00
Kaushik Iska
d1747142e0 VirtualDisplay size constraint - add a comment explaining the reason (flutter/engine#8780)
* VirtualDisplay size: add a comment explaining the reason

Address nits in: https://github.com/flutter/engine/pull/8704

* remove locale import
2019-04-29 17:19:05 -07:00
Dan Field
c7e9c7b016 Fix crash when cursor ends up at invalid position (flutter/engine#8747) 2019-04-26 15:43:44 -07:00
Kaushik Iska
1a247c1d1c Limit the size of VirtualDisplay we create in android (flutter/engine#8704)
- This can cause phones to restart as documented in https://github.com/flutter/flutter/issues/28978
2019-04-25 13:44:45 -07:00
Zachary Anderson
0299216745 Plumb arguments from Settings to Dart main() (flutter/engine#8710) 2019-04-25 07:57:54 -07:00
Chris Bracken
98f182594e Fix reflective ctor invocation in FlutterFragment (flutter/engine#8735)
Class.newInstance() propagates any exception thrown by the nullary
constructor, including a checked exception. This effectively bypasses
the compile-time exception checking that would otherwise be performed by
the compiler. The Constructor.newInstance method avoids this problem by
wrapping any exception thrown by the constructor in a (checked)
InvocationTargetException.
2019-04-24 17:50:19 -07:00
liyuqian
358e88cabf Revert "Only allow mappings for ICU initialization. (#8656)" (flutter/engine#8682)
This reverts commit dfaa1c9292238e73c56d36f7264adc63ea53745c.

Reverts flutter/engine#8656

Reason:  https://github.com/flutter/engine/pull/8656 seems to break the framework windows tests and the engine roll (see https://cirrus-ci.com/task/4704667236827136 and https://github.com/flutter/flutter/pull/31330). The failure has been consistent for 7 consecutive engine-to-framework auto-rolls.

TBR: @chinmaygarde
2019-04-22 10:28:54 -07:00
Stanislav Baranov
4b86efc066 Remove support for downloading dynamic patches. (flutter/engine#8663) 2019-04-22 09:05:06 -07:00
Chinmay Garde
0b2269e30e Put the testing lib in the flutter namespace. (flutter/engine#8661) 2019-04-20 20:42:46 -07:00
Chinmay Garde
572b7b80fb Allow native bindings in secondary isolates. (flutter/engine#8658)
The callbacks can be wired in via the Settings object. Both runtime and shell unit-tests have been patched to test this.
2019-04-19 17:36:36 -07:00
Chinmay Garde
dfaa1c9292 Only allow mappings for ICU initialization. (flutter/engine#8656)
If the mapping callback is not set or it the callback returns invalid data, ICU initialization will be embedder responsibility.

This affects all embedders and the following have been audited:
* Android: Via a symbol mapping.
* iOS: Via a file mapping.
* Embedder: Via a file mapping.
* Fuchsia: Via a VMO mapping
* Test shells and Flutter tester: Via file mapping with ICU data needing to be next to the executable.
2019-04-19 15:01:40 -07:00
Chinmay Garde
7758ff9f51 Cleanup references to FLX archives from the engine. (flutter/engine#8653) 2019-04-19 12:49:07 -07:00
Chinmay Garde
1133591eeb Add factory methods to FileMapping that make it easy to create common mappings. (flutter/engine#8652)
The GetMapping calls removed in this patch had the same code and had to be repeated across different test harnesses as well as in dart_snapshot.cc. Just make this a factory method so the code is less verbose.
2019-04-19 12:48:53 -07:00
Ben Konyi
ef2a551576 Disable auth codes for Observatory test (flutter/engine#8646) 2019-04-18 17:46:32 -07:00
Ben Konyi
d6b169c641 Enable VM service authentication codes by default (flutter/engine#8594) 2019-04-18 14:17:25 -07:00
Ben Konyi
d78a466267 Add support for authentication codes via MDNS on iOS (flutter/engine#8625) 2019-04-18 12:12:29 -07:00
Chinmay Garde
12410da5f7 Avoid leaking the VM in the shell unittests and assert VM state in existing tests. (flutter/engine#8628) 2019-04-18 11:32:33 -07:00
Shi-Hao Hong
1ead577b35 Fix typo in comment (flutter/engine#8617) 2019-04-17 15:03:50 -07:00
liyuqian
27e4dac06b Rename flow namespace to flutter (flutter/engine#8615)
This follows our namespace change from shell to flutter: https://github.com/flutter/engine/pull/8520.
2019-04-17 14:38:45 -07:00
stuartmorgan
1fd410c44f Add FLEPluginRegistry for macOS (flutter/engine#8611)
Creates a minimal FLEPluginRegistry protocol, which is a subset of the
FlutterPluginRegistry.

This is a small step toward eventually merging the APIs, but allows
changing the example project structure to better reflect what a future
template will look like.
2019-04-17 10:53:59 -07:00
Michael Klimushyn
5df695efdf Pipe Z bounds from ViewportMetrics to Flow (flutter/engine#8583)
This is the first step in making Flutter aware of and responsive to Z
bound overflow. On its own this patch shouldn't result in any changes in
behavior. This will need to be followed up with a patch in Fuchsia's
Flutter runner to set the Z bounds after this lands, and another patch
in the engine actually implementing the desired overflow behavior.

This Z bound info is routed through the engine itself to make sure the
bounds in flow are truly consistent from the Fuchsia runner. However
these values should eventually be exposed to the framework as well.
2019-04-17 09:56:46 -07:00
stuartmorgan
e722bba483 Add desktop shell unittests to test script (flutter/engine#8600)
Builds the unit test on all platforms, and adds them to the aggregate test script.
2019-04-16 22:37:39 -07:00
stuartmorgan
922d6df36f Implement StandardMethodCodec for C++ shells (flutter/engine#8598)
Adds StandardMethodCodec support to the C++ client wrapper. This makes it
substantially easier to add Windows and Linux support for existing plugins, as
StandardMethodCodec is the default plugin protocol.

Fixes flutter/flutter#30670

Does not include extensibility for the codec, which will be added later.
2019-04-16 19:49:09 -07:00
stuartmorgan
9b2819a3bb Variant type for C++ client wrapper (flutter/engine#8592)
Adds a type that can hold any of the types corresponding to the Dart types
that are supported by the standard message channel codec. This provides
the foundation for adding standard message codec support for the C++
desktop shells (flutter/flutter#30670).
2019-04-16 16:33:07 -07:00
Qxyat
500f19660d Composite Embedded Views with the correct GrContext
PaintRecorder Canvases are not associated with GrContexts.
2019-04-16 14:13:34 -07:00
Chris Bracken
e7bd1767be Add null check in FLETextInputPlugin (flutter/engine#8538)
Adds a guard on `_activeClientID` in `insertNewline:`. The conditional
around the `insertText:replacementRange:` call already catches this, but
we then unconditionally pack `_activeClientID` into an `NSArray`, which
disallows nil.
2019-04-12 21:10:23 -07:00
Kaushik Iska
f9648fe057 Revert Versions API (flutter/engine#7828)
* Revert "Fix versions implementation (#7726)"

This reverts commit 82b3db052387161a8eed5f98f08080f1a60b7dfb.

* Revert "Expose the Flutter engine, Dart and Skia versions to Dart. (#7634)"

This reverts commit ec6f6c35b36548a2cf745c0a4b3cb8e5b6ee0e72.

* remove namespace shell stuff

* fix format

* fix licenses
2019-04-12 14:23:13 -07:00
Matt Carroll
8b4adba352 Android Embedding PR29: Improve FlutterFragment construction API + engine config API. (flutter/engine#8540) 2019-04-12 13:19:05 -07:00
Chris Bracken
e4cca1bd56 Remove unused import in FlutterActivityDelegate (flutter/engine#8563)
android.app.UiModeManager is unused in FlutterActivityDelegate.
2019-04-12 11:17:57 -07:00
Diego Ballesteros Villamizar
9d9892d005 Add missing <memory> include to text_input_model.h (flutter/engine#8562)
text_input_model.h uses std::unique_ptr but does not include the memory header.
2019-04-12 10:48:11 -07:00
stuartmorgan
6956c8a88c Export extern constants in embedder.h (flutter/engine#8550)
PR #8498 made these constants extern, but forgot to export them so they
would be public symbols.
2019-04-11 23:32:29 -07:00
Matt Carroll
4b8ea49e58 Android Embedding PR30: Make FlutterView focusable so that the keyboard can interact with it. (flutter/engine#8551) 2019-04-11 13:50:42 -07:00
Chris Bracken
d467c50378 Correct nullability for FlutterStandardReader (flutter/engine#8537)
FlutterStandardReader's `readValueOfType:` method returns nil when
called with `FlutterStandardFieldNil`. By extension, `readValue` can
also return nil values.
2019-04-11 09:59:08 -07:00
Matt Carroll
0e05ad325d Android Embedding PR28: Report app is active to Flutter in FlutterFragment.onResume() instead of onPostResume() forwarded from Activity. (flutter/engine#8536) 2019-04-10 17:47:56 -07:00