DEV/flutter_flutter
1
0
Fork 0
mirror of https://github.com/flutter/flutter.git synced 2026-02-20 02:29:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
33,449 Commits 882 Branches 1,069 Tags
Commit Graph

25337 Commits

Author SHA1 Message Date
skia-flutter-autoroll
d5e79a8ae8 Roll Skia from c59cb89f8d15 to 2cae982f7f2f (3 revisions) (flutter/engine#49567) 
https://skia.googlesource.com/skia.git/+log/c59cb89f8d15..2cae982f7f2f

2024-01-05 michaelludwig@google.com [skif] Avoid resolving a simpled deferred color filter
2024-01-05 johnstiles@google.com Remove fSharedElements member from ThreadContext.
2024-01-05 johnstiles@google.com Migrate ProgramElements array into Parser.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-05 21:35:57 +00:00
skia-flutter-autoroll
f1714913c5 Roll Skia from 9ec012033c2b to c59cb89f8d15 (1 revision) (flutter/engine#49565) 
https://skia.googlesource.com/skia.git/+log/9ec012033c2b..c59cb89f8d15

2024-01-05 michaelludwig@google.com [graphite] Don't check AdapterProperties in WASM builds

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-05 20:50:04 +00:00
skia-flutter-autoroll
35b7c12e80 Roll Skia from 548827f77466 to 9ec012033c2b (1 revision) (flutter/engine#49564) 
https://skia.googlesource.com/skia.git/+log/548827f77466..9ec012033c2b

2024-01-05 brianosman@google.com Revert "Add GCC support to Raster Pipeline"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-05 20:03:34 +00:00
skia-flutter-autoroll
8d584e0069 Roll Skia from 52be1b25c3a2 to a006922df1c5 (4 revisions) (flutter/engine#49559) 
https://skia.googlesource.com/skia.git/+log/52be1b25c3a2..a006922df1c5

2024-01-05 johnstiles@google.com Report duplicate-symbol errors without ThreadContext::ReportError.
2024-01-05 michaelludwig@google.com [graphite] Temporarily disable SSBOs on Dawn D3D11
2024-01-05 brianosman@google.com Add GCC support to Raster Pipeline
2024-01-05 drott@chromium.org [Fontations-backend] Add COLRv0/v1 support to Fontations backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-05 17:36:12 +00:00
Dan Field
3078ba7036 Allow spawning additional UI isolates in flutter_tester (flutter/engine#48706) 
This enables work ongoing by @derekxu16 to improve performance in flutter_tester when running multiple files from large test suites.

Specifically, it:

- Exposes a `Spawn` C symbol from flutter_tester that runs the current kernel in a new UI isolate with a different entrypoint and/or route name
- Exposes two symbols from flutter_tester to allow a test harness to more efficiently load particular kernel files or to lookup an entrypoint from an imported source file.
- Avoids re-loading the kernel file completely when spawning a new UI isolate

Googlers can look at go/flutter-tester-isolates for some more context. If anyone wants I'm happy to create a public version of that doc.
 2024-01-05 17:13:59 +00:00
zoujunhua
b98cd15293 Add build dependencies for Android Embedder (flutter/engine#48397) 
The build of embedded Android depends on the symbols of the
'icudtl.dat', as described in the change
'cf6fbe1fdcda6db2ed5d18a254b2c7c91f54f7aa' and
'7922a335e88dcb12bf6a1c681ffd6770234bbf24'.

fixes https://github.com/flutter/flutter/issues/97347


## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat

---------

Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
 2024-01-05 09:02:48 -08:00
skia-flutter-autoroll
d953c64e6f Roll Skia from 75e2f75aaa20 to 52be1b25c3a2 (2 revisions) (flutter/engine#49556) 
https://skia.googlesource.com/skia.git/+log/75e2f75aaa20..52be1b25c3a2

2024-01-05 johnstiles@google.com Fix SPIR-V issue with multiple interface blocks and u_skRTFlip.
2024-01-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6de9699bbab6 to 251696c8011d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-05 14:59:19 +00:00
skia-flutter-autoroll
6e4bd0b907 Roll Fuchsia Linux SDK from 0Q4I0x-Kt7T6DOE1b... to l0zn1BQFRjNyaZb-v... (flutter/engine#49552) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-05 12:07:25 +00:00
skia-flutter-autoroll
f56b1ffa7e Roll Skia from bdd1e88f3b83 to 75e2f75aaa20 (4 revisions) (flutter/engine#49551) 
https://skia.googlesource.com/skia.git/+log/bdd1e88f3b83..75e2f75aaa20

2024-01-05 bungeman@google.com FreeType to ignore already visited colrv1 subtrees
2024-01-05 drott@chromium.org [Fontations-backend] Rename Cargo package
2024-01-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 58247e808c13 to 6de9699bbab6 (11 revisions)
2024-01-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7b559e9f56e3 to c8ff88bfeb04 (3 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-05 09:17:08 +00:00
skia-flutter-autoroll
5fc0743c2e Roll Skia from dab831e8dcec to da75878a3aea (1 revision) (flutter/engine#49546) 
https://skia.googlesource.com/skia.git/+log/dab831e8dcec..da75878a3aea

2024-01-04 sunnyps@chromium.org graphite: Enable storage buffers with Dawn backend

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-05 00:18:09 +00:00
Jim Graham
423d8ab803 [Impeller] RenderPass now provides the Orthographic matrix (flutter/engine#49544) 
Clients of the `RenderPass` would each compute the Orthographic matrix themselves even though it was the same for the life of a given pass. They can now get a cached version from the `RenderPass` itself.
 2024-01-04 23:25:11 +00:00
gaaclarke
9000d68d50 [Impeller] migrate blur to calculating coefficients on the cpu (flutter/engine#49512) 
issue: https://github.com/flutter/flutter/issues/131580

This factors out the gaussian blur fragment shader to be a more generic kernel fragment shader.  We can't use this for the old gaussian blur because it's kernel is unbounded in one dimension.  I implemented this by passing in the coefficients into the UBO so it can't support that.

Profile after change:
```
    "average_vsync_transitions_missed": 2.0,
    "90th_percentile_vsync_transitions_missed": 2.0,
    "99th_percentile_vsync_transitions_missed": 2.0,
    "average_vsync_frame_lag": 0.0,
    "90th_percentile_vsync_frame_lag": 0.0,
    "99th_percentile_vsync_frame_lag": 0.0,
    "average_layer_cache_count": 0.0,
    "90th_percentile_layer_cache_count": 0.0,
    "99th_percentile_layer_cache_count": 0.0,
    "average_frame_request_pending_latency": 16636.624373956594,
    "90th_percentile_frame_request_pending_latency": 16718.0,
    "99th_percentile_frame_request_pending_latency": 16761.0,
    "worst_layer_cache_count": 0.0,
    "average_layer_cache_memory": 0.0,
    "90th_percentile_layer_cache_memory": 0.0,
    "99th_percentile_layer_cache_memory": 0.0,
    "worst_layer_cache_memory": 0.0,
    "average_picture_cache_count": 0.0,
    "90th_percentile_picture_cache_count": 0.0,
    "99th_percentile_picture_cache_count": 0.0,
    "worst_picture_cache_count": 0.0,
    "average_picture_cache_memory": 0.0,
    "90th_percentile_picture_cache_memory": 0.0,
    "99th_percentile_picture_cache_memory": 0.0,
    "worst_picture_cache_memory": 0.0,
    "total_ui_gc_time": 1.65,
    "30hz_frame_percentage": 0.0,
    "60hz_frame_percentage": 100.0,
    "80hz_frame_percentage": 0.0,
    "90hz_frame_percentage": 0.0,
    "120hz_frame_percentage": 0.0,
    "illegal_refresh_rate_frame_count": 0,
    "average_gpu_frame_time": 21.875,
    "90th_percentile_gpu_frame_time": 31.25,
    "99th_percentile_gpu_frame_time": 31.25,
    "worst_gpu_frame_time": 31.25,
    "average_cpu_usage": 162.86326532653064,
    "90th_percentile_cpu_usage": 167.3,
    "99th_percentile_cpu_usage": 168.500003,
    "average_gpu_usage": 93.26530612244898,
    "90th_percentile_gpu_usage": 94.0,
    "99th_percentile_gpu_usage": 95.0,
    "average_memory_usage": 113.56696428571429,
    "90th_percentile_memory_usage": 145.484375,
    "99th_percentile_memory_usage": 152.75
```

This is a 13% (21.25 / 25 ) drop in `average_gpu_frame_time` from the last profile in https://github.com/flutter/engine/pull/49299.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-04 22:35:13 +00:00
Mitchell Goodwin
9f290c3cea Get the correct iOS system font for each weight (flutter/engine#48937) 
See [flutter/issue/139689](https://github.com/flutter/flutter/issues/139689) and [flutter/issue/132475](https://github.com/flutter/flutter/issues/132475)

Registers all of the possible font weight values for "CupertinoSystemDisplay". The registering of "CupertinoSystemText" was removed, as the fallback will correctly show the right fonts, and this logic does not work for the smaller font due to Apple APIs removing the font weight.

The font weights for 800 and 900 had to be added outside of the loop as they were coming back with values different from what was being put in.

Before:
<img width="250" alt="Screenshot 2023-12-06 at 1 17 11 PM" src="https://github.com/flutter/engine/assets/58190796/036231eb-d4e2-4c93-82de-fa62d7ddc7c1">

After:
<img width="364" alt="Screenshot 2024-01-03 at 3 15 33 PM" src="https://github.com/flutter/engine/assets/58190796/69651f01-d694-4758-9fb5-acf50a1895c4">

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-04 21:47:13 +00:00
Camille Simon
6252becd06 [Android] Re-land "Re-land 'Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34'" (flutter/engine#49101) 
Re-lands https://github.com/flutter/engine/pull/48936 that was reverted due to missing `DEPS` dependency (added).

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-04 21:33:10 +00:00
godofredoc
27b91a4e08 Use Mac M1s or x86 wherever possible. (flutter/engine#49540) 
Arch type was fixed to x86 because release candidate branches didn't have rosetta installed. Rosetta was enabled on December unblocking the use of M1 machines in most of mac ios sub-builds.

Bug: https://github.com/flutter/flutter/issues/133207

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-04 21:05:30 +00:00
skia-flutter-autoroll
acfba59d15 Roll Skia from 48ba1246efdf to dab831e8dcec (1 revision) (flutter/engine#49538) 
https://skia.googlesource.com/skia.git/+log/48ba1246efdf..dab831e8dcec

2024-01-04 drott@chromium.org Cleanup code gated by SK_DISABLE_SKFONTARGS_CHANGED_TYPE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 19:21:21 +00:00
skia-flutter-autoroll
acc16853ef Roll Skia from e8e426f1429a to 48ba1246efdf (2 revisions) (flutter/engine#49537) 
https://skia.googlesource.com/skia.git/+log/e8e426f1429a..48ba1246efdf

2024-01-04 michaelludwig@google.com [graphite] Optimize UniformManager and fix layout bugs in std430
2024-01-04 johnstiles@google.com Fix mislabeled columns/rows arguments in Metal codegen.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 18:21:46 +00:00
skia-flutter-autoroll
c3f81c746d Roll Skia from 9c2e9a2b06f3 to e8e426f1429a (11 revisions) (flutter/engine#49536) 
https://skia.googlesource.com/skia.git/+log/9c2e9a2b06f3..e8e426f1429a

2024-01-04 brianosman@google.com Disable lax-vector-conversions in clang
2024-01-04 michaelludwig@google.com Revert "[skif] Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE flag"
2024-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8b92d1069ee8 to 7b559e9f56e3 (4 revisions)
2024-01-04 johnstiles@google.com Migrate SkSLToXxxxxxx wrappers into GPU-specific subdirectories.
2024-01-04 johnstiles@google.com Remove ThreadContext::RTAdjustState.
2024-01-04 brianosman@google.com Reland "Update bots' NDK to r26b"
2024-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from b9d08e6f5a57 to 64bda34e7703
2024-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from a6b9a7447d68 to 295eece61cce (3 revisions)
2024-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from b9d08e6f5a57 to 58247e808c13 (8 revisions)
2024-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b09f6a97d1da to 8b92d1069ee8 (9 revisions)
2024-01-04 michaelludwig@google.com [skif] Remove SK_RESOLVE_FILTERS_BEFORE_RESTORE flag

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 17:32:02 +00:00
skia-flutter-autoroll
c689330bfc Manual roll Dart SDK from 7e9f7eab80d3 to 7f2523c2fa9a (3 revisions) (flutter/engine#49534) 
Manual roll requested by zra@google.com

https://dart.googlesource.com/sdk.git/+log/7e9f7eab80d3..7f2523c2fa9a

2024-01-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-279.0.dev
2024-01-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-278.0.dev
2024-01-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-277.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 16:23:19 +00:00
skia-flutter-autoroll
9523fac026 Roll Fuchsia Linux SDK from Wgogr8K1YZdo7yOnn... to 0Q4I0x-Kt7T6DOE1b... (flutter/engine#49529) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 11:15:04 +00:00
Michael Brase
7c5452d3ae [fuchsia] Remove LoggingSocketTest.UseSyslogOnFuchsia test (flutter/engine#49524) 
This test reads back logged messages on Fuchsia to verify that FML
logging has the log sink setup correctly. However, it relies on internal
implementation details of the Fuchsia log packet format, which recently
changed (to support structured logging) and it broke this test. Since
there isn't a supported way to parse structured log packets outside of
the Fuchsia repository, I'm removing this test to unblock the SDK roll.

flutter/flutter#140950
b/315973146

## Pre-launch Checklist

- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-01-04 00:30:03 -08:00
skia-flutter-autoroll
2bbf466fde Roll Skia from 14378602a81f to 9c2e9a2b06f3 (1 revision) (flutter/engine#49518) 
https://skia.googlesource.com/skia.git/+log/14378602a81f..9c2e9a2b06f3

2024-01-04 johnstiles@google.com Instantiate sk_RTAdjust directly rather than using ThreadContext.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 03:24:08 +00:00
skia-flutter-autoroll
7f1bea3d11 Roll Skia from aa1b0074a1b5 to 14378602a81f (2 revisions) (flutter/engine#49516) 
https://skia.googlesource.com/skia.git/+log/aa1b0074a1b5..14378602a81f

2024-01-04 michaelludwig@google.com [graphite] Add layout to UniformManagerTest checks
2024-01-04 michaelludwig@google.com [graphite] Use templates to avoid copying UniformManager API in PipelineDataGatherer

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 02:31:36 +00:00
Casey Hillers
9be43f26a3 Add Flutter CI status to README (flutter/engine#49330) 
https://github.com/flutter/flutter/issues/140460
 2024-01-04 01:34:17 +00:00
skia-flutter-autoroll
45eb89dfb3 Roll Skia from dd4077962cd5 to 81c8c425a050 (1 revision) (flutter/engine#49513) 
https://skia.googlesource.com/skia.git/+log/dd4077962cd5..81c8c425a050

2024-01-03 johnstiles@google.com Split SymbolTable::instantiateSymbolRef in half.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 00:54:23 +00:00
Jonny Wang
1b161e263e [fuchsia] Add libbackend_fuchsia_globals.so to common_libs (flutter/engine#49484) 
The libbackend_fuchsia_globals.so is now required by libsyslog.so, so
include it in the list of Fuchsia common_libs.

*Replace this paragraph with a description of what this PR is changing
or adding, and why. Consider including before/after screenshots.*

b/315973146

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x ] All existing and new tests are passing.

---------

Co-authored-by: skia-flutter-autoroll <skia-flutter-autoroll@skia.org>
Co-authored-by: Michael Brase <mbrase@google.com>
 2024-01-03 16:47:32 -08:00
skia-flutter-autoroll
7c56f5ead4 Roll Skia from e32d4d4f71eb to dd4077962cd5 (1 revision) (flutter/engine#49510) 
https://skia.googlesource.com/skia.git/+log/e32d4d4f71eb..dd4077962cd5

2024-01-03 johnstiles@google.com Forward-declare dependencies in PipelineUtils.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-04 00:04:08 +00:00
skia-flutter-autoroll
537ebfe48e Roll Skia from 7d73dd415ae9 to e32d4d4f71eb (3 revisions) (flutter/engine#49508) 
https://skia.googlesource.com/skia.git/+log/7d73dd415ae9..e32d4d4f71eb

2024-01-03 michaelludwig@google.com [skif] Remove SK_USE_LEGACY_CONTENT_BOUNDS_PROPAGATION flag
2024-01-03 ccameron@chromium.org Add SkGradientShader::ColorSpace::kOKLabGamutMap and kOKLCHGamutMap
2024-01-03 michaelludwig@google.com Remove staging flag from flutter_defines

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 23:12:59 +00:00
skia-flutter-autoroll
9ce1ec17a9 Roll Skia from 1ce1aa1f90fa to 7d73dd415ae9 (3 revisions) (flutter/engine#49506) 
https://skia.googlesource.com/skia.git/+log/1ce1aa1f90fa..7d73dd415ae9

2024-01-03 egdaniel@google.com Remove default enabling of vulkan on android in gn.
2024-01-03 johnstiles@google.com Remove Compiler::toBackend calls.
2024-01-03 johnstiles@google.com Decouple HLSL code generation from SkSL::Compiler.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 22:07:08 +00:00
skia-flutter-autoroll
b69420468d Roll Skia from 063e339bedfc to 1ce1aa1f90fa (6 revisions) (flutter/engine#49503) 
https://skia.googlesource.com/skia.git/+log/063e339bedfc..1ce1aa1f90fa

2024-01-03 johnstiles@google.com Decouple SPIR-V code generation from SkSL::Compiler.
2024-01-03 johnstiles@google.com Fix SKSL_ENABLE_TRACING flag in test code.
2024-01-03 brianosman@google.com Skip LastFragColorWithoutCaps.sksl error test (to fix Pixel4a bots)
2024-01-03 nicolettep@google.com [graphite] Add MSAA pipeline creation structs to VulkanResourceProvider
2024-01-03 johnstiles@google.com Decouple WGSL code generation from SkSL::Compiler.
2024-01-03 brianosman@google.com Revert "Update bots' NDK to r26b"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 21:12:52 +00:00
gaaclarke
d52f315f41 [Impeller] new blur: limit uvs to blur region (flutter/engine#49299) 
This will run the blur passes on a subset of the texture passed into it that will actually be blurred.  This is an optimization for backdrop filters.

issue: https://github.com/flutter/flutter/issues/131580
test coverage: devicelab `backdrop_filter_perf_ios__timeline_summary`

## performance results

This results in a 50% reduction in average GPU time in our benchmark, 79% reduction in the "99% percentile".
```
BEFORE

    "average_vsync_transitions_missed": 3.889423076923077,
    "90th_percentile_vsync_transitions_missed": 4.0,
    "99th_percentile_vsync_transitions_missed": 4.0,
    "average_vsync_frame_lag": 0.0,
    "90th_percentile_vsync_frame_lag": 0.0,
    "99th_percentile_vsync_frame_lag": 0.0,
    "average_layer_cache_count": 0.0,
    "90th_percentile_layer_cache_count": 0.0,
    "99th_percentile_layer_cache_count": 0.0,
    "average_frame_request_pending_latency": 16654.368333333332,
    "90th_percentile_frame_request_pending_latency": 16692.0,
    "99th_percentile_frame_request_pending_latency": 16749.0,
    "worst_layer_cache_count": 0.0,
    "average_layer_cache_memory": 0.0,
    "90th_percentile_layer_cache_memory": 0.0,
    "99th_percentile_layer_cache_memory": 0.0,
    "worst_layer_cache_memory": 0.0,
    "average_picture_cache_count": 0.0,
    "90th_percentile_picture_cache_count": 0.0,
    "99th_percentile_picture_cache_count": 0.0,
    "worst_picture_cache_count": 0.0,
    "average_picture_cache_memory": 0.0,
    "90th_percentile_picture_cache_memory": 0.0,
    "99th_percentile_picture_cache_memory": 0.0,
    "worst_picture_cache_memory": 0.0,
    "total_ui_gc_time": 0.659,
    "30hz_frame_percentage": 0.0,
    "60hz_frame_percentage": 100.0,
    "80hz_frame_percentage": 0.0,
    "90hz_frame_percentage": 0.0,
    "120hz_frame_percentage": 0.0,
    "illegal_refresh_rate_frame_count": 0,
    "average_gpu_frame_time": 52.13341346153846,
    "90th_percentile_gpu_frame_time": 62.5,
    "99th_percentile_gpu_frame_time": 62.5,
    "worst_gpu_frame_time": 62.5,
    "average_cpu_usage": 69.08979595918369,
    "90th_percentile_cpu_usage": 70.4,
    "99th_percentile_cpu_usage": 71.699999,
    "average_gpu_usage": 100.0,
    "90th_percentile_gpu_usage": 100.0,
    "99th_percentile_gpu_usage": 100.0,
    "average_memory_usage": 118.79942602040816,
    "90th_percentile_memory_usage": 138.125,
    "99th_percentile_memory_usage": 143.65625

AFTER

    "average_vsync_transitions_missed": 2.0,
    "90th_percentile_vsync_transitions_missed": 2.0,
    "99th_percentile_vsync_transitions_missed": 2.0,
    "average_vsync_frame_lag": 0.0,
    "90th_percentile_vsync_frame_lag": 0.0,
    "99th_percentile_vsync_frame_lag": 0.0,
    "average_layer_cache_count": 0.0,
    "90th_percentile_layer_cache_count": 0.0,
    "99th_percentile_layer_cache_count": 0.0,
    "average_frame_request_pending_latency": 16635.025,
    "90th_percentile_frame_request_pending_latency": 16715.0,
    "99th_percentile_frame_request_pending_latency": 16802.0,
    "worst_layer_cache_count": 0.0,
    "average_layer_cache_memory": 0.0,
    "90th_percentile_layer_cache_memory": 0.0,
    "99th_percentile_layer_cache_memory": 0.0,
    "worst_layer_cache_memory": 0.0,
    "average_picture_cache_count": 0.0,
    "90th_percentile_picture_cache_count": 0.0,
    "99th_percentile_picture_cache_count": 0.0,
    "worst_picture_cache_count": 0.0,
    "average_picture_cache_memory": 0.0,
    "90th_percentile_picture_cache_memory": 0.0,
    "99th_percentile_picture_cache_memory": 0.0,
    "worst_picture_cache_memory": 0.0,
    "total_ui_gc_time": 1.732,
    "30hz_frame_percentage": 0.0,
    "60hz_frame_percentage": 100.0,
    "80hz_frame_percentage": 0.0,
    "90hz_frame_percentage": 0.0,
    "120hz_frame_percentage": 0.0,
    "illegal_refresh_rate_frame_count": 0,
    "average_gpu_frame_time": 25.01558603491272,
    "90th_percentile_gpu_frame_time": 31.25,
    "99th_percentile_gpu_frame_time": 31.25,
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-03 20:46:00 +00:00
skia-flutter-autoroll
c86035488d Roll Skia from 1144b7950404 to 063e339bedfc (7 revisions) (flutter/engine#49500) 
https://skia.googlesource.com/skia.git/+log/1144b7950404..063e339bedfc

2024-01-03 brianosman@google.com Update bots' NDK to r26b
2024-01-03 drott@chromium.org [fontations-backend] Resolve palette overrides and store CPAL palette
2024-01-03 drott@chromium.org Fix viewer build after build target renames
2024-01-03 johnstiles@google.com Reland "Fix fuzzer-discovered Metal issue with sk_LastFragColor."
2024-01-03 johnstiles@google.com Decouple Metal code generation from SkSL::Compiler.
2024-01-03 michaelludwig@google.com [graphite] Disable short uniforms
2024-01-03 michaelludwig@google.com [graphite] Clean-up Uniform header, pack fields and add type asserts

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 20:18:47 +00:00
gaaclarke
408561bab3 [Impeller] pulled out the path unit tests to their own file (flutter/engine#49499) 
issue: https://github.com/flutter/flutter/issues/140106
tests: refactor of code

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-03 20:07:15 +00:00
John McCutchan
718ac2c814 Fix a crash in the new SurfaceProducer external texture (flutter/engine#49496) 
The following sequence of events would lead to a crash:

- Reader A is created.
- Reader A produces a frame (A0)
- Texture is resized.
- Reader B is created and reader A is scheduled to be closed.
- Reader A produces a frame (A1). This is skipped.
- Reader A is closed.
- Frame A0 is acquired.

Because we closed Reader A the frame A0 is invalid.

The fix is to not close Reader A when it is the last reader to produce a
frame.

Fixes internal bug b/318458306
 2024-01-03 10:56:46 -08:00
Jonah Williams
7446f3ff6f [Impeller] Disable compute for Vulkan. (flutter/engine#49463) 
This code is missing correct barriers which cannot be specified at the HAL level, see https://github.com/flutter/flutter/issues/140798
 2024-01-03 18:48:11 +00:00
Tong Mu
ceaa4c9fc6 Revert skiping illegal render in Dart (flutter/engine#49473) 2024-01-03 10:45:16 -08:00
skia-flutter-autoroll
607e8dca77 Roll Skia from 9e8069bba51d to 1144b7950404 (1 revision) (flutter/engine#49494) 
https://skia.googlesource.com/skia.git/+log/9e8069bba51d..1144b7950404

2024-01-03 johnstiles@google.com Decouple GLSL code generation from SkSL::Compiler.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 17:36:18 +00:00
skia-flutter-autoroll
9bc1c5bbce Roll Skia from a9db1213b179 to 9e8069bba51d (18 revisions) (flutter/engine#49490) 
https://skia.googlesource.com/skia.git/+log/a9db1213b179..9e8069bba51d

2024-01-03 johnstiles@google.com Remove shaderCompiler() from GrGpu.
2024-01-03 johnstiles@google.com Remove caps member from SkSL::Compiler.
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from bd5dce9a8e85 to a6b9a7447d68 (35 revisions)
2024-01-03 drott@chromium.org [COLRv1] Add tests for PaintColrGlyph cycle detection
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from fd810f3d94c5 to 766692bfd3f0
2024-01-03 mike@reedtribe.org add include guard
2024-01-03 egdaniel@google.com [Graphite] Fix Vulkan write and readPixels to RGB_888 format
2024-01-03 herb@google.com Reland "Compare two segments at a given y"
2024-01-03 mike@reedtribe.org Expose limit for TypefaceCache
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d32a5c6f592d to b9d08e6f5a57 (36 revisions)
2024-01-03 brianosman@google.com Add SK_ASSUME macro, to replace clang-only __builtin_assume
2024-01-03 drott@chromium.org Revert^2 "[Fontations-backend] Use new outline API"
2024-01-03 drott@chromium.org Pick unsigned 16 bit type for SkFontArgument palette overrides
2024-01-03 drott@chromium.org [Fontations-backend] Resolve palettes FFI functionality
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from abf17e333489 to b09f6a97d1da (60 revisions)
2024-01-03 egdaniel@google.com Fix convexity check when we backtrack right from the start.
2024-01-03 olv@google.com [ganesh] Add VK_FORMAT_G10X6_B10X6R10X6_2PLANE_420_UNORM_3PACK16 support
2024-01-03 skia-autoroll@skia-public.iam.gserviceaccount.com Manual roll Dawn from d7465b8b2585 to 5566afc92caf (21 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 16:02:29 +00:00
skia-flutter-autoroll
cb4649c27a Roll Skia from 4b16117e94b2 to a9db1213b179 (1 revision) (flutter/engine#49487) 
https://skia.googlesource.com/skia.git/+log/4b16117e94b2..a9db1213b179

2023-12-21 johnstiles@google.com Fix IWYU inclusion of <atomic> when TRACE_EVENT is used.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com,egdaniel@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-01-03 15:08:07 +00:00
Dan Field
125a9161bb [Impeller] Allow multiple --runtime-stage-* parameters to impellerc (flutter/engine#49475) 
This patch will be important for Android/Vulkan, where we'll need to bundle GLES, Vulkan, and SkSL (at least for now).

I've refactored impellerc_main to break up some of the larger methods into more granular ones.

I've also changed the way that the `IPLR` output works so that we create as many compilers as runtime stages requested.

We still are in a weird situation where we create one "Default" compiler for the reflection data and depfile. I don't think that needs to be addressed in this patch, but we should do something about this. I've talked a little with @bdero and @jonahwilliams - it will probably involve something like making the generated reflection data a bit more flexible than it currently is so that it can more ergonomically capture different platform anomalies - we could do this either by having a compiler type that is explicitly for generating reflection data rather than using one arbitrary one and making the reflector try to be platform agnostic. I've filed a couple TODOs related to this and linked them in the patch.

Fixes https://github.com/flutter/flutter/issues/140817
 2024-01-03 06:55:29 +00:00
Jonah Williams
3abb46f682 [Impeller] add doc on iOS flamegraph capture. (flutter/engine#49469) 
I find flamegraphs pretty useful, but Xcode doesn't have one built in that I know of.
 2024-01-02 23:52:21 +00:00
Loïc Sharma
8be4835c7c Revert "Reland "[Windows] Move to FlutterCompositor for rendering" (flutter/engine#49461) 
This reverts https://github.com/flutter/engine/pull/49262 (f3381e1080) as it regressed [`material_floating_search_bar`](https://pub.dev/packages/material_floating_search_bar_2)'s animation.

This revert was created manually due to merge conflicts.

Issue tracking bug: https://github.com/flutter/flutter/issues/140828

Part of https://github.com/flutter/flutter/issues/128904

<details>
<summary>Minimal repro of the broken animation...</summary>

Here's what the animation is supposed to look like:
![good](https://publish-01.obsidian.md/access/b48ac8ca270cd9dac18c4a64d11b1c02/assets/2023-12-28-compositor_animation_regression_good.gif)

Here's what the animation actually looks like: ![bad](https://publish-01.obsidian.md/access/b48ac8ca270cd9dac18c4a64d11b1c02/assets/2023-12-28-compositor_animation_regression_bad.gif)

Here is a minimal repro of the broken animation:

```dart
// The Windows compositor changes regresses the animation in
// the `material_floating_search_bar_2` package:
// 
// https://pub.dev/packages/material_floating_search_bar_2/versions/0.5.0
//
// Below is a minimal repro of the broken animation. This has two pieces:
//
//  1. The background fades to a grey color
//  2. A box is "revealed" using a custom clipper
//
// On framework commit b417fb828b332b0a4b0c80b742d86aa922de2649 this animation is broken on Windows.
// On framework commit 9c2a7560096223090d38bbd5b4c46760be396bc1 this animation works as expected on Windows.
//
// Good gif: https://publish-01.obsidian.md/access/b48ac8ca270cd9dac18c4a64d11b1c02/assets/2023-12-28-compositor_animation_regression_good.gif
// Bad gif: https://publish-01.obsidian.md/access/b48ac8ca270cd9dac18c4a64d11b1c02/assets/2023-12-28-compositor_animation_regression_bad.gif
import 'dart:math';
import 'dart:ui';

import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    // Not using `MaterialApp` is necessary to reproduce:
    return Container(
      color: Colors.white,
      child: const Directionality(
        textDirection: TextDirection.ltr,
        child: FloatingSearchBar(),
      ),
    );

    // Switching to `MaterialApp` fixes the issue:
    // return const MaterialApp(
    //   home: Scaffold(
    //     body: FloatingSearchBar(),
    //   ),
    // );
  }
}

class FloatingSearchBar extends StatefulWidget {
  const FloatingSearchBar({super.key});

  @override
  FloatingSearchBarState createState() => FloatingSearchBarState();
}

class FloatingSearchBarState extends State<FloatingSearchBar> with SingleTickerProviderStateMixin {
  late final AnimationController _controller = AnimationController(
    vsync: this,
    duration: const Duration(seconds: 2),
  );

  @override
  void dispose() {
    _controller.dispose();
    super.dispose();
  }

  void _animate() {
    if (_controller.isDismissed || _controller.status == AnimationStatus.reverse) {
      _controller.forward();
    } else {
      _controller.reverse();
    }
  }

  @override
  Widget build(BuildContext context) {
    return AnimatedBuilder(
      animation: _controller,
      builder: (BuildContext context, _) {
        return Stack(
          children: <Widget>[
            if (!_controller.isDismissed)
              FadeTransition(
                opacity: _controller,
                child: const SizedBox.expand(
                  child: DecoratedBox(
                    decoration: BoxDecoration(color: Colors.black26),
                  ),
                ),
              ),

            _buildSearchBar(),
          ],
        );
      },
    );
  }

  Widget _buildSearchBar() {
    return Column(
      crossAxisAlignment: CrossAxisAlignment.stretch,
      children: <Widget>[
        // This is where the search text input would go...
        GestureDetector(
          onTap: () => _animate(),
          child: Text(
            switch (_controller.status) {
              AnimationStatus.forward || AnimationStatus.completed => 'Click to close',
              AnimationStatus.reverse || AnimationStatus.dismissed => 'Click to open',
            },
            style: const TextStyle(color: Colors.black),
          ),
        ),
        
        // Below are where the search results would be. Clicking on the search
        // input above reveals the results below.

        // Removing this fixes the background's fade transition.
        ClipOval(
          clipper: _CircularRevealClipper(
            fraction: _controller.value,
          ),
          child: DecoratedBox(
            decoration: BoxDecoration(
              color: Colors.white,
              // Removing this line fixes the background's fade transition.
              borderRadius: BorderRadius.circular(16.0),
            ),
            child: const Padding(
              padding: EdgeInsets.all(64.0),
              child: Text(
                'Hello world',
                style: TextStyle(color: Colors.black),
              ),
            ),
          ),
        ),
      ],
    );
  }
}

class _CircularRevealClipper extends CustomClipper<Rect> {
  const _CircularRevealClipper({required this.fraction});

  final double fraction;

  @override
  Rect getClip(Size size) {
    final double halfWidth = size.width * 0.5;
    final double maxRadius = sqrt(halfWidth * halfWidth + size.height * size.height);
    final double radius = lerpDouble(0.0, maxRadius, fraction) ?? 0;

    return Rect.fromCircle(
      center: Offset(halfWidth, 0),
      radius: radius,
    );
  }

  @override
  bool shouldReclip(CustomClipper<Rect> oldClipper) {
    if (oldClipper is _CircularRevealClipper) {
      return oldClipper.fraction != fraction;
    }

    return true;
  }
}

```

</details>

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-02 23:31:04 +00:00
Dan Field
1255dfd26a Start wiring up fragment program for OpenGLES (flutter/engine#49347) 
Makes fragment programs work for OpenGLES backend.

Fixes https://github.com/flutter/flutter/issues/113715
Fixes https://github.com/flutter/flutter/issues/105538
I cannot find a dedicated issue for this, but there probably is someone somewhere and I don't want to file a new one for it.
 2024-01-02 22:11:05 +00:00
Yegor
7dce8b8825 [web] make TextStyle implementations consistent (flutter/engine#49465) 
Make TextStyle implementations consistent across web renderers and consistent with the mobile implementation. This will allow us to unskip `test/painting/text_style_test.dart` on the framework side.
 2024-01-02 20:41:08 +00:00
John McCutchan
6518198fc6 Android Platform Views support Verified Input Events (flutter/engine#49268) 
Android Platform Views process MotionEvents in a complicated way:

1. MotionEvent is captured and delivered to
PlatformViewWrapper.onTouchEvent (TLHC) or
FlutterMutatorView.onTouchEvent (HC)
2. MotionEvent is transformed by the AndroidTouchProcessor into a
PointerEvent
3. AndroidTouchProcessor sends the PointerEvent over the
PlatformViewChannel
4. Framework processes the PointerEvent
5. Framework sends the PointerEvent over the PlatformViewChannel.
6. in PlatformViewsController.onTouch a new MotionEvent is synthesized
7. The MotionEvent is delivered to the platform view

After step (6) the MotionEvent will fail Verification
(`android.hardware.input.InputManager.verifyInputEvent`).

The fix requires that in step (6) we use the original motion event
delivered in step (1) instead of synthesizing a new instance.
 2024-01-02 11:32:06 -08:00
gaaclarke
9ae8b1e79c [Impeller] new blur: implemented ping ponging (flutter/engine#49252) 
This will reuse the downsample texture for the blur pass.

issue: https://github.com/flutter/flutter/issues/140189

Testing: This has golden image coverage for the refactoring. There is a
slight performance difference which will show up in benchmarks. Ideally
there would also be a memory test for the blur. I don't think there is
one yet.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-01-02 11:23:08 -08:00
Dan Field
76fc29312f Make sure to finish the suite if all tests are skipped (flutter/engine#49339) 
Fixes https://github.com/flutter/flutter/issues/140481

Before this fix, if all tests are skipped, the `onDone` callback never fires, which means the recieve port never closes, which means the process just hangs indefinitely (and the success message is never printed).
 2024-01-02 18:34:04 +00:00
Rulong Chen（陈汝龙）
ba2b335b99 Fix NPE when platform plugin delegate is null (flutter/engine#49391) 
Fixes: 
https://github.com/flutter/flutter/issues/140600
https://github.com/flutter/flutter/issues/140031

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
 2024-01-02 08:54:39 -08:00
Rulong Chen（陈汝龙）
62abbc2a03 Add try-with-resource support to TraceSection (flutter/engine#49445) 
This PR adds a new way to define scoped trace events in Java, using the try-with-resource construct. This makes code simpler to read, and less error-prone.

Before:
```java
try {
  TraceSection.begin("name");
  // ....
} finally {
  TraceSection.end();
}
```

Now:
```java
try (TraceSection e = TraceSection.scoped("name")) {
  // ...
}
```

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 2024-01-02 16:35:19 +00:00
skia-flutter-autoroll
f4bf7e1ad2 Roll Dart SDK from 4b2415d82948 to 54ae19428139 (1 revision) (flutter/engine#49423) 
https://dart.googlesource.com/sdk.git/+log/4b2415d82948..54ae19428139

2023-12-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.3.0-273.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2023-12-29 17:43:08 +00:00