9341 Commits

Author SHA1 Message Date
Alexander Aprelev
d58d893dec In tests run dart code on ui(rather than on platform) thread. (flutter/engine#17686) 2020-04-13 16:50:11 -07:00
skia-flutter-autoroll
5386ac8b70 Roll src/third_party/skia d468a1619a2f..f3953d04a0b8 (11 commits) (flutter/engine#17685) 2020-04-13 16:50:08 -07:00
George Wright
3e1e1b342d Use VK_LAYER_KHRONOS_validation only on Fuchsia (flutter/engine#17683) 2020-04-13 16:45:03 -07:00
Ferhat
1e6e25c4da [web] Fix compositing order when adding paragraph tags (flutter/engine#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
gaaclarke
3849b114d4 Made it so unit tests can be written against all ios engine code. (flutter/engine#17624) 2020-04-13 12:34:54 -07:00
George Wright
05390d1871 Enable required extension 2020-04-13 12:14:06 -07:00
Nurhan Turgut
29c24b8a47 Run integration tests on ci (flutter/engine#17598)
* changing felt script to fetch flutter

* changing the clone_flutter.sh code

* running integration tests with felt on cirrus. fetch framework in CI (not in local).

* only run cirrus tests on chrome. fix a comma in the flutter command path

* adding comments to public flags

* use local engine parameter for flutter pub get

* change flutter executable used for flutter drive command

* fix a cleanup issue. address comments. add toolException. enable web in flutter

* address reviwer comments. fix issue with local-engine

* address reviwer comments. fix issue with local-engine

* using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage

* clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set

* fixing typos. updating readme for the new flag.

* fix directory error

* addressing reviewer comments
2020-04-13 09:54:54 -07:00
skia-flutter-autoroll
998038836a Roll src/third_party/skia 4b4efe4d6f1f..d468a1619a2f (1 commits) (flutter/engine#17677) 2020-04-13 07:00:02 -07:00
skia-flutter-autoroll
7d9ab8a4ac Roll src/third_party/skia 32c61af49cdb..4b4efe4d6f1f (3 commits) (flutter/engine#17675) 2020-04-13 02:50:01 -07:00
skia-flutter-autoroll
bdb620ad59 Roll src/third_party/skia 6dfc55454671..32c61af49cdb (1 commits) (flutter/engine#17672) 2020-04-12 23:10:01 -07:00
skia-flutter-autoroll
b870c8826b Roll src/third_party/skia 459ecee2cbdc..6dfc55454671 (2 commits) (flutter/engine#17663) 2020-04-12 01:45:02 -07:00
stuartmorgan
9db5c3fb62 Fix C++ MethodChannel reply type (flutter/engine#17607)
Makes InvokeMethod's reply a high-level response object, rather than
binary data, matching the abstraction level of the class (and the other
languages' implementations).

In support of that:
- Adds the logic to the codecs to decode response envelopes, which had
  never been implemented.
- Adds a convience implementation of MethodResult that forwards to
  lambdas, so that one-off invocation handlers are easier to write.

Also simplified BinaryMessenger's API so that subclasses only need to
implement one version of Send, rather than two almost-identical versions.

Fixes https://github.com/flutter/flutter/issues/53223
2020-04-11 19:06:37 -07:00
Jason Simmons
2105db78eb Update editing state in InputConnectionAdaptor.setSelection (flutter/engine#17652)
The BaseInputConnection superclass does not call endBatchEdit
in setSelection and therefore does not implicitly cause
InputConnectionAdaptor to send a state update.

Some input modes such as numeric keypads will not function without
these updates.
2020-04-11 17:29:50 -07:00
skia-flutter-autoroll
96ae70db30 Roll src/third_party/skia daf94c56bcb3..459ecee2cbdc (1 commits) (flutter/engine#17655) 2020-04-11 12:00:02 -07:00
Mehmet Fidanboylu
2a925e4636 Add support for setting allow http flag in Dart VM (flutter/engine#17653) 2020-04-11 11:55:05 -07:00
stuartmorgan
f8d35c125d Always build GTK shell (flutter/engine#17634) 2020-04-11 11:50:03 -07:00
Gary Qian
8e18094f12 Implement Hashcode for TextEditingValue in InputConnectionAdaptor (flutter/engine#17643) 2020-04-10 16:00:01 -07:00
skia-flutter-autoroll
c2acb0782b Roll src/third_party/skia 801ba0d6064f..daf94c56bcb3 (4 commits) (flutter/engine#17644) 2020-04-10 15:30:02 -07:00
Mouad Debbar
9189386f95 [web] Combine duplicate platform message spy implementations (flutter/engine#17615) 2020-04-10 13:30:41 -07:00
Chris Yang
8500bd4156 Reland "Improve iOS PlatformViews to better handle thread merging. #16935" (flutter/engine#17609) 2020-04-10 13:25:02 -07:00
skia-flutter-autoroll
b0bcdadb79 Roll src/third_party/skia 96bfeff55c58..801ba0d6064f (8 commits) (flutter/engine#17639) 2020-04-10 13:15:04 -07:00
Chris Bracken
c6ad79ea8a Roll fuchsia/sdk/core/linux-amd64 from VzWN4... to LnaL2... (flutter/engine#17640)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC  on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-04-10 12:41:20 -07:00
godofredoc
6b8717e6ad Remove duplicated cirrus tasks. (flutter/engine#17625)
Some cirrus tasks are also running on LUCI. We are removing duplicated
tasks to free up cirrus capacity.

https://github.com/flutter/flutter/issues/54412
2020-04-10 10:42:41 -07:00
skia-flutter-autoroll
3de91deb3f Roll src/third_party/skia f7255d72f8da..96bfeff55c58 (4 commits) (flutter/engine#17638) 2020-04-10 09:55:04 -07:00
Chris Bracken
ab779dada5 Eliminate fx_log_init call (flutter/engine#17622)
fx_log_init was already a no-op, and was eliminated in the latest
Fuchsia SDK.

See: https://fuchsia.googlesource.com/fuchsia/+/47e568475f535c00f53c86e19ff4d8736a7b261f
2020-04-10 09:02:52 -07:00
skia-flutter-autoroll
3cccfe1977 Roll src/third_party/skia 05e2350de5a9..f7255d72f8da (1 commits) (flutter/engine#17633) 2020-04-10 08:00:03 -07:00
skia-flutter-autoroll
b5b16f2244 Roll src/third_party/skia 48d345fd83fd..05e2350de5a9 (3 commits) (flutter/engine#17629) 2020-04-10 01:10:03 -07:00
liyuqian
6c93145ef5 Read SkSLs from asset (flutter/engine#17601)
Fixes https://github.com/flutter/flutter/issues/53117

Test added:
- ShellTest.CanLoadSkSLsFromAsset
2020-04-10 00:16:33 -07:00
skia-flutter-autoroll
a2ed53dc2e Roll src/third_party/skia 854ac61e90a4..48d345fd83fd (1 commits) (flutter/engine#17627) 2020-04-09 23:15:02 -07:00
Ferhat
08e7546e0a Fix Path hit test code for high dpi devices (flutter/engine#17608) 2020-04-09 22:18:42 -07:00
Francisco Magdaleno
c38e7106c0 [windows] Sends complete key data to framework (flutter/engine#17577) 2020-04-09 20:55:02 -07:00
skia-flutter-autoroll
efff943c47 Roll src/third_party/skia 8561fc23c927..854ac61e90a4 (36 commits) (flutter/engine#17620) 2020-04-09 20:45:04 -07:00
Shi-Hao Hong
7eae32d7f2 Revert getSystemGestureExclusionRects and setSystemGestureExclusionRects (flutter/engine#17613)
* Revert getSystemGestureExclusionRects and setSystemGestureExclusionRects 

* Remove references to removed PlatformChannelTest.java file
2020-04-09 20:44:37 -07:00
Joshua Seaton
e9abdbf148 [tools][fuchsia] Reland 'Do not tar debug symbol CIPD uploads' (flutter/engine#17597)
Fuchsia is the main consumer of these CIPD packages and - to simplify
its infrastructure - it is migrating its SDK partners over to producing
a CIPD package containing a flat .build-id directory.

This change also updates the CIPD package so that the .build-id
directory is placed at the root.

Bug: fxbug.dev/41443
2020-04-09 16:09:31 -07:00
Chris Bracken
682af7ed8e Eliminate verify_framework presubmit step (flutter/engine#17617)
This was originally added in 5600aee512fe8f8fc2c17da3dc871bea45d3e8f3 as
a means of avoiding running framework tests if they're known to be
failing, but given how flaky Cirrus infrastructure has historically
been, the number of false positives is too high.
2020-04-09 15:22:22 -07:00
gaaclarke
bbae0c06d4 Enabled hiding the home indicator with SystemChrome.setEnabledSystemUIOverlays (flutter/engine#17574) 2020-04-09 09:43:38 -07:00
skia-flutter-autoroll
3fd7aa9da4 Roll src/third_party/skia f6860405e1bf..8561fc23c927 (7 commits) (flutter/engine#17592)
https://skia.googlesource.com/skia.git/+log/f6860405e1bf..8561fc23c927

git log f6860405e1bf..8561fc23c927 --date=short --first-parent --format='%ad %ae %s'
2020-04-08 egdaniel@google.com Update gpu flush semaphore contract.
2020-04-08 senorblanco@chromium.org Dawn: staging manager rewrite.
2020-04-08 fmalita@chromium.org [SVG] Fix spec links
2020-04-08 mtklein@google.com stifle leaks in terminator_CreateDevice()
2020-04-08 mtklein@google.com get skvm/llvm building again
2020-04-08 mtklein@google.com narrow use of fast_unwind_on_malloc=0
2020-04-08 mtklein@google.com shard ASAN bonusconfigs bot

Created with:
  gclient setdep -r src/third_party/skia@8561fc23c927

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: csmartdalton@google.com
2020-04-09 10:28:04 -04:00
Chris Yang
efe45cd875 Revert "Improve iOS PlatformViews to better handle thread merging. (#16935)" (flutter/engine#17600)
This reverts commit 930696bbb75ffdb098df4081e0353f4fac38b075.
2020-04-08 21:15:38 -07:00
Nurhan Turgut
4dc4c1fcf2 [web] using pkill to quit safari (flutter/engine#17533)
* adding an apple script to quit safari

* making changes to utils and adding cleanup after unit tests failed

* switch saai quit to pkill instead of applescript

* adding toolexception

* adding a cleanup function option to felt.

* removing unnecassary await's added for the previos version of the PR

* removing unnecassary async

* fix analyze error
2020-04-08 17:35:10 -07:00
Chris Yang
930696bbb7 Improve iOS PlatformViews to better handle thread merging. (flutter/engine#16935) 2020-04-08 17:33:33 -07:00
Ferhat
cf1e97470b [web] Fix multi-reply on message channel. Add test (flutter/engine#17591)
* Fix multi-reply on message channel. Add test
* Add check for viewInstanceCount
* skip no-headless test
2020-04-08 17:18:06 -07:00
Dan Field
d5f40cc11e set -e on assemble_apk.sh (flutter/engine#17588)
* set -e on assemble_apk.sh

* build the necessary artifacts
2020-04-08 14:52:14 -07:00
Mouad Debbar
ec2ab6a871 [web] Fix regression of pointer events on mobile browsers (flutter/engine#17595) 2020-04-08 14:48:56 -07:00
Mouad Debbar
f353d919aa [web] Fix window.defaultRouteName (flutter/engine#17580) 2020-04-08 13:51:38 -07:00
Gary Qian
a03f69c53a Implement repeat filtering logic in Android Embedder (flutter/engine#17509) 2020-04-08 12:51:43 -07:00
godofredoc
e894999885 Add logs between fuchsia test steps. (flutter/engine#17584)
* Add logs between fuchsia test steps.

Adding logs and date time in between steps will simplify finding the
steps that are failing during the fuchsia tests.

https://github.com/flutter/flutter/issues/54253

* Use date command instead of DATE..

* Remove extra log line.

* Same spacer lenght for all the log lines.
2020-04-08 12:50:17 -07:00
liyuqian
9f6c6e0218 Fix typo in shell_benchmarks (flutter/engine#17578) 2020-04-08 12:16:03 -07:00
Harry Terkelsen
fc74a96f37 Do not enable antialiasing by default in CanvasKit mode (flutter/engine#17534)
* Do not enable antialiasing by default in CanvasKit mode

* Add comment
2020-04-08 11:55:23 -07:00
Kaushik Iska
78c5bc73ba [perf] Add a SceneDisplayLag event when we miss vsyncs (flutter/engine#17575)
This event goes from now -> current vsync target time
to avoid the limitations as seen in https://github.com/flutter/flutter/issues/54095#issuecomment-610636237

This event also tags additional metadata to capture
`vsync_transitions_missed` considering the refresh rate of the display.
2020-04-08 09:14:11 -07:00
Emmanuel Garcia
36c79c8a65 Change the directory to the scenario app (flutter/engine#17583) 2020-04-08 08:40:04 -07:00