Ben Konyi
d3f45828bf
Reland "Remove references to Observatory ( #38919 )" ( flutter/engine#39139 )
...
This reverts commit 5dd945442b230a2c0549ee6d798fda71e031a4a9.
2023-01-30 09:50:09 -05:00
skia-flutter-autoroll
a4cdc853dc
Roll Fuchsia Linux SDK from TiK_fVODtUaKOgxRf... to O_p8I_8713KlTZ7WG... ( flutter/engine#39231 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-28 22:16:06 +00:00
skia-flutter-autoroll
b7ccf7bfba
Roll Skia from 0b75650caf2a to 7df7a83f733d (13 revisions) ( flutter/engine#39225 )
...
https://skia.googlesource.com/skia.git/+log/0b75650caf2a..7df7a83f733d
2023-01-28 bsalomon@google.com Fix temporary SkMatrixProvider used to build SkVM in SkDraw:drawAtlas.
2023-01-27 johnstiles@google.com Revert "Remove canvas scale from runtime-intrinsics slide."
2023-01-27 bsalomon@google.com Make SkColorFilterBase::appendStages virtual and remove onAppendStages.
2023-01-27 kyslov@google.com Exposing Gainmap via BitmapRegionDecoder
2023-01-27 bsalomon@google.com Reland "Seed coords earlier in shader traversal for SkRasterPipeline."
2023-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from d723200bd4b5 to ead30fe6b410 (8 revisions)
2023-01-27 bsalomon@google.com Revert "Seed coords earlier in shader traversal for SkRasterPipeline."
2023-01-27 bsalomon@google.com Seed coords earlier in shader traversal for SkRasterPipeline.
2023-01-27 sharaks@google.com Update Skia milestone to 112
2023-01-27 nicolettep@google.com Roll Dawn from 3076a8bf178e to b2ec2c350576 (11 revisions)
2023-01-27 kyslov@google.com This rolls back JPEGR support via dedicated JPEGR decoder. Further JPEGR support will be via SkAndroidCodec::getGainmap.
2023-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump ua-parser-js from 0.7.31 to 0.7.33 in /modules/pathkit
2023-01-27 49699333+dependabot[bot]@users.noreply.github.com Bump ua-parser-js from 0.7.31 to 0.7.33 in /modules/canvaskit
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-28 11:07:18 +00:00
Jenn Magder
55a427bec8
Default to running the scenario tests on an arm iOS simulator variant on an Apple Silicon host Mac ( flutter/engine#39210 )
...
* Default to using an arm iOS simulator variant on Apple Silicon
* Kick tests
2023-01-28 02:57:45 +00:00
skia-flutter-autoroll
9f3d10fa70
Roll Dart SDK from 2cd9b7ac95e8 to 135f4c51c9ff (3 revisions) ( flutter/engine#39214 )
...
https://dart.googlesource.com/sdk.git/+log/2cd9b7ac95e8..135f4c51c9ff
2023-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-176.0.dev
2023-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-175.0.dev
2023-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-174.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-28 00:16:50 +00:00
Jenn Magder
1b4ce3fa8b
Use arm64 engine variant on simulators in iOS unit tests ( flutter/engine#39213 )
2023-01-28 00:16:47 +00:00
Miguel
f1bbb90589
[fuchsia] Diagnostics directory rights are R* ( flutter/engine#39203 )
2023-01-27 17:44:24 -05:00
Tamir Duberstein
15f53d515e
[fuchsia] Migrate to new RealmBuilder API ( flutter/engine#39205 )
...
See https://fxrev.dev/793422 .
Missed in 92fca42e0667969b3a78815c77afca9c6acd1c83,
3bfa5c5b1db5391d49cc58f9a23f1b4cd802d3e3 and
d429b674f1dd60590fda077fd893a4493c2b5455.
2023-01-27 15:42:15 -05:00
Jonah Williams
6306da26f1
[Impeller] support overlapping stops with SSBO gradients. ( flutter/engine#39174 )
...
* [impeller] gradient stops
* Support overlapping stops
* ++
* update test values
* Use padding type
* bytes not floats
* move to entity
* ++
* Update gradient_generator.h
* Update aiks_unittests.cc
* ++
2023-01-27 19:32:35 +00:00
Zachary Anderson
b62b3fb9ec
Move Linux Fuchsia FEMU to bringup due to flakes ( flutter/engine#39202 )
...
For https://github.com/flutter/flutter/issues/119356
2023-01-27 11:30:22 -08:00
Jonah Williams
1cb65559a3
[impellerc] remove remaining remap sampler support ( flutter/engine#39198 )
2023-01-27 18:50:56 +00:00
Jonah Williams
b8974b5199
[impellerc] remove coffset usage ( flutter/engine#39199 )
...
* [impellerc] remove coffset usage
* ++
2023-01-27 18:47:56 +00:00
Derek Xu
e31df55438
Handle proto deps that were added to the Dart SDK ( flutter/engine#39098 )
2023-01-27 10:24:53 -08:00
Zachary Anderson
54e53b326e
Fix for downstream C++20 compiler ( flutter/engine#39197 )
2023-01-27 10:12:19 -08:00
Tamir Duberstein
d429b674f1
[fuchsia] Migrate to new RealmBuilder API ( flutter/engine#39196 )
...
See https://fxrev.dev/793422 .
Missed in 92fca42e0667969b3a78815c77afca9c6acd1c83 and
3bfa5c5b1db5391d49cc58f9a23f1b4cd802d3e3.
2023-01-27 13:01:28 -05:00
Kaushik Iska
2dac47078e
Enable vulkan dev on macOS host ( flutter/engine#39179 )
2023-01-27 09:34:58 -08:00
Constantine Shablya
dcef53581c
Fix Vulkan embedder example ( flutter/engine#39052 )
2023-01-27 15:55:06 +00:00
skia-flutter-autoroll
c37e4cc691
Roll Skia from 091ec9bdcf9b to 0b75650caf2a (5 revisions) ( flutter/engine#39190 )
...
https://skia.googlesource.com/skia.git/+log/091ec9bdcf9b..0b75650caf2a
2023-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 3f8e117e3655 to d723200bd4b5 (5 revisions)
2023-01-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b64b573bac2b to 1d9b8d802eb2 (17 revisions)
2023-01-27 armansito@google.com [sksl][wgsl] Support vector splat constructor
2023-01-26 herb@google.com Combine prepareForMaskDrawing
2023-01-26 johnstiles@google.com Add Raster Pipeline codegen support to SkRuntimeEffect.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-27 15:55:03 +00:00
skia-flutter-autoroll
9f0c1f3734
Roll Dart SDK from dcdd3fbb3116 to 2cd9b7ac95e8 (2 revisions) ( flutter/engine#39185 )
...
https://dart.googlesource.com/sdk.git/+log/dcdd3fbb3116..2cd9b7ac95e8
2023-01-27 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-173.0.dev
2023-01-26 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-172.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-27 15:52:54 +00:00
skia-flutter-autoroll
2f734d9484
Roll Fuchsia Linux SDK from kdjOCYzDtnfY30985... to 6c2H32X3EXOGlWIgb... ( flutter/engine#39193 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-27 15:51:04 +00:00
Jonah Williams
82a5c50210
[Impeller] ensure 1x1 has mipcount of 1 ( flutter/engine#39182 )
...
* [Impeller] ensure 1x1 has mipcount of 1
* Update geometry_unittests.cc
* Update size.h
2023-01-27 03:33:27 +00:00
Tamir Duberstein
3bfa5c5b1d
[fuchsia] Migrate to new RealmBuilder API ( flutter/engine#39175 )
...
See https://fxrev.dev/793422 .
Missed in 92fca42e0667969b3a78815c77afca9c6acd1c83.
2023-01-26 17:54:43 -08:00
skia-flutter-autoroll
2b4159dedf
Roll Skia from ba4721319a92 to 091ec9bdcf9b (12 revisions) ( flutter/engine#39177 )
...
https://skia.googlesource.com/skia.git/+log/ba4721319a92..091ec9bdcf9b
2023-01-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 3c9bfe50679a to bd000c01fd40
2023-01-26 jvanverth@google.com [metal] Fix MetalWindowContext destruction on Mac
2023-01-26 jmbetancourt@google.com add visibility to targets referenced by ganesh/gl BUILD file
2023-01-26 herb@google.com Simplify prepare_for_SDFT_drawing add pos mapping
2023-01-26 armansito@google.com [sksl][wgsl] Function call expressions with no out-params
2023-01-26 johnstiles@google.com Simplify for-loops that do not use `continue`.
2023-01-26 johnstiles@google.com Add an Analysis pass to check if a loop uses `continue` or `break`.
2023-01-26 michaelludwig@google.com [graphite] Support elliptical corners for hairlines in AnalyticRRectRenderStep
2023-01-26 johnstiles@google.com Simplify function-result stack in RP codegen.
2023-01-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 50eca412c1e8 to 3f8e117e3655 (5 revisions)
2023-01-26 johnstiles@google.com Implement length intrinsic in RP codegen.
2023-01-26 johnstiles@google.com Simplify the switch-case block visitor.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-26 23:41:50 +00:00
Hannes Winkler
7e99ce795b
properly namespace flutter software pixel formats ( flutter/engine#38847 )
...
- rename `kGray8 --> kFlutterSoftwarePixelFormatGray8`
- rename `kRGB565 --> kFlutterSoftwarePixelFormatRGB565`
- etc.
2023-01-26 22:30:17 +00:00
Zachary Anderson
56a4d347ae
Revert "[macos] Move TextInputPlugin outside of visible area ( #39031 )" ( flutter/engine#39176 )
...
This reverts commit d06ef7a5bfbed4cba6eb98f47b618803ac6c8a53.
2023-01-26 13:47:58 -08:00
Matej Knopp
d06ef7a5bf
[macos] Move TextInputPlugin outside of visible area ( flutter/engine#39031 )
...
* [macos] Move TextInputPlugin outside of visible area
* Make plugin empty and add test
2023-01-26 21:12:44 +00:00
J-P Nurmi
d7963e6fa1
[Linux][FlView] fix rendering on startup when shown after plugin registration ( flutter/engine#38982 )
...
* [FlView] fix rendering on startup when shown after plugin registration
* Add clarifying comment
2023-01-26 21:11:20 +00:00
skia-flutter-autoroll
4ba3d1a87c
Roll Skia from e9ac244d61b2 to ba4721319a92 (1 revision) ( flutter/engine#39170 )
...
https://skia.googlesource.com/skia.git/+log/e9ac244d61b2..ba4721319a92
2023-01-26 herb@google.com Convert prepareForSDFTDrawing to shared code
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-26 20:25:14 +00:00
skia-flutter-autoroll
b8547ed599
Roll Fuchsia Linux SDK from ggI4a2jNo5aj6Rp6w... to kdjOCYzDtnfY30985... ( flutter/engine#39169 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-26 19:48:07 +00:00
Jonah Williams
e5d80e9fe2
[Impeller] partially remove remap sampler support ( flutter/engine#39147 )
...
* partially remove remap sampler support
* Update runtime_effect_contents.cc
2023-01-26 19:20:05 +00:00
Tamir Duberstein
92fca42e06
[fuchsia] Migrate to new RealmBuilder API ( flutter/engine#39163 )
...
See https://fxrev.dev/793422 .
2023-01-26 11:15:23 -08:00
skia-flutter-autoroll
cc7fdccf19
Roll Skia from ad7955820dc6 to e9ac244d61b2 (6 revisions) ( flutter/engine#39165 )
...
https://skia.googlesource.com/skia.git/+log/ad7955820dc6..e9ac244d61b2
2023-01-26 johnstiles@google.com Add support for dynamically-uniform if statements.
2023-01-26 johnstiles@google.com Add RP codegen support for dynamically-uniform ternaries.
2023-01-26 johnstiles@google.com Add Analysis check for dynamically-uniform expressions.
2023-01-26 johnstiles@google.com Add RP builder support for branch_if_all_slots_equal.
2023-01-26 johnstiles@google.com Add RasterPipeline op branch_if_all_lanes_equal.
2023-01-26 herb@google.com Add lock/unlock to StrikeForGPU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-26 18:15:16 +00:00
skia-flutter-autoroll
b5f63c8f71
Roll Skia from 5e363a69efbe to ad7955820dc6 (2 revisions) ( flutter/engine#39161 )
...
https://skia.googlesource.com/skia.git/+log/5e363a69efbe..ad7955820dc6
2023-01-26 robertphillips@google.com [graphite] Update DM configs for upcoming testing
2023-01-26 johnstiles@google.com Remove canvas scale from runtime-intrinsics slide.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-26 16:26:31 +00:00
Ricardo Amador
2e9905afab
Update infrastructure python code to be compatible with python 2 and python 3 ( flutter/engine#39133 )
...
* Compatibility with python2 and python3
* Formatting
* Updated to use a function instead of decoding bytes in multiple places.
* Formatting and whitespace cleanup.
* Fix import statement.
* Linter change for docstring.
* Formatting.
* Remove function from run_tests.py since it is a pain to import.
* Add todo message for python 2 deprecation.
* Updated copyright year.
2023-01-26 16:04:31 +00:00
skia-flutter-autoroll
e1ddee7b74
Roll Skia from 0e1cb7bc43dc to 5e363a69efbe (3 revisions) ( flutter/engine#39158 )
...
https://skia.googlesource.com/skia.git/+log/0e1cb7bc43dc..5e363a69efbe
2023-01-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ba538cd033e4 to 50eca412c1e8 (2 revisions)
2023-01-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 660e4a7c0d4f to b64b573bac2b (9 revisions)
2023-01-26 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 8666a7bf5e4a to 0162309d048f (6 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-26 08:35:11 +00:00
skia-flutter-autoroll
f91eed3e5c
Roll Skia from 393fb1ec80f4 to 3d0e2ad41911 (6 revisions) ( flutter/engine#39153 )
...
https://skia.googlesource.com/skia.git/+log/393fb1ec80f4..3d0e2ad41911
2023-01-25 kjlubick@google.com Add shim file for SkTSearch.h
2023-01-25 bungeman@google.com Handle strikeout metrics in SkScalerContext_Mac
2023-01-25 jvanverth@google.com Add minimal perspective text GM.
2023-01-25 herb@google.com Move memory accounting to allocation sites
2023-01-25 kjlubick@google.com [base] Move several more files from src/core into base.
2023-01-25 kjlubick@google.com Remove empty file SkUtilsArm.cpp
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-26 04:32:04 +00:00
Brandon DeRosier
d6491b8368
[Impeller] Use analytical normals for stroke caps ( flutter/engine#39124 )
2023-01-25 16:14:15 -08:00
Tong Mu
02a18907ce
Reland "[macOS] Formalize FlutterViewController's initialization flow, and prohibit replacing" ( flutter/engine#39145 )
...
* Revert "Revert "[macOS] Formalize FlutterViewController's initialization flow, and prohibit replacing (#38981 )" (#39144 )"
This reverts commit be4ea1a42d27ca88007f9013fd7c5526087b3268.
* Fix?
2023-01-26 00:13:47 +00:00
Tong Mu
be4ea1a42d
Revert "[macOS] Formalize FlutterViewController's initialization flow, and prohibit replacing ( #38981 )" ( flutter/engine#39144 )
...
This reverts commit a8242f0b392a03c4c8fb3d299cabceb06462a647.
2023-01-25 15:16:59 -08:00
Tong Mu
a8242f0b39
[macOS] Formalize FlutterViewController's initialization flow, and prohibit replacing ( flutter/engine#38981 )
...
This PR adds FlutterViewController.id, and formalizes how FlutterViewController is initialized by FlutterEngine:
When FlutterViewController is set to the engine, the engine calls FlutterViewController#attachToEngine:withId:.
When FlutterViewController is unset from the engine, the engine calls FlutterViewController#detachFromEngine.
This allows the ID to be generated by the engine.
The default View ID is now 1 instead of 0. In this way, we can use 0 as an empty value, the value for FlutterViewController.id when the FVC is not attached to an engine. (IDs are meant to be opaque, and views should be a map, not an array anyway.)
This PR moves almost all initialization code into FVC's CommonInit to ensure that all init path produces the expected result.
With this PR, FlutterEngine no long supports replacing viewController (from non-null to a different non-null). Setting the view controller (from null to non-null) is intended to allow pre-warming an engine before displaying it in add-to-app, but replacing the view controller does not make much sense.
If the developer wants to persist the state of the view between different windows, they could just attach the view controller to different windows.
In fact, Flutter doesn't even have a way to create a FlutterViewController that is unattached to an engine. All initializers either require an engine or create an engine.
As a result, unit tests that used to create FVC with the wrong initializer are fixed.
2023-01-25 14:32:27 -08:00
Kaushik Iska
68a9f036b7
Get the vulkan backend working again ( flutter/engine#39103 )
...
* Enable Vulkan to be developed on macOS host
* Disables modern features as SSBOs are wired on Vulkan yet.
* Sub-optimal presentation mode must not be a fatal issue.
* Allow for shader outputs not to be consumed.
* remove enabling macOS
2023-01-25 21:51:16 +00:00
skia-flutter-autoroll
0699029706
Roll Skia from c4b171fe5668 to 393fb1ec80f4 (9 revisions) ( flutter/engine#39138 )
...
https://skia.googlesource.com/skia.git/+log/c4b171fe5668..393fb1ec80f4
2023-01-25 bsalomon@google.com Remove unnecessary use of SkOverrideDeviceMatrixProvider
2023-01-25 nicolettep@google.com Revert "Add SkJpegGainmapEncoder::EncodeJpegR and EncodeHDRGM"
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 71bd1907ea2f to ba538cd033e4 (2 revisions)
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from a101f5006435 to d23b977e964d
2023-01-25 bungeman@google.com [canvaskit] Control trivial_abi in compile_gm.sh
2023-01-25 jmbetancourt@google.com remove unused config groups in sk_app Bazel BUILD file
2023-01-25 herb@google.com Make memory accounting go through SkStrike
2023-01-25 kjlubick@google.com [base] Add extra tests for cubic and quadratic root solving
2023-01-25 jlavrova@google.com Fixing broken Android autoroll
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-25 21:31:18 +00:00
Callum Moffat
be0feedee7
Fix position of ImageFilter layer when raster-cached ( flutter/engine#38567 )
...
* Fix position of ImageFilter layer when raster-cached
* Move integral transform and add tests
* Don't round in Preroll
2023-01-25 21:12:02 +00:00
Brandon DeRosier
02b0210563
[Impeller] Make text glyph offsets respect the current transform ( flutter/engine#39119 )
2023-01-25 12:01:50 -08:00
Michael Goderbauer
c545a799d2
Remove unnecessary null checks ( flutter/engine#39113 )
2023-01-25 10:15:02 -08:00
skia-flutter-autoroll
a5500ec179
Roll Fuchsia Linux SDK from E9m-Gk382PkB7_Nbp... to pGX7tanT1okL8XCg-... ( flutter/engine#39130 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-25 17:01:10 +00:00
Zachary Anderson
daeb8316d7
Only build analyze_snapshot on Linux host ( flutter/engine#39129 )
2023-01-25 08:35:57 -08:00
skia-flutter-autoroll
d15e4fe71f
Roll Skia from da5034f9d117 to c4b171fe5668 (1 revision) ( flutter/engine#39127 )
...
https://skia.googlesource.com/skia.git/+log/da5034f9d117..c4b171fe5668
2023-01-25 ccameron@chromium.org Add SkJpegGainmapEncoder::EncodeJpegR and EncodeHDRGM
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-25 15:47:02 +00:00
Jonah Williams
6347667c37
[web] use a render target instead of a new surface for Picture.toImage ( flutter/engine#38573 )
...
* [web] use a render target instead of a new surface for Picture.toImage
* setup grcontext if missing
* ++
* dispose
* Add unit test for MakeRenderTarget
* ++
* ++
* ++
* ++
* ++
* ++
* ++
2023-01-25 15:09:01 +00:00
skia-flutter-autoroll
a891ed0e8a
Roll Skia from 8ffd5c20d634 to da5034f9d117 (4 revisions) ( flutter/engine#39123 )
...
https://skia.googlesource.com/skia.git/+log/8ffd5c20d634..da5034f9d117
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 9a72a98eb94f to 660e4a7c0d4f (4 revisions)
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from c744a23d77d5 to bb0229002db5 (5 revisions)
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from d7a3d7db7fde to 8666a7bf5e4a (8 revisions)
2023-01-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from ab6fd1e74de0 to 71bd1907ea2f (5 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC nicolettep@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-01-25 11:07:20 +00:00