14 Commits

Author SHA1 Message Date
Hans Muller
221e1e0dee Dismissable provides intrinsic support for resize animation 2015-07-22 12:55:45 -07:00
Hixie
383e504f5a Introduce an explicit Key type.
This fixes some theoretical bugs whereby we were using hashCode to try
to get unique keys for objects, but really we wanted object identity.
It also lays the groundwork for a new GlobalKey concept.

I tried to keep the impact on the code minimal, which is why the "Key"
constructor is actually a factory that returns a StringKey. The code
has this class hierarchy:

```
   KeyBase
    |
   Key--------------+---------------+
    |               |               |
   StringKey    ObjectKey       UniqueKey
```

...where the constructors are Key and Key.stringify (StringKey),
Key.fromObjectIdentity (ObjectKey), and Key.unique (UniqueKey).

We could instead of factory methods use regular constructors with the
following hierarchy:

```
   KeyBase
    |
   LocalKey---------+---------------+
    |               |               |
   Key      ObjectIdentityKey   UniqueKey
```

...with constructors Key, Key.stringify, ObjectIdentityKey, and
UniqueKey, but I felt that that was maybe a more confusing hierarchy.
I don't have a strong opinion on this.
2015-07-22 09:14:06 -07:00
Hixie
5e6d9d6bb5 Remove redundant operator== and hashCode functions in card example.
It turns out that we aren't really using these. The identity logic is sufficient.

Also, add some asserts for a crash I had once but couldn't reproduce, in case that helps catch it next time.
2015-07-21 15:26:54 -07:00
Adam Barth
a43a34e901 Fix more analyzer warnings 2015-07-21 13:59:18 -07:00
Adam Barth
6dc026bdac Merge pull request #191 from abarth/image_height_width
Separate width and height parameters for Image widgets
2015-07-21 13:54:56 -07:00
Adam Barth
b5d28fb524 Merge pull request #192 from abarth/fix_warnings
Fix analyzer warnings
2015-07-21 13:52:37 -07:00
Adam Barth
b8d45ce91e Fix analyzer warnings 2015-07-21 13:51:27 -07:00
Adam Barth
50eac9559a Separate width and height parameters for Image widgets
This change makes it easier to defined only the width or the height of an image
and let the other value be filled in from the image's intrinsic aspect ratio.

Fixes #175
2015-07-21 13:46:10 -07:00
Matt Perry
a421da3c1b Renamed AnimatedType to AnimatedValue 2015-07-21 12:55:16 -07:00
Hans Muller
344ee7ccf4 Make it possible to identify BlockViewport children whose size or type has changed 2015-07-20 15:41:21 -07:00
Collin Jackson
6eb137185a Navigator improvements, avoid building invisible routes 2015-07-17 09:38:22 -07:00
Collin Jackson
e3244086fe Make example look more beautiful 2015-07-16 17:36:25 -07:00
Collin Jackson
79ccfe6b87 Support for settings fly-in animation 2015-07-16 17:22:20 -07:00
Collin Jackson
a64559ab70 After running filter-branch, move root directory into sky/ 2015-07-16 11:54:25 -07:00