87 Commits

Author SHA1 Message Date
Yegor
590381a00a
soften shadows even more; fix shadow alpha (#18029)
* soften shadows even more; fix shadow alpha
2020-04-29 20:54:21 -07:00
Mouad Debbar
7c084c57bd
[web] Use correct shell operator to compare file limits (#18032) 2020-04-29 18:12:48 -07:00
Ferhat
753514cefb
Canvas regression (#17738)
* Change backdrop filter element location based on ancestor clip. Add test.
* update test
* Addressed review comments. updated goldens
* Check ancestor on retain
* addressed review comments
2020-04-20 18:59:17 -07:00
Nurhan Turgut
ca3b36357f
[web] fix ulimit issues on Mac (#17767)
* check the max user limit before changing the limits

* more detailed changes in the file/user limit increase

* addressing pr reviews
2020-04-17 17:55:52 -07:00
Ferhat
4a1085a6f2
[web] Fix compositing order when adding paragraph tags (#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
Nurhan Turgut
deef2663ac
Run integration tests on ci (#17598)
* changing felt script to fetch flutter

* changing the clone_flutter.sh code

* running integration tests with felt on cirrus. fetch framework in CI (not in local).

* only run cirrus tests on chrome. fix a comma in the flutter command path

* adding comments to public flags

* use local engine parameter for flutter pub get

* change flutter executable used for flutter drive command

* fix a cleanup issue. address comments. add toolException. enable web in flutter

* address reviwer comments. fix issue with local-engine

* address reviwer comments. fix issue with local-engine

* using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage

* clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set

* fixing typos. updating readme for the new flag.

* fix directory error

* addressing reviewer comments
2020-04-13 09:54:54 -07:00
Nurhan Turgut
6245149b41
[web] using pkill to quit safari (#17533)
* adding an apple script to quit safari

* making changes to utils and adding cleanup after unit tests failed

* switch saai quit to pkill instead of applescript

* adding toolexception

* adding a cleanup function option to felt.

* removing unnecassary await's added for the previos version of the PR

* removing unnecassary async

* fix analyze error
2020-04-08 17:35:10 -07:00
Ferhat
c779894d08
[web] Fix canvas z-index leaking across repaints when element is reused. (#17378)
* Fix z-index leak. Add test for canvas reuse
* add regression test
* update golden locks
* fix analysis errors
2020-03-30 12:54:06 -07:00
Yegor
7bd8dee5be
fix implicit dynamic and two lints everywhere; implicit cast in dev/ (#17372) 2020-03-29 19:23:37 -07:00
Nurhan Turgut
a973ade331
change chrome version (#17382)
* change chrome version

* change chrome version
2020-03-27 16:52:02 -07:00
Yegor
b2a7470748
Reland "add limited analysis options (#17332)" (#17374)
* Reland "add limited analysis options (#17332)"

This time I'm starting without Cirrus. Will add Cirrus serpartely from code changes.

This reverts commit 6d33ee1a2ca7d404ebd5cb434d8ab859bf8ac0b7.

* disable Cirrus analysis check
2020-03-27 11:06:10 -07:00
Chinmay Garde
6d33ee1a2c
Revert "add limited analysis options (#17332)" (#17368)
This reverts commit 5389159643fa26342580208b6a9de547ef4de406.
2020-03-27 02:38:50 -07:00
Yegor
5389159643
add limited analysis options (#17332)
add limited analysis options
2020-03-26 14:38:59 -07:00
Nurhan Turgut
44fc6760d7
[web] improving felt: running target unit tests, cleaning up used proccesses (#17339)
* improving felt: running target unit tests, cleaning up used proccesses

* removing null check
2020-03-26 14:01:36 -07:00
Nurhan Turgut
af440db830
[web] use web drivers as a library only. do not fetch/clone web_installers (#17299)
* use web drivers as a library only. do not fetch/clone web_installers

* fixing comments

* addressing reviewer comments

* adding a trim to output. otherwise last fails
2020-03-24 15:37:33 -07:00
Yegor
2f769be663
Soften shadows (#17231)
* Soften shadows

* update goldens
2020-03-20 19:50:00 -07:00
Nurhan Turgut
48902d146a
Felt add integration (#17190)
* adding arguments to felt for running different type of tests

* adding test type enums to felt

* more changes to felt for testing branches

* more additions to code

* more changes to felt

* adding code for cloning web_drivers

* validating test directories. running the integration tests. update the readme file partially

* Removing todo lists used for development

* addressing reviewers comments

* remove unused imports

* addressing more reviewer comments

* addressing more reviewer comments

* addressing reviewer comments.

* addressing reviewer comments.

* fixing typos

* using chromedriverinstaller as a library. Fixing the commit number used from web_installers repo

* clean drivers directory after tests finish

* addressing more reviewer comments

* throwing all critical exceptions instead of logging and returning boolean flags

* adding todos for items we can do for making felt easier to use for local development

* do not run integration tests on CIs. Added an issue to the TODO.

* changing todo's with issues.
2020-03-20 19:24:13 -07:00
Nurhan Turgut
9a3016fbed
increasing user limits for macos (#17097) 2020-03-11 12:15:47 -07:00
Yegor
d41e25b549
Revert "Revert "fix shadows and mask filter blurs (#16963)" (#17008)" (#17040)
This reverts 619acd58ca55b2a85cf70d0f7861e3c98058972d and re-lands 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1. The 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1 was good. The screenshot changes were expected.

Fixes https://github.com/flutter/flutter/issues/32215
2020-03-09 20:32:59 -07:00
Ferhat
7f942f273b
Add support for firefox mac installer. Update web_ui pubspec for http.wq (#17044)
* Add support for firefox mac installer. Update web_ui pubspec for http.wq
* Addressed review comment 'final'
2020-03-09 18:13:37 -07:00
Chris Bracken
619acd58ca
Revert "fix shadows and mask filter blurs (#16963)" (#17008)
Broke golden file tests in the framework. Reverting to unblock the
engine roll to the framework.

This reverts commit 6cfa7fcad64e2fe70bca01cfbc4598ecd24613b1.
2020-03-07 10:18:10 -08:00
Yegor
6cfa7fcad6
fix shadows and mask filter blurs (#16963)
* fix shadows and mask filter blurs

* update goldens

* clarify the choice to min the shadows
2020-03-05 22:07:57 -08:00
Nurhan Turgut
9ac76ad5ad
[web] changing user limits for macos (#16797)
* changing user limits for macos

* check kernel name instead
2020-02-25 15:04:07 -08:00
vsmenon
0ef67b5e74
opt out dart:ui from nnbd (#16473)
* opt out dart:ui from nnbd

* Annotate tests as well
2020-02-20 11:04:00 -08:00
Nurhan Turgut
77c5812d48
[web] Skipping failing edge tests (#16626)
* making edge default test browser on windows. adding some skips (not all) for methods failing on edge

* skip failing tests. make egde default for testing

* skip one more test

* addressing reviewer comments. removing extra bat file
2020-02-18 09:36:04 -08:00
Nurhan Turgut
65d1126778
[web] Fixing launching Safari. This should solve the LUCI issue (#16590)
* Fixing launching Safari. This should solve the LUCI issue

* more comments and linking the issue
2020-02-14 10:27:20 -08:00
Ferhat
cd77e78430
Fix drawRRect failure when shader is specified (#16601) 2020-02-14 09:08:28 -08:00
Nurhan Turgut
8f8af1f890
Update felt documentation (#16559) 2020-02-12 14:05:08 -08:00
Yegor
1daba53187
Partially fix canvas vs text paint order when running on Blink/Webkit browsers (#16483)
fix canvas vs text paint order in Blink/Webkit
2020-02-10 13:41:50 -08:00
Ferhat
8f89bac4b7
[web] Fixes incorrect transform when context save and transforms are deferred. (#16412)
* Fix transform order in clipStack replay
2020-02-05 15:02:34 -08:00
Mouad Debbar
036ddbb0ee
[web][felt] If full dart-sdk isn't available, install it (#16341) 2020-02-03 15:06:24 -08:00
Yegor
804dca62a1
Use bundled Roboto in all tests (#16218)
* Use bundled Roboto in all tests
2020-01-30 17:31:32 -08:00
Nurhan Turgut
2415e9654b
updating the versions of the browsers for flutter web engine unit tests (#15977) 2020-01-24 16:28:21 -08:00
Dan Field
89f3471fa7
the the fix (#15973) 2020-01-24 12:43:32 -08:00
Ferhat
3d5bbb4371
Implement Canvas drawPoints API for Html backend (#15870) 2020-01-21 16:37:41 -08:00
Nurhan Turgut
f38f6a09be
windpws batch script for running felt. it does not have snapshot option (#15746) 2020-01-21 09:30:57 -08:00
Ferhat
98c1aeaa3b
Clipping path fix for browsers that don't use correct units when applying clip-path css using svg (#15712) 2020-01-17 10:41:02 -08:00
Nurhan Turgut
76b36e0512
[web] edge launcher for windows (#15690)
* edge launcher for windows

* addressing PR comments

* url mistake

* remove uncessary import

* initialization error fix

* format
2020-01-16 14:48:13 -08:00
Yegor
8c855dba98
fix text blurriness in HTML-rendered text (#15649)
* fix text blurriness in HTML-rendered text
2020-01-15 14:20:28 -08:00
Nurhan Turgut
bc41ab5139
[web] Add Edge support for Flutter Engine unit-tests. (#15641)
* Add Edge support for Flutter Engine unit-tests. This does not include the launcher

* Add mapping from browser name to platform.

* remove ie from supported browser maps
2020-01-14 16:44:44 -08:00
Nurhan Turgut
94c5b9f7d4 modify test_runner.dart for windows to fix test build errors (#15326) 2020-01-09 14:58:01 -08:00
Nurhan Turgut
f001ea29f1
adding windows platform to felt. fixing signal (#15111) 2020-01-08 06:30:57 -08:00
Ferhat
27a221d6d0
Refactor BitmapCanvas, lazily allocate canvas, fix image composition bug. (#15153)
* Refactor BitmapCanvas. Fix image compositing bug. Allocate canvas lazily
* Fix recording canvas test by restoring context save
* Update recording canvas test for drawColor to show multiply blend
2020-01-07 15:36:48 -08:00
Yegor
33813929e3
[web] implement pushImageFilter (#14599)
implement pushImageFilter in the HTML and CanvasKit backends
2019-12-20 12:10:56 -08:00
Ferhat
40b84fc193
Fix lint warnings across web_ui, add missing browserEngine case in text field. (#14535)
* Fix lint warnings across web_ui

* add textureCoordinates/indices getters for Vertices

* fix compositor indices
2019-12-19 17:39:33 -08:00
Nurhan Turgut
f5b877af9a
[web] Run engine tests on Safari locally by launching safari installed on MacOS (#14555)
* Launch safari browser

* Adding safari tests to supported browsers

* changing the directrory for redirect file. This works without opening a permision pop-up. Note: there is no headless mode in safari

* addressing reviewer comments
2019-12-19 08:05:16 -08:00
Nurhan Turgut
2ba5633369
instructions for running firefox/safari tests (#14562)
* instructions for running firefox/safari tests

* addressing reviewer comments.
2019-12-19 07:33:51 -08:00
Nurhan Turgut
2805da9e5d
Enable web engine unit tests on Firefox (#14267)
* Enable web engine unit tests on Firefox

* addressing PR comments

* addressing PR comments

* fix the version name on the lock file
2019-12-09 16:27:14 -08:00
Nurhan Turgut
91ef612ee0
[web] [tests] Changing configurations for firefox (#14148)
* Changing configurations for firefox

* remove headless

* change comments on configurations files

* remove unused boolean
2019-12-05 15:17:34 -08:00
Yegor
5d9509ae05
[web][felt] fix source map path (#14134) 2019-12-04 13:28:23 -08:00