3853 Commits

Author SHA1 Message Date
Dan Field
d0596582fe
Fix tests that use bogus objects, update TestImageInfo interface (#64599) 2020-08-25 23:26:06 -07:00
LongCatIsLooong
6536f65048
Revert "Warns when single line text fields overflow (#63639)" (#64573)
This reverts commit 0ab5ecc86b1f13854ecc0cb4a89fbdc9938c5212.
2020-08-25 11:11:15 -07:00
chunhtai
39d7a019c1
Reland "fix wrap intrinsic height calculation (#63420)" (#64276) 2020-08-25 10:01:07 -07:00
Mouad Debbar
707f995de3
[web] Fix and enable editable_text_test.dart (#64516) 2020-08-25 04:51:03 -07:00
LongCatIsLooong
0ab5ecc86b
Warns when single line text fields overflow (#63639) 2020-08-24 18:16:05 -07:00
xubaolin
f44f43358f
Fix bug when tapping ListTitle with CheckboxListTile tristate enable (#63925)
* fix bug when tap ListTitle when tristate enable #63846

* fix bug when tap ListTitle when tristate enable #63846

* code style

* improve the unit test case

* bow to convention
2020-08-24 15:31:33 -07:00
Todd Volkert
52b5b3ea43
Add GestureDetector.onDoubleTapDown() (#64431)
* Add GestureDetector.onDoubleTapDown()

* Review comments
2020-08-24 13:34:19 -07:00
LongCatIsLooong
7d6ffc7cc9
Add rect logic to getOffsetToReveal when onlySlivers is true (#64295) 2020-08-24 12:36:04 -07:00
Alex Li
2c3652b8fb
[EditableText] Fix TextField crashed with composing and maxLength set (#63754) 2020-08-24 12:16:05 -07:00
Jonah Williams
acd82534ee
[null-safety] remove mockito from route test (#64363)
Removes more mockito to unblock migration of all tests to sound null safety. #62886
2020-08-24 12:13:30 -07:00
David Reveman
02612bfe32
Pointer event resampler (#41118) (#60558) 2020-08-24 12:11:05 -07:00
LongCatIsLooong
53e25a61c9
Reland "Prevent material switch from recreating its render object when it becomes disabled (#61398)", reverted in #64062 (#64354) 2020-08-21 14:52:08 -07:00
Jonah Williams
d4e2c6bc29
[null-safety] remove mockito from refresh control test (#64280) 2020-08-21 13:31:03 -07:00
Ian Hickson
93395b4890
Add null safety migration annotations. (#64227) 2020-08-21 11:21:04 -07:00
Jonah Williams
714dd2febc
[null-safety] remove mockito from network tests (#64284)
More work towards removal of mockito to facilitate strong null safety tests.

#62886
2020-08-21 10:43:57 -07:00
LongCatIsLooong
90908b0beb
Revert "Prevent material switch from recreating its render object when it becomes disabled (#61398)" (#64062) 2020-08-21 10:34:08 -07:00
Dan Field
eef4220a87
Make large jumpTo recommend deferred loading (#64271) 2020-08-20 17:46:07 -07:00
timekone
f777ead154
Clip image of BoxDecoration to circle when shape is BoxShape.circle (#63352) 2020-08-20 17:21:05 -07:00
Kate Lovett
618ab7d275
Fix floating snackbar Y (#64268) 2020-08-20 15:11:07 -07:00
LI DONGZE
abbd5b149a
Add native stacktrace field for PlatformException. (#64199) 2020-08-20 15:01:06 -07:00
Todd Volkert
4d8934af48
Re-apply "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)" (#64254)
This reverts commit ce40de69b7b4f89c66d19c8dbd3bd86ae30f1bc6.

(this re-applies #64189 by reverting #64249)
2020-08-20 08:19:34 -07:00
Mehmet Fidanboylu
ce40de69b7
Revert "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)" (#64249)
This reverts commit 21cfed34d478d6a1c0223557a7935b69b15613bb.
2020-08-20 07:31:50 -07:00
TheBirb
a1097d70ed
Added tests (#62635) 2020-08-19 22:31:05 -07:00
Tong Mu
fb0b982324
Change MouseTracker's interface for clarity. Simplify MouseRegion's implementation. (#64119)
* Redesigns the interface between MouseTracker and RendererBinding&RenderView.
* Simplifies the structure of RenderMouseRegion.
* Extracts the common utility code between mouse_tracker_test and mouse_tracker_cursor_test.
2020-08-19 18:51:56 -07:00
Todd Volkert
21cfed34d4
(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)
* (insert|move|remove)ChildRenderObject Deprecation: Step 1

This deprecates the following methods:

* RenderObjectElement.insertChildRenderObject
* RenderObjectElement.moveChildRenderObject
* RenderObjectElement.removeChildRenderObject

...and replaces them with the following methods:

* RenderObjectElement.insertRenderObjectChild
* RenderObjectElement.moveRenderObjectChild
* RenderObjectElement.removeRenderObjectChild

The reason for the deprecation is to provide the `oldSlot` argument to
the `moveRenderObjectChild` method (such an argument was missing from
the now-deprecated `moveChildRenderObject` method) and the `slot`
argument to the `removeRenderObjectChild` method (such an argument was
missing from the now-deprecated `removeChildRenderObject` method). While
no argument was added to `insertRenderObjectChild`, the name change (and
corresponding deprecation) was made to maintain naming parity with the
other two methods.

This initial step does not update or remove any of the `slotToChild`
patterns that exist in the framework. This work is being separated
into two commits in case something needs to be reverted to minimize
the scope of each commit.

See https://github.com/flutter/flutter/issues/63269 for more info
2020-08-19 17:39:07 -07:00
Jimmy Robert
d69ae36398
Fix tooltip position. (#60479) 2020-08-19 16:11:06 -07:00
Greg Spencer
041a3eaa84
Standardize the nullability of arguments to raw key data constructors. (#63523)
This standardizes the handling of nullability for the LogicalKeyboardKey.keyLabel and RawKeyEventData.keyLabel accessors so that they are non-nullable, but can be empty.

Before this change, the keyLabel could be either null or an empty string to indicate that there wasn't a label, which makes it harder to test for, since both need to be checked for. Since an empty string is sufficient, there is no need for it to be nullable.

Also, in raw_keyboard.dart, the web and Windows implementations wouldn't accept null values for parameters in the Map coming from the message, but tests were supplying null for some of them. This makes web and Windows creation of events match the other platforms, and makes the migration of tests to non-nullability easier.
2020-08-19 15:03:17 -07:00
Justin McCandless
ec24a819ea
ClipboardStatusNotifier should handle errors in Clipboard.getData (#64012) 2020-08-19 14:36:08 -07:00
Darren Austin
2735a661f9
Changes to initialDate for CalendarDatePicker should update the state. (#64115) 2020-08-19 13:36:06 -07:00
Mouad Debbar
2b67846aab
Make SelectableText work better on web (#63786) 2020-08-19 13:31:06 -07:00
Jonah Williams
38e0c25823
[flutter_tools] reland: enable --null-assertions for flutter framework tests (#64120)
Reland of acdb909 with fixes to semantics.dart

#61042
2020-08-19 13:25:42 -07:00
Masayuki Ono (mono)
606abc915f
Fix title color of license detail page (#63249) 2020-08-19 09:01:06 -07:00
Rami
021cf56fc9
[Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (#64097) 2020-08-19 09:30:28 -04:00
Jenn Magder
1b47759528
Revert "[null-safety] enable null assertions for framework tests (#64071)" (#64118)
This reverts commit acdb909fcb7fa078d2c536db4c5182c4b1b37337.
2020-08-18 18:08:51 -07:00
Jonah Williams
acdb909fcb
[null-safety] enable null assertions for framework tests (#64071) 2020-08-18 17:21:04 -07:00
Greg Spencer
d1eff0b413
Hook up soft keyboard "next" and "previous" buttons so that they move the focus by default (#63592)
Focus will be moved automatically if onEditingComplete is not specified, but must
by moved manually if onEditingComplete is specified.
2020-08-18 16:46:58 -07:00
Mehmet Fidanboylu
bd6252eb3a
Revert "Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413)" (#64091)
This reverts commit 64d76f2fb7ed5eb785c660084b18ed5a51fd926b.
2020-08-18 13:55:33 -07:00
Alexander Aprelev
61362cff85
Move away from deprecated NoSuchMethodError to NoSuchMethodError.withInvocation (#63974) 2020-08-18 08:41:02 -07:00
Mehmet Fidanboylu
473744df2c
Revert "fix wrap intrinsic height calculation (#63420)" (#64046)
This reverts commit 72619b86421bfdbf4ef7b98cb893b168b89c8677.
2020-08-18 08:07:14 -07:00
Andre
9e0ad9b6b5
Fix FittedBox BoxFit.scaleDown sizing (#63668) 2020-08-17 22:36:02 -07:00
Ian Hickson
8f3805f5af
Build routes even less. (#62588) 2020-08-17 15:16:06 -07:00
LongCatIsLooong
579cab8a86
Prevent material switch from recreating its render object when it becomes disabled (#61398) 2020-08-17 11:36:02 -07:00
Ming Lyu (CareF)
c2368bdd6f
bug fix for pointer id in test gestures (#63816) 2020-08-15 10:41:02 -07:00
LongCatIsLooong
64d76f2fb7
Prevent viewport.showOnScreen from scrolling the viewport if the specified Rect is already visible. (#56413) 2020-08-14 16:41:03 -07:00
Michael Goderbauer
37ddad61ca
Make textfields restorable (#63401) 2020-08-14 12:02:38 -07:00
Declan Woods
03dcd1bd5a
Fix SafeArea and SliverSafeArea debug flag properties (#63455) 2020-08-14 12:01:05 -07:00
MH Johnson
bee9522f18
[Text Scaling][Material] Update BottomNavigationBar to show tooltips on long press. (#59127) 2020-08-13 22:53:27 -04:00
Wikiwix
88118bcbd1
Fix sort indicator for DataTables (#62795)
* Fix sort indicator for DataTables

As per material spec ascending order should be shown via an upward arrow
This commit changes the displayed arrows accordingly.

* Test sort indicator orientation in DataTable
2020-08-13 15:17:43 -07:00
Yuqian Li
3ff76f47fb
Add clipBehavior to ListView, GridView, PageView (#63147)
These widgets are missing from
https://github.com/flutter/flutter/pull/59364

With this change, developers can use clipBehavior for
https://github.com/flutter/flutter/issues/59424
2020-08-13 15:01:41 -07:00
Michael Goderbauer
39a46bedad
Remove decommission from RestorationBuckets (#63687) 2020-08-13 15:01:04 -07:00