14147 Commits

Author SHA1 Message Date
Dan Field
d0596582fe
Fix tests that use bogus objects, update TestImageInfo interface (#64599) 2020-08-25 23:26:06 -07:00
Jenn Magder
f5187535d5
Revert "[flutter_tools] avoid creating Android Devices if AndroidSDK cannot be found (#64524)" (#64602)
This reverts commit 47596c62038599045977fae87c98b25eab456379.
2020-08-25 17:55:58 -07:00
Greg Spencer
c8bbb522c5
Protect against null context in release mode (#64474) 2020-08-25 13:01:03 -07:00
LongCatIsLooong
6536f65048
Revert "Warns when single line text fields overflow (#63639)" (#64573)
This reverts commit 0ab5ecc86b1f13854ecc0cb4a89fbdc9938c5212.
2020-08-25 11:11:15 -07:00
Jonah Williams
47596c6203
[flutter_tools] avoid creating Android Devices if AndroidSDK cannot be found (#64524)
Avoid creating AndroidDevice discovery if the SDK cannot be located. Previously the tool would use which/where adb, however this required us to handle the AndroidSdk class being potentially null - which required an additional layer of indirection around all access. Sometimes these were forgotten leading to NPEs.

In general, not much can be done with an Android Device if the actual SDK is not installed.
2020-08-25 11:08:27 -07:00
Jonah Williams
f0a3cbace3
[flutter_tools] handle FileSystemException thrown when attempting to decode stamp file (#64559)
Fixes #64246

If decoding the string contents of a stamp file fails, treat it as if the stamp file is missing. This is always safe to do, since at worst it downloads more artifacts. The files could end up corrupted if they were edited by another program, for example
2020-08-25 10:58:21 -07:00
Jonah Williams
23032d772d
[flutter_tools] refactor artifact downloading to retry zip exceptions. (#64512) 2020-08-25 10:06:04 -07:00
chunhtai
39d7a019c1
Reland "fix wrap intrinsic height calculation (#63420)" (#64276) 2020-08-25 10:01:07 -07:00
Jonah Williams
059de1537e
[flutter_tools] support code size tooling on iOS, linux, windows, macOS, and Android on Windows (#63610)
Adds support for size analysis on iOS, macOS, linux, and Windows - using an uncompressed directory based approach. The output format is not currently specified.

Adds support for size analysis on android on windows, switching to package:archive

Updates the console format to display as a tree, allowing longer paths. Increases the number of dart libraries shown (to avoid only ever printing the flutter/dart:ui libraries, which dominate the size)
2020-08-25 10:00:24 -07:00
stuartmorgan
dd0c881275
[windows] Update plugin template (#64521)
The pointer-argument-based version of Success() is deprecated; this
updates the template to use the new reference-based version (which
allows for inline construction of the response value).

Part of https://github.com/flutter/flutter/issues/63975
2020-08-25 08:30:05 -07:00
Mouad Debbar
707f995de3
[web] Fix and enable editable_text_test.dart (#64516) 2020-08-25 04:51:03 -07:00
LongCatIsLooong
0ab5ecc86b
Warns when single line text fields overflow (#63639) 2020-08-24 18:16:05 -07:00
Jenn Magder
e960d773ee
Change iOS plugin simulator archs from allow list to deny list (#64504) 2020-08-24 17:48:05 -07:00
Jonah Williams
54e2a0e694
Reland: Increase threshold for usage of compute for utf8 decoding on large strings to 50 KB (#64498) 2020-08-24 17:01:04 -07:00
xubaolin
f44f43358f
Fix bug when tapping ListTitle with CheckboxListTile tristate enable (#63925)
* fix bug when tap ListTitle when tristate enable #63846

* fix bug when tap ListTitle when tristate enable #63846

* code style

* improve the unit test case

* bow to convention
2020-08-24 15:31:33 -07:00
Jonah Williams
41e553bbfc
[flutter_tools] migrate flutter_goldens, flutter_goldens client to null-safety (#64201) 2020-08-24 15:31:05 -07:00
Jonah Williams
302f9f751b
[flutter_tools] remove globals from utils (#63831) 2020-08-24 15:26:03 -07:00
Jonah Williams
ed4a8e8d05
Revert "Pass --verbose-logging to flutter_tester (#64440)" (#64517)
This reverts commit 8b52e6a8b2994e848ff43841c8bad154237dc0e8.
2020-08-24 14:50:38 -07:00
Hans Muller
60bf8cd211
Update origin material button API doc with obsolete API warnings (#64472) 2020-08-24 13:37:47 -07:00
Hans Muller
3d5abd4bd3
Removed deprecated ContainedButton and ContainedButtonTheme classes (#64483) 2020-08-24 13:37:33 -07:00
Todd Volkert
52b5b3ea43
Add GestureDetector.onDoubleTapDown() (#64431)
* Add GestureDetector.onDoubleTapDown()

* Review comments
2020-08-24 13:34:19 -07:00
Todd Volkert
8b52e6a8b2
Pass --verbose-logging to flutter_tester (#64440) 2020-08-24 13:33:56 -07:00
LongCatIsLooong
7d6ffc7cc9
Add rect logic to getOffsetToReveal when onlySlivers is true (#64295) 2020-08-24 12:36:04 -07:00
Apurv Jha
e30e795a3c
fix: typo fixed from ENTER to SPACE (#64235) 2020-08-24 12:21:05 -07:00
Alex Li
2c3652b8fb
[EditableText] Fix TextField crashed with composing and maxLength set (#63754) 2020-08-24 12:16:05 -07:00
Jonah Williams
acd82534ee
[null-safety] remove mockito from route test (#64363)
Removes more mockito to unblock migration of all tests to sound null safety. #62886
2020-08-24 12:13:30 -07:00
David Reveman
02612bfe32
Pointer event resampler (#41118) (#60558) 2020-08-24 12:11:05 -07:00
Jonah Williams
35c95a2fce
Revert "Increase threshold for usage of compute for utf8 decoding on large strings to 50 KB (#64350)" (#64372)
This reverts commit f07f4120e9a5232a7c7af3151f254d5536a79b44.
2020-08-21 18:56:03 -07:00
LongCatIsLooong
53e25a61c9
Reland "Prevent material switch from recreating its render object when it becomes disabled (#61398)", reverted in #64062 (#64354) 2020-08-21 14:52:08 -07:00
Jonah Williams
f07f4120e9
Increase threshold for usage of compute for utf8 decoding on large strings to 50 KB (#64350)
On a local benchmark, removing compute is faster than compute in both debug and release mode on a Pixel 4. On a MotoG4, a much larger text sample (800 Kb) takes 50 ms, so we cannot simple remove the limit. Increase to 50 Kb which should take at most a ms or two on an older device, and only microseconds on newerones.
2020-08-21 14:33:56 -07:00
Jonah Williams
d4e2c6bc29
[null-safety] remove mockito from refresh control test (#64280) 2020-08-21 13:31:03 -07:00
Ian Hickson
93395b4890
Add null safety migration annotations. (#64227) 2020-08-21 11:21:04 -07:00
xubaolin
2f2130a885
Improve docs for [PageStorage] (#63634) 2020-08-21 11:16:04 -07:00
Jonah Williams
ee12d7c3fc
[flutter_tools] check for permission issues when copying file (#63540) 2020-08-21 11:11:04 -07:00
Ian Hickson
39be8a40b5
More restoration documentation (#63438) 2020-08-21 10:51:05 -07:00
Jonah Williams
714dd2febc
[null-safety] remove mockito from network tests (#64284)
More work towards removal of mockito to facilitate strong null safety tests.

#62886
2020-08-21 10:43:57 -07:00
Todd Volkert
dae720bef4
Remove remaining uses of childToSlot (#64273)
The remaining uses of this pattern were all due to wanting to have
the child's slot when `Element.forgetChild()` was called. However,
when that method is called, the child's `slot` value is still valid
in the context of the parent, so the uses can just use `child.slot`.

This is the final round of cleanup from the fallout of #63269
2020-08-21 10:41:05 -07:00
LongCatIsLooong
90908b0beb
Revert "Prevent material switch from recreating its render object when it becomes disabled (#61398)" (#64062) 2020-08-21 10:34:08 -07:00
Dan Field
eef4220a87
Make large jumpTo recommend deferred loading (#64271) 2020-08-20 17:46:07 -07:00
stuartmorgan
8489d460a4
Update Windows template for wrapper file change (#64173)
* Minor adjustment for engine change, and rev template version

* whitespace fix
2020-08-20 17:36:46 -07:00
stuartmorgan
ca0ddbbc94
Add WindowProc delegation to Windows template (#64166)
This wires up the new WindowProc delegation system that allows plugins
to handle top-level window messages (e.g., to control resize behavior).

Fixes #53168
2020-08-20 17:36:10 -07:00
timekone
f777ead154
Clip image of BoxDecoration to circle when shape is BoxShape.circle (#63352) 2020-08-20 17:21:05 -07:00
Kate Lovett
618ab7d275
Fix floating snackbar Y (#64268) 2020-08-20 15:11:07 -07:00
Ming Lyu (CareF)
c8c575c894
update TimelineStream in flutter_driver (#64258) 2020-08-20 15:01:10 -07:00
LI DONGZE
abbd5b149a
Add native stacktrace field for PlatformException. (#64199) 2020-08-20 15:01:06 -07:00
Ian Hickson
c3a47b3449
Remove more timeouts (#63433) 2020-08-20 14:56:05 -07:00
xster
a2e5e074ab
Move Android doctor SDK check to 29 and Cirrus images to 30 (#63517) 2020-08-20 11:06:32 -07:00
Todd Volkert
2d0634eb32
Remove childToSlot pattern (#64217) 2020-08-20 10:57:15 -07:00
Todd Volkert
4d8934af48
Re-apply "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)" (#64254)
This reverts commit ce40de69b7b4f89c66d19c8dbd3bd86ae30f1bc6.

(this re-applies #64189 by reverting #64249)
2020-08-20 08:19:34 -07:00
Mehmet Fidanboylu
ce40de69b7
Revert "(insert|move|remove)ChildRenderObject Deprecation: Step 1 (#64189)" (#64249)
This reverts commit 21cfed34d478d6a1c0223557a7935b69b15613bb.
2020-08-20 07:31:50 -07:00