Chris Bracken
b236465bed
Revert "Track lastKnownRemoteTextEditingValue separately from received data ( #49406 )" ( #50082 )
...
This change broke some internal tests that set the text editing value to
the same thing (the empty string) twice in a row. Note that in that
case, the developer had subclassed EditableTextState and overridden the
updateEditingValue method, which may or may not be relevant to the
failure.
This reverts commit 83d4d63a716ec8551f0d59f852a40925ddd73d8a.
2020-02-03 20:40:10 -08:00
Dan Field
26619b3c35
Reland #49925 ( #50071 )
...
* Reland "Fix custom Elements that wants to decorate State.build (#49925 )" (#50068 )"
This reverts commit 62fdcb031945c23dacb481bd464cbea8ec9037d4.
Updates stack filtering for new frames in stateful element
2020-02-03 20:39:49 -08:00
Jenn Magder
62fdcb0319
Revert "Fix custom Elements that wants to decorate State.build ( #49925 )" ( #50068 )
...
This reverts commit a1143d174f0e97b1fb831bcf87f438d07f2351d7.
2020-02-03 16:42:47 -08:00
creativecreatorormaybenot
abf4e1617d
Docs (RenderObject): minor fix and link to more information ( #49992 )
2020-02-03 14:43:02 -08:00
Remi Rousselet
a1143d174f
Fix custom Elements that wants to decorate State.build ( #49925 )
2020-02-03 14:38:07 -08:00
Bogdan Lukin
9e9e741672
fix cupertino selection handle paint with transparent color ( #49910 )
2020-02-03 14:38:04 -08:00
Shi-Hao Hong
e10df3c1a6
Step 1.5 of 3: AboutDialog uses scrollable AlertDialog ( #49913 )
2020-01-31 19:23:01 -08:00
Dan Field
8600d2305e
Image provider fix ( #49920 )
...
* Fix image provider missing early return
* test
* comments
* whitespace, another comment
2020-01-31 19:19:48 -08:00
Dan Field
a1aa3c5b3d
Reland elide long tree walks ( #49891 )
2020-01-31 19:18:03 -08:00
Hans Muller
bf4cde74e1
Clarified AppBar toolbar layout API docs ( #49583 )
2020-01-31 15:33:01 -08:00
Kate Lovett
8b600032ee
Fixing constraints.precedingScrollExtent passed to SliverPadding child ( #49433 )
2020-01-31 12:58:03 -08:00
Kate Lovett
bc8bfb10f8
Exposing inner controller of NestedScrollView ( #49004 )
2020-01-31 12:53:03 -08:00
chunhtai
2dc71a343f
reland Refactors global key duplication detection ( #49896 )
...
* reland "Refactors global key duplication detection (#46183 )"
This reverts commit d2b66dbfcfdad68473fc4366e3042cd2e17706ac.
* fix test
2020-01-31 12:51:42 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations ( #49622 )
2020-01-31 18:30:21 +01:00
Bogdan Lukin
275ec45ec4
fix material selection handle paint with transparent textSelectionHandleColor ( #49830 )
2020-01-31 09:28:17 -08:00
Shi-Hao Hong
effc019054
Revert "Elide tree walks ( #48413 )" ( #49886 )
...
This reverts commit 46ccd086745bb9ade53f2457f3bb91942b2af970.
2020-02-01 00:20:04 +08:00
Dan Field
46ccd08674
Elide tree walks ( #48413 )
2020-01-31 07:09:44 -08:00
Gary Qian
83d4d63a71
Track lastKnownRemoteTextEditingValue separately from received data ( #49406 )
2020-01-30 18:10:36 -08:00
Jonah Williams
d2b66dbfcf
Revert "Refactors global key duplication detection ( #46183 )" ( #49847 )
...
This reverts commit 340b193f20e85f2cfbebf84fe315112985a38a13.
2020-01-30 17:02:16 -08:00
chunhtai
340b193f20
Refactors global key duplication detection ( #46183 )
2020-01-30 14:23:02 -08:00
Greg Spencer
e7baef08a1
Use DiagnosticableMixin instead of Diagnosticable for some conditionals. ( #49726 )
...
This PR fixes #49647 by changing DiagnosticableMixin.toDiagnosticsNode and other things to accept DiagnosticableMixin instead of requiring Diagnosticable.
2020-01-30 14:18:09 -08:00
Dan Field
169529c370
Defer image decoding when scrolling fast ( #49389 )
2020-01-30 11:38:00 -08:00
Matthew Cliatt
9375377fa9
Fix handling backspace on macos with text selection ( #49760 )
...
Fixes #46150 by catching both the delete and backspace keys, rather than just the delete key.
2020-01-30 09:36:41 -08:00
chunhtai
406d8f7f1e
Fix focus when popping pages ( #49714 )
...
Fixes the focus handling when popping pages so that when multiple pages are popped, the focus doesn't try to focus the interstitial pages.
2020-01-30 09:35:58 -08:00
liyuqian
2ccf3f877d
Print more layer debug info ( #49679 )
2020-01-30 09:33:01 -08:00
Jonah Williams
58811028a4
[flutter] Allow hot reload replacements of Stateless/Stateful Widget ( #48932 )
2020-01-30 07:58:03 -08:00
Gary Qian
52df599419
Expose TextHeightBehavior in Text, RichText, and DefaultTextStyle. ( #48346 )
2020-01-29 17:02:57 -08:00
Dan Field
7aec9b4602
Avoid calling didChangeDependences on a State that has dropped out of the tree ( #49527 )
2020-01-29 14:33:01 -08:00
chunhtai
de7da494a1
Navigator 2.0: Refactor the imperative api to continue working in the new navigation system ( #44930 )
2020-01-29 13:43:02 -08:00
LongCatIsLooong
dbaa4c2374
fix date picker range validation ( #49637 )
2020-01-29 12:43:02 -08:00
Anthony
6a74be53b3
[a11y] Re-land Make sure RenderFractionalTranslation updates its semantics after the translation field is set ( #49708 )
...
Re-land Make sure RenderFractionalTranslation updates its semantics after the translation field is set
2020-01-29 13:05:49 -05:00
Jason Simmons
722b4277ca
Provide a non-null default value for the compute debug label in release mode ( #49638 )
2020-01-28 16:43:01 -08:00
Dan Field
e7984bd4f6
Handle StackOverflows ( #49629 )
2020-01-28 16:38:02 -08:00
Tong Mu
da0a7d8b2e
MouseTracker no longer requires annotations attached ( #48453 )
2020-01-28 15:03:01 -08:00
Dan Field
fabeb2a16f
Revert string interp ( #49602 )
2020-01-28 07:56:51 -08:00
Michael Goderbauer
bc5ea0a05a
Reland "Do not rebuild Routes when a new opaque Route is pushed on top" ( #49376 )
2020-01-27 23:56:41 -08:00
Darren Austin
9980d6e550
Script to generate missing localization resources ( #49379 )
...
Added a new script to generate missing localizations for use when adding new localizations to the Flutter framework.
2020-01-27 17:50:59 -08:00
Hans Muller
900f15844b
Fix a TextTheme.body1 deprecation warning typo ( #49557 )
2020-01-27 17:43:02 -08:00
Greg Spencer
1a3379d571
Fix semantic sort name ( #48920 )
2020-01-27 16:13:02 -08:00
Dan Field
8b2993337a
revert #48985 ( #49572 )
2020-01-27 14:36:02 -08:00
Gary Qian
f323540416
Fix StrutStyle docs to remove references to leading property. ( #49443 )
2020-01-27 13:10:12 -08:00
Lasse R.H. Nielsen
f9908f5436
Address extra FutureOr from _isolates_io.dart. ( #49043 )
2020-01-27 13:03:02 -08:00
chunhtai
4964fb62e1
reland add lifecycle enum and remove workaround ( #49368 )
2020-01-27 10:38:02 -08:00
joellurcook
cf86592c23
Run secondary animation of previous route when using pushReplacement(… ( #42100 )
2020-01-27 10:33:03 -08:00
Tong Mu
10649ac42a
Fix TransformLayer with perspective transform ( #49441 )
2020-01-25 10:58:02 -08:00
Dan Field
bcfc293ca9
recommendDeferredLoading ( #49319 )
2020-01-25 01:18:03 -08:00
Darren Austin
782f9cceac
Expose a color property to CloseButton ( #49256 )
2020-01-24 19:08:02 -08:00
Hans Muller
bc5c46438a
Migrate TextTheme to 2018 APIs ( #48547 )
2020-01-24 19:03:01 -08:00
Dan Field
ab8632b181
Fix the the typos ( #49442 )
2020-01-24 12:25:19 -08:00
Tong Mu
0450e7c0ff
Trigger MouseRegion.toHover only on hover events ( #47403 )
2020-01-24 10:33:02 -08:00