4122 Commits

Author SHA1 Message Date
Jason Simmons
e06f69e1cd
Remove an obsolete workaround for Blink's calculation of baselines (#16966) 2018-04-25 14:24:07 -07:00
Yegor
a7d7652a5f
Set text direction in semantics along with Directionality (#16907)
* Set text direction in semantics along with Directionality

* update tests for the extra SemanticsNode
2018-04-24 18:29:26 -07:00
Yegor
d354096299
a11y traversal: sort locally; use new sorting algorithm (#16253)
New a11y traversal:

- sort direct sibling SemanticsNodes only
- use new sorting algorithm
- implement RTL
- test semantics in traversal order by default
- add AppBar traversal test
- breaking: remove nextNodeId/previousNodeId from the framework
- breaking: remove DebugSemanticsDumpOrder.geometricOrder
2018-04-23 14:23:49 -07:00
Hans Muller
d3d4976f63
InputDecorator input and hint widgets have the same width (#16894) 2018-04-23 13:53:15 -07:00
debuggerx01
ff58db4ac3 Fix hue to 0.0 when red == green == blue. (#16872)
When passing a Color object with same R/G/B code ( e.g. [new Color.fromRGBO(100, 100, 100, 1.0)] ) to HSVColor.fromColor(Color color) , the hue in return will be NaN .
2018-04-23 13:47:47 -07:00
Emmanuel Garcia
d43b4d0ad8 Fix #16247: SizeTransition clamps negative size factors (#16579)
As pointed out in the bug, the issue is fixed by just clamping sizeFactor.value.

Fixes #16247
2018-04-23 13:47:07 -07:00
Greg Spencer
a043ac41f6
Adding an API for capturing an image of a RenderRepaintBoundary. (#16758)
This adds a toImage function to RenderRepaintBoundary that returns an uncompressed raw image of the RenderRepaintBoundary and its children. A device pixel ratio different from the physical ratio may be specified for the captured image. A value of 1.0 will give an image in logical pixels.
2018-04-23 12:28:17 -07:00
Greg Spencer
037df5f2ff
Remove unneeded assert in UnconstrainedBox (#16778)
This addresses #16593 by removing the unneeded assert in the setter for constrainedAxis. Null was meant to be allowed there.

This replaces #16599 and fixes #16593, reported by @maksimr
2018-04-23 12:27:33 -07:00
xster
90ca815242
Make bottom app bar safe area friendly (#16820) 2018-04-20 17:14:03 -07:00
Michael Goderbauer
2eb290e718
Wire up SemanticsFlag.isHidden (#16772) 2018-04-20 17:10:40 -07:00
Jonah Williams
e7cd5d3867
Throw FlutterError when calling setState in State constructor (#16759)
* log error when calling setState in constructor
2018-04-19 18:00:38 -07:00
Jonah Williams
034a663d33
Semantics object support for edge triggered semantics (#16081)
Semantics object support for edge triggered semantics
2018-04-19 17:59:19 -07:00
Greg Spencer
b83eb465fd
Updating the Chip demo in the Gallery to include all the new types of chips. (#16522)
This chip demo is more interactive than the last one, trying to exercise all of the types of chips for a demo that lets you select different types of "chips" (like tortilla, wood, micro, etc.), and then filter them and select an action on them.
2018-04-19 16:43:22 -07:00
xster
133c98a85b
Fine-tune iOS's scroll start feel (#16721)
* Fine-tune iOS's scroll start feel

* remove negations in doc

* Our own dart-side gesture arena also contributes to the 'jerk'. Make sure that snap is accounted as well.

* Added more code comments from review.
2018-04-19 16:17:44 -07:00
Michael Goderbauer
1ba99b94f2
SliverList works with changing children that are keyed (#16724)
Fixes #14590.
2018-04-19 16:05:41 -07:00
Greg Spencer
0b389fc92e
Change CircleAvatar to use BoxFit.cover for images (#16649)
This is a PR giving some love to the abandoned PR #16263 by @harrisonturton

I've added a test, and formatted it to be readable.

Currently the CircleAvatar does not set a fit property on the DecorationImage it uses to paint images. This causes non-square images to not fully cover the circle, which looks pretty bad. This PR sets it to BoxFix.cover.

Fixes #13478.
2018-04-19 15:52:40 -07:00
Greg Spencer
e6b62a3a30
Adding some tests for onTapDown and onTapCancel (#16682)
Adding some tests for onTapDown and onTapCancel for the InkWell, as suggested in post-submission comments by @Hixie in #16190.

Also, added those to the diagnostic output.
2018-04-18 11:27:55 -07:00
Jacob Richman
928c41e9a7
Support summary-details tree view (#16638)
Support summary-details tree view.
2018-04-18 09:09:34 -07:00
Greg Spencer
824b806bfc
Add missing docs to public function. (#16651)
Adding missing docs to the forceRebuild function in the widget inspector.
2018-04-17 12:19:15 -07:00
Michael Goderbauer
f049f436c8
Update AppBar docs to analyze sample code (#16634) 2018-04-16 14:17:55 -07:00
Jonah Williams
b1ecf1ea9a
Add localizations for navigation menu, popup menu, dialog, and alert (#16633)
* add localizations for navigation menu, popup menu, dialog, and alert
2018-04-16 14:09:20 -07:00
Jacob Richman
ab9ba3f909
Support exposing the InspectorService over the Flutterservice extension protocol as well as the observatory protocol. (#15876)
* Support exposing the InspectorService over the Flutter
service extension protocol as well as the observatory protocol.

We will probably remove most of the observatory protocol support once a
couple versions of the Flutter IntelliJ plugin have shipped that use the
Flutter service extension protocol. The only reason to continue supporting
the observatory protocol is it will allow using the inspector when paused
at a breakpoint.
2018-04-16 10:04:40 -07:00
Greg Spencer
6c049ec286
Rename AnimatedChildSwitcher to AnimatedSwitcher (#16551)
We don't really like the name AnimatedChildSwitcher, and we think that AnimatedSwitcher might be better (since the Child part is redundant). We also considered AnimatedChild, AnimatedTransition and AnimatedReplacement (among others).

Nothing in here besides a rename.
2018-04-15 19:24:49 -07:00
Ian Hickson
1c3f6a851f
Fix formatting of Flex error message (#16498) 2018-04-12 21:16:39 -07:00
Greg Spencer
c73b8a7cf6
Fix a bug in the AnimatedChildSwitcher, add builders. (#16250)
This fixes a rendering problem in the AnimatedChildSwitcher where it would add a new "previous" child each time it rebuilt, and if you did it fast enough, all of them would disappear from the page.

It also expands the API for AnimatedChildSwitcher to allow you to specify your own transition and/or layout builder for the transition.

Fixes #16226
2018-04-12 16:17:26 -07:00
Greg Spencer
7a78741920
Revert "Changing the slider thumb size." (#16541)
This reverts commit 6494ab23f6a063c689441f55c3aba1b3c8e26b5b.
2018-04-12 16:11:43 -07:00
Greg Spencer
5129d8ffa6
Rename Rail to Track, per UX guideline (#16519) 2018-04-12 12:32:30 -07:00
Greg Spencer
4dbbf67887
Adding ChipTheme, ChipThemeData, and some more tests. (#16447)
This converts the chips to use a ChipThemeData to get most of their customization values from (if not overridden by specific arguments to the chip constructors), and to have the base ThemeData contain one of these. It also adds the ChipTheme widget that will allow overriding the theme for a particular subtree in the widget hierarchy.

Added tests for both, and just more tests in general for the Chips.
2018-04-12 11:13:42 -07:00
Greg Spencer
c31706f996
Changing the slider thumb size. (#16515)
The spec changed the size of the slider thumb, so this just effects that change.
2018-04-12 10:22:41 -07:00
Devon Carew
071485258f
Revert "re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server (#16281)" (#16482)
This reverts commit 2f41ea546f98a2bacabcd2444ca7ce4127a4360a.
2018-04-11 16:49:38 -07:00
Devon Carew
2f41ea546f
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server (#16281)
re-write flutter analyze (the single-shot and --flutter-repo) to use the analysis server
2018-04-11 14:50:36 -07:00
Michael Goderbauer
49a3adc1ac
AutomaticKeepAlive now keeps alive (#16445)
Fixes https://github.com/flutter/flutter/issues/16346.

See https://github.com/flutter/flutter/issues/16346#issuecomment-380255095 for detailed explanation of what was going wrong before this fix.
2018-04-11 10:31:47 -07:00
Alexander Aprelev
a2951a9a1f Roll engine to ed303c628fe4b322529f8cf01ecb38135a2bab73 (dart roll)
Changes since last roll:
```
ed303c628 Roll dart sdk again. Previous roll required 23ae4fa098 revert. (#4966)
8cd272733 Revert "Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (#4960)" (#4965)
9199b40f2 Revert "Support multiple shells in a single process. (#4932)" (#4964)
6baff4c82 Support multiple shells in a single process. (#4932)
31c5bb427 Roll dart to 7764e6962e22afcf4b58c4e3cef3147330f3c884. (#4960)
c8e4c6984 Avoid copying the contents of large platform message responses (#4947)
5ff527295 Update to use new vulkan GrBackendRenderTarget ctor. (#4962)
0c8993a1a Update to use new vulkan GrBackendRenderTarget ctor (part 2) (#4963)
132ebdda8 Revert "Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (#4958)" (#4961)
11882ab9e Roll src/third_party/skia/ 9874bf1bc..52e16d984 (135 commits) (#4958)
```

Add consts
2018-04-10 20:17:06 -07:00
Ian Hickson
497b9deb2a
Some cleanup of Chips that I found while learning the code. (#16249) 2018-04-10 16:43:57 -07:00
Jason Simmons
c3ce892c9e
Add support for locale-specific text styles (#16430)
See https://github.com/flutter/flutter/issues/12630 and
https://github.com/flutter/flutter/issues/16408
2018-04-10 13:41:51 -07:00
Greg Spencer
c43134a71c
Fixes a problem with the height of the chip label (#16420)
There was a bug in the size calculation for the height of the chip label, where it would force the label to be larger than it wanted to be, causing text to not be vertically centered.
2018-04-10 12:02:52 -07:00
Jonah Williams
fbfaffe1db
Do not add run spacing if there are no run metrics (#16290)
* do not add run spacing if there are no run metrics
2018-04-10 09:38:00 -07:00
Roberto Scaramuzzi
cdc68a73e6 Update text_form_field.dart (#15843)
* Update text_form_field.dart

* Update text_form_field_test.dart

* Update text_form_field_test.dart

* Update text_form_field_test.dart
2018-04-09 13:43:43 -07:00
Jacob Richman
660408edd6
Switch to the new Matrix4.tryInvert method to avoid throwing and catching (#15771) exceptions while performing hit testing. 2018-04-09 10:32:22 -07:00
Jonah Williams
037a4aef16
Un(less)conditionally schedule first callback frame when creating ticker (#16261)
* always schedule first frame when creating ticker, regardless of phase or frame
2018-04-06 13:09:07 -07:00
David Shuckerow
cb3df70da6
Spelling (#16210) 2018-04-06 10:00:06 -07:00
Greg Spencer
6055c56e23
Rename chip's border attribute to shape for consistency. (#16276)
This renames the chip's border attribute to 'shape' so that it is consistent with the other places where we supply a ShapeBorder.

This is a breaking change, but a very small one: the border attribute was introduced only a few months ago, and is not widely used.
2018-04-05 16:16:00 -07:00
Hans Muller
af9e15f361
Added BeveledRectangleBorder ShapeBorder (#16279) 2018-04-05 16:02:47 -07:00
Hans Muller
c7d982eba3
Updated appearance of filled TextFields - added UnderlineInputBorder.borderRadius (#16272) 2018-04-05 12:08:11 -07:00
Yegor
eb69a20c0a
fix date/time picker borders (#16240) 2018-04-04 16:39:25 -07:00
Jonah Williams
ae96e81ce4
export RawKeyEvent from RawKeyboardListener (#15956)
Adds an export of the RawKeyEvent type from the RawKeyboardListener library, since it is required by the API
2018-04-04 10:06:10 -07:00
Adam Barth
3ff25c7792
Add _PointerState#toString (#16197)
This method makes it easier to debug issues involving broken pointer
states.
2018-04-04 09:03:56 -07:00
Greg Spencer
7a6a65a597
Adding all the different types of chips, along with their complex behaviors (#16039)
This implements various different chip types: There are now the InputChip, ChoiceChip, FilterChip, ActionChip, and the original vanilla Chip, all of which have different uses. They can be customized in a number of ways. See their docs for more information.

Also fixes #16083
2018-04-03 19:31:08 -07:00
David Shuckerow
68c77e37e2
Add a bottom app bar to the floating action button motion demo. (#16196) 2018-04-03 19:30:14 -07:00
Hans Muller
b8629bab8d
Made Card's margin configurable (#16203) 2018-04-03 17:41:58 -07:00