354 Commits

Author SHA1 Message Date
Cedric GESTES
db6fb7f1fd
[web] also hide scrollbars in text_editing (#18019) 2020-05-04 14:02:46 -07:00
Ferhat
989d910130
[web] Remove left/top/transform reset since all code paths now set ltwh (#17867)
* [web] Remove left/top/transform reset since all code paths now set ltwh
* Remove unused style var
* Handle path=null , address review comments
* Added comment for reset code
2020-05-04 08:46:21 -07:00
Ferhat
705fcac4eb
[web] Fix cachedLastStyle state leak across canvases. Reduce ctx.font reset calls. (#17980)
* Fix cachedLastStyle state leak across canvases. Reduce ctx.font reset calls.

* Remove font set test
2020-05-03 18:06:08 -07:00
Mouad Debbar
3e975147fd
[web] First batch of unit tests for line breaker (#18034) 2020-04-30 10:50:51 -07:00
Yegor
590381a00a
soften shadows even more; fix shadow alpha (#18029)
* soften shadows even more; fix shadow alpha
2020-04-29 20:54:21 -07:00
Mouad Debbar
7c084c57bd
[web] Use correct shell operator to compare file limits (#18032) 2020-04-29 18:12:48 -07:00
Mouad Debbar
aa00d50396
[web] Don't allow empty initial route (#17936) 2020-04-27 13:54:07 -07:00
Mouad Debbar
d132ac576b
[web] Fix exception when getting boxes for rich text range (#17933) 2020-04-24 14:30:32 -07:00
Ferhat
cade0e90ca
[web] Batch systemFontChange messages (#17885)
* Batch systemFontChange messages
* Update test for async
2020-04-24 14:10:22 -07:00
Ferhat
371a8a05b0
[web] When a canvas element is reused and is first element in child list, preserve zIndex. (#17906)
* Fix zIndex removal on reuse
* Move check after append call to simplify
2020-04-23 15:09:59 -07:00
Nurhan Turgut
8fff8da38d
[web] autofill hints (#17887)
* adding autofill hints map from flutter values to the browser values, which will  be used by the web engine:

* removing unused reverse map

* addressing reviewer comments

* changing licences
2020-04-23 10:00:56 -07:00
Ferhat
ace381d76c
[web] Speedup color to css string 25% (#17866)
* Speedup color to css string 25%
2020-04-22 12:28:29 -07:00
Yegor
deaf14ec7d
Use Float32List as Matrix storage inside the Web engine (#17856)
This change converts all Float64List matrices to Float32List at the dart:ui interface boundary. Internally, it only uses Float32List. Float32List requires less memory and is orders of magnitude faster to allocate, and it has sufficient precision as Flutter mobile engine and Skia use 32-bit floats anyway.

This change speeds up frame preroll by 50% on the bench_card_infinite_scroll benchmark.

For more details on Float64Array allocation in JS (which backs Float64List in Dart) see the following:

https://bugs.chromium.org/p/v8/issues/detail?id=9199
https://bugs.chromium.org/p/v8/issues/detail?id=2022
2020-04-22 11:08:23 -07:00
Yegor
1beb220852
Report SceneBuilder submetrics through profiling API (#17852)
* add scenebuilder submetrics
* Disable Profiler by default
2020-04-22 09:15:18 -07:00
Ferhat
8d7071ea46
Prevent unnecessary DOM append call when canvas is reused (#17864) 2020-04-21 23:00:02 -07:00
Dan Field
f043e73d43
Roll CanvasKit to 0.14.0, fix Canvas.saveLayer(null, paint) (#17849) 2020-04-21 19:22:21 -07:00
Gary Qian
8dc91229b4
PlatformResolvedLocale localization message channel (#17755) 2020-04-21 15:34:44 -07:00
Ferhat
753514cefb
Canvas regression (#17738)
* Change backdrop filter element location based on ancestor clip. Add test.
* update test
* Addressed review comments. updated goldens
* Check ancestor on retain
* addressed review comments
2020-04-20 18:59:17 -07:00
Mouad Debbar
b0c4be9bd8
[web] Synthesize keyup event when the browser doesn't trigger a keyup (#17742) 2020-04-20 15:23:39 -07:00
Yegor
219c51f8d7
remove allocation from growLTRB; remove dynamism in vector_math (#17735) 2020-04-18 13:53:53 -07:00
Nurhan Turgut
ca3b36357f
[web] fix ulimit issues on Mac (#17767)
* check the max user limit before changing the limits

* more detailed changes in the file/user limit increase

* addressing pr reviews
2020-04-17 17:55:52 -07:00
Ferhat
5c0da71518
[web] Cleanup. Split path and surface stats code into separate files (#17796)
* Split path and surface stats code into separate files

* Update licenses
2020-04-17 17:47:22 -07:00
Nurhan Turgut
58cdc93242
web engine should not give an error for the new text editing method. (#17771) 2020-04-17 10:27:33 -07:00
Yegor
dd87e3f944
Optimize static content scrolling (#17621)
* store paint command bounds
* do not apply commands outside the clip region
* better cull rect prediction
* enforce RecordingCanvas.endRecording
2020-04-14 20:08:10 -07:00
Ferhat
1192667a7a
[web] Fix extra canvas generation due to context access (#17710)
* Fix extra canvas generation due to context access
* add comment
* address review comment
2020-04-14 15:40:16 -07:00
Ferhat
4a1085a6f2
[web] Fix compositing order when adding paragraph tags (#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
Nurhan Turgut
deef2663ac
Run integration tests on ci (#17598)
* changing felt script to fetch flutter

* changing the clone_flutter.sh code

* running integration tests with felt on cirrus. fetch framework in CI (not in local).

* only run cirrus tests on chrome. fix a comma in the flutter command path

* adding comments to public flags

* use local engine parameter for flutter pub get

* change flutter executable used for flutter drive command

* fix a cleanup issue. address comments. add toolException. enable web in flutter

* address reviwer comments. fix issue with local-engine

* address reviwer comments. fix issue with local-engine

* using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage

* clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set

* fixing typos. updating readme for the new flag.

* fix directory error

* addressing reviewer comments
2020-04-13 09:54:54 -07:00
Mouad Debbar
c69f21a349
[web] Combine duplicate platform message spy implementations (#17615) 2020-04-10 13:30:41 -07:00
Ferhat
6b065297cf
Fix Path hit test code for high dpi devices (#17608) 2020-04-09 22:18:42 -07:00
Nurhan Turgut
6245149b41
[web] using pkill to quit safari (#17533)
* adding an apple script to quit safari

* making changes to utils and adding cleanup after unit tests failed

* switch saai quit to pkill instead of applescript

* adding toolexception

* adding a cleanup function option to felt.

* removing unnecassary await's added for the previos version of the PR

* removing unnecassary async

* fix analyze error
2020-04-08 17:35:10 -07:00
Ferhat
db644677fa
[web] Fix multi-reply on message channel. Add test (#17591)
* Fix multi-reply on message channel. Add test
* Add check for viewInstanceCount
* skip no-headless test
2020-04-08 17:18:06 -07:00
Mouad Debbar
7a591cf475
[web] Fix regression of pointer events on mobile browsers (#17595) 2020-04-08 14:48:56 -07:00
Mouad Debbar
b0b67ef9e2
[web] Fix window.defaultRouteName (#17580) 2020-04-08 13:51:38 -07:00
Harry Terkelsen
38cba0757d
Do not enable antialiasing by default in CanvasKit mode (#17534)
* Do not enable antialiasing by default in CanvasKit mode

* Add comment
2020-04-08 11:55:23 -07:00
Nurhan Turgut
394ac6b484
[web] fix clipboard.getData (#17544)
* remove the fake reply for paste message. the clipboard.dart will reply with the content of the clipboard

* also remove the fake answer for copy
2020-04-07 11:34:33 -07:00
Mouad Debbar
bd760768c8
[web] Detect when the mouseup occurs outside of window (#17495) 2020-04-06 15:06:03 -07:00
cjng96
46277fd2ca
Remove code which skips keyEvent from input control on web (#17242) 2020-04-01 09:32:18 -07:00
Ferhat
40931c8fe5
[web] Fix HtmlImage state pollution due to image.clone optimization (#17370)
* fix drawImage style when destination width==source
* Add regression test
* dartfmt
* update golden lock
* Addressed review comment
* remove transform reset since _drawImage is called
2020-03-30 16:42:36 -07:00
Ferhat
c779894d08
[web] Fix canvas z-index leaking across repaints when element is reused. (#17378)
* Fix z-index leak. Add test for canvas reuse
* add regression test
* update golden locks
* fix analysis errors
2020-03-30 12:54:06 -07:00
Yegor
7bd8dee5be
fix implicit dynamic and two lints everywhere; implicit cast in dev/ (#17372) 2020-03-29 19:23:37 -07:00
Nurhan Turgut
a973ade331
change chrome version (#17382)
* change chrome version

* change chrome version
2020-03-27 16:52:02 -07:00
Yegor
b2a7470748
Reland "add limited analysis options (#17332)" (#17374)
* Reland "add limited analysis options (#17332)"

This time I'm starting without Cirrus. Will add Cirrus serpartely from code changes.

This reverts commit 6d33ee1a2ca7d404ebd5cb434d8ab859bf8ac0b7.

* disable Cirrus analysis check
2020-03-27 11:06:10 -07:00
Chinmay Garde
6d33ee1a2c
Revert "add limited analysis options (#17332)" (#17368)
This reverts commit 5389159643fa26342580208b6a9de547ef4de406.
2020-03-27 02:38:50 -07:00
Yegor
5389159643
add limited analysis options (#17332)
add limited analysis options
2020-03-26 14:38:59 -07:00
Nurhan Turgut
44fc6760d7
[web] improving felt: running target unit tests, cleaning up used proccesses (#17339)
* improving felt: running target unit tests, cleaning up used proccesses

* removing null check
2020-03-26 14:01:36 -07:00
Mouad Debbar
f0caace4fd
[web] Profile text layout and forward data to macrobenchmarks (#17276) 2020-03-26 09:37:14 -07:00
liyuqian
b3075b3091
Rename GPU thread to raster thread in code comments (#17329)
1. Simple "GPU thread" to "raster thread" replacement.

2. Regex replace "GPU([\n\r\s]+//+ thread)" with "raster$1".

3. Regex replace "// gpu$" with "// raster".

4. Simple test change.

5. Run ci/format.sh
2020-03-25 22:49:59 -07:00
Yegor
5845d70b50
Preserve zones in Window callbacks (#17298)
preserve Window callback zones
2020-03-25 17:25:06 -07:00
Ferhat
04182cde5d
Switch ui.window.devicePixelRatio from browser logical to physical. (#17209)
* Switch ui.window.devicePixelRatio to browser dpi
* Add integration test for multi res image loading
* Update cirrus for new integration test
* update canvas golden test root transform
* Update compositing golden test with dpr transform
2020-03-25 12:41:17 -07:00
Mouad Debbar
edfe06c113
Add the chromedriver/ directory to gitignore
This folder is generated by the integration test manager.
2020-03-25 09:08:15 -07:00