7 Commits

Author SHA1 Message Date
Greg Spencer
c001ea6f4a Convert format script to Dart (flutter/engine#20572)
This converts the ci/format.sh script to a Dart script that uses process_runner and isolates to multi-process the clang-format, diffs, and grepping needed to do the formatting changes.

It also will (by default) only check the formatting of changed files.

The user can optionally check all files (--all-files) or do only some types of checks with --check. --verbose prints the versions of the tools used for Clang format and Java format.

Specifying --fix will cause any formatting errors that would have been detected to be fixed.
2020-08-18 13:25:30 -07:00
Greg Spencer
d737cca58e Clean up the CI scripts and make it so that they can be run from anywhere (flutter/engine#20538)
This cleans up the ci scripts so that they can be run from an arbitrary directory, and so that they don't have any bash lint issues, and are more explicit about which dart/pub/dartanalyzer executable they run.

I also fixed the format script to take a "--fix" argument that will fix all of the formatting issues found, including trailing whitespace and gn files.

I added a warning to the license script about untracked/ignored files in the fluttter repo because those so often trip up the license script.

I added missing license information to the ci scripts too.

There's now a bit of boilerplate at the beginning of each script (the follow_links function) in order to reliably find the actual location of the script: I'd put it into a common file, except that that code would be needed to reliably find the common location too, so I needed to duplicate it. It's the same boilerplate as what is used in the flutter/flutter repo for the flutter and dart scripts.

I deleted the ci/test.sh script, since it seems to be obsolete (the test it tries to run doesn't exist anywhere).
2020-08-17 14:03:01 -07:00
liyuqian
2849649e8c Correct --dry-run hint (flutter/engine#17413) 2020-03-31 10:21:02 -07:00
Jason Simmons
5b8bb12621 Fix the dry run mode of the GN format checker script (flutter/engine#13406) 2019-10-29 10:53:52 -07:00
Kaushik Iska
ed39cbade1 [flutter_runner] Kernel platform files can now be built in topaz (flutter/engine#12016)
- Tested this compatibility in topaz repo. The build rules can now be
used to build kernel_platform_files in topaz tree, after this change we
can migrate the platform*dill and vm*snapshot files in topaz to use the
engine built artifacts.

- Also removes some namespace conflicts for dart configuration.
2019-09-06 14:34:26 -07:00
Dan Field
7e4a057aa8 Simplify buildtools (flutter/engine#9875)
Move GN, only get clang
2019-07-17 11:35:58 -07:00
Chinmay Garde
445287d84a Add a GN format presubmit. (flutter/engine#8371) 2019-03-29 13:56:55 -07:00