12831 Commits

Author SHA1 Message Date
chunhtai
ccb762f01b Adds setText to web engine (flutter/engine#24873) 2021-03-09 23:50:02 -08:00
xster
c0b9da55ea update links from https://github.com/flutter/engine/pull/24766 (flutter/engine#24818) 2021-03-09 23:45:02 -08:00
Ren You
4885af8ae3 Revert "Fix memory leak and bug in the RunsOnCreationTaskRunner check (#24690)" (flutter/engine#24874)
This reverts commit e0a475111216cf4775e08441100c0b6a24fd8b84.
2021-03-09 06:29:42 -08:00
Chris Bracken
a712590dfc Only call destruction_callback if non-null (flutter/engine#24845)
In MakeSkSurfaceFromBackingStore and other places in embedder.cc, we
call a texture or framebuffer destruction callback without first
verifying it's non-null. This adds a check before such calls.

Currently fl_renderer_gl_create_backing_store() in the Linux GTK
embedder and ExternalTextureGL::PopulateTexture() in the Windows
embedder either explicitly or implicitly set a null destruction
callback.

This prevents a crash reported when running under OpenGL ES 2.0 reported
in https://github.com/flutter/flutter/issues/76881.

While this prevents the crash, it does not fix the underlying issue.
2021-03-08 17:31:22 -08:00
Chris Bracken
13cf185e1c Correct setup-related typos (flutter/engine#24846)
Corrects uses of setup as a verb to 'set up', leaves noun/noun-phrase
forms of setup as 'setup'. Also settles on 'teardown' as opposed to
tear-down for consistency across the codebase.

A few other minor comment/wording corrections.
2021-03-08 17:31:10 -08:00
David Worsham
5f2b7a72ab fuchsia: Correct PlatformView scale/transform (flutter/engine#24645) 2021-03-08 15:18:16 -08:00
Chris Bracken
8aefbe04f6 Revert "[web] Fix url updates when using Router (#24798)" (flutter/engine#24870)
Seeing many web tests fail with errors like:

```
00:07 +0 -11: test/cupertino/search_field_test.dart: clear button removes text
══╡ EXCEPTION CAUGHT BY FLUTTER FRAMEWORK ╞═════════════════════════════════════════════════════════
The following message was thrown:
Could not navigate to initial route.
The requested route name was: "/default"
There was no corresponding route in the app, and therefore the initial route specified will be
ignored and "/" will be used instead.
════════════════════════════════════════════════════════════════════════════════════════════════════

00:07 +0 -12: test/cupertino/search_field_test.dart: clear button removes text [E]
  Test failed. See exception logs above.
  The test description was: clear button removes text
```

This reverts commit ee8a5e9bd0e8afaded0ea3265e7abe974caf98e1.
2021-03-08 12:21:52 -08:00
skia-flutter-autoroll
1b20b1e388 Roll Fuchsia Linux SDK from hnDJ6SZhJ... to yDVPrfGq5... (flutter/engine#24863) 2021-03-08 09:44:01 -08:00
skia-flutter-autoroll
4c28643362 Roll Skia from 5f2932e0e391 to 07ee548d5bcd (1 revision) (flutter/engine#24856)
https://skia.googlesource.com/skia.git/+log/5f2932e0e391..07ee548d5bcd

2021-03-07 reed@google.com Remove legacy picture-shader impl

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC kjlubick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
2021-03-08 08:26:38 -08:00
skia-flutter-autoroll
590779570e Roll Fuchsia Linux SDK from -kU3jhhRL... to hnDJ6SZhJ... (flutter/engine#24855) 2021-03-07 11:34:01 -08:00
skia-flutter-autoroll
3e69b589d5 Roll Skia from 1314913ff569 to 5f2932e0e391 (1 revision) (flutter/engine#24852) 2021-03-07 09:39:01 -08:00
skia-flutter-autoroll
5948356aa1 Roll Skia from 00d6cf436884 to 1314913ff569 (1 revision) (flutter/engine#24851) 2021-03-06 23:49:01 -08:00
skia-flutter-autoroll
c5f999b0d7 Roll Fuchsia Linux SDK from 4_MXZyYYE... to -kU3jhhRL... (flutter/engine#24850) 2021-03-06 22:04:02 -08:00
skia-flutter-autoroll
0876bc7053 Roll Skia from 8f440b4e1e22 to 00d6cf436884 (1 revision) (flutter/engine#24843) 2021-03-06 12:24:01 -08:00
skia-flutter-autoroll
9a37691305 Roll Fuchsia Linux SDK from Suchs2RGt... to 4_MXZyYYE... (flutter/engine#24842) 2021-03-06 08:39:01 -08:00
Emmanuel Garcia
503af63aef Prevent race condition while switching surfaces (flutter/engine#24838) 2021-03-05 21:50:13 -08:00
skia-flutter-autoroll
e1e6dbe23a Roll Skia from 9ef3f2e3da9f to 8f440b4e1e22 (2 revisions) (flutter/engine#24835) 2021-03-05 19:19:02 -08:00
skia-flutter-autoroll
b45eec6a44 Roll Fuchsia Linux SDK from zPlM6iYY3... to Suchs2RGt... (flutter/engine#24834) 2021-03-05 19:04:01 -08:00
Mouad Debbar
a0f418b769 [web] Don't set both color and foreground at the same time (flutter/engine#24828) 2021-03-05 17:38:19 -08:00
Mouad Debbar
ee8a5e9bd0 [web] Fix url updates when using Router (flutter/engine#24798) 2021-03-05 17:34:01 -08:00
skia-flutter-autoroll
4d2b114fe0 Roll Skia from 3dc6c190dabb to 9ef3f2e3da9f (9 revisions) (flutter/engine#24830) 2021-03-05 16:19:02 -08:00
Yilong Li
2e1ab24820 vulkan: Fix build issue due to missing VK_RESULT_RANGE_SIZE (flutter/engine#24829) 2021-03-05 15:59:02 -08:00
Jason Simmons
b978d1fb46 Initialize max_ascent/descent from the strut only if the strut is valid (flutter/engine#24802) 2021-03-05 15:44:01 -08:00
skia-flutter-autoroll
c3de57f418 Roll Skia from d63638bb7be7 to 3dc6c190dabb (2 revisions) (flutter/engine#24825) 2021-03-05 14:54:02 -08:00
skia-flutter-autoroll
f65c68765b Roll Skia from 319565ac6e65 to d63638bb7be7 (2 revisions) (flutter/engine#24824) 2021-03-05 13:24:01 -08:00
Emmanuel Garcia
e5ca96cc41 Revert "Replace Flutter surface only after all platform views are destroyed (#24363)" (flutter/engine#24800)
This reverts commit 5d850382d4205a9e2f5d42383d63ecb8cae2247b.
2021-03-05 10:45:20 -08:00
skia-flutter-autoroll
eae5a8f6f8 Roll Skia from bf2dd2af4947 to 319565ac6e65 (2 revisions) (flutter/engine#24815) 2021-03-05 10:14:01 -08:00
J-P Nurmi
069154f7ee [linux] Fix text selection via Shift+Home/End (flutter/engine#24623)
Adds TextInputModel::SelectToBeginning/End() and applies when shift key is pressed.
2021-03-05 08:51:33 -08:00
skia-flutter-autoroll
1b6f7c52a0 Roll Skia from 532138cea7ea to bf2dd2af4947 (3 revisions) (flutter/engine#24813) 2021-03-05 08:49:01 -08:00
skia-flutter-autoroll
792a369d7f Roll Skia from 994a571fc79a to 532138cea7ea (4 revisions) (flutter/engine#24812) 2021-03-05 07:24:01 -08:00
skia-flutter-autoroll
c306f3a86a Roll Skia from d42fe062d0a7 to 994a571fc79a (1 revision) (flutter/engine#24806) 2021-03-05 00:29:02 -08:00
skia-flutter-autoroll
f8fccdc536 Roll Skia from 3b58d38966f4 to d42fe062d0a7 (2 revisions) (flutter/engine#24805) 2021-03-04 22:39:01 -08:00
skia-flutter-autoroll
246022b9a7 Roll Skia from 6ba242d2a201 to 3b58d38966f4 (1 revision) (flutter/engine#24804) 2021-03-04 21:19:01 -08:00
Chris Bracken
67f952e952 Update cppwinrt to build 2.0.210304.5 (flutter/engine#24801)
This fixes an issue in CppWinRT related to std::terminate(); the tool
now uses abort() instead.

CppWinRT patch: https://github.com/microsoft/cppwinrt/pull/868

This also fixes a couple bugs in the README.md:
* Uses tmp as the temp dir into which we unpack the nupkg archive rather
  than cppwinrt to avoid confusion with the containing directory, which is
  named cppwinrt.
* Fixes a typo around the directory from which the cipd command should
  be executed.
2021-03-04 18:21:33 -08:00
skia-flutter-autoroll
748c2bd5ec Roll Skia from 55aaefe687c7 to 6ba242d2a201 (18 revisions) (flutter/engine#24799) 2021-03-04 17:54:01 -08:00
chunhtai
92d11213ff Adds set text action for voice access (flutter/engine#24734) 2021-03-04 17:44:01 -08:00
Jason Simmons
71e7d8e96e SkParagraph: support multiple default font families (flutter/engine#24662) 2021-03-04 15:34:01 -08:00
Jason Simmons
6b98e883a1 Allow calls to legacyMakeTypeface in the AssetFontManager (flutter/engine#24612) 2021-03-04 14:54:01 -08:00
Matej Knopp
aa32d53a38 Use hidden window to process flutter messages (flutter/engine#24232)
https://github.com/flutter/flutter/issues/75500
2021-03-04 14:35:15 -08:00
Kaushik Iska
abc42cde56 Guard metal rendering behind SHELL_ENABLE_METAL (flutter/engine#24727) 2021-03-04 09:04:01 -08:00
skia-flutter-autoroll
6ee73bc8fc Roll Fuchsia Linux SDK from _vRi_XkB7... to zPlM6iYY3... (flutter/engine#24782) 2021-03-04 08:34:01 -08:00
skia-flutter-autoroll
8e91c23ed5 Roll Skia from 21c8ad62cd82 to 55aaefe687c7 (2 revisions) (flutter/engine#24779) 2021-03-04 06:34:01 -08:00
skia-flutter-autoroll
670e919b4d Roll Skia from 4db57264955f to 21c8ad62cd82 (2 revisions) (flutter/engine#24774) 2021-03-03 22:39:01 -08:00
Chris Bracken
a15f44a9e2 Revert "[web] Fix painting of last placeholder in paragraph (#24716)" (flutter/engine#24773)
This broke the Linux Web Tests target in the framework tests.

Example failure:
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20web_tests/11335/overview

Failure log:
```
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: WidgetSpan calculate correct intrinsic heights [E]
  Test failed. See exception logs above.
  The test description was: WidgetSpan calculate correct intrinsic heights

01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
01:09 +107 ~2 -1: test/widgets/rich_text_test.dart: RichText implements debugFillProperties
══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
The following assertion was thrown during performLayout():
Assertion failed: file:///b/s/w/ir/k/flutter/packages/flutter/lib/src/rendering/box.dart:2237:16
!RenderObject.debugCheckingIntrinsics
is not true

The relevant error-causing widget was:
  Text file:///b/s/w/ir/k/flutter/packages/flutter_test/lib/src/binding.dart:567:12

When the exception was thrown, this was the stack:
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 236:49  throw_
../dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 29:3    assertFailed
../packages/flutter/src/rendering/layer.dart.js 4485:79                          <fn>
../packages/flutter/src/rendering/layer.dart.js 4551:26                          debugAssertDoesMeetConstraints
../packages/flutter/src/rendering/layer.dart.js 4380:14                          <fn>
../packages/flutter/src/rendering/layer.dart.js 4382:26                          set size
../packages/flutter/src/rendering/paragraph.dart.js 786:17                       performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14                          layout
../packages/flutter/src/rendering/shifted_box.dart.js 451:36                     performLayout
../packages/flutter/src/rendering/layer.dart.js 3392:14                          layout
../packages/flutter/src/rendering/layer.dart.js 4875:58                          performLayout
../packages/flutter/src/rendering/layer.dart.js 3279:14                          [_layoutWithoutResize]
../packages/flutter/src/rendering/layer.dart.js 6876:107                         flushLayout
../packages/flutter_test/src/_matchers_web.dart.js 3990:30                       drawFrame
../packages/flutter/src/rendering/layer.dart.js 6128:12                          [_handlePersistentFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 764:9                          [_invokeFrameCallback]
../packages/flutter/src/scheduler/binding.dart.js 732:37                         handleDrawFrame
../packages/flutter_test/src/_matchers_web.dart.js 3954:12                       scheduleWarmUpFrame
../packages/flutter/src/widgets/widget_span.dart.js 52123:11                     <fn>
../packages/flutter/src/widgets/widget_span.dart.js 52125:7                      runApp
../packages/flutter_test/src/_matchers_web.dart.js 3647:18                       _runTestBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 84:54            runBody
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 123:5            _async
../packages/flutter_test/src/_matchers_web.dart.js 3644:20                       [_runTestBody]
../dart-sdk/lib/async/zone.dart 1386:13                                          _rootRunBinary
../dart-sdk/lib/async/zone.dart 1272:19                                          runBinary
../packages/flutter_test/src/_matchers_web.dart.js 3636:16                       [_runTest]
../packages/flutter_test/src/_matchers_web.dart.js 4072:44                       <fn>
../packages/fake_async/fake_async.dart.js 141:96                                 <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1788:67                                          _runZoned
../dart-sdk/lib/async/zone.dart 1711:10                                          runZoned
../packages/clock/src/stopwatch.dart.js 364:18                                   withClock
../packages/fake_async/fake_async.dart.js 141:55                                 <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1788:67                                          _runZoned
../dart-sdk/lib/async/zone.dart 1711:10                                          runZoned
../packages/fake_async/fake_async.dart.js 141:20                                 run
../packages/flutter_test/src/_matchers_web.dart.js 4067:17                       runTest
../packages/flutter_test/src/_matchers_web.dart.js 5312:24                       <fn>
../packages/test_api/src/frontend/async_matcher.dart.js 862:17                   <fn>
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 45:50            <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 179:98              <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 179:80              <fn>
../dart-sdk/lib/async/zone.dart 1362:47                                          _rootRunUnary
../dart-sdk/lib/async/zone.dart 1265:19                                          runUnary
../dart-sdk/lib/async/future_impl.dart 155:18                                    handleValue
../dart-sdk/lib/async/future_impl.dart 707:44                                    handleValueCallback
../dart-sdk/lib/async/future_impl.dart 736:13                                    _propagateToListeners
../dart-sdk/lib/async/future_impl.dart 406:9                                     <fn>
../packages/stack_trace/src/stack_zone_specification.dart.js 247:16              [_run]
../packages/stack_trace/src/stack_zone_specification.dart.js 170:71              <fn>
../dart-sdk/lib/async/zone.dart 1354:13                                          _rootRun
../dart-sdk/lib/async/zone.dart 1258:19                                          run
../dart-sdk/lib/async/zone.dart 1162:7                                           runGuarded
../dart-sdk/lib/async/zone.dart 1202:23                                          callback
../dart-sdk/lib/async/schedule_microtask.dart 40:11                              _microtaskLoop
../dart-sdk/lib/async/schedule_microtask.dart 49:5                               _startMicrotaskLoop
../dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 166:15           <fn>

The following RenderObject was being processed when the exception was fired: RenderParagraph#e6e8f relayoutBoundary=up1 NEEDS-PAINT:
  creator: RichText ← Text ← Center ← Container-[#9a020] ← [root]
  parentData: offset=Offset(0.0, 0.0) (can use size)
  constraints: BoxConstraints(0.0<=w<=800.0, 0.0<=h<=600.0)
  size: Size(640.0, 40.0)
  textAlign: start
  textDirection: ltr
  softWrap: wrapping at box width
  overflow: clip
  maxLines: unlimited
This RenderObject had the following child:
    text: TextSpan
```

This reverts commit bcba78b6829849ffe7c4638bd69b3ceeb7631666.
2021-03-03 22:27:07 -08:00
skia-flutter-autoroll
220589533f Roll Skia from e4ef35caa1bc to 4db57264955f (1 revision) (flutter/engine#24772) 2021-03-03 21:14:01 -08:00
Chris Bracken
5a99033ec9 Added dependency on CppWinRT for UWP builds (flutter/engine#24770)
CppWinRT is a tool that generates standard C++17 header-file libraries
for Windows Runtime (WinRT) APIs. A more detailed introduction to
C++/WinRT can be found in the Microsoft documentation at
https://docs.microsoft.com/en-us/windows/uwp/cpp-and-winrt-apis/.

The source code is available under an MIT license, from
https://github.com/microsoft/cppwinrt.

Bug: https://github.com/flutter/flutter/issues/70205
2021-03-03 20:51:13 -08:00
skia-flutter-autoroll
4b8cb89a08 Roll Fuchsia Linux SDK from _0kewDFPJ... to _vRi_XkB7... (flutter/engine#24771) 2021-03-03 19:14:01 -08:00
chunhtai
935384301f Enables semantics when voice control is turned on (flutter/engine#24640) 2021-03-03 17:24:02 -08:00
skia-flutter-autoroll
2f060559e5 Roll Skia from 46d9bb255df4 to e4ef35caa1bc (9 revisions) (flutter/engine#24769) 2021-03-03 16:49:01 -08:00
Chris Bracken
e77d5ec898 Move CIPD package creation tools under tools/cipd (flutter/engine#24766)
This moves tooling related to the creation of the Android embedding
bundle CIPD package under tools/cipd. Having a single location for CIPD
package creation tooling avoids spreading these around the tree and aids
in discovery.

This does not change the path within the CIPD package repo, nor does it
change the path to which we download it via gclient as specified in the
DEPS file.

This will be followed by a patch to add a new Windows CIPD package
necessary for UWP builds.
2021-03-03 15:21:28 -08:00