This reverts commit aed6b8c46b05c7cee4506a9757dd9ea1b40583c2.
We revert because it breaks the engine to framework roll. Reverting as
soon as possible allows other engine commits to roll into framework
first so we'll have smaller engine rolls which is good for triaging
regressions.
TBR: rmacnak-google
1f4dfce179 [gardening] Mark co19 LibTest/io/HttpServer/close_A05_t01 flaky
5cbb640f7c Error for type arguments after named constructor with implicit new
2fa1143600 Check classes at mixin applications
ade528c4e6 Fixed the type alias omission in the def. of simple bounds
ddf67772bb Remove warning about inferring packages URI from dart2js
18110717fe Move infer methods to visitor
bd223d0ec4 Add consistent_type_error_test
d95f63d752 Update dartfix to use new invalid type argument fix
0cdd5b9ff3 Raise warning to error: duplicate key in a const map is now an error in Dart.
f6ca2c1d8f Remove the Dart 1 tests.
9f98f5f44c Remove instantiateToBounds parameter from FunctionTypeImpl.relate.
82f31cd250 Add types to method args to avoid analysis warnings.
63c9a241e3 Upgrade WRONG_NUMBER_OF_TYPE_ARGUMENTS_CONSTRUCTOR from a warning to an error
5658d406b7 Add changelog entry for integer literals in double contexts.
6b67cd784b [vm] Make UBSAN happy for the code in Range::BitwiseOp
e4c3fa0a9c Improve recovery when parsing named constructor invocation with invalid type arguments
3e7ce992cf [vm/tfa] Implementation of type arguments tracking in TFA.
001343ce06 [vm, gc] Disable reads and writes to from-space after a scavenge.
97ffcd9a3d [vm] Disable incorrect widening of smis to int32
1a4933715e [gardening] Mark co19 LibTest/io/RawDatagramSocket/any_A03_t01 flaky
e4842a293b Remove extra spaces in headers
58c90dc488 [vm] Fix bytecode in core-jit for simarm64
fab5d0a50d In InheritanceManager remove unused, and deprecate used (in lints) methods.
2989116219 Add some special cases for types we can't/don't need to parse
49b121f20d Remove TypeParameterSerializationContext.location.
244e6c7ffc Infer package URIs
cc884b3449 Remove optional argument from FunctionTypeImpl.forTypedef.
931202df27 Improve wrapping of lists and *notes* in LSP spec comments
3e897ac3b1 [vm] Extend previous status file updates.
23e7f9d1eb Handle references to other classes in comments
472c898c87 [dartdevc] fix for-in loop variable shadowing a var used in initialzer
3fe3106489 [gardening] Fix leaks in run_vm_tests binary detected by ASAN.
a6c8b62056 Remove dummy .packages files
2f7e7a4b52 [vm] Update status files for vm-kernel-mac-product-x64 for issue 34760.
e12538fff0 Move package bundle functionality into SummaryBaseTestStrategy.
96737787e2 Add LSP spec code-gen output
5e7ea5b672 [infra] Add .vpython spec to fix gsutil on the bots (#31065)
3cf0008b13 [vm/bytecode] Remove dependencies on ASTs when running with bytecode
fc0decc262 Improvements to the Dart code generated from the LSP spec.
efcca1132b Switch ErrorVerifier and OverrideVerifier to InheritanceManager2.
c347850976 [gardening] Mark co19 LibTest/io/RawDatagramSocket/timeout_A06_t01 as flaky
5e1bf1d135 Create LibraryScope once per library analyzer.
7c7df7bfa4 Add initial version of feature specification on interface conflicts.
f2bffc6872 Revert "[infra] Upgrade gsutil to a new version (#31065)"
1809bae318 Revert "Ignore JSON exceptions when reading (empty) test results file"
787194e738 [infra] Upgrade gsutil to a new version (#31065)
265d0d9ec1 Update status files after 8648d782
23c36ed029 Elaborate that -0 means -0.0 in double context or when compiled to JS.
8648d782ae Reland "[fasta] Report errors for bounds violations"
5c9a8d8cb5 [VM] Add $target_gen_dir/gen_kernel_bytecode.dill.d to outputs of GN action, to ensure directory is created before action is run
49d7fb39ac Temporarily ignore --strong option in flutter builds
f0a30bc8d1 Revert "[vm] Add a library and class cache to KernelProgramInfo"
1c2ed4ac11 [infra] Include gsutil in vm-kernel fileset to enable coredumps on shards (#31065)
5b32ab3be6 Remove the word "strongMode" from some package:kernel libraries.
dfb8e97b86 Report errors on members hiding prefixes
235a918233 [vm] Remove Dart_LoadScript, Dart_LoadLibrary, Dart_LoadSource, etc.
90e362f63c Deprecate the last non-deprecated EMPTY_LIST
0ab8e42fea Use a special context for serializing generic function types.
c47879d354 Remove one-phase summary logic.
b9dd229e35 Convert element.dart to triple-slash comment style.
e70a7aab8a [VM] Dead code removal - Remove dead code around creation of service isolate in gen_snapshot.cc - Create service isolate from the core snapshot - exclude sources from platform dill file (saves about 2.5MB in size)
662ff7f112 [vm] Remove TokenStream, TokenValue, CompilerStats.
a933f42b9e [VM] Use Symbols::Empty() when there is no source for a script instead of creating new empty string objects. Change-Id: I8ec6702557b07c4c4ede2aece5a3f25b4cde1a5b Reviewed-on: https://dart-review.googlesource.com/c/79060 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Siva Annamalai <asiva@google.com>
72b31316e4 [observatory] Fail gracefully when a Script lacks source code.
Roll tonic to dd971f40ba7646fab586ac2b6370721257109cb7
* Roll dart to version c6254163dc7a5f704d7609af65e4650ef0550ccd
This roll contains the following changes :
c6254163dc Fix source filter in built rule.
a97ddf8ce1 [vm/bytecode] Fix sporadic crashes when running with bytecode.
cf007d1f40 [infra] Add missing entries to the test matrix
9db63ee729 [vm/bytecode] Set 'TypeEnvironment.thisType' when generating bytecode
9c75ab7aa9 More common fasta/analyzer parser error codes
a712a910cf Revise class and mixin header recovery
588b0d1222 make pubspec file path to absolute
74f2348941 (fixdeps) [dart/fuzzer] DartFuzz Improvements
291f8abff8 More hint cleanup in analyzer
1cd2fc5883 [Gardening] Mark pause_on_unhandled_async_exceptions_test also flaky on kernel
1af136987b [infra] Prepare test matrix for the Dart 1 removal
0cc7993ee3 Clean up a couple of hints in analyzer code
22da7488ac [Gardening] Mark two service tests as passing on dartk-windows
def9d4c405 Cleanup endMethod and endFactoryMethod parameter recovery
46983c2de9 [vm/aot/tfa] Detect if a method/setter is called from this
2a6b566ca2 Move byte store to package:analyzer
45cb0815bc Move PerformanceLogger to package:analyzer
3a2308f5c2 Move jenkins_smi_hash to package:analyzer
ec4663ee5c Don't build runtime_kernel in benchmarks.
6b547e2683 Convert analyzer to use onDiagnostics
218d30e26a Skip source files attributed to 'dart:' libraries when writing a dep file.
45a5bc063a Mark the Script.source field as nullable.
ff3992b9ea [test tool] Pass --packages to gen_kernel
644342a6e6 Prepare for analyzer 0.33.0 publish.
cf48bad128 bump linter to 0.1.67
097e716694 [vm/bytecode] Update test status
69358a8755 [vm] Remove Dart_IsSnapshot and Dart_IsDart2Snapshot.
248a15f994 Upgrade dartdoc and dependencies for 0.22.0.
1085dd13d1 Use separate 'type index' for mixin, some nodes might be unresolved.
854720a099 Fix build rule.
878779e1a2 Fix test and add TODO for others that need updating
3daa63bc4c Revert OverrideVerifier back to the old InheritanceManager.
aa25872027 [vm] Fix pkg/vm/tool/precompiler2.
ab3ef0914c Allow "yield" as label
f529ab10f0 Allow "operator" as a static method name
cbf97be4e7 [fuchsia] Switch to new fdio API names
aedf5127bd [vm] Enable bump allocation scope for kernel loader
57f8542ea5 Fix warnings in analyzer package.
a33c1a1c17 [vm] Use proper lookup to find constructor during rebinding.
270fd8e4a8 [vm/aot] Handle annotations on parameters in tree shaker and constant evaluator
6d0601a72b [vm/bytecode] Add bytecodes for int operations and '== null'
10b1b35418 Update changelog for override check fixes
eacf720d2b Functions to demangle mixin application class names
bb2775b16a Only perform override check on declared members.
d3bd06d4e8 Check class interface requirements using override check code.
2dfe46fba2 Additional work on MOVE_FILE and associated tests
6c5326ae80 [vm] Fix issue with debugging generated code within RR.
c57a844841 Characterize behavior of FunctionTypeImpl.forTypedef when typeArguments not provided.
ed42aab273 Move source.dart to package:analyzer
82da68f3f5 Move api_signature to package:analyzer
829ba8a118 Remove unused file_repository.dart
b8cef2cefe Move flat_buffers to package:analyzer
27b17c76d8 Remove unused uri_resolver.dart
29d57107dd Move dependency_walker to package:analyzer
62e67d7277 Adjusted instantiate-to-bound.md such that it covers type aliases
440b9c61a7 Handle duplicated declaration used as prefix.
eb0ec965e3 Move codegen/tools.dart to package:analyzer
fd9a2cb510 Remove unused stuff
bc49637085 Convert package:dev_compiler to use onDiagnostic
44c6312df8 Consolidate VM dependencies on front_end
b628a62aa8 Remove ConstantValueComputer and DirectedGraph.
bd7b776bb4 Fix more quick fix tests
621c41f091 Add mixin support to InterfaceTypeImpl.isMoreSpecificThan.
d2e08e4952 [vm] Disable concurrent sweeping when --deterministic is set.
30aa464f77 [VM] Remove 'corelib' and 'dart-io' sources generation into C++ arrays
abe93563c4 [vm, service] Enable _collectAllGarbage in release mode.
80db08809c Pass InheritanceManager2 into resolver, use for BinaryExpression.
3ef994c287 Some clean ups in InheritanceOverrideVerifier.
4053ff96ec [vm] Fix --print-instructions-sizes-to in debug mode.
edd86ef7a1 Generate quick fix for await in non-async (issue 34647)
49f36b0b2d Reland "Test that the result of instantiate-to-bounds is appropriately checked for super-boundedness."
0016f80467 [dart/fuzzer] Pick execution modes at random by default
4df3626d19 Remove support for (non)nullable types from Analyzer.
93c5dcd00a [infra] Add fuzz testing builder to the test matrix
5cbb1bcdf9 Force lf-lineendings for .dart-files.
* Roll Dart to version 7f9a9feae181573cca609fd1b8760d7992176699
This contains the following commits:
7f9a9feae1 [vm, service] Rename 'invoke' parameter 'receiverId' to 'targetId'.
fa3d8fa567 Don't check for the file presence in transitive sets when we are just creating it.
6f3de544ed [ VM / Hot Reload ] Fixed tests which were crashing periodically. Fixes issue #34599
e811b29788 [vm, gc] Restore growth policy when concurrent marking is not enabled.
0518b334ba Address comments
7c46a28505 Update convert class to mixin assist to remove "abstract"
06744c68b2 Pull reporting for unimplemented inherited members, and declared abstract members from ErrorVerifier.
45c7e4365c Update dartfix to apply changes to file rather than displaying them
9ad59bada2 [dartdevc] fix#34358, int to double conversion for literals
edddc0ba58 Generate source changes for converting class to mixin
2742a5d558 [Gardening] Update test status
d9de98e164 [VM] Delete some dead code in gen_snapshot.cc
51b8fc7bb0 AwaitExpression.precedence => 14
2390b3605f Create a package for shared diagnostics
629d76eb46 Simple dartfix that suggests class to be converted to mixins
8a2cfd8613 Implement InheritanceManager2.getMember() and use it in some places.
71eaf3209b Fix broken 'fasta testing sdk'.
d79f7493b3 Test that type parameters of typedefs are properly bounds checked.
b36f4fffc4 Allow multiple analyzer codes
82b3501c3c Fix supermixin handling in dart2js
c9b05d3f1f Allow super calls in mixin declarations
225b8d5075 Specialize Object properties in static type computation
4a58112a7c Move kernel_impact.dart from ssa/ to kernel/
aaf3b709e6 [release] Prepare changelog for 2.1.0-dev.6.0
e9c949372e Remove unused parts of J/K*Env classes
4659cb9480 Fully split JsToElementMap and KernelToElementMap
a617700b17 Removes code that has become redundant since 98a9adf.
7c54fab8a5 Adjust status files.
76470aca47 [VM] use coresnapshot when initializing an Isolate
* Address review comments.
The `dart_vm_entry_points.txt` file is now deprecated in favor of annotations.
Support for parsing and generating the entry-points files will be removed from Dart shortly.
- Switch core snapshot to Dart 2 and remove support for loading platform.dill.
- Remove support for loading script snapshots.
- Remove support for loading source.
- Remove settings and fix names to reflect the above.
- Remove support for loading the service isolate from source.
The service isolate creation callback may occur on a background thread before
the call the Dart_Initialize within the DartVM construtor can finish. We store
pointers to various snapshots within the DartVM object. These snapshots are
necessary for to successfully create the service isolate. The isolate creation
callback access the global object within the ForProcessIfInitialized method.
This method can return null if the VM object has not been initialized. This
leads to the service protocol failing to start in a non-deterministic manner.
This patch moves the creation and access of the DartVM object within a critical
section.
* Roll Dart to version 1be785ae2ddb1754a184cd638ab719e94d86b4e9
This rolls includes the following changes :
1be785ae2d Clean up some dead code
7b9fb893d2 [vm] Add a service method for 'invoke' as the dual to 'eval'.
099f1504fa Mention -O flag in CHANGELOG
79f69abace [vm/compiler] breakage fix: add missing break
96a1e9985f Fix the pkg bot
7818db20a7 Add analysis hint for invalid use of @visibleForTemplate code.
71d96019d1 [vm/compiler] Introduce 64-bit NEGATE - all archs.
5013a2ccc4 Remove spurious line.
ef2f777625 Mark some analyzer tests as being flaky
cf560fe17b Fix a couple of the tests failing on the analyzer with fasta parser bot
63c11693e6 [gardening] Fix language_2/type_variable_promotion_test.
d0f28884ff [VM] Fix expression evaluation implementation: Never register temporary/unused classes with the system.
e2a1807fc2 [gardening] Update status for io/compile_all_test in PRODUCT AOT mode
f7ff739448 Insert date of 2.0.0 release in Changelog
bcabad6014 [vm] Fix SIMARM64 build on Windows.
af02ccae83 [infra] Fix filesets for new vm-kernel-precomp builders
8e2f28e264 Update homebrew to drop the @2 tab and fix for 2.0
ba119d7292 [VM] Remove "$compiler == precompiler" sections from language_2_precompiler.status
f3a2c0e28f [release] Prepare changelog for 2.1.0-dev.0.0
88cba7d860 [vm/kernel/bytecode] Fix arguments descriptor for List._fromLiteral call in bytecode
bd45ec0c4b [vm, gc] Refactor PageSpace::CollectGarbage to ensure the safepoint and task count remain well-scoped even with early exits.
8195fd8c64 Repair dart2js/string_interpolation_test
a0b335ac6c Try no implicit casts in pkg/analyzer_cli.
3d25d3761b Update pub - leave packages directories alone
327db5e9ab [vm] Fix kernel_isolate use_field_guard flag for kbc
a1ca88f554 Resolve invocation arguments to parameters.
* Address source format error.
