4957 Commits

Author SHA1 Message Date
Jim Graham
f9918c006e Reland "Sequester all Skia<->DL interactions into the skia sub-module" (flutter/engine#40435)
Reland "Sequester all Skia<->DL interactions into the skia sub-module"
2023-03-19 22:59:17 +00:00
Chinmay Garde
5efbf9ae44 [Impeller] Remove work queues. (flutter/engine#40429)
[Impeller] Remove work queues.
2023-03-18 23:42:34 +00:00
Zachary Anderson
6abd95a53b Provisional iOS impeller flag flip (flutter/engine#40405) 2023-03-17 20:35:36 -07:00
Loïc Sharma
3e5a3fa15e [macOS] Remove a single accessibility root assumption (flutter/engine#40316)
[macOS] Remove a single accessibility root assumption
2023-03-17 20:53:39 +00:00
Chris Bracken
1404722d05 Add doc comment to Pipeline (flutter/engine#40388)
Add doc comment to Pipeline
2023-03-17 20:38:55 +00:00
Jason Simmons
7598fa32e5 Wrap the iOS platform message handler in an autorelease pool block (flutter/engine#40373)
Wrap the iOS platform message handler in an autorelease pool block
2023-03-17 19:15:47 +00:00
Zachary Anderson
d39891c432 Un-bitrot impeller_unittests; disable failing tests; disable non-metal backends (flutter/engine#40339) 2023-03-16 19:34:57 -07:00
Loïc Sharma
25727539bb [Windows] Fix crash if clipboard is set to null (flutter/engine#40238)
Currently, the framework allows setting the clipboard to `null`. [Platforms handle this case inconsistently](https://github.com/flutter/flutter/issues/121976#issuecomment-1464721716), and we will update the framework to disallow setting the clipboard's data to `null`.

In the meantime, this change makes the Windows embedder resilient to unexpected clipboard messages. If your clipboard data's text is unexpected, you will now get an error instead of crashing your app.

Part of https://github.com/flutter/flutter/issues/121976
2023-03-16 16:52:27 -07:00
Greg Spencer
0efa11abc1 Handle error more gracefully, add test for same (flutter/engine#40361)
Handle error more gracefully, add test for same
2023-03-16 21:38:47 +00:00
Robert Ancell
84c69f7df9 Fix incorrect usage of fl_method_error_response_new in documentation example (flutter/engine#40288) 2023-03-17 10:23:24 +13:00
Chris Bracken
753bf93b11 [macOS] Eliminate unnecessary dynamic declaration (flutter/engine#40327)
Since `view` is a property of `NSViewController`, it's unnecessary for
us to declare `@dynamic view` in `FlutterViewController`'s
implementation.
2023-03-16 13:19:42 -07:00
Jim Graham
eb3a75ef78 Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module" (#40319)" (flutter/engine#40357)
Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module""
2023-03-16 19:55:51 +00:00
yaakovschectman
c1df0b8413 Pass parameters by value to StreamHandlerError (flutter/engine#40311)
* Pass by value/rvalue

* Test pass by value

* Formatting

* Test nullptr

* Formatting
2023-03-16 14:00:30 -04:00
Michael Goderbauer
dcc4b1b535 Reland: Bump lower Dart SDK constraints to 3.0 (flutter/engine#40318)
* WIP

Bump to 3.0.0-0

* fix lints

* drop web_ui

* opt pointer_converter.dart out of dart 3

* Revert "drop web_ui"

This reverts commit b97a015d5cd0d7e0380a4231be4c31aad36671f1.
2023-03-16 08:07:39 -07:00
Chris Bracken
ec1d7bae5d [macOS,Windows] Use static casts where possible (flutter/engine#40334)
[macOS,Windows] Use static casts where possible
2023-03-16 01:25:08 +00:00
Robert Ancell
c411d37046 Add fl_texture_get_id, so textures can be passed to Flutter (flutter/engine#40290)
Add fl_texture_get_id, so textures can be passed to Flutter
2023-03-16 01:10:07 +00:00
Chris Bracken
970c2c031a [macOS] Rename FlutterViewController.id to viewId (flutter/engine#40323)
[macOS] Rename FlutterViewController.id to viewId
2023-03-15 22:57:55 +00:00
Jim Graham
4107e5a226 Reland "Sequester all Skia<->DL interactions into the skia sub-module" (flutter/engine#40319)
Reland "Sequester all Skia<->DL interactions into the skia sub-module"
2023-03-15 22:56:01 +00:00
Zachary Anderson
32b3e66d7c Revert "Bump lower Dart SDK constraints to 3.0 (#40178)" (flutter/engine#40317)
Revert "Bump lower Dart SDK constraints to 3.0"
2023-03-15 18:53:00 +00:00
Michael Goderbauer
828f3deb86 Bump lower Dart SDK constraints to 3.0 (flutter/engine#40178)
Bump lower Dart SDK constraints to 3.0
2023-03-15 17:57:04 +00:00
Robert Ancell
3c8cac2faa Improve Linux texture examples. (flutter/engine#40289)
Use 'MyTexture' naming to match the Linux shell 'MyApplication'.

Show how to connect up the virtual methods.
2023-03-15 14:09:26 +13:00
Jim Graham
b89acc989c Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module" (#40243)" (flutter/engine#40283)
This reverts commit bbc993164a0d2f7d5a1b7b052ff884500040acc0.
2023-03-14 15:33:08 -07:00
Jim Graham
bbc993164a Reland "Sequester all Skia<->DL interactions into the skia sub-module" (flutter/engine#40243)
Reland "Sequester all Skia<->DL interactions into the skia sub-module"
2023-03-14 18:53:06 +00:00
Zachary Anderson
8c46471d24 Revert "[Impeller] More sundry fixes to the Vulkan backend. (#40244)" (flutter/engine#40247)
Revert "[Impeller] More sundry fixes to the Vulkan backend."
2023-03-13 15:45:38 +00:00
Chinmay Garde
3ea71b3d11 [Impeller] More sundry fixes to the Vulkan backend. (flutter/engine#40244)
[Impeller] More sundry fixes to the Vulkan backend.
2023-03-13 06:49:22 +00:00
Chris Bracken
761ba30bc7 [macOS] Forward mouseDown/Up to view controller (flutter/engine#40241)
This works around an AppKit bug in which mouseDown/mouseUp events are
not correctly forwarded up the responder chain for views nested inside
an NSPopover if (and only if) the macOS "Reduce Transparency"
accessibility setting is enabled in the System Settings.

When the above conditions are satisfied, the nested NSView receives the
mouseDown:/mouseUp: call but if it delegates to the default
implementation (implemented in NSResponder) mouseDown/mouseUp calls are
triggered on containing views (in our case FlutterViewWrapper) but not
triggered on the view controller and other responders in the responder
chain until we an _NSPopoverWindow class is hit.

A minimal AppKit-only (non-Flutter) repro shows this behaviour repros
with even a minimal NSViewController implementation and an unmodified NSView.
See: https://github.com/cbracken/PopoverRepro

A radar has been filed with Apple and a copy posted to OpenRadar.
See: http://www.openradar.me/FB12050037

In order to work around this bug, we override mouseDown/mouseUp in the
topmost containing view of FlutterView (in our case, FlutterViewWrapper)
to have the behaviour documented as the default behaviour in
NSResponder's mouseDown/mouseUp documentation. In otherwords, to simply
forward the call to self.nextResponder.
See: https://developer.apple.com/documentation/appkit/nsresponder/1524634-mousedown

Because replicating the exact configuration of a FlutterView contained
in an NSPopover and System Settings that have been modified to enable
the "Reduce Transparency" setting is difficult and likely error-prone in
infra, we instead simulate the bug by testing that even if NSResponder's
mouseDown/mouseUp method are swizzled to no-op, these calls are
correctly forwarded to the next responder in the chain.

If, in the future Apple does fix this issue, this workaround can be
removed once Flutter's minimum supported macOS SDK is at least the
version that contains the fix.

Issue: https://github.com/flutter/flutter/issues/115015
2023-03-11 12:49:59 -08:00
Dan Field
1de9bf9581 Make the context current before accessing GL in MakeSkiaGpuImage (flutter/engine#40208)
Make the context current before accessing GL in MakeSkiaGpuImage
2023-03-11 00:39:04 +00:00
Robert Ancell
5c4c343488 Add platform channel System.exitApplication and System.requestAppExit support (flutter/engine#40033)
Add platform channel System.exitApplication and System.requestAppExit support
2023-03-10 14:43:35 +13:00
Adam Perry
e9942f8f52 Reland "[fuchsia] Remove component framework v1 support. (#39732)" (flutter/engine#40198)
Previously reverted in #40104, this should now be safe to reland as
the last dependency has been deleted internally.

This reverts commit 9369c1ed1f33cfdad25ebe9cb809d6b5d6941159.
2023-03-09 15:05:45 -08:00
Jonah Williams
726df65356 Reland: Move asset opening to background thread, fix dart persistent value destruction (flutter/engine#40183)
Reland: Move asset opening to background thread, fix dart persistent value destruction
2023-03-09 22:58:04 +00:00
Chris Yang
bdcc4f6e95 [ios] refactor platform_message_handler_ios (flutter/engine#40182)
[ios] refactor platform_message_handler_ios
2023-03-09 21:27:37 +00:00
Loïc Sharma
89a738d1b7 [Embedder API] Lock nested structs to guarantee ABI (flutter/engine#40069)
[Embedder API] Lock nested structs for ABI stability
2023-03-09 21:09:50 +00:00
Loïc Sharma
85065c29e9 [Desktop] Use references for semantics update (flutter/engine#40167)
[Desktop] Use references for semantics update
2023-03-09 19:44:17 +00:00
gaaclarke
9e0db60c6a Made sure we get the initial route from the intent. (flutter/engine#40148)
Android: Made sure we get the initial route from the intent.
2023-03-09 18:42:51 +00:00
Jason Simmons
bd3381321d Make the Linux GTK widget focusable (flutter/engine#40163)
Make the Linux GTK widget focusable
2023-03-09 15:26:57 +00:00
Jim Graham
bc162fe559 Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module" (#40114)" (flutter/engine#40161)
Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module""
2023-03-09 02:41:54 +00:00
Eric Seidel
486cb47593 Add missing inputs declaration (flutter/engine#40133)
inputs = [ "android_exports.lst" ]
was missing from the flutter_shell_native rule, which meant if you edited android_exports.lst it would not notice and would not rebuild/relink.
2023-03-08 13:26:41 -08:00
Dan Field
3950fa55ca Improve error messaging when render target cannot be created (flutter/engine#40150) 2023-03-08 12:33:29 -08:00
Zachary Anderson
44947b8822 Revert "[engine] move asset mapping copy to background thread (#39918)" (flutter/engine#40147)
Revert "[engine] move asset mapping copy to background thread"
2023-03-08 19:30:27 +00:00
Jonah Williams
aa6c168e5f [Impeller] Replace FML_OS_PHYSICAL_IOS compile check with runtime capabilties check based on metal GPU family. (flutter/engine#40124)
[Impeller] Replace FML_OS_PHYSICAL_IOS compile check with runtime capabilties check based on metal GPU family.
2023-03-08 03:25:08 +00:00
Jonah Williams
9bc89c950c [engine] move asset mapping copy to background thread (flutter/engine#39918)
[engine] move asset mapping copy to background thread
2023-03-08 00:28:34 +00:00
hellohuanlin
6e08fa0d29 [platform_view]fix regression for addSubview when re-ordering (flutter/engine#40091)
[platform_view]fix regression for addSubview when re-ordering
2023-03-07 23:56:00 +00:00
Robert Ancell
5041a77db3 Use a single FlGLArea (flutter/engine#39473)
Use a single FlGLArea
2023-03-07 20:51:54 +00:00
Greg Spencer
ce70895a30 Fix some more includes (flutter/engine#40122)
Fix some includes missing "flutter/" prefix.
2023-03-07 20:50:12 +00:00
Jim Graham
53a80bdedf Reland "Sequester all Skia<->DL interactions into the skia sub-module" (flutter/engine#40114)
Reland "Sequester all Skia<->DL interactions into the skia sub-module"
2023-03-07 19:03:17 +00:00
Adam Perry
9369c1ed1f Revert "[fuchsia] Remove component framework v1 support. (#39732)" (flutter/engine#40104)
This reverts commit 181ee0e750727f4ef54e9b8421b264a333a0bdfc.
2023-03-07 10:53:16 -08:00
Jason Simmons
6927af678e Revert "Sequester all Skia<->DL interactions into the skia sub-module (#40083)" (flutter/engine#40103)
Revert "Sequester all Skia<->DL interactions into the skia sub-module (#40083)"
2023-03-07 02:58:49 +00:00
Greg Spencer
c0fbce46f5 Fix imports for FlutterApplication (flutter/engine#40100)
Fix imports for FlutterApplication
2023-03-07 01:26:37 +00:00
Jia Hao
04c31bd554 Optimize search for the default bundle (flutter/engine#39975)
Optimize search for the default bundle
2023-03-07 00:14:48 +00:00
Robert Ancell
ea232f836d Fix incorrect response to platform SystemSound.play (flutter/engine#39992)
* Fix incorrect response to platform SystemSound.play
* Add tests for FlPlatformPlugin
2023-03-07 09:49:49 +13:00