572 Commits

Author SHA1 Message Date
Todd Volkert
0cc58fd046
Fix assert in RenderObject.getTransformTo() (#81590)
The assert was never hitting because it was first hitting a
null cast error in the `renderer.parent!` line in the for
loop.
2021-04-30 21:08:54 -07:00
Todd Volkert
91de4bd3e3
Add onLongPressDown, onLongPressCancel (#81260)
This adds support for GestureDetector.onLongPressDown and
GestureDetector.onLongPressCancel, allowing callers to register
interest in the initial pointer contact that might turn into
a long-press (and the associated cancel event if the gesture
loses).
2021-04-28 12:51:27 -07:00
Angjie Li
b74df388e1
Revert "Migrate to ChannelBuffers.push (#76288)" (#81226)
This reverts commit c26ed03c8a77810136cc087ae60048ace062842d.
2021-04-26 12:57:17 -07:00
creativecreatorormaybenot
5e2f8631f8
Fix Hit Tests in RenderEditable when Scrolled (#81040) 2021-04-26 10:54:04 -07:00
Ren You
e170ea521c
Revert "[RenderEditable] Dont paint caret when selection is invalid (#79607)" (#81076)
This reverts commit 0f8148ec16325493b1b48a21367b839167f940b9.
2021-04-23 16:00:11 -07:00
Ian Hickson
c26ed03c8a
Migrate to ChannelBuffers.push (#76288)
* Migrate to ChannelBuffers.push

* Move TestDefaultBinaryMessenger to its own file

* Apply deprecations and fix usages
2021-04-23 15:39:34 -07:00
Alexandre Ardhuin
59fc92168a
add missing trailing commas (#81065) 2021-04-23 22:47:40 +02:00
Justin Hutchins
dca07d2a8a
Enable previously skipped Editable test (#80761) 2021-04-22 13:19:03 -07:00
Phil Quitslund
61c30c41b2
fix sort_directives violations (#80817) 2021-04-21 13:49:03 -07:00
LongCatIsLooong
0f8148ec16
[RenderEditable] Dont paint caret when selection is invalid (#79607) 2021-04-18 09:14:02 -07:00
Ricardo Canastro
136da59e6b
Support block delete with word and line modifiers (#79973)
Adds support for overridable delete/backspace keyboard shortcuts
2021-04-07 13:29:37 -07:00
Jenn Magder
a637fcd344
Revert "Support block delete with word and line modifiers (#79695)" (#79968)
This reverts commit 0ba2f6a87fbfd857c0a4e01a47e824dcab5462de.
2021-04-07 11:44:30 -07:00
Ricardo Canastro
0ba2f6a87f
Support block delete with word and line modifiers (#79695)
Support for keyboard backspace/delete shortcuts
2021-04-07 10:54:28 -07:00
chunhtai
303ce76d85
Fix RenderEditable register the raw keyboard listener twice (#79877)
* Fix RenderEditable register the raw keyboard listener twice

* skip web test
2021-04-06 11:27:31 -07:00
Greg Spencer
8859f7a799
Revert "Support block delete with word and line modifiers (#77172)" (#79674)
This reverts commit 75453e6ac6647e014765ae6d863e199efc152a16 because it breaks flutter/test/rendering/editable_test.dart

Landing on red to fix the build.
2021-04-02 15:08:13 -07:00
Kate Lovett
e40610d67e
Automatically applying Scrollbars on desktop platforms with configurable ScrollBehaviors (#78588) 2021-04-02 16:40:17 -05:00
Ricardo Canastro
75453e6ac6
Support block delete with word and line modifiers (#77172) 2021-04-02 14:39:03 -07:00
chunhtai
2369d76a1d
Makes text selection match the native behavior (#79308) 2021-04-02 12:09:05 -07:00
Chris Bracken
3e7e06512c
Correct misspellings throughout the codebase (#79500) 2021-04-01 10:04:03 -07:00
Alexandre Ardhuin
e384ca7979
use null aware operators for function invocations (#79049) 2021-03-26 09:34:03 -07:00
chunhtai
bed88a1a5e
Fix rendereditable to check the latest text before setting the selection (#78919)
* Fix rendereditable to check the latest text before setting the selection

* add regression comment

* addressing comments and fix tests
2021-03-25 11:49:44 -07:00
LongCatIsLooong
ea3d4dbd6e
Reland "ConstraintsTransformBox (#77994)" reverted in (#78661) (#78673) 2021-03-24 10:35:02 -07:00
Mouad Debbar
c0bcb4fc16
Revert "ConstraintsTransformBox (#77994)" (#78661)
This reverts commit 8c44abc009a333b0494598c0cfda0fbc07358234.
2021-03-19 16:34:57 -07:00
LongCatIsLooong
8c44abc009
ConstraintsTransformBox (#77994) 2021-03-19 15:56:04 -07:00
Ian Hickson
f3c25fa07a
Align more closely with package:test (#77118) (#78343) 2021-03-16 13:58:02 -07:00
Zachary Anderson
e7e1a04aa3
Revert "Align more closely with package:test (#77118)" (#78329)
This reverts commit 0cbe597540f6b51ab7157ab8747906e9923b79e4.
2021-03-16 09:26:34 -07:00
Ian Hickson
0cbe597540
Align more closely with package:test (#77118) 2021-03-15 16:28:02 -07:00
Michael Goderbauer
d637b1874f
non-breaking changes for prefer_mixin lint (#77837) 2021-03-11 19:50:03 -08:00
Tong Mu
fa06b34024
Refactor: Move mouse cursor classes to "services" package (#77751) 2021-03-11 19:45:04 -08:00
Justin McCandless
541bff4058
Text Editing Movement Keys via Shortcuts (#75032)
Text editing shortcuts involving the arrow keys are no longer handled by RenderEditable's RawKeyboardListener, they use the new Shortcuts setup.  First PR in a plan to port all text editing keyboard handling to shortcuts.
2021-03-11 15:52:04 -08:00
Michael Goderbauer
807bb29888
enable prefer_function_declarations_over_variables lint (#77398) 2021-03-05 18:29:04 -08:00
Michael Goderbauer
ed755fba5e
Enable avoid_unnecessary_containers lint (#77294) 2021-03-04 15:29:03 -08:00
Michael Goderbauer
7b251f5f37
Enable use_function_type_syntax_for_parameters lint (#77163) 2021-03-04 08:59:17 -08:00
Greg Spencer
c6ef4c75d9
Turn on sized_box_for_whitespace lint, fix instances. (#77099) 2021-03-03 17:29:02 -08:00
chunhtai
b0d4d44853
Reland "fixes TextInputFormatter gets wrong old value of a selection" (#76653) 2021-03-02 11:54:02 -08:00
Justin McCandless
1794e81f61
Keep the selection after 'Copy' pressed on iOS. (#76327) 2021-02-23 15:56:04 -08:00
chunhtai
b5139515c1
Revert "fixes TextInputFormatter gets wrong old value of a selection (#75541)" (#76627)
This reverts commit a46139a2cef8144444a3e13a3970e9a267304b91.
2021-02-23 11:25:01 -08:00
chunhtai
a46139a2ce
fixes TextInputFormatter gets wrong old value of a selection (#75541) 2021-02-19 11:16:02 -08:00
Sam Rawlins
dea1c46a3c
Remove "unnecessary" imports. (#75637) 2021-02-10 17:06:03 -08:00
Michael Goderbauer
8e87408fbe
CupertinoPageTransition Optimizations (#75670) 2021-02-10 16:03:07 -08:00
Sam Rawlins
53f5bdbf91
Remove "unnecessary" imports in tests (#75705) 2021-02-09 12:46:05 -08:00
Tomasz Gucio
d031a61a62
Add RenderEditable keys listener back in attach() (#75614) 2021-02-09 12:36:04 -08:00
LongCatIsLooong
76be55813b
Move caret/highlight painting to custom painters (#72828) 2021-02-01 14:41:04 -08:00
Alexandre Ardhuin
d546e1d311
fix for upcoming lint use_named_constants (#74788) 2021-01-27 20:20:44 +01:00
Jia Hao
8a5ace25a5
Improve performance of Widget Tests (#70730) 2021-01-12 17:29:03 -08:00
Nathan Walker
b65a235139
SliverAppBar with ShrinkWrap Patch (#73195) 2021-01-07 10:39:02 -08:00
Todd Volkert
e2a0d03b79
Avoid null check operator failure in RenderFlex._hasOverflow (#72122)
Fixes https://github.com/flutter/flutter/issues/71972
2020-12-17 19:25:28 -08:00
J-P Nurmi
803c07fe3b
Fix EditableText.enableInteractiveSelection on desktop & web (#70972)
selectionEnabled was not taken into account in:

key movement handling in RenderEditable
mouse drag handling in TextSelectionGestureDetectorBuilder
2020-12-17 16:56:47 -08:00
Justin McCandless
fb3dba74b7
Correct text selection pivot points (#71756) 2020-12-14 11:18:05 -08:00
Jia Hao
bf8313f8fc
Add a test for intrinsic size checks (#71539) 2020-12-03 08:48:04 -08:00