1932 Commits

Author SHA1 Message Date
David Worsham
cb0aca7f74 Wire up Opacity on Fuchsia, round 2 (flutter/engine#14024)
* Remove erroneous ChildView opacity

* Wire frame metrics through contexts

* Maintain layer stack inside of SceneBuilder

* Remove EnsureSingleChild

* Centralize system-composite and elevation logic

* Wire up OpacityLayer to Scenic
2019-12-04 19:29:31 -08:00
Chinmay Garde
ce4d1dc06f Fix platform view offsets incorrectly taking into account device pixel ratios. (flutter/engine#14135)
This issue was hidden by an incorrect test expectation that has been corrected.

Fixes b/144555069
Fixes https://github.com/flutter/flutter/issues/45991
2019-12-04 13:15:47 -08:00
David Worsham
df08c2593a Relanding: Add Flow unittests and fixtures (flutter/engine#14091) 2019-12-03 14:33:02 -08:00
Kaushik Iska
16ee373dc9 Revert "Fix fml_unittests (#14062)" (flutter/engine#14087)
This reverts commit ca9e7fc470843285b50999fa0e41ba29084ad474.
2019-12-03 12:24:19 -08:00
liyuqian
52e74298e0 Revert PRs to unblock David and Jim's work (flutter/engine#14088)
* Revert "Add flow test fixtures and tests (#13986)"

This reverts commit 32915132bacdfd0d631421b23bb6a6d5db1095ab.

* Revert "Dynamically determine whether to use offscreen surface based on need (#13976)"

This reverts commit a13401ce86b3019c39154d56644b7b9eb4a5bbe5.
2019-12-03 12:02:37 -08:00
David Worsham
32915132ba Add flow test fixtures and tests (flutter/engine#13986) 2019-12-03 09:43:02 -08:00
Dan Field
69d5294a7a Remove suprious warning (flutter/engine#14079) 2019-12-02 16:51:30 -08:00
stuartmorgan
8a11e4f2de Report backing store changes in the macOS view (flutter/engine#13933) 2019-12-02 16:33:04 -08:00
Francisco Magdaleno
3e6ba41538 Listen to keyUp event on meta modified keys (flutter/engine#13984) 2019-12-02 16:17:19 -08:00
Dan Field
f5aa0ec812 Fix live region logic (flutter/engine#14081) 2019-12-02 15:49:15 -08:00
David Worsham
ca9e7fc470 Fix fml_unittests (flutter/engine#14062) 2019-11-27 16:04:30 -08:00
Jim Graham
a13401ce86 Dynamically determine whether to use offscreen surface based on need (flutter/engine#13976)
Only use an offscreen surface on iOS if a layer which reads back from the destination surface, such as BackdropFilter, is present.
2019-11-27 15:01:25 -08:00
Gary Qian
e4ba568098 Revert "Do not default to downstream affinity on iOS insertText (#13852)" (flutter/engine#14053)
This reverts commit ffe1d3fca6199594535967cf9c05fb4a7ee7cc27.
2019-11-28 07:34:40 +09:00
神楽坂花火
d999372f50 Pass "null" when copy data is null to iOS pasteboard.string (flutter/engine#14046) 2019-11-27 23:46:30 +09:00
Gary Qian
b2a77134a6 Always set mEditable values when different in TextPlugin (flutter/engine#13951) 2019-11-27 07:51:04 +09:00
Dan Field
1d4b394228 Avoid retaining self in block (flutter/engine#14022) 2019-11-26 14:47:00 -08:00
Chinmay Garde
1405016707 Add a separate target for Dart coverter on FML types. (flutter/engine#14011)
The converters are still in a separate target that must be included manually. This allows targets that depend on FML but not Dart runtime not have to depend on the runtime.

Adds a test that includes this target and tests image decompression from assets. There is also a test for the standalone DartConvertor in shell_unittests but not in fml_unittests be cause FML uni-tests cannot yet launch a VM. I will work on adding fixtures for those.
2019-11-26 13:33:56 -08:00
gaaclarke
9442238326 Added docstring for FlutterOverlayView. (flutter/engine#14019) 2019-11-26 13:10:24 -08:00
Kaushik Iska
d6b2b657eb [vulkan] Bundle vulkan validation layer so files (flutter/engine#13930)
Enable vulkan validation for Fuchsia in debug mode as well.
2019-11-25 16:09:56 -08:00
Chinmay Garde
dee0c26a36 Don't crash but warn when the scene builder specifies no layers. (flutter/engine#14008) 2019-11-25 15:38:41 -08:00
Francisco Magdaleno
0ae5cf2b29 Remove device independent mask (flutter/engine#14010) 2019-11-25 14:55:12 -08:00
Jason Simmons
b8182fbd53 Convert images to raster on the GPU thread for Image.toByteData (flutter/engine#13647)
If the image is a cross-context image that might be read from the GPU thread
during onscreen rendering, then it is not safe to read it concurrently from
the IO thread as part of Image.toByteData.

If the GPU thread does not have a graphics context, then fall back to
converting the image on the IO thread.

Fixes https://github.com/flutter/flutter/issues/30697
2019-11-25 14:44:57 -08:00
David Worsham
5aa9e07326 Fix most fml tests on Fuchsia (flutter/engine#14007)
* Add fuchsia MessageLoopImpl; fix several tests
2019-11-25 14:16:50 -08:00
gaaclarke
ec5cf813f6 Made a way to turn off the OpenGL operations on the IO thread for backgrounded apps (flutter/engine#13908) 2019-11-22 14:08:33 -08:00
Gary Qian
ffe1d3fca6 Do not default to downstream affinity on iOS insertText (flutter/engine#13852) 2019-11-22 14:02:50 -08:00
gaaclarke
43dce83fc1 Refactor to passing functions by const ref (flutter/engine#13975)
Moved our code to passing functions by const ref
2019-11-22 12:20:02 -08:00
Matt Carroll
bdff1904c4 Removed GET_ACTIVITIES flag from all manifest meta-data lookups. (#38891) (flutter/engine#13932) 2019-11-21 15:00:27 -08:00
Craig Stout
ff7f96116f [shell][fuchsia] Migrate away from deprecated async loop configs 2019-11-21 13:49:53 -08:00
George Wright
49897131f4 Ensure we use the base CompositorContext's AcquireFrame method when screenshotting (flutter/engine#13934)
This ensures we rasterize into the canvas passed in as subclasses may reimplement AcquireFrame in different ways that don't utilize the canvas object passed in (such as Fuchsia's flutter_runner::CompositorContext).
2019-11-20 14:09:27 -08:00
Ian McKellar
7461c5a43a [flutter_runner] fix a11y tests (flutter/engine#13947)
Instead of running over 400000000 nodes, do something a little quicker.
2019-11-20 12:11:35 -08:00
Chinmay Garde
6df221f6fb Expose the platform view mutator stack to custom compositors. (flutter/engine#13731)
This allows custom compositors to affect scene builder modifications made
to the platform view.

Fixes https://github.com/flutter/flutter/issues/44211
Fixes b/143612326
2019-11-19 10:35:41 -08:00
Chinmay Garde
a48601803b Add virtual destructor to GPUSurfaceSoftwareDelegate. (flutter/engine#13918) 2019-11-19 10:15:34 -08:00
chunhtai
d053943e7c Moves pointer event sanitizing to engine. (flutter/engine#13697)
* Moves pointer event sanitizing to engine

* fix comment format

* fix formatting

* addressing comment

* fix format

* fix format

* addressing comment
2019-11-19 09:48:25 -08:00
Todd Volkert
02a18868b3 Revert "RendererContextSwitch guard flutter's gl context rework. (#13812)" (flutter/engine#13906)
This reverts commit 7552e9370527aae8df06b43dcb6b313d9ebdb365.

This is being reverted because it caused flutter/flutter#45098
(images don't load on iOS).
2019-11-18 18:28:04 -08:00
Ian McKellar
6f8724c59e Work around Fuchsia a11y / ICU name conflict (flutter/engine#13885)
ICU #defines TRUE and FALSE but these are used as enum member name by
the Fuchsia i18n FIDL library. This #undefs TRUE and FALSE before
including the generated FIDL header.

Fixes https://github.com/flutter/flutter/issues/44817
2019-11-15 21:16:44 -08:00
Jonah Williams
f1e34e1ea3 Allow passing hot reload debugging flags through dart-flags (flutter/engine#13780) 2019-11-14 19:12:27 -08:00
James Robinson
e9fb9f7bb8 [flow][fuchsia] Add more tracing to layers and Fuchsia surface pool (flutter/engine#13864)
This adds more trace events to more layer operations and enhances the
trace counters for the Fuchsia vulkan surface pool to include retained
surface counts, emit stats on recycle events that might change the
surface count, and by separating counters which measure bytes from
counters which measure counts to make analysis simpler.
2019-11-14 15:31:37 -08:00
Kaushik Iska
4620ef2a3b [fuchsia] Package flutter_frontend_server snapshot for fuchsia (flutter/engine#13865) 2019-11-14 14:18:19 -08:00
Darren Austin
9c643907f0 Guard against orphaned semantic objects from referencing dead accessibility bridge on iOS (flutter/engine#13857)
* Guard against orphaned semantic objects trying to reference a dead bridge on iOS.

* Switched back to a function instead of a macro for checking the bridge.

* Fixed some formatting issues.
2019-11-14 12:16:02 -08:00
Chinmay Garde
f2997c18a6 Fix test to account for pixel ratio transformations being framework responsibility. (flutter/engine#13850)
This incorrect assumption led to the introduction of a failure on an external embedder. Also dries up the section that copies the picture to the embedder managed render targets.

Fixes https://github.com/flutter/flutter/issues/43906
Fixes https://b.corp.google.com/issues/143529469
2019-11-14 12:15:33 -08:00
Chris Yang
7552e93705 RendererContextSwitch guard flutter's gl context rework. (flutter/engine#13812) 2019-11-14 11:50:45 -08:00
Matt Carroll
be849d1363 Add support for --dart-flags in FlutterShellArgs. (#44855) (flutter/engine#13855) 2019-11-14 04:09:08 +00:00
Jim Graham
c36b203a4e Avoid GL calls when compiling for Fuchsia. (flutter/engine#13847)
* Avoid GL calls when compiling for Fuchsia.
2019-11-13 16:41:03 -08:00
Todd Volkert
16ebe4633a Remove unused import (flutter/engine#13832) 2019-11-13 14:12:46 -08:00
chunhtai
7787960f0c reland add lifecycle enum (flutter/engine#13767)
This reverts commit 5e7e183369b3816650f776c767e241bb98a87276.
2019-11-13 11:26:25 -08:00
Kaushik Iska
24bf127ba8 [dart_runner] Initialize logging and tracing (flutter/engine#13829)
Remove !defined(FUCHSIA_SDK) bits to start using the SDK
apis to initialize logging and trace events for dart runners.
2019-11-13 10:02:09 -08:00
George Wright
47f1a8028a Create a WeakPtrFactory for use on the UI thread in VsyncWaiter (flutter/engine#13781) 2019-11-12 15:46:07 -08:00
Chinmay Garde
2d7d114126 Document the coordinate space of points in FlutterPointerEvent. (flutter/engine#13782) 2019-11-12 12:21:50 -08:00
Matt Carroll
6bf82e4675 Expose asset lookup from plugin binding. (#42019) (flutter/engine#13743) 2019-11-12 07:14:27 +00:00
Chris Yang
590dc94eb8 Revert "Reland "Guarding EAGLContext used by Flutter #13314" (#13759)" (flutter/engine#13788)
This reverts commit 6390e62036d69c4923cc6cf2379b9eb9f25870ba.
2019-11-11 17:17:18 -08:00