1209 Commits

Author SHA1 Message Date
Yegor
703525502b
make compiler worker count configurable (#17616)
* make compiler worker count configurable
2020-05-08 11:18:02 -07:00
Yegor
68bf137634
skip painting clipped out pictures (#18204) 2020-05-08 11:14:30 -07:00
Siva
9b905d3f03
Manual roll of Dart 617bc54b71...39e0e75fcf (#18215)
This roll unforks the Dart SDK to use the non nullable SDk,
the engine platform file is built with all the dart:* libraries
opted in except for dart:ui

dart-lang/sdk@617bc54b71 [dart2js] unit test patch for unfork cl.
dart-lang/sdk@ce5d18b0f0 [CFE] - Update exectations of CFE unit tests to account for NNBD unfork
dart-lang/sdk@be0c78a7cc [dart2js] Fix platform-binaries on bots.
dart-lang/sdk@03ce33f80c [BUILD] - Initial CL to unfork the NNBD Dart SDK
2020-05-07 20:58:44 -07:00
Ferhat
e7ee47d917
[web] Implement matrix parameter for linear gradient (#18208)
* Implement linear gradient matrix
* update golden locks
* Remove matrix check in RadialGradient
2020-05-07 17:22:54 -07:00
Nurhan Turgut
d6aa099de7
Autofill main part (#17986)
* changes for getting the configuration

* running autofill

* simplifications, remove unused map

* more changes

* make single autofill fields work. remove print messages

* remove an extra line

* remove extra file. also update chrome version

* addressing reviewers comments

* addressing reviewer comments

* addressing reviewer comments

* addressing reviewer comments

* changing comments

* changing comments

* adding a comment on subscriptions lifecycle

* fixing a bug which was failing the existing unit tests

* add unit tests for AutofillInfo and EngineAutofillForm. add autocomplete to textarea

* add unit tests for method channels

* remove json from the end of the file

* do not change the input type for the focused element

* check name instead of autocomplete for firefox

* check name instead of autocomplete for firefox in other methods as well

* fixing a bug in the autofillhints file, testing if firefox is failing for username hint or for all autocomplete values

* fix the breaking unit test
2020-05-06 12:58:46 -07:00
Ferhat
80c090d9ea
Fix path bounds for multiple rects. Implement winding rules (#18165) 2020-05-05 20:53:51 -07:00
Jason Simmons
905836d466
[web] Upgrade the test package to remove the dependency on package_resolver (#18135) 2020-05-05 10:57:02 -07:00
Ferhat
a0983d36f7
[web] Add support for ColorFilter on images (#18111)
* Implement Color filter for images
* Add blend modes
* complete set of blend modes
* Add golden test for blend modes, fix size setting when using drawImage instead of drawImageRect
* Add comments
* Update golden locks
* Fix analyzer errors
Co-authored-by: Harry Terkelsen <hterkelsen@users.noreply.github.com>
* fix blend group count in test
2020-05-05 10:22:16 -07:00
Ferhat
4b7380b55f
[web] Workaround for compositing bug in chrome/webkit (#18128)
* Fix compositing error when multiple canvas(s) are reused
* address review comments
* track all element counts
2020-05-05 10:11:56 -07:00
Mouad Debbar
b774f6a40b
[web] Add support for syncing unicode line break properties (#18040) 2020-05-04 20:59:41 -07:00
Cedric GESTES
db6fb7f1fd
[web] also hide scrollbars in text_editing (#18019) 2020-05-04 14:02:46 -07:00
Ferhat
989d910130
[web] Remove left/top/transform reset since all code paths now set ltwh (#17867)
* [web] Remove left/top/transform reset since all code paths now set ltwh
* Remove unused style var
* Handle path=null , address review comments
* Added comment for reset code
2020-05-04 08:46:21 -07:00
Ferhat
705fcac4eb
[web] Fix cachedLastStyle state leak across canvases. Reduce ctx.font reset calls. (#17980)
* Fix cachedLastStyle state leak across canvases. Reduce ctx.font reset calls.

* Remove font set test
2020-05-03 18:06:08 -07:00
Alexander Aprelev
1c8ee9856b
Introduce runtime check that it is root isolate that makes UI native calls. (#18050)
* Revert "Do not register UI-related native functions in secondary isolates (#6401)"

This reverts commit 69ae5694de54d2a163743dcec727fcea1c7bc8e1 as it doesn't work when root and secondary isolates run in the same isolate group.

* Confirm it is root isolate that makes UI native calls.

* Fix format, UIDartState reference from Fuchsia source

* No UI isolate check for fuchsia calls

* Fix typo. Remove redundant runtime calls
2020-05-01 09:05:41 -07:00
Mouad Debbar
3e975147fd
[web] First batch of unit tests for line breaker (#18034) 2020-04-30 10:50:51 -07:00
Yegor
590381a00a
soften shadows even more; fix shadow alpha (#18029)
* soften shadows even more; fix shadow alpha
2020-04-29 20:54:21 -07:00
Mouad Debbar
7c084c57bd
[web] Use correct shell operator to compare file limits (#18032) 2020-04-29 18:12:48 -07:00
Siva
aa695d4d7b
Revert all build changes made to test the Dart NNBD unfork CL. (#18033) 2020-04-29 12:32:30 -07:00
Jason Simmons
01cf8c36ce
Disable the import_internal_library analyzer check for dart:ui (#18009)
The latest version of dartanalyzer does not support disabling this for a
specific line of code.
2020-04-28 13:45:47 -07:00
Siva
494a63c411
Trial PR to enable null safety unfork in the Dart SDK. (#17818)
* Trial PR to enable null safety unfork in the Dart SDK.

* Fix web-sdk builds.

* Manua; Roll of Dart cab69e77066b0db305187fd6e618a4f524ae9efd...03429b20cd67f85d65cc589b529ab8c1a4780912

dart-lang/sdk@ cab69e7706 [BUILD] - Initial CL to unfork the NNBD Dart SDK NOTE: This is a trial submit and will be reverted immediately.
2020-04-27 19:51:23 -07:00
Mouad Debbar
aa00d50396
[web] Don't allow empty initial route (#17936) 2020-04-27 13:54:07 -07:00
Mouad Debbar
d132ac576b
[web] Fix exception when getting boxes for rich text range (#17933) 2020-04-24 14:30:32 -07:00
Ferhat
cade0e90ca
[web] Batch systemFontChange messages (#17885)
* Batch systemFontChange messages
* Update test for async
2020-04-24 14:10:22 -07:00
Ferhat
371a8a05b0
[web] When a canvas element is reused and is first element in child list, preserve zIndex. (#17906)
* Fix zIndex removal on reuse
* Move check after append call to simplify
2020-04-23 15:09:59 -07:00
Nurhan Turgut
8fff8da38d
[web] autofill hints (#17887)
* adding autofill hints map from flutter values to the browser values, which will  be used by the web engine:

* removing unused reverse map

* addressing reviewer comments

* changing licences
2020-04-23 10:00:56 -07:00
Ferhat
ace381d76c
[web] Speedup color to css string 25% (#17866)
* Speedup color to css string 25%
2020-04-22 12:28:29 -07:00
Yegor
deaf14ec7d
Use Float32List as Matrix storage inside the Web engine (#17856)
This change converts all Float64List matrices to Float32List at the dart:ui interface boundary. Internally, it only uses Float32List. Float32List requires less memory and is orders of magnitude faster to allocate, and it has sufficient precision as Flutter mobile engine and Skia use 32-bit floats anyway.

This change speeds up frame preroll by 50% on the bench_card_infinite_scroll benchmark.

For more details on Float64Array allocation in JS (which backs Float64List in Dart) see the following:

https://bugs.chromium.org/p/v8/issues/detail?id=9199
https://bugs.chromium.org/p/v8/issues/detail?id=2022
2020-04-22 11:08:23 -07:00
Yegor
1beb220852
Report SceneBuilder submetrics through profiling API (#17852)
* add scenebuilder submetrics
* Disable Profiler by default
2020-04-22 09:15:18 -07:00
Ferhat
8d7071ea46
Prevent unnecessary DOM append call when canvas is reused (#17864) 2020-04-21 23:00:02 -07:00
Dan Field
f043e73d43
Roll CanvasKit to 0.14.0, fix Canvas.saveLayer(null, paint) (#17849) 2020-04-21 19:22:21 -07:00
Gary Qian
8dc91229b4
PlatformResolvedLocale localization message channel (#17755) 2020-04-21 15:34:44 -07:00
Ferhat
753514cefb
Canvas regression (#17738)
* Change backdrop filter element location based on ancestor clip. Add test.
* update test
* Addressed review comments. updated goldens
* Check ancestor on retain
* addressed review comments
2020-04-20 18:59:17 -07:00
Mouad Debbar
b0c4be9bd8
[web] Synthesize keyup event when the browser doesn't trigger a keyup (#17742) 2020-04-20 15:23:39 -07:00
Yegor
219c51f8d7
remove allocation from growLTRB; remove dynamism in vector_math (#17735) 2020-04-18 13:53:53 -07:00
Nurhan Turgut
ca3b36357f
[web] fix ulimit issues on Mac (#17767)
* check the max user limit before changing the limits

* more detailed changes in the file/user limit increase

* addressing pr reviews
2020-04-17 17:55:52 -07:00
Ferhat
5c0da71518
[web] Cleanup. Split path and surface stats code into separate files (#17796)
* Split path and surface stats code into separate files

* Update licenses
2020-04-17 17:47:22 -07:00
Nurhan Turgut
58cdc93242
web engine should not give an error for the new text editing method. (#17771) 2020-04-17 10:27:33 -07:00
Brian Osman
fb208b486e
Convert semantics_node from SkMatrix44 to SkM44 (#17763)
* Convert semantics_node from SkMatrix44 to SkM44
2020-04-17 07:24:40 -04:00
Yegor
dd87e3f944
Optimize static content scrolling (#17621)
* store paint command bounds
* do not apply commands outside the clip region
* better cull rect prediction
* enforce RecordingCanvas.endRecording
2020-04-14 20:08:10 -07:00
Ferhat
1192667a7a
[web] Fix extra canvas generation due to context access (#17710)
* Fix extra canvas generation due to context access
* add comment
* address review comment
2020-04-14 15:40:16 -07:00
Ferhat
4a1085a6f2
[web] Fix compositing order when adding paragraph tags (#17645)
* Add test and dartfmt
* Update golden locks
* Addressed review comments
* Fix lint error (unused widthConstraint)
* Add maxDiffRatePercent for text diff on mac/linux
2020-04-13 13:30:52 -07:00
Nurhan Turgut
deef2663ac
Run integration tests on ci (#17598)
* changing felt script to fetch flutter

* changing the clone_flutter.sh code

* running integration tests with felt on cirrus. fetch framework in CI (not in local).

* only run cirrus tests on chrome. fix a comma in the flutter command path

* adding comments to public flags

* use local engine parameter for flutter pub get

* change flutter executable used for flutter drive command

* fix a cleanup issue. address comments. add toolException. enable web in flutter

* address reviwer comments. fix issue with local-engine

* address reviwer comments. fix issue with local-engine

* using engine/flutter/.dart_tools as clone directory. enabling clone script for local usage

* clean flutter repo with felt clean. add a flag to skip cloning the repo. always clone the repo even for local development, unless this flag is set

* fixing typos. updating readme for the new flag.

* fix directory error

* addressing reviewer comments
2020-04-13 09:54:54 -07:00
Mehmet Fidanboylu
47a88e8ea3
Add support for setting allow http flag in Dart VM (#17653) 2020-04-11 11:55:05 -07:00
Mouad Debbar
c69f21a349
[web] Combine duplicate platform message spy implementations (#17615) 2020-04-10 13:30:41 -07:00
Ferhat
6b065297cf
Fix Path hit test code for high dpi devices (#17608) 2020-04-09 22:18:42 -07:00
Nurhan Turgut
6245149b41
[web] using pkill to quit safari (#17533)
* adding an apple script to quit safari

* making changes to utils and adding cleanup after unit tests failed

* switch saai quit to pkill instead of applescript

* adding toolexception

* adding a cleanup function option to felt.

* removing unnecassary await's added for the previos version of the PR

* removing unnecassary async

* fix analyze error
2020-04-08 17:35:10 -07:00
Ferhat
db644677fa
[web] Fix multi-reply on message channel. Add test (#17591)
* Fix multi-reply on message channel. Add test
* Add check for viewInstanceCount
* skip no-headless test
2020-04-08 17:18:06 -07:00
Mouad Debbar
7a591cf475
[web] Fix regression of pointer events on mobile browsers (#17595) 2020-04-08 14:48:56 -07:00
Mouad Debbar
b0b67ef9e2
[web] Fix window.defaultRouteName (#17580) 2020-04-08 13:51:38 -07:00
Harry Terkelsen
38cba0757d
Do not enable antialiasing by default in CanvasKit mode (#17534)
* Do not enable antialiasing by default in CanvasKit mode

* Add comment
2020-04-08 11:55:23 -07:00