153 Commits

Author SHA1 Message Date
nturgut
03ff8a4096
TBR: remove the extra values which was overshadowing the test result (#22483)
* remove the extra values which was overshadowing the test result

* increase difference. canvaskit gives different results

* increase difference more. firefox gave 1.7 diff. add comments
2020-11-12 18:24:38 -08:00
nturgut
4d44b7e7d9
Upgrades to felt (running on multiple modes, multiple backends, single test target option) (#22260)
* testing running the tests on all build modes

* don't run debug mode on other browsers

* fix platform message test failures

* some cleanup. change dispose platform channel message

* adding flags to control the integration tests better with felt

* running tests by target name, selecting web rendering backend

* fix conditions

* carrying some conditions to helper methods. Adding comments

* create a blocked list for failing canvaskit test

* parse parameters before all integration tests

* Give better warning to developers for tests that are blocked for CI

* address some reviwer comments (more remains)

* remove named parameters

* also run with auto mode

* add verbose option

* reduce the number of tests running. skip url_test for now
2020-11-11 17:18:15 -08:00
Yegor
1e3ceb037f
Update pubspecs to null-safe dependencies (#22366)
* update pubspecs to null-safe dependencies

* remove build_runner dep; upgrade quiver

* use analysis_options.yaml to control analysis scope
2020-11-06 17:54:53 -08:00
Devon Carew
8c5b0a6abf
use the dart analyze command to analyze source (#22212) 2020-10-29 18:46:52 -07:00
Zachary Anderson
b54bb88f00
Migrate runZoned to runZonedGuarded (#22198) 2020-10-29 11:02:35 -07:00
Ferhat
0747f2f4b1
[web] Fix 3d transforms for html backend (#21499)
* Workaround for canvas element lacking support for 3d setTransform

* update golden test

* Add webkit workaround

* Implement DOM rendering for perspective

* cleanup

* update goldens lock

* Add check for shader and filtermask for dom use

* Fix svg viewBox. Move zIndex check to bitmap canvas

* Fix null check warning

* Fix scene_builder zIndex=-1 test to force canvas usage

* Add blendmode handling for DOM mode

* Update maxdiff and golden locks

* Remove unused import

* Add drawcolor/drawpaint test. Fix bounds for drawColor/drawPaint

* update golden locks

* adjust drawColor for dpr

* Update test to use canvas

* Fix toDataUrl NNBD

* Update Picture.toImage to use canvas to obstain image data

* Remove write:true from golden calls

* Add fill-rule for _pathToSvgElement

* Update golden locks

* Fix sceneBuilder pushClip / add missing clipBehaviour

* Fix test now that clipping works correctly

* move overflow handling for tests into DOMClip.addOverflow

* Add clipRect to test to keep render inside bitmap canvas area

* Update compositing test, fix drawColor coordinates

* update golden locks

* Skip test for matchGolden infra fail

* update golden lock

* merge

* update maxdiff for text over canvas

* update golden diff

* update paint spread bounds maxdiff

* update paint spread maxDiff
2020-10-19 17:27:27 -07:00
Ferhat
890f016207
[web] Implement ClipOp.difference (#21901) 2020-10-17 00:09:41 -07:00
nturgut
3b2da6be9f
[web] enabling firefox screenshot tests. adding to documentation (#21807)
* enabling firefox screenshot tests. adding to documentation

* test with correct goldens

* update goldens SHA

* change the goldens with flutter/goldens repo

* do not run preparation step twice. this will cause test_results to be deleted
2020-10-13 19:26:34 -07:00
nturgut
38d8ebaa46
E2e screenshot tests2 (#21383)
* carrying code

* more changes for carrying the code

* rebase changes onto ios-screenshot tests

* adding screenshot capability to text_editing e2e test

* address some comments

* change enable flag for isUnitTestsScreenshotsAvailable

* addressing the reviewer comments

* change the dependency for path

* add to licencense file

* changing goldens commit no. the new commit has the screenshot goldens

* update readme file

* firefox tests needs LUCI changes

* change to release mode since screenshots were taken in release mode

* change window size

* some argument changes

* small comment change

* test the chrome linux tests again

* use roboto font instead of default font

* addressing reviewer comments

* change commit for goldens
2020-10-12 16:25:57 -07:00
nturgut
83e18142e8
chrome driver for chrome 86 (#21705) 2020-10-08 13:41:05 -07:00
Yegor
de7c0b9b81
Respect the --debug option in Firefox (#21438) 2020-10-02 18:17:02 -07:00
nturgut
d877b830cb
[web] enable ios safari screenshot tests (#21226)
* enable ios safari screenshot tests

* this is the value used for screenshots in the repo.

* change revision

* fix the error made in the gaps

* do not try to fetch on LUCI

* lunix luci migth break existing prs. only skip fetching for mac

* add a placeholder tests for shadow golden test

* try to use iPhone 11 Pro on LUCI

* change the scale and the smoke test image

* add unmerged goldens PR to tests all the screenshots. will be removed later

* change the goldens lock back to flutter/goldens

* change wrong comment on screenshot tests block

* address reviewer comments

* change the commit number for goldens file

* skip canvas blend mode tests

* debugging LUCI error

* debugging LUCI error printing directory contents

* skip one test, remove the debug logs

* change the revision number to include the correct chrome files
2020-09-25 12:30:57 -07:00
David Iglesias
3d0f12974d
[web] Add canUpdateAsMatch to PersistedPlatformView. (#21313) 2020-09-23 21:47:02 -07:00
nturgut
6e42b54d59
creating test result directory before running tests (#21324)
* creating test result directory. adding a prepare method to test runner

* addressing reviewer comments
2020-09-22 12:51:14 -07:00
nturgut
c5588af6fa
[web] run safari desktop tests on luci (#21228)
* run safari desktop tests on luci

* fix safari issue. focus on dom element when new transform is received. add transform to test cases

* Update text_editing.dart

minor change to retrigger tests (recipe change is merged)
2020-09-17 13:00:06 -07:00
Mouad Debbar
7bda396b0f
[web] Fix mis-aligned widget spans (#21112) 2020-09-15 12:58:07 -07:00
nturgut
1cabedf8ac
running screenshot tests on ios-safari unit tests (#20963)
* running screenshot tests on ios-safari unit tests

* fixing the golden_smoke tests. changes to the documentation

* addressing reviewer comments

* cropping footer from the simulator screenshot. addressing some reviewer comments

* use .dart_tools for recording the screenshots

* fix the usage of the method

* adding TODO's for missing documentation and not supported windows tests

* addressing comments

* changing to incremental counter for file names

* add comment to the counter

* fix anaylze issues

* using takescreenshot method from the iosSimulator.

* address reviewer comments

* fix the scaling issue. disable eronous test

* change the smoke file for top gap 282

* change the variable name for scale factor
2020-09-15 12:36:00 -07:00
Chris Bracken
b92f788d90
[felt] Eliminate ninja-jobs argument (#21135)
Migrate to autoninja which works out the ideal level of parallelism.
2020-09-14 11:12:16 -07:00
Chris Bracken
1fa99cd618
[felt] Use autoninja instead of hardcoding threads (#21130)
autoninja is included as part of depot_tools and automatically
determines the optimal thread count.

Also applies quoting on the affected lines.
2020-09-12 12:14:05 -07:00
Chris Bracken
404e9b7505
Check for dart2js on felt startup (#21046)
This adds a check for the presence of dart2js in the engine build.

Felt relies on an engine build with `--full-dart-sdk` set. Previously,
we checked for the presence of pub, but not for the presence of
web-specific tooling such as dart2js that felt relies on. Pub is built
as part of the default Dart SDK build when `--full-dart-sdk` is not set,
so its presence is insufficient to prove that other required tooling is
present.

Without this check, we get the following error on run:

    Unhandled exception:
    ProcessException: No such file or directory
      Command: /Users/cbracken/src/flutter/engine/src/out/host_debug_unopt/dart-sdk/bin/dart2js --no-minify --disable-inlining --enable-asserts --enable-experiment=non-nullable --no-sound-null-safety -O2 -o test/paragraph_builder_test.dart.browser_test.dart.js test/paragraph_builder_test.dart
2020-09-09 14:04:52 -07:00
Jim Graham
d77c4e540e
adjust blur radius for HTML to match CanvasKit (#20840)
* adjust blur radius for HTML to match CanvasKit

* switch to new goldens for new blur radius logic
2020-09-04 12:10:48 -07:00
Jim Graham
6a6986da47
improve sensitivity of BackdropFilter web tests (#20915) 2020-09-03 21:47:41 -07:00
nturgut
80f4481d23
renaming e2e tests to integration (#20954)
* renaming e2e tests to integration

* change the name of the files in the blocked list
2020-09-02 14:52:09 -07:00
nturgut
80a1cac4fc
Fix debugging issue (#20841) 2020-08-28 10:03:55 -07:00
Ferhat
e67ae1e307
[web] Fix path rendering when addPolygon is chained with other verbs. (#20803) 2020-08-27 20:25:38 -07:00
Ferhat
f0a8230fca
[web] Implement SceneBuilder.pushColorFilter for html (#20821)
* Implement Color filter layer
* Add test with BlendMode color
* update licenses file
* Move blend functions into color_filter.dart
* dartfmt
* Add missing default clause
* Remove switch default
2020-08-27 12:06:22 -07:00
Zachary Anderson
fe0a995fdf
Revert "[web] Implement SceneBuilder.pushColorFilter for html (#20802)" (#20820)
This reverts commit 2decf195d2def7aa82b2d6e4c29ce932a78c73f2.
2020-08-27 10:12:55 -07:00
Ferhat
2decf195d2
[web] Implement SceneBuilder.pushColorFilter for html (#20802)
* Implement Color filter layer
* Add test with BlendMode color
* update licenses file
* Move blend functions into color_filter.dart
* dartfmt
2020-08-27 08:49:12 -07:00
nturgut
74d32ecdbd
[web] update chrome version (#20470)
* update chrome version, should be merged after recipe changes

* changing directory to use chrome driver in LUCI

* changing directory path's order

* add cipd packages's chrome version for mac

* addressing reviewer comments

* more documentation. update readme

* remove late since it didn't build. remove distinction in paths for local and LUCI.

* addressing reviewer comments. (non-null fields needs rechanging)

* addressing reviewer comments. adding 2.6 on files missing the notation
2020-08-19 12:28:44 -07:00
nturgut
bb24b4938f
[web] Build unit tests with dart2js instead of build_runner (#20390)
* change from build_runner to dart2js

* add internalBootstrapBrowserTest to some of the tests

* add internalBootstrapBrowserTest to all remaining tests

* make tests build in paralel. Total time dropped from 586 to 177 seconds for 8 core MacBook

* change isolates with pool

* fixing analysis errors

* skipping canvaskit tests for ios-safari

* copy image files to the build directory

* adding internalBootstrapBrowserTest to newly added tests

* add internalBootstrapBrowserTest to faling path iterator test

* necessary changes to make chrome windows work

* in windows test in chrome instead of edge. our edge code was for legacy edge

* do not run golden unit tests on Windows LUCI bots for now

* addressing reviewer comments. Adding a method for deciding when to run integration tests.

* remove lines that I forgot to remove

* fixing analysis error. add issue for todo

* add bootstap to a test file

* adding bootstrap to another test

* add internalBootstrapBrowserTest to a golden test

* return test result in bat file. use archieve package to unzip

* fixing logs for chrome_installer

* use archieve and archieve entity instead of dynamic

* adding comments for windows platform archieve part

* addressing reviewer comments

* change readme file
2020-08-17 16:19:27 -07:00
Yegor
0809f21392
fix clipped and transformed content in HTML clip (#20310)
* fixed clipped and transformed content in HTML clip
2020-08-07 11:28:00 -07:00
nturgut
c134e1658d
add information collection for safari bots (#20123)
* add information collection for safari bots

* remove unused parts. add cast to fix analyze errors

* add more information. address reviwer comments

* address reviewr comments

* typo fix
2020-07-30 15:21:34 -07:00
Mouad Debbar
f0cc38fdb5
[web] Set correct defaults for text in canvas (#20067) 2020-07-29 08:56:42 -07:00
nturgut
4220301e40
re-enable integration tests. increase sdk version. (#20075) 2020-07-27 19:37:47 -07:00
nturgut
f27729e97b
both trees are red, stop running integration tests (#20060) 2020-07-27 11:15:56 -07:00
nturgut
c0ac43da97
Add a todo to felt (PR to rerun the tree) (#20025) 2020-07-25 21:12:15 -07:00
nturgut
debb36da5d
Address platform changes in the integration tests. (#20008) 2020-07-24 10:52:57 -07:00
Ferhat
5d921fcb57
[web] Fixes arc scaling when counter clockwise (#19927)
* [web] Fix arc scaling when counter clockwise
* update golden write
* Removed unused var
2020-07-22 10:02:07 -07:00
nturgut
da8defdc5f
Migrating web_analysis from Cirrus to LUCI (PART 1) (#19726)
* adding a script for web_analysis for using from luci.

* addressing reviewer comments
2020-07-14 10:14:31 -07:00
Alexandre Ardhuin
218d98f4d8
Operator equals (#19303)
* use Object for operator==

* apply style guide for operator==
2020-06-30 23:16:31 +02:00
nturgut
d758e069da
collect logs using the new web_installers repo (#19298) 2020-06-25 10:27:53 -07:00
nturgut
2c04b9ab8e
skip ios safari tests on felt level (#19280)
* skip ios safari tests on felt level

* instead of skipping use the new web_installers repo

* re-skip the test. led run failed with another error

* remove led json
2020-06-24 20:51:38 -07:00
nturgut
3fcf5463b9
Run IOS unit tests on LUCI (#19141)
* change the version of simulator. luci bots only has 13.0

* skip failing pointer binding tests

* skip path_metrics (canvaskit) and a method from surface_test

* fix analyzer errors

* remove extra added touch event context test

* removing left overs for screenshot debugging

* apply reviewers suggestion for skipping tests
2020-06-23 15:22:01 -07:00
nturgut
683cc1594d
Enable firefox integration tests (#19164)
* firefox integration tests enable

* addressing reviewer comments
2020-06-22 13:16:57 -07:00
nturgut
a358e99a6e
[web] Running integration tests on Safari on Local (#18488)
* rebase. carry driver functionality to drivermanager

* rebase. nabling integration tests on Safari on MacOS

* addressing reviewer comments, updating web_drivers dependency commit number

* addressing reviewer comments

* addressing reviewer comments
2020-06-18 16:48:04 -07:00
Yegor
00aa0bc071
take web_ui to null safety (#19027)
move web_ui to NNBD syntax
2020-06-16 15:28:06 -07:00
nturgut
965fbbed17
renaming variables on integration tests manager (#18975) 2020-06-10 16:33:52 -07:00
nturgut
a6435210ac
Update firefox.dart (#18939) 2020-06-10 11:29:19 -07:00
nturgut
eaa2f7f90f
[web] running ios unit tests from felt … (#18856)
* running ios unit tests from felt by booting/shutingdown simulators. create simulator with felt

* changing the readme file for ios,mac,xcode spellings

* addressing reviewer comments

* fix analyse error

* fixing cleanup issue. solution: adding and await and using for loop instead of foreach
2020-06-10 09:33:17 -07:00
nturgut
201dc00cb9
[web] Adding profile parameter to firefox (#18792)
* opening firefox with a given profile

* use .dart_tool for temporary directory. delete the directory if exits before creation
2020-06-04 13:22:13 -07:00